Hash
stringlengths 40
40
| Date
stringlengths 19
20
⌀ | Author
stringlengths 2
30
| commit_message
stringlengths 3
28.8k
| IsMerge
bool 1
class | Additions
int64 0
55.2k
| Deletions
int64 0
991
| Total Changes
int64 -3
55.2k
| git_diff
stringlengths 23
47.3k
| Repository Name
stringclasses 159
values | Owner
stringclasses 85
values | Primary Language
stringclasses 20
values | Language
stringclasses 19
values | Stars
float64 218
411k
⌀ | Forks
float64 8
79k
⌀ | Description
stringclasses 96
values | Repository
stringclasses 161
values | type
stringclasses 6
values | Comment
stringlengths 7
156
⌀ |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
8f350c262ac97d9fdd28f6ecf34bc0247fa392d6
|
2024-11-04 18:47:46
|
jbengler
|
Increment version number to 0.1.0
| false
| 2
| 3
| 5
|
--- DESCRIPTION
@@ -1,6 +1,6 @@
Package: tidyplots
Title: Tidy Plots for Scientific Papers
-Version: 0.1.0
+Version: 0.0.2.9000
Authors@R:
person("Jan Broder", "Engler", , "[email protected]", role = c("aut", "cre", "cph"),
comment = c(ORCID = "0000-0002-3169-2076"))
--- NEWS.md
@@ -1,5 +1,6 @@
-# tidyplots 0.1.0
+# tidyplots (development version)
+* The package is still in early development. Expect user-facing and breaking changes.
* New S3 class `tidycolor` for color schemes. The print method of `tidycolor` sends a html preview of the color scheme to the RStudio viewer panel.
* New `new_color_scheme()` to create custom color schemes.
* New build-in color schemes using the prefix `colors_discrete_`, `colors_continuous_` and `colors_diverging_`.
|
tidyplots
|
jbengler
|
R
|
R
| 495
| 18
|
Tidy Plots for Scientific Papers
|
jbengler_tidyplots
|
CONFIG_CHANGE
|
version updates are done
|
dc19062cf9c1864e5377e6031d98f9a09d788bff
|
2025-04-06T00:05:51Z
|
chromium-internal-autoroll
|
Roll optimization-guide from 5122fca332c8 to a96fd8cc0fc8 https://chrome-internal.googlesource.com/chrome/components/optimization_guide.git/+log/5122fca332c8..a96fd8cc0fc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/optimization-guide-chromium Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: Ib6fd2d960010f80160f3f98403cdfd4eadc611b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6435559 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1443145}
| false
| 2
| 2
| 4
|
--- DEPS
@@ -4635,7 +4635,7 @@ deps = {
'src/components/optimization_guide/internal': {
'url': Var('chrome_git') + '/chrome/components/optimization_guide.git' + '@' +
- '5122fca332c88051d6dbcec748e0f55df957dfe0',
+ 'a96fd8cc0fc8feab1676ce8076f5ec60079e6d7a',
'condition': 'checkout_src_internal',
},
--- components/optimization_guide/internal
@@ -1 +1 @@
-Subproject commit 5122fca332c88051d6dbcec748e0f55df957dfe0
+Subproject commit a96fd8cc0fc8feab1676ce8076f5ec60079e6d7a
|
chromium
| null |
C
|
C
| null | null |
Browser
|
_chromium
|
CONFIG_CHANGE
|
roll optimization guide link changed
|
e4939f304e69074a714f2f86871ebc0f1dbc1e9c
|
2024-07-05 20:25:52
|
jbengler
|
90 degree rotate_labels
| false
| 5
| 4
| 9
|
--- R/adjust.R
@@ -10,12 +10,11 @@ ff_adjust_axis <- function(axis) {
# Rotate labels
if (rotate_labels == TRUE) rotate_labels <- 45
- if (is.numeric(rotate_labels) && rotate_labels != 0) {
- if (rotate_labels >= 90) vjust <- 0.5 else vjust <- 1
+ if (is.numeric(rotate_labels)) {
if (axis == "x")
- plot <- plot + ggplot2::theme(axis.text.x = ggplot2::element_text(angle = rotate_labels, hjust = 1, vjust = vjust))
+ plot <- plot + ggplot2::theme(axis.text.x = ggplot2::element_text(angle = rotate_labels, hjust=1))
if (axis == "y")
- plot <- plot + ggplot2::theme(axis.text.y = ggplot2::element_text(angle = rotate_labels, hjust = vjust, vjust = 1))
+ plot <- plot + ggplot2::theme(axis.text.y = ggplot2::element_text(angle = rotate_labels, hjust=1))
}
# Adjust limits
--- vignettes/articles/Visualizing-data.Rmd
@@ -57,7 +57,7 @@ animals %>%
add_data_points(shape = 1)
```
-However, data points can also be used to plot a _discrete variable_ against a _continuous variable_.
+However, data points can also be used when plotting a _discrete variable_ like `treatment` against a _continuous variable_ like `score`.
```{r}
study %>%
|
tidyplots
|
jbengler
|
R
|
R
| 495
| 18
|
Tidy Plots for Scientific Papers
|
jbengler_tidyplots
|
CODE_IMPROVEMENT
|
Non-functional code changes to improve readability, migration etc.
|
c8804bff6d1616a23547eaff3f91b75200a3319a
|
2025-02-08 03:47:10
|
yongruilin
|
fix: flagz endpoint to return parsed flags value
| false
| 9
| 1
| 10
|
--- cmd/kube-apiserver/app/options/completion.go
@@ -57,7 +57,7 @@ func (s *ServerRunOptions) Complete(ctx context.Context) (CompletedOptions, erro
if err != nil {
return CompletedOptions{}, err
}
- controlplane, err := s.Options.Complete(ctx, *s.ParsedFlags, []string{"kubernetes.default.svc", "kubernetes.default", "kubernetes"}, []net.IP{apiServerServiceIP})
+ controlplane, err := s.Options.Complete(ctx, s.Flags(), []string{"kubernetes.default.svc", "kubernetes.default", "kubernetes"}, []net.IP{apiServerServiceIP})
if err != nil {
return CompletedOptions{}, err
}
--- cmd/kube-apiserver/app/options/options.go
@@ -41,8 +41,6 @@ type ServerRunOptions struct {
CloudProvider *kubeoptions.CloudProviderOptions
Extra
- // ParsedFlags hold the parsed CLI flags.
- ParsedFlags *cliflag.NamedFlagSets
}
type Extra struct {
@@ -102,9 +100,6 @@ func NewServerRunOptions() *ServerRunOptions {
// Flags returns flags for a specific APIServer by section name
func (s *ServerRunOptions) Flags() (fss cliflag.NamedFlagSets) {
- if s.ParsedFlags != nil {
- return *s.ParsedFlags
- }
s.Options.AddFlags(&fss)
s.CloudProvider.AddFlags(fss.FlagSet("cloud provider"))
@@ -161,6 +156,5 @@ func (s *ServerRunOptions) Flags() (fss cliflag.NamedFlagSets) {
"The number of apiservers running in the cluster, must be a positive number. (In use when --endpoint-reconciler-type=master-count is enabled.)")
fs.MarkDeprecated("apiserver-count", "apiserver-count is deprecated and will be removed in a future version.")
- s.ParsedFlags = &fss
return fss
}
--- cmd/kube-apiserver/app/options/options_test.go
@@ -335,7 +335,6 @@ func TestAddFlags(t *testing.T) {
CloudConfigFile: "/cloud-config",
CloudProvider: "azure",
},
- ParsedFlags: s.ParsedFlags,
}
expected.Authentication.OIDC.UsernameClaim = "sub"
--- cmd/kube-apiserver/app/server.go
@@ -124,7 +124,6 @@ cluster's shared state through which all other components interact.`,
fs := cmd.Flags()
namedFlagSets := s.Flags()
- s.ParsedFlags = &namedFlagSets
verflag.AddFlags(namedFlagSets.FlagSet("global"))
globalflag.AddGlobalFlags(namedFlagSets.FlagSet("global"), cmd.Name(), logs.SkipLoggingConfigurationFlags())
options.AddCustomGlobalFlags(namedFlagSets.FlagSet("generic"))
|
kubernetes
|
kubernetes
|
Go
|
Go
| 113,460
| 40,344
|
Production-Grade Container Scheduling and Management
|
nan_kubernetes
|
CONFIG_CHANGE
|
Very small changes
|
85ab02ba583f88ad8aeb04c3dd057778a08f885f
| null |
Brody McKee
|
feat: remove unused React imports (#9853)
| false
| 0
| 2
| -2
|
--- App.js
@@ -1,4 +1,3 @@
-import React from 'react';
import logo from './logo.svg';
import './App.css';
--- App.test.js
@@ -1,4 +1,3 @@
-import React from 'react';
import { render, screen } from '@testing-library/react';
import App from './App';
|
facebook_create-react-app.json
| null | null | null | null | null | null |
facebook_create-react-app.json
|
CODE_IMPROVEMENT
|
3, removed unused imports
|
0742e898e3b5ca93597d19b0606524f9c43f5c56
|
2024-03-05 22:17:13
|
Kingkor Roy Tirtho
|
docs: add installation through homebrew instruction in README
| false
| 9
| 0
| 9
|
--- README.md
@@ -138,15 +138,6 @@ This handy table lists all the methods you can use to install Spotube:
</a>
</td>
</tr>
- <tr>
- <td>Macos - <a href="https://brew.sh">Homebrew</a></td>
- <td>
-<pre lang="bash">
-brew tap krtirtho/apps
-brew install --cask spotube
-</pre>
- </td>
- </tr>
<tr>
<td>Windows - <a href="https://chocolatey.org">Chocolatey</a></td>
<td>
|
spotube
|
krtirtho
|
Dart
|
Dart
| 35,895
| 1,491
|
🎧 Open source Spotify client that doesn't require Premium nor uses Electron! Available for both desktop & mobile!
|
krtirtho_spotube
|
DOC_CHANGE
|
The prefix fix: suggests a bug fix, but the actual change is not fixing code behavior, it’s improving documentation rendering
|
b7dc04c086c1c17195c86d57d47e8b522e810259
| null |
Harrison Chase
|
fix links
| false
| 1
| 1
| 0
|
--- autonomous_agents.md
@@ -16,5 +16,5 @@ usage of LangChain's collection of tools.
- [Baby AGI with Tools](autonomous_agents/baby_agi_with_agent.ipynb): building off the above notebook, this example substitutes in an agent with tools as the execution tools, allowing it to actually take actions.
-## AutoGPT ([Original Repo] (https://github.com/Significant-Gravitas/Auto-GPT))
+## AutoGPT ([Original Repo](https://github.com/Significant-Gravitas/Auto-GPT))
- [AutoGPT](autonomous_agents/autogpt.ipynb): a notebook implementing AutoGPT in LangChain primitives
|
langchain-ai_langchain.json
| null | null | null | null | null | null |
langchain-ai_langchain.json
|
BUG_FIX
|
5, fix written in commit msg.
|
681b0caf97831d3f237c12b6525af54969ceb09e
|
2023-05-26 12:42:41
|
adams549659584
|
fix: :bug: fix auth
| false
| 8
| 5
| 13
|
--- api/index.go
@@ -4,20 +4,16 @@ import (
"adams549659584/go-proxy-bingai/api/helper"
"adams549659584/go-proxy-bingai/common"
"net/http"
- "strings"
)
func Index(w http.ResponseWriter, r *http.Request) {
if r.URL.Path == "/" {
http.Redirect(w, r, common.PROXY_WEB_PAGE_PATH, http.StatusFound)
- return
- }
- if strings.HasPrefix("/turing", r.URL.Path) {
+ } else {
if !helper.CheckAuth(r) {
helper.UnauthorizedResult(w)
return
}
+ common.NewSingleHostReverseProxy(common.BING_URL).ServeHTTP(w, r)
}
- common.NewSingleHostReverseProxy(common.BING_URL).ServeHTTP(w, r)
-
}
--- frontend/package.json
@@ -1,6 +1,6 @@
{
"name": "go-proxy-bingai",
- "version": "1.8.2",
+ "version": "1.8.1",
"private": true,
"scripts": {
"dev": "vite",
--- frontend/src/views/chat/components/Chat/Chat.vue
@@ -50,6 +50,8 @@ onMounted(async () => {
// show conversion
SydneyFullScreenConv.initWithWaitlistUpdate({ cookLoc: {} }, 10);
+ initChatService();
+
isShowLoading.value = false;
hackStyle();
initChatPrompt();
@@ -95,7 +97,6 @@ const afterAuth = (data: SysConfig) => {
if (!data.isSysCK) {
userStore.checkUserToken();
}
- initChatService();
};
const initChat = async () => {
|
go-proxy-bingai
|
adams549659584
|
HTML
|
HTML
| 8,773
| 13,135
|
用 Vue3 和 Go 搭建的微软 New Bing 演示站点,拥有一致的 UI 体验,支持 ChatGPT 提示词,国内可用。
|
adams549659584_go-proxy-bingai
|
BUG_FIX
|
obvious
|
a81e481a8f9731b97d1ac8cdfd8b5b15c88d0991
|
2024-03-14 06:42:06
|
Daniel Frederico Lins Leite
|
fix predicate entry fn (#5723) ## Description
This PR fix predicate entry function decoding arguments.
## Checklist
- [ ] I have linked to any relevant issues.
- [ ] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
| false
| 31
| 2
| 33
|
--- forc-plugins/forc-doc/src/tests/expects/impl_trait/mod.rs
@@ -45,7 +45,7 @@ fn test_impl_traits_default() {
assert_search_js(
&doc_path,
&expect![[r#"
- var SEARCH_INDEX={"core":[{"html_filename":"trait.AsRawSlice.html","module_info":["core","raw_slice"],"name":"AsRawSlice","preview":"Trait to return a type as a <code>raw_slice</code>.\n","type_name":"trait"},{"html_filename":"fn.from_str_array.html","module_info":["core","str"],"name":"from_str_array","preview":"","type_name":"function"},{"html_filename":"trait.Add.html","module_info":["core","ops"],"name":"Add","preview":"Trait for the addition of two values.\n","type_name":"trait"},{"html_filename":"trait.Subtract.html","module_info":["core","ops"],"name":"Subtract","preview":"Trait for the subtraction of two values.\n","type_name":"trait"},{"html_filename":"trait.Multiply.html","module_info":["core","ops"],"name":"Multiply","preview":"Trait for the multiplication of two values.\n","type_name":"trait"},{"html_filename":"trait.Divide.html","module_info":["core","ops"],"name":"Divide","preview":"Trait for the division of two values.\n","type_name":"trait"},{"html_filename":"trait.Mod.html","module_info":["core","ops"],"name":"Mod","preview":"Trait for the modulo of two values.\n","type_name":"trait"},{"html_filename":"trait.Not.html","module_info":["core","ops"],"name":"Not","preview":"Trait to invert a type.\n","type_name":"trait"},{"html_filename":"trait.Eq.html","module_info":["core","ops"],"name":"Eq","preview":"Trait to evaluate if two types are equal.\n","type_name":"trait"},{"html_filename":"trait.Ord.html","module_info":["core","ops"],"name":"Ord","preview":"Trait to evaluate if one value is greater or less than another of the same type.\n","type_name":"trait"},{"html_filename":"trait.BitwiseAnd.html","module_info":["core","ops"],"name":"BitwiseAnd","preview":"Trait to bitwise AND two values of the same type.\n","type_name":"trait"},{"html_filename":"trait.BitwiseOr.html","module_info":["core","ops"],"name":"BitwiseOr","preview":"Trait to bitwise OR two values of the same type.\n","type_name":"trait"},{"html_filename":"trait.BitwiseXor.html","module_info":["core","ops"],"name":"BitwiseXor","preview":"Trait to bitwise XOR two values of the same type.\n","type_name":"trait"},{"html_filename":"trait.Shift.html","module_info":["core","ops"],"name":"Shift","preview":"Trait to bit shift a value.\n","type_name":"trait"},{"html_filename":"fn.ok_str_eq.html","module_info":["core","ops"],"name":"ok_str_eq","preview":"","type_name":"function"},{"html_filename":"struct.StorageKey.html","module_info":["core","storage"],"name":"StorageKey","preview":"Describes a location in storage.\n","type_name":"struct"},{"html_filename":"struct.Buffer.html","module_info":["core","codec"],"name":"Buffer","preview":"","type_name":"struct"},{"html_filename":"struct.BufferReader.html","module_info":["core","codec"],"name":"BufferReader","preview":"","type_name":"struct"},{"html_filename":"trait.AbiDecode.html","module_info":["core","codec"],"name":"AbiDecode","preview":"","type_name":"trait"},{"html_filename":"trait.AbiEncode.html","module_info":["core","codec"],"name":"AbiEncode","preview":"","type_name":"trait"},{"html_filename":"fn.encode.html","module_info":["core","codec"],"name":"encode","preview":"","type_name":"function"},{"html_filename":"fn.abi_decode.html","module_info":["core","codec"],"name":"abi_decode","preview":"","type_name":"function"},{"html_filename":"fn.contract_call.html","module_info":["core","codec"],"name":"contract_call","preview":"","type_name":"function"},{"html_filename":"fn.decode_script_data.html","module_info":["core","codec"],"name":"decode_script_data","preview":"","type_name":"function"},{"html_filename":"fn.decode_predicate_data.html","module_info":["core","codec"],"name":"decode_predicate_data","preview":"","type_name":"function"},{"html_filename":"fn.decode_first_param.html","module_info":["core","codec"],"name":"decode_first_param","preview":"","type_name":"function"},{"html_filename":"fn.decode_second_param.html","module_info":["core","codec"],"name":"decode_second_param","preview":"","type_name":"function"}],"impl_traits":[{"html_filename":"trait.Foo.html","module_info":["impl_traits","foo"],"name":"Foo","preview":"","type_name":"trait"},{"html_filename":"trait.Baz.html","module_info":["impl_traits","foo"],"name":"Baz","preview":"","type_name":"trait"},{"html_filename":"struct.Bar.html","module_info":["impl_traits","bar"],"name":"Bar","preview":"","type_name":"struct"}]};
+ var SEARCH_INDEX={"core":[{"html_filename":"trait.AsRawSlice.html","module_info":["core","raw_slice"],"name":"AsRawSlice","preview":"Trait to return a type as a <code>raw_slice</code>.\n","type_name":"trait"},{"html_filename":"fn.from_str_array.html","module_info":["core","str"],"name":"from_str_array","preview":"","type_name":"function"},{"html_filename":"trait.Add.html","module_info":["core","ops"],"name":"Add","preview":"Trait for the addition of two values.\n","type_name":"trait"},{"html_filename":"trait.Subtract.html","module_info":["core","ops"],"name":"Subtract","preview":"Trait for the subtraction of two values.\n","type_name":"trait"},{"html_filename":"trait.Multiply.html","module_info":["core","ops"],"name":"Multiply","preview":"Trait for the multiplication of two values.\n","type_name":"trait"},{"html_filename":"trait.Divide.html","module_info":["core","ops"],"name":"Divide","preview":"Trait for the division of two values.\n","type_name":"trait"},{"html_filename":"trait.Mod.html","module_info":["core","ops"],"name":"Mod","preview":"Trait for the modulo of two values.\n","type_name":"trait"},{"html_filename":"trait.Not.html","module_info":["core","ops"],"name":"Not","preview":"Trait to invert a type.\n","type_name":"trait"},{"html_filename":"trait.Eq.html","module_info":["core","ops"],"name":"Eq","preview":"Trait to evaluate if two types are equal.\n","type_name":"trait"},{"html_filename":"trait.Ord.html","module_info":["core","ops"],"name":"Ord","preview":"Trait to evaluate if one value is greater or less than another of the same type.\n","type_name":"trait"},{"html_filename":"trait.BitwiseAnd.html","module_info":["core","ops"],"name":"BitwiseAnd","preview":"Trait to bitwise AND two values of the same type.\n","type_name":"trait"},{"html_filename":"trait.BitwiseOr.html","module_info":["core","ops"],"name":"BitwiseOr","preview":"Trait to bitwise OR two values of the same type.\n","type_name":"trait"},{"html_filename":"trait.BitwiseXor.html","module_info":["core","ops"],"name":"BitwiseXor","preview":"Trait to bitwise XOR two values of the same type.\n","type_name":"trait"},{"html_filename":"trait.Shift.html","module_info":["core","ops"],"name":"Shift","preview":"Trait to bit shift a value.\n","type_name":"trait"},{"html_filename":"fn.ok_str_eq.html","module_info":["core","ops"],"name":"ok_str_eq","preview":"","type_name":"function"},{"html_filename":"struct.StorageKey.html","module_info":["core","storage"],"name":"StorageKey","preview":"Describes a location in storage.\n","type_name":"struct"},{"html_filename":"struct.Buffer.html","module_info":["core","codec"],"name":"Buffer","preview":"","type_name":"struct"},{"html_filename":"struct.BufferReader.html","module_info":["core","codec"],"name":"BufferReader","preview":"","type_name":"struct"},{"html_filename":"trait.AbiDecode.html","module_info":["core","codec"],"name":"AbiDecode","preview":"","type_name":"trait"},{"html_filename":"trait.AbiEncode.html","module_info":["core","codec"],"name":"AbiEncode","preview":"","type_name":"trait"},{"html_filename":"fn.encode.html","module_info":["core","codec"],"name":"encode","preview":"","type_name":"function"},{"html_filename":"fn.abi_decode.html","module_info":["core","codec"],"name":"abi_decode","preview":"","type_name":"function"},{"html_filename":"fn.contract_call.html","module_info":["core","codec"],"name":"contract_call","preview":"","type_name":"function"},{"html_filename":"fn.decode_script_data.html","module_info":["core","codec"],"name":"decode_script_data","preview":"","type_name":"function"},{"html_filename":"fn.decode_first_param.html","module_info":["core","codec"],"name":"decode_first_param","preview":"","type_name":"function"},{"html_filename":"fn.decode_second_param.html","module_info":["core","codec"],"name":"decode_second_param","preview":"","type_name":"function"}],"impl_traits":[{"html_filename":"trait.Foo.html","module_info":["impl_traits","foo"],"name":"Foo","preview":"","type_name":"trait"},{"html_filename":"trait.Baz.html","module_info":["impl_traits","foo"],"name":"Baz","preview":"","type_name":"trait"},{"html_filename":"struct.Bar.html","module_info":["impl_traits","bar"],"name":"Bar","preview":"","type_name":"struct"}]};
"object"==typeof exports&&"undefined"!=typeof module&&(module.exports=SEARCH_INDEX);"#]],
);
assert_file_tree(
@@ -55,7 +55,6 @@ fn test_impl_traits_default() {
"core/all.html",
"core/codec/fn.abi_decode.html",
"core/codec/fn.contract_call.html",
- "core/codec/fn.decode_predicate_data.html",
"core/codec/fn.decode_first_param.html",
"core/codec/fn.decode_script_data.html",
"core/codec/fn.decode_second_param.html",
--- sway-core/src/semantic_analysis/ast_node/declaration/auto_impl.rs
@@ -628,7 +628,7 @@ where
let args_types = format!("({args_types},)");
format!(
"pub fn __entry() -> bool {{
- let args = decode_predicate_data::<{args_types}>();
+ let args = decode_script_data::<{args_types}>();
main({expanded_args})
}}"
)
--- sway-lib-core/src/codec.sw
@@ -91,26 +91,6 @@ impl BufferReader {
BufferReader { ptr, pos: 0 }
}
- pub fn from_predicate_data() -> BufferReader {
- let predicate_index = asm(r1) {
- gm r1 i3; // GET_VERIFYING_PREDICATE
- r1: u64
- };
- match __gtf::<u8>(predicate_index, 0x200) { // GTF_INPUT_TYPE
- 0u8 => {
- let ptr = __gtf::<raw_ptr>(predicate_index, 0x20C); // INPUT_COIN_PREDICATE_DATA
- let _len = __gtf::<u64>(predicate_index, 0x20A); // INPUT_COIN_PREDICATE_DATA_LENGTH
- BufferReader { ptr, pos: 0 }
- },
- 2u8 => {
- let ptr = __gtf::<raw_ptr>(predicate_index, 0x24A); // INPUT_MESSAGE_PREDICATE_DATA
- let _len = __gtf::<u64>(predicate_index, 0x247); // INPUT_MESSAGE_PREDICATE_DATA_LENGTH
- BufferReader { ptr, pos: 0 }
- },
- _ => __revert(0),
- }
- }
-
pub fn read_bytes(ref mut self, count: u64) -> raw_slice {
let next_pos = self.pos + count;
@@ -3905,14 +3885,6 @@ where
T::abi_decode(buffer)
}
-pub fn decode_predicate_data<T>() -> T
-where
- T: AbiDecode,
-{
- let mut buffer = BufferReader::from_predicate_data();
- T::abi_decode(buffer)
-}
-
pub fn decode_first_param<T>() -> T
where
T: AbiDecode,
|
sway
|
fuellabs
|
Rust
|
Rust
| 62,435
| 5,382
|
🌴 Empowering everyone to build reliable and efficient smart contracts.
|
fuellabs_sway
|
BUG_FIX
|
obvious
|
b2c4552416c394ee562fa8fe05e9b5aa485440cb
| null |
David Luzar
|
feat: re-order zoom buttons (#3837) * feat: re-order zoom buttons * undo last commit & change zoomOut/zoomIn order
| false
| 1
| 1
| 0
|
--- Actions.tsx
@@ -204,8 +204,8 @@ export const ZoomActions = ({
}) => (
<Stack.Col gap={1}>
<Stack.Row gap={1} align="center">
- {renderAction("zoomIn")}
{renderAction("zoomOut")}
+ {renderAction("zoomIn")}
{renderAction("resetZoom")}
</Stack.Row>
</Stack.Col>
|
excalidraw_excalidraw.json
| null | null | null | null | null | null |
excalidraw_excalidraw.json
|
NEW_FEAT
|
5, reorder buttons which is a new feature
|
4fe3a556faf790ba993223cfdda16e281b6cb76d
|
2024-08-19 22:08:53
|
Daniel Hiltgen
|
Add cuda v12 variant and selection logic Based on compute capability and driver version, pick v12 or v11 cuda variants.
| false
| 84
| 48
| 132
|
--- Dockerfile
@@ -1,7 +1,7 @@
ARG GOLANG_VERSION=1.22.5
ARG CMAKE_VERSION=3.22.1
-ARG CUDA_VERSION_11=11.3.1
-ARG CUDA_VERSION_12=12.4.0
+# this CUDA_VERSION corresponds with the one specified in docs/gpu.md
+ARG CUDA_VERSION=11.3.1
ARG ROCM_VERSION=6.1.2
ARG JETPACK_6=r36.2.0
ARG JETPACK_5=r35.4.1
@@ -13,7 +13,7 @@ COPY .git .git
COPY .gitmodules .gitmodules
COPY llm llm
-FROM --platform=linux/amd64 nvidia/cuda:$CUDA_VERSION_11-devel-centos7 AS cuda-11-build-amd64
+FROM --platform=linux/amd64 nvidia/cuda:$CUDA_VERSION-devel-centos7 AS cuda-build-amd64
ARG CMAKE_VERSION
COPY ./scripts/rh_linux_deps.sh /
RUN CMAKE_VERSION=${CMAKE_VERSION} sh /rh_linux_deps.sh
@@ -23,29 +23,9 @@ WORKDIR /go/src/github.com/ollama/ollama/llm/generate
ARG CGO_CFLAGS
ENV GOARCH amd64
RUN --mount=type=cache,target=/root/.ccache \
- OLLAMA_SKIP_STATIC_GENERATE=1 \
- OLLAMA_SKIP_CPU_GENERATE=1 \
- CMAKE_CUDA_ARCHITECTURES="50;52;53;60;61;62;70;72;75;80;86" \
- CUDA_VARIANT="_v11" \
- bash gen_linux.sh
-
-FROM --platform=linux/amd64 nvidia/cuda:$CUDA_VERSION_12-devel-centos7 AS cuda-12-build-amd64
-ARG CMAKE_VERSION
-COPY ./scripts/rh_linux_deps.sh /
-RUN CMAKE_VERSION=${CMAKE_VERSION} sh /rh_linux_deps.sh
-ENV PATH /opt/rh/devtoolset-10/root/usr/bin:$PATH
-COPY --from=llm-code / /go/src/github.com/ollama/ollama/
-WORKDIR /go/src/github.com/ollama/ollama/llm/generate
-ARG CGO_CFLAGS
-ENV GOARCH amd64
-RUN --mount=type=cache,target=/root/.ccache \
- OLLAMA_SKIP_STATIC_GENERATE=1 \
- OLLAMA_SKIP_CPU_GENERATE=1 \
- CMAKE_CUDA_ARCHITECTURES="60;61;62;70;72;75;80;86;87;89;90;90a" \
- CUDA_VARIANT="_v12" \
- bash gen_linux.sh
+ OLLAMA_SKIP_STATIC_GENERATE=1 OLLAMA_SKIP_CPU_GENERATE=1 bash gen_linux.sh
-FROM --platform=linux/arm64 nvidia/cuda:$CUDA_VERSION_11-devel-rockylinux8 AS cuda-11-build-server-arm64
+FROM --platform=linux/arm64 nvidia/cuda:$CUDA_VERSION-devel-rockylinux8 AS cuda-build-server-arm64
ARG CMAKE_VERSION
COPY ./scripts/rh_linux_deps.sh /
RUN CMAKE_VERSION=${CMAKE_VERSION} sh /rh_linux_deps.sh
@@ -54,8 +34,7 @@ COPY --from=llm-code / /go/src/github.com/ollama/ollama/
WORKDIR /go/src/github.com/ollama/ollama/llm/generate
ARG CGO_CFLAGS
ENV GOARCH arm64
-RUN --mount=type=cache,target=/root/.ccache \
- OLLAMA_SKIP_STATIC_GENERATE=1 OLLAMA_SKIP_CPU_GENERATE=1 bash gen_linux.sh
+RUN OLLAMA_SKIP_STATIC_GENERATE=1 OLLAMA_SKIP_CPU_GENERATE=1 bash gen_linux.sh
FROM --platform=linux/arm64 nvcr.io/nvidia/l4t-jetpack:${JETPACK_6} AS cuda-build-jetpack6-arm64
ARG CMAKE_VERSION
@@ -160,10 +139,8 @@ COPY . .
COPY --from=static-build-amd64 /go/src/github.com/ollama/ollama/llm/build/linux/ llm/build/linux/
COPY --from=cpu_avx-build-amd64 /go/src/github.com/ollama/ollama/llm/build/linux/ llm/build/linux/
COPY --from=cpu_avx2-build-amd64 /go/src/github.com/ollama/ollama/llm/build/linux/ llm/build/linux/
-COPY --from=cuda-11-build-amd64 /go/src/github.com/ollama/ollama/dist/ dist/
-COPY --from=cuda-11-build-amd64 /go/src/github.com/ollama/ollama/llm/build/linux/ llm/build/linux/
-COPY --from=cuda-12-build-amd64 /go/src/github.com/ollama/ollama/dist/ dist/
-COPY --from=cuda-12-build-amd64 /go/src/github.com/ollama/ollama/llm/build/linux/ llm/build/linux/
+COPY --from=cuda-build-amd64 /go/src/github.com/ollama/ollama/dist/ dist/
+COPY --from=cuda-build-amd64 /go/src/github.com/ollama/ollama/llm/build/linux/ llm/build/linux/
COPY --from=rocm-build-amd64 /go/src/github.com/ollama/ollama/dist/ dist/
COPY --from=rocm-build-amd64 /go/src/github.com/ollama/ollama/llm/build/linux/ llm/build/linux/
ARG GOFLAGS
@@ -178,8 +155,8 @@ ARG GOLANG_VERSION
WORKDIR /go/src/github.com/ollama/ollama
COPY . .
COPY --from=static-build-arm64 /go/src/github.com/ollama/ollama/llm/build/linux/ llm/build/linux/
-COPY --from=cuda-11-build-server-arm64 /go/src/github.com/ollama/ollama/dist/ dist/
-COPY --from=cuda-11-build-server-arm64 /go/src/github.com/ollama/ollama/llm/build/linux/ llm/build/linux/
+COPY --from=cuda-build-server-arm64 /go/src/github.com/ollama/ollama/dist/ dist/
+COPY --from=cuda-build-server-arm64 /go/src/github.com/ollama/ollama/llm/build/linux/ llm/build/linux/
## arm binary += 381M
COPY --from=cuda-build-jetpack6-arm64 /go/src/github.com/ollama/ollama/llm/build/linux/ llm/build/linux/
COPY --from=cuda-build-jetpack6-arm64 /go/src/github.com/ollama/ollama/dist/ dist/
--- gpu/cuda_common.go
@@ -4,17 +4,9 @@ package gpu
import (
"log/slog"
- "os"
- "regexp"
- "runtime"
- "strconv"
"strings"
)
-// Jetson devices have JETSON_JETPACK="x.y.z" factory set to the Jetpack version installed.
-// Included to drive logic for reducing Ollama-allocated overhead on L4T/Jetson devices.
-var CudaTegra string = os.Getenv("JETSON_JETPACK")
-
func cudaGetVisibleDevicesEnv(gpuInfo []GpuInfo) (string, string) {
ids := []string{}
for _, info := range gpuInfo {
@@ -27,38 +19,3 @@ func cudaGetVisibleDevicesEnv(gpuInfo []GpuInfo) (string, string) {
}
return "CUDA_VISIBLE_DEVICES", strings.Join(ids, ",")
}
-
-func cudaGetVariant(gpuInfo CudaGPUInfo) string {
- if runtime.GOARCH == "arm64" && runtime.GOOS == "linux" {
- if CudaTegra != "" {
- ver := strings.Split(CudaTegra, ".")
- if len(ver) > 0 {
- return "jetpack" + ver[0]
- }
- } else if data, err := os.ReadFile("/etc/nv_tegra_release"); err == nil {
- r := regexp.MustCompile(` R(\d+) `)
- m := r.FindSubmatch(data)
- if len(m) != 2 {
- slog.Info("Unexpected format for /etc/nv_tegra_release. Set JETSON_JETPACK to select version")
- } else {
- if l4t, err := strconv.Atoi(string(m[1])); err == nil {
- // Note: mapping from L4t -> JP is inconsistent (can't just subtract 30)
- // https://developer.nvidia.com/embedded/jetpack-archive
- switch l4t {
- case 35:
- return "jetpack5"
- case 36:
- return "jetpack6"
- default:
- slog.Info("unsupported L4T version", "nv_tegra_release", string(data))
- }
- }
- }
- }
- }
-
- if gpuInfo.computeMajor < 6 || gpuInfo.DriverMajor < 12 {
- return "v11"
- }
- return "v12"
-}
--- gpu/gpu.go
@@ -15,7 +15,9 @@ import (
"log/slog"
"os"
"path/filepath"
+ "regexp"
"runtime"
+ "strconv"
"strings"
"sync"
"unsafe"
@@ -64,6 +66,10 @@ var RocmComputeMin = 9
// TODO find a better way to detect iGPU instead of minimum memory
const IGPUMemLimit = 1 * format.GibiByte // 512G is what they typically report, so anything less than 1G must be iGPU
+// Jetson devices have JETSON_JETPACK="x.y.z" factory set to the Jetpack version installed.
+// Included to drive logic for reducing Ollama-allocated overhead on L4T/Jetson devices.
+var CudaTegra string = os.Getenv("JETSON_JETPACK")
+
// Note: gpuMutex must already be held
func initCudaHandles() *cudaHandles {
// TODO - if the ollama build is CPU only, don't do these checks as they're irrelevant and confusing
@@ -227,6 +233,35 @@ func GetGPUInfo() GpuInfoList {
depPath := GetDepDir()
+ var cudaVariant string
+ if runtime.GOARCH == "arm64" && runtime.GOOS == "linux" {
+ if CudaTegra != "" {
+ ver := strings.Split(CudaTegra, ".")
+ if len(ver) > 0 {
+ cudaVariant = "jetpack" + ver[0]
+ }
+ } else if data, err := os.ReadFile("/etc/nv_tegra_release"); err == nil {
+ r := regexp.MustCompile(` R(\d+) `)
+ m := r.FindSubmatch(data)
+ if len(m) != 2 {
+ slog.Info("Unexpected format for /etc/nv_tegra_release. Set JETSON_JETPACK to select version")
+ } else {
+ if l4t, err := strconv.Atoi(string(m[1])); err == nil {
+ // Note: mapping from L4t -> JP is inconsistent (can't just subtract 30)
+ // https://developer.nvidia.com/embedded/jetpack-archive
+ switch l4t {
+ case 35:
+ cudaVariant = "jetpack5"
+ case 36:
+ cudaVariant = "jetpack6"
+ default:
+ slog.Info("unsupported L4T version", "nv_tegra_release", string(data))
+ }
+ }
+ }
+ }
+ }
+
// Load ALL libraries
cHandles = initCudaHandles()
@@ -236,6 +271,7 @@ func GetGPUInfo() GpuInfoList {
gpuInfo := CudaGPUInfo{
GpuInfo: GpuInfo{
Library: "cuda",
+ Variant: cudaVariant,
},
index: i,
}
@@ -261,10 +297,7 @@ func GetGPUInfo() GpuInfoList {
gpuInfo.FreeMemory = uint64(memInfo.free)
gpuInfo.ID = C.GoString(&memInfo.gpu_id[0])
gpuInfo.Compute = fmt.Sprintf("%d.%d", memInfo.major, memInfo.minor)
- gpuInfo.computeMajor = int(memInfo.major)
- gpuInfo.computeMinor = int(memInfo.minor)
gpuInfo.MinimumMemory = cudaMinimumMemory
- cudaVariant := cudaGetVariant(gpuInfo)
if depPath != "" {
gpuInfo.DependencyPath = depPath
// Check for variant specific directory
@@ -277,7 +310,6 @@ func GetGPUInfo() GpuInfoList {
gpuInfo.Name = C.GoString(&memInfo.gpu_name[0])
gpuInfo.DriverMajor = driverMajor
gpuInfo.DriverMinor = driverMinor
- gpuInfo.Variant = cudaGetVariant(gpuInfo)
// query the management library as well so we can record any skew between the two
// which represents overhead on the GPU we must set aside on subsequent updates
--- gpu/types.go
@@ -53,10 +53,8 @@ type CPUInfo struct {
type CudaGPUInfo struct {
GpuInfo
- OSOverhead uint64 // Memory overhead between the driver library and management library
- index int //nolint:unused,nolintlint
- computeMajor int //nolint:unused,nolintlint
- computeMinor int //nolint:unused,nolintlint
+ OSOverhead uint64 // Memory overhead between the driver library and management library
+ index int //nolint:unused,nolintlint
}
type CudaGPUInfoList []CudaGPUInfo
|
ollama
|
ollama
|
Go
|
Go
| 131,099
| 10,753
|
Get up and running with Llama 3.3, DeepSeek-R1, Phi-4, Gemma 2, and other large language models.
|
ollama_ollama
|
NEW_FEAT
|
obvious
|
129306fd9e9698a6605864f26160c1462ba6a32e
|
2022-10-20 09:23:18
|
bannedbook
|
update
| false
| 0
| 0
| 0
|
--- docs/vsp.py
Binary files a/docs/vsp.py and b/docs/vsp.py differ
|
fanqiang
|
bannedbook
|
Kotlin
|
Kotlin
| 39,286
| 7,317
|
翻墙-科学上网
|
bannedbook_fanqiang
|
DOC_CHANGE
|
binary changes in .py files inside docs folder
|
68a2c9e85f4e304135b3c4320fd89623b50a9eb4
|
2024-06-25 06:54:54
|
Jelly Lee
|
Create deploy.sh
| false
| 142
| 0
| 142
|
--- llm-localization/ascend/mindie/docker/deploy.sh
@@ -1,142 +0,0 @@
-#!/bin/bash
-
-echo "入参:" $@
-
-for a in "$@"; do
- #echo $a
- if [[ `echo $a | grep "^--model_name="` ]]; then
- model_name=`echo $a | grep "^--model_name=" | awk -F '=' '{print $2}'`
- fi
- if [[ `echo $a | grep "^--model_weight_path="` ]]; then
- model_weight_path=`echo $a | grep "^--model_weight_path=" | awk -F '=' '{print $2}'`
- fi
- if [[ `echo $a | grep "^--world_size="` ]]; then
- world_size=`echo $a | grep "^--world_size=" | awk -F '=' '{print $2}'`
- fi
- if [[ `echo $a | grep "^--npu_mem_size="` ]]; then
- npu_mem_size=`echo $a | grep "^--npu_mem_size=" | awk -F '=' '{print $2}'`
- fi
-done
-
-if [ -z "$model_name" ]; then
- model_name="default"
-fi
-
-if [ -z "$model_weight_path" ]; then
- model_weight_path="/workspace/models"
-fi
-
-if [ -z "$world_size" ]; then
- world_size=4
-fi
-
-if [ -z "$npu_mem_size" ]; then
- npu_mem_size=8
-fi
-
-echo "平台入参: model_name: $model_name, model_weight_path: $model_weight_path , world_size: $world_size , npu_mem_size: $npu_mem_size"
-
-
-npuids=""
-card_num=$(($world_size - 1))
-for i in `seq 0 $card_num`
- do
- if [[ $i == $card_num ]] ;
- then
- npuids=$npuids$i
- else
- npuids=$npuids$i","
- fi
- done
-
-
-echo $npuids
-
-
-DEPLOYMENT_CONF_PATH="/home/guodong.li/workspace/config.json"
-
-# DEPLOYMENT_CONF_PATH="/usr/local/Ascend/mindie/latest/mindie-service/conf/config.json"
-
-cat <<EOF > $DEPLOYMENT_CONF_PATH
-{
- "OtherParam":
- {
- "ResourceParam" :
- {
- "cacheBlockSize" : 128,
- "preAllocBlocks" : 4
- },
- "LogParam" :
- {
- "logLevel" : "Info",
- "logPath" : "/logs/mindservice.log"
- },
- "ServeParam" :
- {
- "ipAddress" : "0.0.0.0",
- "port" : 1025,
- "maxLinkNum" : 300,
- "httpsEnabled" : false,
- "tlsCaPath" : "security/ca/",
- "tlsCaFile" : ["ca.pem"],
- "tlsCert" : "security/certs/server.pem",
- "tlsPk" : "security/keys/server.key.pem",
- "tlsPkPwd" : "security/pass/mindie_server_key_pwd.txt",
- "kmcKsfMaster" : "tools/pmt/master/ksfa",
- "kmcKsfStandby" : "tools/pmt/standby/ksfb",
- "tlsCrl" : "security/certs/server_crl.pem"
- }
- },
- "WorkFlowParam":
- {
- "TemplateParam" :
- {
- "templateType": "Standard",
- "templateName" : "Standard_llama",
- "pipelineNumber" : 1
- }
- },
- "ModelDeployParam":
- {
- "maxSeqLen" : 2560,
- "npuDeviceIds" : [[$npuids]],
- "ModelParam" : [
- {
- "modelInstanceType": "Standard",
- "modelName" : "$model_name",
- "modelWeightPath" : "$model_weight_path",
- "worldSize" : $world_size,
- "cpuMemSize" : 5,
- "npuMemSize" : $npu_mem_size,
- "backendType": "atb"
- }
- ]
- },
- "ScheduleParam":
- {
- "maxPrefillBatchSize" : 50,
- "maxPrefillTokens" : 8192,
- "prefillTimeMsPerReq" : 150,
- "prefillPolicyType" : 0,
- "decodeTimeMsPerReq" : 50,
- "decodePolicyType" : 0,
- "maxBatchSize" : 200,
- "maxIterTimes" : 512,
- "maxPreemptCount" : 200,
- "supportSelectBatch" : false,
- "maxQueueDelayMicroseconds" : 5000
- }
-}
-EOF
-
-echo "部署参数,$DEPLOYMENT_CONF_PATH"
-cat $DEPLOYMENT_CONF_PATH
-
-# source /usr/local/Ascend/ascend-toolkit/set_env.sh
-# source /usr/local/Ascend/mindie/set_env.sh
-# source /usr/local/Ascend/llm_model/set_env.sh
-
-# export PYTHONPATH=/usr/local/Ascend/llm_model:$PYTHONPATH
-# cd /usr/local/Ascend/mindie/latest/mindie-service/bin
-
-# ./mindieservice_daemon
|
llm-action
|
liguodongiot
|
HTML
|
HTML
| 15,588
| 1,812
|
本项目旨在分享大模型相关技术原理以及实战经验(大模型工程化、大模型应用落地)
|
liguodongiot_llm-action
|
NEW_FEAT
|
Obvious
|
b56548969a835479f66b82551f84bab0131db760
|
2025-02-24 22:50:04
|
Iwo Plaza
|
Use implicit namespace to better align Animated module with OSS types (#49559) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/49559 ## Motivation Modernising the RN codebase to allow for modern Flow tooling to process it. ## This diff Renames `Animated.js` to `AnimatedExports.js`, and introduces an intermediate file that reexports `* as Animated` as a default. This should have equivalent runtime behavior, but allows for a common interface file: `Animated.js.flow` to reinterpret the module as having single exports. TypeScript treats this as a namespace. Changelog: [Internal] Reviewed By: huntie Differential Revision: D69849314 fbshipit-source-id: cdaa605ba5361d3349c6dd0e84fd0fbfee263941
| false
| 214
| 86
| 300
|
--- packages/react-native/Libraries/Animated/Animated.js
@@ -4,12 +4,45 @@
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
- * @flow strict-local
+ * @flow
* @format
- * @oncall react_native
*/
-import * as Animated from './AnimatedExports';
+export type {CompositeAnimation, Numeric} from './AnimatedImplementation';
-export type {CompositeAnimation, Numeric} from './AnimatedTypes';
-export default Animated;
+import typeof AnimatedFlatList from './components/AnimatedFlatList';
+import typeof AnimatedImage from './components/AnimatedImage';
+import typeof AnimatedScrollView from './components/AnimatedScrollView';
+import typeof AnimatedSectionList from './components/AnimatedSectionList';
+import typeof AnimatedText from './components/AnimatedText';
+import typeof AnimatedView from './components/AnimatedView';
+
+import Platform from '../Utilities/Platform';
+import AnimatedImplementation from './AnimatedImplementation';
+import AnimatedMock from './AnimatedMock';
+
+const Animated: typeof AnimatedImplementation = Platform.isDisableAnimations
+ ? AnimatedMock
+ : AnimatedImplementation;
+
+export default {
+ get FlatList(): AnimatedFlatList {
+ return require('./components/AnimatedFlatList').default;
+ },
+ get Image(): AnimatedImage {
+ return require('./components/AnimatedImage').default;
+ },
+ get ScrollView(): AnimatedScrollView {
+ return require('./components/AnimatedScrollView').default;
+ },
+ get SectionList(): AnimatedSectionList {
+ return require('./components/AnimatedSectionList').default;
+ },
+ get Text(): AnimatedText {
+ return require('./components/AnimatedText').default;
+ },
+ get View(): AnimatedView {
+ return require('./components/AnimatedView').default;
+ },
+ ...Animated,
+};
--- packages/react-native/Libraries/Animated/AnimatedExports.js
@@ -1,49 +0,0 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * @flow
- * @format
- * @oncall react_native
- */
-
-import typeof AnimatedFlatList from './components/AnimatedFlatList';
-import typeof AnimatedImage from './components/AnimatedImage';
-import typeof AnimatedScrollView from './components/AnimatedScrollView';
-import typeof AnimatedSectionList from './components/AnimatedSectionList';
-import typeof AnimatedText from './components/AnimatedText';
-import typeof AnimatedView from './components/AnimatedView';
-
-import Platform from '../Utilities/Platform';
-import AnimatedImplementation from './AnimatedImplementation';
-import AnimatedMock from './AnimatedMock';
-
-const Animated: typeof AnimatedImplementation = Platform.isDisableAnimations
- ? AnimatedMock
- : AnimatedImplementation;
-
-// Treating this as multiple lazy export statements
-// eslint-disable-next-line lint/no-commonjs-exports
-module.exports = {
- get FlatList(): AnimatedFlatList {
- return require('./components/AnimatedFlatList').default;
- },
- get Image(): AnimatedImage {
- return require('./components/AnimatedImage').default;
- },
- get ScrollView(): AnimatedScrollView {
- return require('./components/AnimatedScrollView').default;
- },
- get SectionList(): AnimatedSectionList {
- return require('./components/AnimatedSectionList').default;
- },
- get Text(): AnimatedText {
- return require('./components/AnimatedText').default;
- },
- get View(): AnimatedView {
- return require('./components/AnimatedView').default;
- },
- ...Animated,
-};
--- packages/react-native/Libraries/Animated/AnimatedExports.js.flow
@@ -1,46 +0,0 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * @flow
- * @format
- * @oncall react_native
- */
-
-import AnimatedImplementation from './AnimatedImplementation';
-
-export {default as FlatList} from './components/AnimatedFlatList';
-export {default as Image} from './components/AnimatedImage';
-export {default as ScrollView} from './components/AnimatedScrollView';
-export {default as SectionList} from './components/AnimatedSectionList';
-export {default as Text} from './components/AnimatedText';
-export {default as View} from './components/AnimatedView';
-export {default as Color} from './nodes/AnimatedColor';
-export {AnimatedEvent as Event} from './AnimatedEvent';
-export {default as Interpolation} from './nodes/AnimatedInterpolation';
-export {default as Node} from './nodes/AnimatedNode';
-export {default as Value} from './nodes/AnimatedValue';
-export {default as ValueXY} from './nodes/AnimatedValueXY';
-
-export const add = AnimatedImplementation.add;
-export const attachNativeEvent = AnimatedImplementation.attachNativeEvent;
-export const createAnimatedComponent =
- AnimatedImplementation.createAnimatedComponent;
-export const decay = AnimatedImplementation.decay;
-export const delay = AnimatedImplementation.delay;
-export const diffClamp = AnimatedImplementation.diffClamp;
-export const divide = AnimatedImplementation.divide;
-export const event = AnimatedImplementation.event;
-export const forkEvent = AnimatedImplementation.forkEvent;
-export const loop = AnimatedImplementation.loop;
-export const modulo = AnimatedImplementation.modulo;
-export const multiply = AnimatedImplementation.multiply;
-export const parallel = AnimatedImplementation.parallel;
-export const sequence = AnimatedImplementation.sequence;
-export const spring = AnimatedImplementation.spring;
-export const stagger = AnimatedImplementation.stagger;
-export const subtract = AnimatedImplementation.subtract;
-export const timing = AnimatedImplementation.timing;
-export const unforkEvent = AnimatedImplementation.unforkEvent;
--- packages/react-native/Libraries/Animated/AnimatedImplementation.js
@@ -11,7 +11,6 @@
'use strict';
import type {EventConfig, Mapping} from './AnimatedEvent';
-import type {CompositeAnimation} from './AnimatedTypes';
import type {
AnimationConfig,
EndCallback,
@@ -39,7 +38,14 @@ import AnimatedTracking from './nodes/AnimatedTracking';
import AnimatedValue from './nodes/AnimatedValue';
import AnimatedValueXY from './nodes/AnimatedValueXY';
-export type {CompositeAnimation, Numeric} from './AnimatedTypes';
+export type CompositeAnimation = {
+ start: (callback?: ?EndCallback, isLooping?: boolean) => void,
+ stop: () => void,
+ reset: () => void,
+ _startNativeLoop: (iterations?: number) => void,
+ _isUsingNativeDriver: () => boolean,
+ ...
+};
const add = function (
a: AnimatedNode | number,
@@ -546,6 +552,19 @@ const event = function (
}
};
+// All types of animated nodes that represent scalar numbers and can be interpolated (etc)
+type AnimatedNumeric =
+ | AnimatedAddition
+ | AnimatedDiffClamp
+ | AnimatedDivision
+ | AnimatedInterpolation<number>
+ | AnimatedModulo
+ | AnimatedMultiplication
+ | AnimatedSubtraction
+ | AnimatedValue;
+
+export type {AnimatedNumeric as Numeric};
+
/**
* The `Animated` library is designed to make animations fluid, powerful, and
* easy to build and maintain. `Animated` focuses on declarative relationships
--- packages/react-native/Libraries/Animated/AnimatedTypes.js
@@ -1,40 +0,0 @@
-/**
- * Copyright (c) Meta Platforms, Inc. and affiliates.
- *
- * This source code is licensed under the MIT license found in the
- * LICENSE file in the root directory of this source tree.
- *
- * @flow strict-local
- * @format
- * @oncall react_native
- */
-
-import type {EndCallback} from './animations/Animation';
-import type AnimatedAddition from './nodes/AnimatedAddition';
-import type AnimatedDiffClamp from './nodes/AnimatedDiffClamp';
-import type AnimatedDivision from './nodes/AnimatedDivision';
-import type AnimatedInterpolation from './nodes/AnimatedInterpolation';
-import type AnimatedModulo from './nodes/AnimatedModulo';
-import type AnimatedMultiplication from './nodes/AnimatedMultiplication';
-import type AnimatedSubtraction from './nodes/AnimatedSubtraction';
-import type AnimatedValue from './nodes/AnimatedValue';
-
-export type CompositeAnimation = {
- start: (callback?: ?EndCallback, isLooping?: boolean) => void,
- stop: () => void,
- reset: () => void,
- _startNativeLoop: (iterations?: number) => void,
- _isUsingNativeDriver: () => boolean,
- ...
-};
-
-// All types of animated nodes that represent scalar numbers and can be interpolated (etc)
-export type Numeric =
- | AnimatedAddition
- | AnimatedDiffClamp
- | AnimatedDivision
- | AnimatedInterpolation<number>
- | AnimatedModulo
- | AnimatedMultiplication
- | AnimatedSubtraction
- | AnimatedValue;
--- packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap
@@ -112,8 +112,17 @@ exports[`public API should not change unintentionally Libraries/Alert/RCTAlertMa
`;
exports[`public API should not change unintentionally Libraries/Animated/Animated.js 1`] = `
-"export type { CompositeAnimation, Numeric } from \\"./AnimatedTypes\\";
-declare export default typeof Animated;
+"export type { CompositeAnimation, Numeric } from \\"./AnimatedImplementation\\";
+declare const Animated: typeof AnimatedImplementation;
+declare export default {
+ get FlatList(): AnimatedFlatList,
+ get Image(): AnimatedImage,
+ get ScrollView(): AnimatedScrollView,
+ get SectionList(): AnimatedSectionList,
+ get Text(): AnimatedText,
+ get View(): AnimatedView,
+ ...Animated,
+};
"
`;
@@ -139,57 +148,13 @@ declare export class AnimatedEvent {
"
`;
-exports[`public API should not change unintentionally Libraries/Animated/AnimatedExports.js 1`] = `
-"declare const Animated: typeof AnimatedImplementation;
-declare module.exports: {
- get FlatList(): AnimatedFlatList,
- get Image(): AnimatedImage,
- get ScrollView(): AnimatedScrollView,
- get SectionList(): AnimatedSectionList,
- get Text(): AnimatedText,
- get View(): AnimatedView,
- ...Animated,
-};
-"
-`;
-
-exports[`public API should not change unintentionally Libraries/Animated/AnimatedExports.js.flow 1`] = `
-"export { default as FlatList } from \\"./components/AnimatedFlatList\\";
-export { default as Image } from \\"./components/AnimatedImage\\";
-export { default as ScrollView } from \\"./components/AnimatedScrollView\\";
-export { default as SectionList } from \\"./components/AnimatedSectionList\\";
-export { default as Text } from \\"./components/AnimatedText\\";
-export { default as View } from \\"./components/AnimatedView\\";
-export { default as Color } from \\"./nodes/AnimatedColor\\";
-export { AnimatedEvent as Event } from \\"./AnimatedEvent\\";
-export { default as Interpolation } from \\"./nodes/AnimatedInterpolation\\";
-export { default as Node } from \\"./nodes/AnimatedNode\\";
-export { default as Value } from \\"./nodes/AnimatedValue\\";
-export { default as ValueXY } from \\"./nodes/AnimatedValueXY\\";
-declare export const add: $FlowFixMe;
-declare export const attachNativeEvent: $FlowFixMe;
-declare export const createAnimatedComponent: $FlowFixMe;
-declare export const decay: $FlowFixMe;
-declare export const delay: $FlowFixMe;
-declare export const diffClamp: $FlowFixMe;
-declare export const divide: $FlowFixMe;
-declare export const event: $FlowFixMe;
-declare export const forkEvent: $FlowFixMe;
-declare export const loop: $FlowFixMe;
-declare export const modulo: $FlowFixMe;
-declare export const multiply: $FlowFixMe;
-declare export const parallel: $FlowFixMe;
-declare export const sequence: $FlowFixMe;
-declare export const spring: $FlowFixMe;
-declare export const stagger: $FlowFixMe;
-declare export const subtract: $FlowFixMe;
-declare export const timing: $FlowFixMe;
-declare export const unforkEvent: $FlowFixMe;
-"
-`;
-
exports[`public API should not change unintentionally Libraries/Animated/AnimatedImplementation.js 1`] = `
-"export type { CompositeAnimation, Numeric } from \\"./AnimatedTypes\\";
+"export type CompositeAnimation = {
+ start: (callback?: ?EndCallback, isLooping?: boolean) => void,
+ stop: () => void,
+ reset: () => void,
+ ...
+};
declare const add: (
a: AnimatedNode | number,
b: AnimatedNode | number
@@ -261,6 +226,16 @@ declare const event: (
argMapping: $ReadOnlyArray<?Mapping>,
config: EventConfig
) => any;
+type AnimatedNumeric =
+ | AnimatedAddition
+ | AnimatedDiffClamp
+ | AnimatedDivision
+ | AnimatedInterpolation<number>
+ | AnimatedModulo
+ | AnimatedMultiplication
+ | AnimatedSubtraction
+ | AnimatedValue;
+export type { AnimatedNumeric as Numeric };
declare export default {
Value: AnimatedValue,
ValueXY: AnimatedValueXY,
@@ -308,25 +283,6 @@ exports[`public API should not change unintentionally Libraries/Animated/Animate
"
`;
-exports[`public API should not change unintentionally Libraries/Animated/AnimatedTypes.js 1`] = `
-"export type CompositeAnimation = {
- start: (callback?: ?EndCallback, isLooping?: boolean) => void,
- stop: () => void,
- reset: () => void,
- ...
-};
-export type Numeric =
- | AnimatedAddition
- | AnimatedDiffClamp
- | AnimatedDivision
- | AnimatedInterpolation<number>
- | AnimatedModulo
- | AnimatedMultiplication
- | AnimatedSubtraction
- | AnimatedValue;
-"
-`;
-
exports[`public API should not change unintentionally Libraries/Animated/Easing.js 1`] = `
"declare const Easing: {
step0(n: number): number,
--- scripts/build/build-types/buildTypes.js
@@ -28,7 +28,6 @@ const IGNORE_PATTERNS = [
const ENTRY_POINTS = [
'packages/react-native/Libraries/ActionSheetIOS/ActionSheetIOS.js',
'packages/react-native/Libraries/Alert/Alert.js',
- 'packages/react-native/Libraries/Animated/Animated.js',
'packages/react-native/Libraries/AppState/AppState.js',
'packages/react-native/Libraries/BatchedBridge/NativeModules.js',
'packages/react-native/Libraries/Blob/Blob.js',
|
react-native
|
facebook
|
C++
|
C++
| 120,863
| 24,536
|
A framework for building native applications using React
|
facebook_react-native
|
CODE_IMPROVEMENT
|
renaming and restructuring of files
|
9b634444e799c47fd88ab9f5f7787e5a35569a09
|
2024-02-22 20:44:57
|
Vinta Chen
|
remove Compatibility section
| false
| 0
| 9
| 9
|
--- README.md
@@ -19,6 +19,7 @@ Inspired by [awesome-php](https://github.com/ziadoz/awesome-php).
- [Code Analysis](#code-analysis)
- [Command-line Interface Development](#command-line-interface-development)
- [Command-line Tools](#command-line-tools)
+ - [Compatibility](#compatibility)
- [Computer Vision](#computer-vision)
- [Concurrency and Parallelism](#concurrency-and-parallelism)
- [Configuration](#configuration)
@@ -287,6 +288,14 @@ Inspired by [awesome-php](https://github.com/ziadoz/awesome-php).
* [mycli](https://github.com/dbcli/mycli) - MySQL CLI with autocompletion and syntax highlighting.
* [pgcli](https://github.com/dbcli/pgcli) - PostgreSQL CLI with autocompletion and syntax highlighting.
+## Compatibility
+
+*Libraries for migrating from Python 2 to 3.*
+
+* [python-future](http://python-future.org/index.html) - The missing compatibility layer between Python 2 and Python 3.
+* [modernize](https://github.com/PyCQA/modernize) - Modernizes Python code for eventual Python 3 migration.
+* [six](https://pypi.org/project/six/) - Python 2 and 3 compatibility utilities.
+
## Computer Vision
*Libraries for Computer Vision.*
|
awesome-python
|
vinta
|
Python
|
Python
| 236,071
| 25,368
|
An opinionated list of awesome Python frameworks, libraries, software and resources.
|
vinta_awesome-python
|
DOC_CHANGE
|
Obvious
|
3c7667a694face1827356a7c90ee6f86a9c0baa0
|
2024-09-26 00:03:11
|
Andrew Clark
|
Unify perform{Sync,Concurrent}WorkOnRoot implementation (#31029) Over time the behavior of these two paths has converged to be
essentially the same. So this merges them back into one function. This
should save some code size and also make it harder for the behavior to
accidentally diverge. (For the same reason, rolling out this change
might expose some areas where we had already accidentally diverged.)
| false
| 115
| 176
| 291
|
--- packages/react-reconciler/src/ReactFiberRootScheduler.js
@@ -15,9 +15,6 @@ import type {BatchConfigTransition} from './ReactFiberTracingMarkerComponent';
import {
disableLegacyMode,
enableDeferRootSchedulingToMicrotask,
- disableSchedulerTimeoutInWorkLoop,
- enableProfilerTimer,
- enableProfilerNestedUpdatePhase,
} from 'shared/ReactFeatureFlags';
import {
NoLane,
@@ -34,12 +31,12 @@ import {
CommitContext,
NoContext,
RenderContext,
- flushPassiveEffects,
getExecutionContext,
getWorkInProgressRoot,
getWorkInProgressRootRenderLanes,
isWorkLoopSuspendedOnData,
- performWorkOnRoot,
+ performConcurrentWorkOnRoot,
+ performSyncWorkOnRoot,
} from './ReactFiberWorkLoop';
import {LegacyRoot} from './ReactRootTags';
import {
@@ -65,10 +62,6 @@ import {
} from './ReactFiberConfig';
import ReactSharedInternals from 'shared/ReactSharedInternals';
-import {
- resetNestedUpdateFlag,
- syncNestedUpdateFlag,
-} from './ReactProfilerTimer';
// A linked list of all the roots with pending work. In an idiomatic app,
// there's only a single root, but we do support multi root apps, hence this
@@ -394,7 +387,7 @@ function scheduleTaskForRootDuringMicrotask(
const newCallbackNode = scheduleCallback(
schedulerPriorityLevel,
- performWorkOnRootViaSchedulerTask.bind(null, root),
+ performConcurrentWorkOnRoot.bind(null, root),
);
root.callbackPriority = newCallbackPriority;
@@ -403,67 +396,15 @@ function scheduleTaskForRootDuringMicrotask(
}
}
-type RenderTaskFn = (didTimeout: boolean) => RenderTaskFn | null;
+export type RenderTaskFn = (didTimeout: boolean) => RenderTaskFn | null;
-function performWorkOnRootViaSchedulerTask(
+export function getContinuationForRoot(
root: FiberRoot,
- didTimeout: boolean,
+ originalCallbackNode: mixed,
): RenderTaskFn | null {
- // This is the entry point for concurrent tasks scheduled via Scheduler (and
- // postTask, in the future).
-
- if (enableProfilerTimer && enableProfilerNestedUpdatePhase) {
- resetNestedUpdateFlag();
- }
-
- // Flush any pending passive effects before deciding which lanes to work on,
- // in case they schedule additional work.
- const originalCallbackNode = root.callbackNode;
- const didFlushPassiveEffects = flushPassiveEffects();
- if (didFlushPassiveEffects) {
- // Something in the passive effect phase may have canceled the current task.
- // Check if the task node for this root was changed.
- if (root.callbackNode !== originalCallbackNode) {
- // The current task was canceled. Exit. We don't need to call
- // `ensureRootIsScheduled` because the check above implies either that
- // there's a new task, or that there's no remaining work on this root.
- return null;
- } else {
- // Current task was not canceled. Continue.
- }
- }
-
- // Determine the next lanes to work on, using the fields stored on the root.
- // TODO: We already called getNextLanes when we scheduled the callback; we
- // should be able to avoid calling it again by stashing the result on the
- // root object. However, because we always schedule the callback during
- // a microtask (scheduleTaskForRootDuringMicrotask), it's possible that
- // an update was scheduled earlier during this same browser task (and
- // therefore before the microtasks have run). That's because Scheduler batches
- // together multiple callbacks into a single browser macrotask, without
- // yielding to microtasks in between. We should probably change this to align
- // with the postTask behavior (and literally use postTask when
- // it's available).
- const workInProgressRoot = getWorkInProgressRoot();
- const workInProgressRootRenderLanes = getWorkInProgressRootRenderLanes();
- const lanes = getNextLanes(
- root,
- root === workInProgressRoot ? workInProgressRootRenderLanes : NoLanes,
- );
- if (lanes === NoLanes) {
- // No more work on this root.
- return null;
- }
-
- // Enter the work loop.
- // TODO: We only check `didTimeout` defensively, to account for a Scheduler
- // bug we're still investigating. Once the bug in Scheduler is fixed,
- // we can remove this, since we track expiration ourselves.
- const forceSync = !disableSchedulerTimeoutInWorkLoop && didTimeout;
- performWorkOnRoot(root, lanes, forceSync);
-
- // The work loop yielded, but there may or may not be work left at the current
- // priority. Need to determine whether we need to schedule a continuation.
+ // This is called at the end of `performConcurrentWorkOnRoot` to determine
+ // if we need to schedule a continuation task.
+ //
// Usually `scheduleTaskForRootDuringMicrotask` only runs inside a microtask;
// however, since most of the logic for determining if we need a continuation
// versus a new task is the same, we cheat a bit and call it here. This is
@@ -473,27 +414,11 @@ function performWorkOnRootViaSchedulerTask(
if (root.callbackNode === originalCallbackNode) {
// The task node scheduled for this root is the same one that's
// currently executed. Need to return a continuation.
- return performWorkOnRootViaSchedulerTask.bind(null, root);
+ return performConcurrentWorkOnRoot.bind(null, root);
}
return null;
}
-function performSyncWorkOnRoot(root: FiberRoot, lanes: Lanes) {
- // This is the entry point for synchronous tasks that don't go
- // through Scheduler.
- const didFlushPassiveEffects = flushPassiveEffects();
- if (didFlushPassiveEffects) {
- // If passive effects were flushed, exit to the outer work loop in the root
- // scheduler, so we can recompute the priority.
- return null;
- }
- if (enableProfilerTimer && enableProfilerNestedUpdatePhase) {
- syncNestedUpdateFlag();
- }
- const forceSync = true;
- performWorkOnRoot(root, lanes, forceSync);
-}
-
const fakeActCallbackNode = {};
function scheduleCallback(
--- packages/react-reconciler/src/ReactFiberWorkLoop.js
@@ -22,6 +22,7 @@ import type {
TransitionAbort,
} from './ReactFiberTracingMarkerComponent';
import type {OffscreenInstance} from './ReactFiberActivityComponent';
+import type {RenderTaskFn} from './ReactFiberRootScheduler';
import type {Resource} from './ReactFiberConfig';
import {
@@ -31,6 +32,7 @@ import {
enableProfilerNestedUpdatePhase,
enableDebugTracing,
enableSchedulingProfiler,
+ disableSchedulerTimeoutInWorkLoop,
enableUpdaterTracking,
enableCache,
enableTransitionTracing,
@@ -248,9 +250,11 @@ import {
recordRenderTime,
recordCommitTime,
recordCommitEndTime,
+ resetNestedUpdateFlag,
startProfilerTimer,
stopProfilerTimerIfRunningAndRecordDuration,
stopProfilerTimerIfRunningAndRecordIncompleteDuration,
+ syncNestedUpdateFlag,
} from './ReactProfilerTimer';
import {setCurrentTrackFromLanes} from './ReactFiberPerformanceTrack';
@@ -304,6 +308,7 @@ import {
ensureRootIsScheduled,
flushSyncWorkOnAllRoots,
flushSyncWorkOnLegacyRootsOnly,
+ getContinuationForRoot,
requestTransitionLane,
} from './ReactFiberRootScheduler';
import {getMaskedContext, getUnmaskedContext} from './ReactFiberContext';
@@ -885,22 +890,59 @@ export function isUnsafeClassRenderPhaseUpdate(fiber: Fiber): boolean {
return (executionContext & RenderContext) !== NoContext;
}
-export function performWorkOnRoot(
+// This is the entry point for every concurrent task, i.e. anything that
+// goes through Scheduler.
+export function performConcurrentWorkOnRoot(
root: FiberRoot,
- lanes: Lanes,
- forceSync: boolean,
-): void {
+ didTimeout: boolean,
+): RenderTaskFn | null {
+ if (enableProfilerTimer && enableProfilerNestedUpdatePhase) {
+ resetNestedUpdateFlag();
+ }
+
if ((executionContext & (RenderContext | CommitContext)) !== NoContext) {
throw new Error('Should not already be working.');
}
+ // Flush any pending passive effects before deciding which lanes to work on,
+ // in case they schedule additional work.
+ const originalCallbackNode = root.callbackNode;
+ const didFlushPassiveEffects = flushPassiveEffects();
+ if (didFlushPassiveEffects) {
+ // Something in the passive effect phase may have canceled the current task.
+ // Check if the task node for this root was changed.
+ if (root.callbackNode !== originalCallbackNode) {
+ // The current task was canceled. Exit. We don't need to call
+ // `ensureRootIsScheduled` because the check above implies either that
+ // there's a new task, or that there's no remaining work on this root.
+ return null;
+ } else {
+ // Current task was not canceled. Continue.
+ }
+ }
+
+ // Determine the next lanes to work on, using the fields stored
+ // on the root.
+ // TODO: This was already computed in the caller. Pass it as an argument.
+ let lanes = getNextLanes(
+ root,
+ root === workInProgressRoot ? workInProgressRootRenderLanes : NoLanes,
+ );
+ if (lanes === NoLanes) {
+ // Defensive coding. This is never expected to happen.
+ return null;
+ }
+
// We disable time-slicing in some cases: if the work has been CPU-bound
// for too long ("expired" work, to prevent starvation), or we're in
// sync-updates-by-default mode.
+ // TODO: We only check `didTimeout` defensively, to account for a Scheduler
+ // bug we're still investigating. Once the bug in Scheduler is fixed,
+ // we can remove this, since we track expiration ourselves.
const shouldTimeSlice =
- !forceSync &&
!includesBlockingLane(lanes) &&
- !includesExpiredLane(root, lanes);
+ !includesExpiredLane(root, lanes) &&
+ (disableSchedulerTimeoutInWorkLoop || !didTimeout);
let exitStatus = shouldTimeSlice
? renderRootConcurrent(root, lanes)
: renderRootSync(root, lanes);
@@ -942,10 +984,7 @@ export function performWorkOnRoot(
}
// Check if something threw
- if (
- (disableLegacyMode || root.tag !== LegacyRoot) &&
- exitStatus === RootErrored
- ) {
+ if (exitStatus === RootErrored) {
const lanesThatJustErrored = lanes;
const errorRetryLanes = getLanesToRetrySynchronouslyOnError(
root,
@@ -994,6 +1033,7 @@ export function performWorkOnRoot(
}
ensureRootIsScheduled(root);
+ return getContinuationForRoot(root, originalCallbackNode);
}
function recoverFromConcurrentError(
@@ -1424,6 +1464,104 @@ function markRootSuspended(
);
}
+// This is the entry point for synchronous tasks that don't go
+// through Scheduler
+export function performSyncWorkOnRoot(root: FiberRoot, lanes: Lanes): null {
+ if ((executionContext & (RenderContext | CommitContext)) !== NoContext) {
+ throw new Error('Should not already be working.');
+ }
+
+ const didFlushPassiveEffects = flushPassiveEffects();
+ if (didFlushPassiveEffects) {
+ // If passive effects were flushed, exit to the outer work loop in the root
+ // scheduler, so we can recompute the priority.
+ // TODO: We don't actually need this `ensureRootIsScheduled` call because
+ // this path is only reachable if the root is already part of the schedule.
+ // I'm including it only for consistency with the other exit points from
+ // this function. Can address in a subsequent refactor.
+ ensureRootIsScheduled(root);
+ return null;
+ }
+
+ if (enableProfilerTimer && enableProfilerNestedUpdatePhase) {
+ syncNestedUpdateFlag();
+ }
+
+ let exitStatus = renderRootSync(root, lanes);
+ if (
+ (disableLegacyMode || root.tag !== LegacyRoot) &&
+ exitStatus === RootErrored
+ ) {
+ // If something threw an error, try rendering one more time. We'll render
+ // synchronously to block concurrent data mutations, and we'll includes
+ // all pending updates are included. If it still fails after the second
+ // attempt, we'll give up and commit the resulting tree.
+ const originallyAttemptedLanes = lanes;
+ const errorRetryLanes = getLanesToRetrySynchronouslyOnError(
+ root,
+ originallyAttemptedLanes,
+ );
+ if (errorRetryLanes !== NoLanes) {
+ lanes = errorRetryLanes;
+ exitStatus = recoverFromConcurrentError(
+ root,
+ originallyAttemptedLanes,
+ errorRetryLanes,
+ );
+ }
+ }
+
+ if (exitStatus === RootFatalErrored) {
+ prepareFreshStack(root, NoLanes);
+ markRootSuspended(root, lanes, NoLane, false);
+ ensureRootIsScheduled(root);
+ return null;
+ }
+
+ if (exitStatus === RootDidNotComplete) {
+ // The render unwound without completing the tree. This happens in special
+ // cases where need to exit the current render without producing a
+ // consistent tree or committing.
+ markRootSuspended(
+ root,
+ lanes,
+ workInProgressDeferredLane,
+ workInProgressRootDidSkipSuspendedSiblings,
+ );
+ ensureRootIsScheduled(root);
+ return null;
+ }
+
+ let renderEndTime = 0;
+ if (enableProfilerTimer && enableComponentPerformanceTrack) {
+ renderEndTime = now();
+ }
+
+ // We now have a consistent tree. Because this is a sync render, we
+ // will commit it even if something suspended.
+ const finishedWork: Fiber = (root.current.alternate: any);
+ root.finishedWork = finishedWork;
+ root.finishedLanes = lanes;
+ commitRoot(
+ root,
+ workInProgressRootRecoverableErrors,
+ workInProgressTransitions,
+ workInProgressRootDidIncludeRecursiveRenderUpdate,
+ workInProgressDeferredLane,
+ workInProgressRootInterleavedUpdatedLanes,
+ workInProgressSuspendedRetryLanes,
+ IMMEDIATE_COMMIT,
+ renderStartTime,
+ renderEndTime,
+ );
+
+ // Before exiting, make sure there's a callback scheduled for the next
+ // pending level.
+ ensureRootIsScheduled(root);
+
+ return null;
+}
+
export function flushRoot(root: FiberRoot, lanes: Lanes) {
if (lanes !== NoLanes) {
upgradePendingLanesToSync(root, lanes);
--- packages/react-reconciler/src/__tests__/ReactSiblingPrerendering-test.js
@@ -349,7 +349,6 @@ describe('ReactSiblingPrerendering', () => {
<div>
<Suspense fallback={<Text text="Loading inner..." />}>
<AsyncText text="B" />
- <AsyncText text="C" />
</Suspense>
</div>
</Suspense>
@@ -371,17 +370,10 @@ describe('ReactSiblingPrerendering', () => {
// is throttled because it's been less than a Just Noticeable Difference
// since the outer fallback was committed.
//
- // In the meantime, we could choose to start prerendering C, but instead
+ // In the meantime, we could choose to start prerendering B, but instead
// we wait for a JND to elapse and the commit to finish — it's not
// worth discarding the work we've already done.
- await waitForAll([
- 'A',
- 'Suspend! [B]',
-
- // C is skipped because we're no longer in prerendering mode; there's
- // a new fallback we can show.
- 'Loading inner...',
- ]);
+ await waitForAll(['A', 'Suspend! [B]', 'Loading inner...']);
expect(root).toMatchRenderedOutput(<div>Loading outer...</div>);
// Fire the timer to commit the outer fallback.
@@ -393,10 +385,8 @@ describe('ReactSiblingPrerendering', () => {
</div>,
);
});
- // Once the inner fallback is committed, we can start prerendering C.
- assertLog(
- gate('enableSiblingPrerendering') ? ['Suspend! [B]', 'Suspend! [C]'] : [],
- );
+ // Once the outer fallback is committed, we can start prerendering B.
+ assertLog(gate('enableSiblingPrerendering') ? ['Suspend! [B]'] : []);
});
it(
--- packages/react-reconciler/src/__tests__/ReactSuspenseyCommitPhase-test.js
@@ -239,7 +239,11 @@ describe('ReactSuspenseyCommitPhase', () => {
expect(root).toMatchRenderedOutput(<suspensey-thing src="B" />);
});
- it('does suspend commit during urgent initial mount at the root when sync rendering', async () => {
+ // @TODO This isn't actually ideal behavior. We would really want the commit to suspend
+ // even if it is forced to be sync because we don't want to FOUC but refactoring the sync
+ // pathway is too risky to land right now so we just accept that we can still FOUC in this
+ // very specific case.
+ it('does not suspend commit during urgent initial mount at the root when sync rendering', async () => {
const root = ReactNoop.createRoot();
await act(async () => {
ReactNoop.flushSync(() => {
@@ -248,15 +252,19 @@ describe('ReactSuspenseyCommitPhase', () => {
});
assertLog(['Image requested [A]']);
expect(getSuspenseyThingStatus('A')).toBe('pending');
- // Suspend the initial mount
- expect(root).toMatchRenderedOutput(null);
+ // We would expect this to be null if we did in fact suspend this commit
+ expect(root).toMatchRenderedOutput(<suspensey-thing src="A" />);
resolveSuspenseyThing('A');
expect(getSuspenseyThingStatus('A')).toBe('fulfilled');
expect(root).toMatchRenderedOutput(<suspensey-thing src="A" />);
});
- it('does suspend commit during urgent update at the root when sync rendering', async () => {
+ // @TODO This isn't actually ideal behavior. We would really want the commit to suspend
+ // even if it is forced to be sync because we don't want to FOUC but refactoring the sync
+ // pathway is too risky to land right now so we just accept that we can still FOUC in this
+ // very specific case.
+ it('does not suspend commit during urgent update at the root when sync rendering', async () => {
const root = ReactNoop.createRoot();
await act(() => resolveSuspenseyThing('A'));
expect(getSuspenseyThingStatus('A')).toBe('fulfilled');
@@ -275,8 +283,8 @@ describe('ReactSuspenseyCommitPhase', () => {
});
assertLog(['Image requested [B]']);
expect(getSuspenseyThingStatus('B')).toBe('pending');
- // Suspend and remain on previous screen
- expect(root).toMatchRenderedOutput(<suspensey-thing src="A" />);
+ // We would expect this to be hidden if we did in fact suspend this commit
+ expect(root).toMatchRenderedOutput(<suspensey-thing src="B" />);
resolveSuspenseyThing('B');
expect(getSuspenseyThingStatus('B')).toBe('fulfilled');
|
react
|
facebook
|
JavaScript
|
JavaScript
| 232,878
| 47,794
|
The library for web and native user interfaces.
|
facebook_react
|
PERF_IMPROVEMENT
|
Obvious
|
07420419bb1a7da3f1c1ad3116e40dfdea57aed6
| null |
Travis Beatty
|
Fix Typo in Design Document Overview s/arechitecture/architecture/
| false
| 1
| 1
| 0
|
--- DESIGN.md
@@ -21,7 +21,7 @@ Kubernetes builds on top of [Docker](http://www.docker.io) to construct a cluste
As container based applications and systems get larger, some tools are provided to facilitate sanity. This includes ways for containers to find and communicate with each other and ways to work with and manage sets of containers that do similar work.
-When looking at the arechitecture of the system, we'll break it down to services that run on the worker node and services that play a "master" role.
+When looking at the architecture of the system, we'll break it down to services that run on the worker node and services that play a "master" role.
## Key Concept: Container Pod
|
kubernetes_kubernetes.json
| null | null | null | null | null | null |
kubernetes_kubernetes.json
|
CONFIG_CHANGE
|
5, readme or comment change
|
110fdedef0c28bd5b26e5611e4510163d0a6242c
| null |
Joe Haddad
|
Update detect-port-alt (#4250)
| false
| 1
| 1
| 0
|
--- package.json
@@ -40,7 +40,7 @@
"babel-code-frame": "6.26.0",
"chalk": "1.1.3",
"cross-spawn": "5.1.0",
- "detect-port-alt": "1.1.5",
+ "detect-port-alt": "1.1.6",
"escape-string-regexp": "1.0.5",
"filesize": "3.5.11",
"global-modules": "1.0.0",
|
facebook_create-react-app.json
| null | null | null | null | null | null |
facebook_create-react-app.json
|
BUG_FIX
|
5, the number in description is pull request and it is tagged with bug fix
|
cf1d8a20487e2d0a6f7105fe7b6ac1d7a8de0684
|
2023-05-07 09:03:49
|
Wout De Puysseleir
|
Add CHANGELOG.md
| false
| 34
| 0
| 34
|
--- CHANGELOG.md
@@ -1,33 +0,0 @@
-# Changelog
-
-All notable changes to this project will be documented in this file.
-
-The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
-and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
-
-## [Unreleased]
-
-### Added
-
-- Added `~V` sigil for using Svelte as an alternative DSL for LiveView
-- Added ability to use `$lib` inside Svelte components like: `import Component from "$lib/component.Svelte"`
-
-### Fixed
-
-- Removed duplicate minify in `build.js`
-
-### Changed
-
-- `build.js` file adds `tsconfig.json` configuration
-
-## [0.4.2] - 2023-04-12
-
-### Added
-
-- Start of the changelog
-- End-To-End Reactivity with LiveView
-- Server-Side Rendered (SSR) Svelte
-- Svelte Preprocessing Support with svelte-preprocess
-- Tailwind Support
-- Dead View Support
-- Slot Interoperability (Experimental)
--- README.md
@@ -421,7 +421,6 @@ Inside `assets/package.json`
- Update the version in `README.md`
- Update the version in `package.json`
- Update the version in `mix.exs`
-- Update the changelog
Run:
|
live_svelte
|
woutdp
|
Elixir
|
Elixir
| 1,416
| 58
|
Svelte inside Phoenix LiveView with seamless end-to-end reactivity
|
woutdp_live_svelte
|
DOC_CHANGE
|
md file added
|
2feecd46bdbf6138b8c97123f35affb572e32a01
|
2025-02-24 07:54:40
|
Tsubasa Nagasawa
|
[e2e/node] update base image from busybox to agnhost Since around 2024/11/27, a Node E2E test that repeatedly creates Pods and checks whether they terminate with the expected exit code has occasionally ended with exit code 2, making it flaky. There have been no changes in kubelet that would modify the exit code before 2024/11/27, so the cause is likely elsewhere. Rather than an issue with the container runtime, it is possible that the problem lies in the BusyBox base image. To narrow down the cause, we will replace the base image from BusyBox to Agnhost. Signed-off-by: Tsubasa Nagasawa <[email protected]>
| false
| 3
| 3
| 6
|
--- test/e2e/node/pods.go
@@ -610,7 +610,7 @@ func (s podFastDeleteScenario) Pod(worker, attempt int) *v1.Pod {
InitContainers: []v1.Container{
{
Name: "fail",
- Image: imageutils.GetE2EImage(imageutils.Agnhost),
+ Image: imageutils.GetE2EImage(imageutils.BusyBox),
Command: []string{
"/bin/false",
},
@@ -625,7 +625,7 @@ func (s podFastDeleteScenario) Pod(worker, attempt int) *v1.Pod {
Containers: []v1.Container{
{
Name: "blocked",
- Image: imageutils.GetE2EImage(imageutils.Agnhost),
+ Image: imageutils.GetE2EImage(imageutils.BusyBox),
Command: []string{
"/bin/true",
},
@@ -654,7 +654,7 @@ func (s podFastDeleteScenario) Pod(worker, attempt int) *v1.Pod {
Containers: []v1.Container{
{
Name: "fail",
- Image: imageutils.GetE2EImage(imageutils.Agnhost),
+ Image: imageutils.GetE2EImage(imageutils.BusyBox),
Command: []string{
"/bin/false",
},
|
kubernetes
|
kubernetes
|
Go
|
Go
| 113,460
| 40,344
|
Production-Grade Container Scheduling and Management
|
kubernetes_kubernetes
|
CODE_IMPROVEMENT
|
Non-functional code changes to improve readability, migration etc.
|
76d44c7d0abece36de3069515cd688be71594419
|
2023-06-03 11:56:19
|
adams549659584
|
fix: fix dependencies
| false
| 32
| 39
| 71
|
--- frontend/package.json
@@ -12,7 +12,6 @@
"format": "prettier --write src/"
},
"dependencies": {
- "naive-ui": "^2.34.4",
"pinia": "^2.0.36",
"pinia-plugin-persistedstate": "^3.1.0",
"vue": "^3.3.2",
@@ -30,6 +29,7 @@
"autoprefixer": "^10.4.14",
"eslint": "^8.39.0",
"eslint-plugin-vue": "^9.11.0",
+ "naive-ui": "^2.34.3",
"npm-run-all": "^4.1.5",
"postcss": "^8.4.23",
"prettier": "^2.8.8",
--- frontend/pnpm-lock.yaml
@@ -1,9 +1,10 @@
-lockfileVersion: '6.0'
+lockfileVersion: '6.1'
+
+settings:
+ autoInstallPeers: true
+ excludeLinksFromLockfile: false
dependencies:
- naive-ui:
- specifier: ^2.34.4
- version: 2.34.4([email protected])
pinia:
specifier: ^2.0.36
version: 2.0.36([email protected])([email protected])
@@ -51,6 +52,9 @@ devDependencies:
eslint-plugin-vue:
specifier: ^9.11.0
version: 9.13.0([email protected])
+ naive-ui:
+ specifier: ^2.34.3
+ version: 2.34.3([email protected])
npm-run-all:
specifier: ^4.1.5
version: 4.1.5
@@ -1233,6 +1237,7 @@ packages:
engines: {node: '>=6.9.0'}
dependencies:
regenerator-runtime: 0.13.11
+ dev: true
/@babel/[email protected]:
resolution: {integrity: sha512-8SegXApWe6VoNw0r9JHpSteLKTpTiLZ4rMlGIm9JQ18KiCtyQiAMEazujAHrUS5flrcqYZa75ukev3P6QmUwUw==}
@@ -1275,7 +1280,7 @@ packages:
css-render: ~0.15.12
dependencies:
css-render: 0.15.12
- dev: false
+ dev: true
/@css-render/[email protected]([email protected]):
resolution: {integrity: sha512-AQLGhhaE0F+rwybRCkKUdzBdTEM/5PZBYy+fSYe1T9z9+yxMuV/k7ZRqa4M69X+EI1W8pa4kc9Iq2VjQkZx4rg==}
@@ -1283,11 +1288,11 @@ packages:
vue: ^3.0.11
dependencies:
vue: 3.3.2
- dev: false
+ dev: true
/@emotion/[email protected]:
resolution: {integrity: sha512-kBJtf7PH6aWwZ6fka3zQ0p6SBYzx4fl1LoZXE2RrnYST9Xljm7WfKJrU4g/Xr3Beg72MLrp1AWNUmuYJTL7Cow==}
- dev: false
+ dev: true
/@esbuild/[email protected]:
resolution: {integrity: sha512-KBMWvEZooR7+kzY0BtbTQn0OAYY7CsiydT63pVEaPtVYF0hXbUaOyZog37DKxK7NF3XacBJOpYT4adIJh+avxA==}
@@ -1586,7 +1591,7 @@ packages:
/@juggle/[email protected]:
resolution: {integrity: sha512-dfLbk+PwWvFzSxwk3n5ySL0hfBog779o8h68wK/7/APo/7cgyWp5jcXockbxdk5kFRkbeXWm4Fbi9FrdN381sA==}
- dev: false
+ dev: true
/@nodelib/[email protected]:
resolution: {integrity: sha512-vq24Bq3ym5HEQm2NKCr3yXDwjc7vTsEThRDnkp2DK9p1uqLR+DHurm/NOTo0KG7HYHU7eppKZj3MyqYuMBf62g==}
@@ -1723,17 +1728,17 @@ packages:
/@types/[email protected]:
resolution: {integrity: sha512-+2FW2CcT0K3P+JMR8YG846bmDwplKUTsWgT2ENwdQ1UdVfRk3GQrh6Mi4sTopy30gI8Uau5CEqHTDZ6YvWIUPA==}
- dev: false
+ dev: true
/@types/[email protected]:
resolution: {integrity: sha512-z0ptr6UI10VlU6l5MYhGwS4mC8DZyYer2mCoyysZtSF7p26zOX8UpbrV0YpNYLGS8K4PUFIyEr62IMFFjveSiQ==}
dependencies:
- '@types/lodash': 4.14.195
- dev: false
+ '@types/lodash': 4.14.194
+ dev: true
- /@types/[email protected]:
- resolution: {integrity: sha512-Hwx9EUgdwf2GLarOjQp5ZH8ZmblzcbTBC2wtQWNKARBSxM9ezRIAUpeDTgoQRAFB0+8CNWXVA9+MaSOzOF3nPg==}
- dev: false
+ /@types/[email protected]:
+ resolution: {integrity: sha512-r22s9tAS7imvBt2lyHC9B8AGwWnXaYb1tY09oyLkXDs4vArpYJzw09nj8MLx5VfciBPGIb+ZwG0ssYnEPJxn/g==}
+ dev: true
/@types/[email protected]:
resolution: {integrity: sha512-sMo3EngB6QkMBlB9rBe1lFdKSLqljyWPPWv6/FzSxh/IDlyVWSzE9RiF4eAuerQHybrWdqBgAGb03PM89qOasA==}
@@ -2138,7 +2143,7 @@ packages:
/[email protected]:
resolution: {integrity: sha512-7HhHjtERjqlNbZtqNqy2rckN/SpOOlmDliet+lP7k+eKZEjPk3DgyeU9lIXLdeLz0uBbbVp+9Qdow9wJWgwwfg==}
- dev: false
+ dev: true
/[email protected]:
resolution: {integrity: sha512-iAB+JbDEGXhyIUavoDl9WP/Jj106Kz9DEn1DPgYw5ruDn0e3Wgi3sKFm55sASdGBNOQB8F59d9qQ7deqrHA8wQ==}
@@ -2391,7 +2396,7 @@ packages:
dependencies:
'@emotion/hash': 0.8.0
csstype: 3.0.11
- dev: false
+ dev: true
/[email protected]:
resolution: {integrity: sha512-/Tb/JcjK111nNScGob5MNtsntNM1aCNUDipB/TkwZFhyDrrE47SOx/18wF2bbjgc3ZzCSKW1T5nt5EbFoAz/Vg==}
@@ -2401,7 +2406,7 @@ packages:
/[email protected]:
resolution: {integrity: sha512-sa6P2wJ+CAbgyy4KFssIb/JNMLxFvKF1pCYCSXS8ZMuqZnMsrxqI2E5sPyoTpxoPU/gVZMzr2zjOfg8GIZOMsw==}
- dev: false
+ dev: true
/[email protected]:
resolution: {integrity: sha512-I7K1Uu0MBPzaFKg4nI5Q7Vs2t+3gWWW648spaF+Rg7pI9ds18Ugn+lvg4SHczUdKlHI5LWBXyqfS8+DufyBsgQ==}
@@ -2412,14 +2417,14 @@ packages:
date-fns: '>=2.0.0'
dependencies:
date-fns: 2.30.0
- dev: false
+ dev: true
/[email protected]:
resolution: {integrity: sha512-fnULvOpxnC5/Vg3NCiWelDsLiUc9bRwAPs/+LfTLNvetFCtCTN+yQz15C/fs4AwX1R9K5GLtLfn8QW+dWisaAw==}
engines: {node: '>=0.11'}
dependencies:
'@babel/runtime': 7.21.5
- dev: false
+ dev: true
/[email protected]:
resolution: {integrity: sha512-e/1zu3xH5MQryN2zdVaF0OrdNLUbvWxzMbi+iNA6Bky7l1RoP8a2fIbRocyHclXt/arDrrR6lL3TqFD9pMQTsg==}
@@ -2758,7 +2763,7 @@ packages:
/[email protected]:
resolution: {integrity: sha512-qaeGN5bx63s/AXgQo8gj6fBkxge+OoLddLniox5qtLAEY5HSnuSlISXVPxnSae1dWblvTh4/HoMIB+mbMsvZzw==}
- dev: false
+ dev: true
/[email protected]:
resolution: {integrity: sha512-f3qQ9oQy9j2AhBe/H9VC91wLmKBCCU/gDOnKNAYG5hswO7BLKj09Hc5HYNz9cGI++xlpDCIgDaitVs03ATR84Q==}
@@ -3042,7 +3047,7 @@ packages:
/[email protected]:
resolution: {integrity: sha512-MedQhoqVdr0U6SSnWPzfiadUcDHfN/Wzq25AkXiQv9oiOO/sG0S7XkvpFIqWBl9Yq1UYyYOOVORs5UW2XlPyzg==}
engines: {node: '>=12.0.0'}
- dev: false
+ dev: true
/[email protected]:
resolution: {integrity: sha512-mxIDAb9Lsm6DoOJ7xH+5+X4y1LU/4Hi50L9C5sIswK3JzULS4bwk1FvjdBgvYR4bzT4tuUQiC15FE2f5HbLvYw==}
@@ -3374,7 +3379,7 @@ packages:
/[email protected]:
resolution: {integrity: sha512-mKnC+QJ9pWVzv+C4/U3rRsHapFfHvQFoFB92e52xeyGMcX6/OlIl78je1u8vePzYZSkkogMPJ2yjxxsb89cxyw==}
- dev: false
+ dev: true
/[email protected]:
resolution: {integrity: sha512-FT1yDzDYEoYWhnSGnpE/4Kj1fLZkDFyqRb7fNt6FdYOSxlUWAtp42Eh6Wb0rGIv/m9Bgo7x4GhQbm5Ys4SG5ow==}
@@ -3390,6 +3395,7 @@ packages:
/[email protected]:
resolution: {integrity: sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==}
+ dev: true
/[email protected]:
resolution: {integrity: sha512-KpNARQA3Iwv+jTA0utUVVbrh+Jlrr1Fv0e56GGzAFOXN7dk/FviaDW8LHmK52DlcH4WP2n6gI8vN1aesBFgo9w==}
@@ -3481,15 +3487,15 @@ packages:
thenify-all: 1.6.0
dev: true
- /[email protected]([email protected]):
- resolution: {integrity: sha512-aPG8PDfhSzIzn/jSC9y3Jb3Pe2wHJ7F0cFV1EWlbImSrZECeUmoc+fIcOSWbizoztkKfaUAeKwYdMl09MKkj1g==}
+ /[email protected]([email protected]):
+ resolution: {integrity: sha512-fUMr0dzb/iGsOTWgoblPVobY5X5dihQ1eam5dA+H74oyLYAvgX4pL96xQFPBLIYqvyRFBAsN85kHN5pLqdtpxA==}
peerDependencies:
vue: ^3.0.0
dependencies:
'@css-render/plugin-bem': 0.15.12([email protected])
'@css-render/vue3-ssr': 0.15.12([email protected])
'@types/katex': 0.14.0
- '@types/lodash': 4.14.195
+ '@types/lodash': 4.14.194
'@types/lodash-es': 4.17.7
async-validator: 4.2.5
css-render: 0.15.12
@@ -3505,7 +3511,7 @@ packages:
vooks: 0.2.12([email protected])
vue: 3.3.2
vueuc: 0.4.51([email protected])
- dev: false
+ dev: true
/[email protected]:
resolution: {integrity: sha512-BGcqMMJuToF7i1rt+2PWSNVnWIkGCU78jBG3RxO/bZlnZPK2Cmi2QaffxGO/2RvWi9sL+FAiRiXMgsyxQ1DIDA==}
@@ -3935,6 +3941,7 @@ packages:
/[email protected]:
resolution: {integrity: sha512-kY1AZVr2Ra+t+piVaJ4gxaFaReZVH40AKNo7UCX6W+dEwBo/2oZJzqfuN1qLq1oL45o56cPaTXELwrTh8Fpggg==}
+ dev: true
/[email protected]:
resolution: {integrity: sha512-knzmNAcuyxV+gQCufkYcvOqX/qIIfHLv0u5x79kRxuGojfYVky1f15TzZEu2Avte8QGepvUNTnLskf8E6X6Vyg==}
@@ -4050,7 +4057,7 @@ packages:
/[email protected]:
resolution: {integrity: sha512-lEV5VB8BUKTo/AfktXJcy+JeXns26ylbMkIUco8CYREsQijuz4mrXres2Q+vMLdwkuLxJdIPQ8IlCIxLYm71Yw==}
- dev: false
+ dev: true
/[email protected]:
resolution: {integrity: sha512-sauaDf/PZdVgrLTNYHRtpXa1iRiKcaebiKQ1BJdpQlWH2lCvexQdX55snPFyK7QzpudqbCI0qXFfOasHdyNDGQ==}
@@ -4372,7 +4379,7 @@ packages:
/[email protected]:
resolution: {integrity: sha512-M8RGFoKtZ8dF+iwJfAJTOH/SM4KluKOKRJpjCMhI8bG3qB74zrFoArKZ62ll0Fr3mqkMJiQOmWYkdYgDeITYQg==}
- dev: false
+ dev: true
/[email protected]:
resolution: {integrity: sha512-Y/arvbn+rrz3JCKl9C4kVNfTfSm2/mEp5FSz5EsZSANGPSlQrpRI5M4PKF+mJnE52jOO90PnPSc3Ur3bTQw0gA==}
@@ -4506,7 +4513,7 @@ packages:
dependencies:
evtd: 0.2.4
vue: 3.3.2
- dev: false
+ dev: true
/[email protected]([email protected])([email protected])([email protected]):
resolution: {integrity: sha512-dNJaf0fYOWncmjxv9HiSa2xrSjipjff7IkYE5oIUJ2x5HKu3cXgA8LRgzOwTc5MhwyFYRSU0xyN0Phbx3NsQYw==}
@@ -4567,7 +4574,7 @@ packages:
dependencies:
evtd: 0.2.4
vue: 3.3.2
- dev: false
+ dev: true
/[email protected]([email protected]):
resolution: {integrity: sha512-rt+yuCtXvscYot9SQQj3WKZJVSriPNqVkpVBNEHPzSgBv7QIYzsS410VqVgvx8f9AAPgjg+XPKvmV3vOqqkJQQ==}
@@ -4660,7 +4667,7 @@ packages:
vdirs: 0.1.8([email protected])
vooks: 0.2.12([email protected])
vue: 3.3.2
- dev: false
+ dev: true
/[email protected]:
resolution: {integrity: sha512-YQ+BmxuTgd6UXZW3+ICGfyqRyHXVlD5GtQr5+qjiNW7bF0cqrzX500HVXPBOvgXb5YnzDd+h0zqyv61KUD7+Sg==}
|
go-proxy-bingai
|
adams549659584
|
HTML
|
HTML
| 8,773
| 13,135
|
用 Vue3 和 Go 搭建的微软 New Bing 演示站点,拥有一致的 UI 体验,支持 ChatGPT 提示词,国内可用。
|
adams549659584_go-proxy-bingai
|
CONFIG_CHANGE
|
Obvious
|
63e710d1abfd8a3c3413206675817d5261db8b8e
|
2024-08-02 07:35:40
|
2dust
|
Simplifying the filter configuration file
| false
| 43
| 46
| 89
|
--- V2rayNG/app/src/main/kotlin/com/v2ray/ang/viewmodel/MainViewModel.kt
@@ -3,11 +3,14 @@ package com.v2ray.ang.viewmodel
import android.app.Application
import android.content.BroadcastReceiver
import android.content.Context
+import android.content.DialogInterface
import android.content.Intent
import android.content.IntentFilter
import android.content.res.AssetManager
import android.os.Build
import android.util.Log
+import android.view.LayoutInflater
+import android.widget.ArrayAdapter
import androidx.appcompat.app.AlertDialog
import androidx.lifecycle.AndroidViewModel
import androidx.lifecycle.MutableLiveData
@@ -18,6 +21,7 @@ import com.v2ray.ang.AngApplication
import com.v2ray.ang.AppConfig
import com.v2ray.ang.AppConfig.ANG_PACKAGE
import com.v2ray.ang.R
+import com.v2ray.ang.databinding.DialogConfigFilterBinding
import com.v2ray.ang.dto.EConfigType
import com.v2ray.ang.dto.ServerConfig
import com.v2ray.ang.dto.ServersCache
@@ -213,50 +217,49 @@ class MainViewModel(application: Application) : AndroidViewModel(application) {
listRemarks.count() - 1
}
-// val ivBinding = DialogConfigFilterBinding.inflate(LayoutInflater.from(context))
-// ivBinding.spSubscriptionId.adapter = ArrayAdapter<String>(
-// context,
-// android.R.layout.simple_spinner_dropdown_item,
-// listRemarks
-// )
-// ivBinding.spSubscriptionId.setSelection(checkedItem)
-// ivBinding.etKeyword.text = Utils.getEditable(keywordFilter)
-// val builder = AlertDialog.Builder(context).setView(ivBinding.root)
-// builder.setTitle(R.string.title_filter_config)
-// builder.setPositiveButton(R.string.tasker_setting_confirm) { dialogInterface: DialogInterface?, _: Int ->
-// try {
-// val position = ivBinding.spSubscriptionId.selectedItemPosition
-// subscriptionId = if (listRemarks.count() - 1 == position) {
-// ""
-// } else {
-// subscriptions[position].first
-// }
-// keywordFilter = ivBinding.etKeyword.text.toString()
-// settingsStorage?.encode(AppConfig.CACHE_SUBSCRIPTION_ID, subscriptionId)
-// settingsStorage?.encode(AppConfig.CACHE_KEYWORD_FILTER, keywordFilter)
-// reloadServerList()
-//
-// dialogInterface?.dismiss()
-// } catch (e: Exception) {
-// e.printStackTrace()
-// }
-// }
-// builder.show()
- AlertDialog.Builder(context)
- .setSingleChoiceItems(listRemarks.toTypedArray(), checkedItem) { dialog, i ->
- try {
- subscriptionId = if (listRemarks.count() - 1 == i) {
- ""
- } else {
- subscriptions[i].first
- }
- settingsStorage?.encode(AppConfig.CACHE_SUBSCRIPTION_ID, subscriptionId)
- reloadServerList()
- dialog.dismiss()
- } catch (e: Exception) {
- e.printStackTrace()
+ val ivBinding = DialogConfigFilterBinding.inflate(LayoutInflater.from(context))
+ ivBinding.spSubscriptionId.adapter = ArrayAdapter<String>(
+ context,
+ android.R.layout.simple_spinner_dropdown_item,
+ listRemarks
+ )
+ ivBinding.spSubscriptionId.setSelection(checkedItem)
+ ivBinding.etKeyword.text = Utils.getEditable(keywordFilter)
+ val builder = AlertDialog.Builder(context).setView(ivBinding.root)
+ builder.setTitle(R.string.title_filter_config)
+ builder.setPositiveButton(R.string.tasker_setting_confirm) { dialogInterface: DialogInterface?, _: Int ->
+ try {
+ val position = ivBinding.spSubscriptionId.selectedItemPosition
+ subscriptionId = if (listRemarks.count() - 1 == position) {
+ ""
+ } else {
+ subscriptions[position].first
}
- }.show()
+ keywordFilter = ivBinding.etKeyword.text.toString()
+ settingsStorage?.encode(AppConfig.CACHE_SUBSCRIPTION_ID, subscriptionId)
+ settingsStorage?.encode(AppConfig.CACHE_KEYWORD_FILTER, keywordFilter)
+ reloadServerList()
+
+ dialogInterface?.dismiss()
+ } catch (e: Exception) {
+ e.printStackTrace()
+ }
+ }
+ builder.show()
+// AlertDialog.Builder(context)
+// .setSingleChoiceItems(listRemarks.toTypedArray(), checkedItem) { dialog, i ->
+// try {
+// subscriptionId = if (listRemarks.count() - 1 == i) {
+// ""
+// } else {
+// subscriptions[i].first
+// }
+// reloadServerList()
+// dialog.dismiss()
+// } catch (e: Exception) {
+// e.printStackTrace()
+// }
+// }.show()
}
fun getPosition(guid: String): Int {
|
v2rayng
|
2dust
|
Kotlin
|
Kotlin
| 38,863
| 5,828
|
A V2Ray client for Android, support Xray core and v2fly core
|
2dust_v2rayng
|
CODE_IMPROVEMENT
|
refactoring done for code simplification
|
0006350cc76f6dc8b1245f625bc268cea8feb447
|
2022-01-28 01:33:48
|
Lucas De Angelis
|
French translation for module "Graph" (#634) The first part of the translation is a direct translation of the
english part. The second is too, although it wasn't done by me
but by wikipedia contributors (the second paragraph of the
English wikipedia introduction is exactly the same as the first
paragraph of the French wikipedia "Description")
Add french version redirection on the README.md. The french
version is placed before the portuguese version to have a
cleaner diff (no trailing commas to edit)
| false
| 24
| 0
| 24
|
--- src/data-structures/graph/README.fr-FR.md
@@ -1,23 +0,0 @@
-# Graph
-
-En informatique, un **graphe** est une structure de
-données abstraite qui implémente les concepts de
-graphe orienté et de graphe non-orienté venant
-des mathématiques, plus précisément du domaine de
-la théorie des graphes.
-
-La structure de données abstraite de graphe consiste
-en un ensemble fini, éventuellement mutable de sommets
-ou nœuds ou points, avec un ensemble de paires ordonnées
-ou non de tels éléments. Ces paires sont des arêtes, arcs
-non orientés, ou lignes pour un graphe non orienté, et
-flèches, arêtes orientées , arcs, ou lignes orientées
-dans le cas orienté. Les sommets peuvent faire partie
-de la structure, ou être des entités extérieures,
-représentées par des entiers ou des références.
-
-
-
-## References
-
-- [Wikipedia](https://fr.wikipedia.org/wiki/Graphe_(type_abstrait))
\ No newline at end of file
--- src/data-structures/graph/README.md
@@ -3,7 +3,6 @@
_Read this in other languages:_
[_简体中文_](README.zh-CN.md),
[_Русский_](README.ru-RU.md),
-[_Français_](README.fr-FR.md),
[_Português_](README.pt-BR.md)
In computer science, a **graph** is an abstract data type
|
javascript-algorithms
|
trekhleb
|
JavaScript
|
JavaScript
| 190,336
| 30,518
|
📝 Algorithms and data structures implemented in JavaScript with explanations and links to further readings
|
trekhleb_javascript-algorithms
|
DOC_CHANGE
|
changes in readme
|
6d8195154aa93e4d25798b6af43afda31a5d1b6c
|
2022-01-25 14:04:17
|
儿时
|
Add Chinise Translation (#842)
| false
| 31
| 0
| 31
|
--- src/algorithms/sorting/quick-sort/README.md
@@ -1,9 +1,5 @@
# Quicksort
-_Read this in other languages:_
-[_简体中文_](README.zh-CN.md)
-
-
Quicksort is a divide and conquer algorithm.
Quicksort first divides a large array into two smaller
sub-arrays: the low elements and the high elements.
--- src/algorithms/sorting/quick-sort/README.zh-CN.md
@@ -1,27 +0,0 @@
-# 快速排序
-
-快速排序是一种分而治之的算法。快速排序首先将一个大数组分成两个较小的子数组:比某个数小的元素和比某个数大的元素。然后快速排序可以递归地对子数组进行排序。
-
-步骤是:
-
-1. 从数组中选择一个元素,称为基点
-
-2. 分区:对数组重新排序,使所有值小于基点的元素都在它左边,而所有值大于基点的元素都在它右边(相等的值可以放在任何一边)。在此分区之后,基点处于其最终位置(左边和右边的中间位置)。这称为分区操作。
-
-3. 递归地将上述步骤应用于左边的数组和右边的数组。
-
-快速排序算法的动画可视化。水平线是基点值。
-
-
-
-## 复杂度
-
-| Name | Best | Average | Worst | Memory | Stable | Comments |
-| -------------- | :-----------: | :-----------: | :-----------: | :----: | :----: | :------------------------------------------------------------ |
-| **Quick sort** | n log(n) | n log(n) | n<sup>2</sup> | log(n) | No | Quicksort is usually done in-place with O(log(n)) stack space |
-
-## 引用
-
-- [Wikipedia](https://en.wikipedia.org/wiki/Quicksort)
-
-- [YouTube](https://www.youtube.com/watch?v=SLauY6PpjW4&index=28&list=PLLXdhg_r2hKA7DPDsunoDZ-Z769jWn4R8)
|
javascript-algorithms
|
trekhleb
|
JavaScript
|
JavaScript
| 190,336
| 30,518
|
📝 Algorithms and data structures implemented in JavaScript with explanations and links to further readings
|
trekhleb_javascript-algorithms
|
DOC_CHANGE
|
changes in readme
|
d2cb6c34df31a3e78293a3ac95b393be45a2b635
|
2024-04-02 08:16:05
|
Zhuang Ma
|
fix typo
| false
| 3
| 3
| 6
|
--- src/discovery-of-by-product-advantages.md
@@ -23,7 +23,7 @@
主业最大的副产品:工作流和方法论
-主业最大的副产品是我们在工作中积累下来的工作流和方法论,换言之,是「如何将一件事情做得比别人好」的诀窍。这些积累原本就随着我们的职业生涯不断增长,是职业发展的主要推动力。在行业中分享这些知识,不但和主业没有冲突,而且是大多数公司鼓励的。
+主业最大的副产品是我们在工作中积累下来的工作流和方法论,换言之,是「如何讲一件事情做得比别人好」的诀窍。这些积累原本就随着我们的职业生涯不断增长,职业发展的主要推动力。在行业中分享这些知识,不但和主业没有冲突,而且是大多数公司鼓励的。
针对工作流和方法论的副产品形式,已经有大量成熟的渠道。
@@ -102,7 +102,7 @@ ComfyUI
#### 产品化
-最后,产品化也是工作流和方法论作为副产品的一大方向。当你能很好的手动实现某个业务后,你可以逐步将其自动化或者半自动化,最终作为一个服务来售卖。对一人企业而言,这也是《纳瓦尔宝典》中说的「将你自己产品化」。
+最后,产品化也是工作流和方法论作为副产品的一大方向。当你能很好的手动实现某个业务后,你可以逐步将其自动化或者半自动化,最终作为一个服务来售卖。对一人企业而已,这也是《纳瓦尔宝典》中说的「将你自己产品化」。
这个产品不一定是软件,也不一定需要编码。逻辑思维最初只是公众号,后期才发展为得到APP。但如果已有的方式不适合我们的副产品,那我们可以创造一个独有的产品来承载它。
@@ -184,4 +184,4 @@ Reading as a Service
兴趣爱好副产品和生活方式副产品非常类似,区别只是它来源于兴趣爱好。这里要强调的是,一个反常识的事实时,很多人以为自己有兴趣爱好,但大部分时候都只是叶公好龙,并没有真正在兴趣爱好上投入太多,「玩都玩不专业」。
-还有的人可能兴趣爱好很多,但都浅尝辄止,每隔一个月换一个。这种也难以产生优质副产品。如果没有能坚持数年持续投入的兴趣爱好,我们更建议考虑其他副产品。
+还有的人可能兴趣爱好很多,但都浅尝辄止,每隔一个月换一个。这种也难以产生优质副产品。如果没有能坚持数年持续投入的兴趣爱好,我们更建议考虑其他副产品。
\ No newline at end of file
|
one-person-businesses-methodology-v2.0
|
easychen
|
PHP
|
PHP
| 5,272
| 464
|
《一人企业方法论》第二版,也适合做其他副业(比如自媒体、电商、数字商品)的非技术人群。
|
easychen_one-person-businesses-methodology-v2.0
|
DOC_CHANGE
|
Updating business methodology documentation
|
13bc0e032faaca301863a118316dda7be30bc40f
| null |
Igor De Paula
|
Fix upload progress event example
| false
| 1
| 1
| 0
|
--- index.html
@@ -28,7 +28,7 @@
var config = {
onUploadProgress: function(progressEvent) {
- var percentCompleted = progressEvent.loaded / progressEvent.total;
+ var percentCompleted = Math.round( (progressEvent.loaded * 100) / progressEvent.total );
}
};
|
axios_axios.json
| null | null | null | null | null | null |
axios_axios.json
|
BUG_FIX
|
5, fix written in commit msg
|
5c01a1094986c4dd50a6ee4d9f7617abdfabb58a
|
2023-02-08 00:47:51
|
syedmouaazfarrukh
|
[readme] added JavaScript Roadmap link
| false
| 1
| 0
| 1
|
--- README.md
@@ -3781,7 +3781,6 @@ Other Style Guides
- [ExploringJS](https://exploringjs.com/)
- [ES6 Compatibility Table](https://kangax.github.io/compat-table/es6/)
- [Comprehensive Overview of ES6 Features](http://es6-features.org/)
- - [JavaScript Roadmap](https://roadmap.sh/javascript)
**Read This**
|
javascript
|
airbnb
|
JavaScript
|
JavaScript
| 146,197
| 26,671
|
JavaScript Style Guide
|
airbnb_javascript
|
DOC_CHANGE
|
changes in readme
|
e5a0ee9ce37df594892185506bdc84a39da156fa
|
2025-02-17 08:32:18
|
Dongjoon Hyun
|
[SPARK-51233][BUILD] Update `pom.xml` to use `https` for `licenses` element ### What changes were proposed in this pull request? This PR aims to update `pom.xml` to use `https` for `licenses` element like ASF parent `pom.xml` for Apache Spark 4.0.0. ### Why are the changes needed? ASF parent `pom.xml` file switched to `https` for `licenses` element almost 9 years ago (May 12, 2016) - [MPOM-116](https://issues.apache.org/jira/browse/MPOM-116) Use https wherever possible - https://github.com/apache/maven-apache-parent/commit/6dfc92ab89f6f8e5f8eb4c40707d2e72828fa2f8 Note that the existing link of Apache Spark code was a part of the initial commit during donating Spark to ASF foundation on Sep 1, 2013. - https://github.com/apache/spark/commit/46eecd110a4017ea0c86cbb1010d0ccd6a5eb2ef ### Does this PR introduce _any_ user-facing change? No, there is no behavior change. This is only updating a metadata of pom.xml. ### How was this patch tested? Manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49974 from dongjoon-hyun/SPARK-51233. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
| false
| 1
| 1
| 2
|
--- pom.xml
@@ -33,7 +33,7 @@
<licenses>
<license>
<name>Apache-2.0</name>
- <url>https://www.apache.org/licenses/LICENSE-2.0.html</url>
+ <url>http://www.apache.org/licenses/LICENSE-2.0.html</url>
<distribution>repo</distribution>
</license>
</licenses>
|
apache-spark
| null |
Scala
|
Scala
| null | null |
Apache Spark - A unified analytics engine for large-scale data processing
|
_apache-spark
|
CONFIG_CHANGE
|
Only config file changes have been made.
|
bd372dcdc2ecd4cd4345c044949e94f070e3c3f3
|
2025-02-26 08:30:45
|
Bartek Iwańczuk
|
refactor: update deno_core to enable pointer compression (#28306) Exposes `deno_core/v8_enable_pointer_compression` feature:
https://github.com/denoland/deno_core/commit/d67efcba0ae01d2714573cfd7784fee3532ba653
| false
| 9
| 9
| 18
|
--- Cargo.lock
@@ -1751,9 +1751,9 @@ dependencies = [
[[package]]
name = "deno_core"
-version = "0.340.0"
+version = "0.338.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "fe2827cc1215963b5073cca7db7c0ed8d8717a40e5ebad20832ae70e6df2d9d1"
+checksum = "113f3f08bd5daf99f1a7876c0f99cd8c3c609439fa0b808311ec856a253e95f0"
dependencies = [
"anyhow",
"az",
@@ -2374,9 +2374,9 @@ dependencies = [
[[package]]
name = "deno_ops"
-version = "0.216.0"
+version = "0.214.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "07cc2bc8f1754c7f66b701a05fb12ca39dc582edf8b4f04a422ae487f0223fa9"
+checksum = "6ad885bf882be535f7714c713042129acba6f31a8efb5e6b2298f6e40cab9b16"
dependencies = [
"indexmap 2.3.0",
"proc-macro-rules",
@@ -7280,9 +7280,9 @@ dependencies = [
[[package]]
name = "serde_v8"
-version = "0.249.0"
+version = "0.247.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "41bd50e0136873d94207fcbd1a78bd8da0b7bfa4537e1383377c7cf2c1d811b1"
+checksum = "12bbfafb7b707cbed49d1eaf48f4aa41b5ff57f813d1a80f77244e6e2fa4507e"
dependencies = [
"deno_error",
"num-bigint",
@@ -9027,9 +9027,9 @@ dependencies = [
[[package]]
name = "v8"
-version = "134.5.0"
+version = "134.4.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "21c7a224a7eaf3f98c1bad772fbaee56394dce185ef7b19a2e0ca5e3d274165d"
+checksum = "224c6c3d1fd3c0356224b2ad355b61c242cdafa9d14cc31b7f161ea177b3b4e9"
dependencies = [
"bindgen 0.70.1",
"bitflags 2.8.0",
--- Cargo.toml
@@ -51,7 +51,7 @@ repository = "https://github.com/denoland/deno"
[workspace.dependencies]
deno_ast = { version = "=0.45.1", features = ["transpiling"] }
-deno_core = { version = "0.340.0" }
+deno_core = { version = "0.338.0" }
deno_bench_util = { version = "0.187.0", path = "./bench_util" }
deno_config = { version = "=0.50.0", features = ["workspace"] }
|
deno
|
denoland
|
Rust
|
Rust
| 102,021
| 5,502
|
A modern runtime for JavaScript and TypeScript.
|
denoland_deno
|
PERF_IMPROVEMENT
|
Code change: indexing added
|
bdf9819d731fdea32dd34c0204b98f960f23adb3
|
2025-03-20 12:16:30
|
Kevin Ariobimo
|
fix(curriculum): typo in explanation of spaced repetition (#59351)
| false
| 1
| 1
| 2
|
--- curriculum/challenges/english/25-front-end-development/lecture-welcome-to-freecodecamp/6763500bd5a85d5898cc21a9.md
@@ -16,7 +16,7 @@ Learning is a skill all its own. And I'm going to quickly introduce you to key o
These come from engineering professor Barbara Oakley's book, *Learning how to Learn.*
-Concept number 1: spaced repetition. Learning for half an hour each day for a week is much more effective than learning for three and a half hours all in one day. This is because of the role that sleep plays in memory. When you sleep, your brain builds and reinforces neural structures. With spaced repetition, you review concepts regularly — first every few days, then every few weeks, then every few months. Each time, your retention of those concepts improves. freeCodeCamp has spaced repetition baked right into the curriculum.
+Concept number 1: spaced repetition. Learning for half an hour each day for a week is much more effective than learning for three and a half hours all in one day. This is because the of role that sleep plays in memory. When you sleep, your brain builds and reinforces neural structures. With spaced repetition, you review concepts regularly — first every few days, then every few weeks, then every few months. Each time, your retention of those concepts improves. freeCodeCamp has spaced repetition baked right into the curriculum.
Concept number 2: interleaving practice. Rather than just studying one concept for an entire study session, it's better to get a little exposure to lots of concepts. This shakes up your brain, and forces you to continually reframe what you know. Through interleaving practice, you train yourself to be more agile in your thinking. For this reason, the freeCodeCamp curriculum covers a ton of ground quickly, then circles back to reinforce everything over and over.
|
freecodecamp
|
freecodecamp
|
TypeScript
|
TypeScript
| 410,748
| 39,092
|
freeCodeCamp.org's open-source codebase and curriculum. Learn to code for free.
|
freecodecamp_freecodecamp
|
CODE_IMPROVEMENT
|
Code change: type annotation added
|
68ab7330a0aeb7fd71db8dfc70ae35274bbb2887
|
2022-07-17 15:27:08
|
Yangshun Tay
|
misc: update README
| false
| 3
| 3
| 6
|
--- README.md
@@ -9,13 +9,13 @@
<a href="https://www.techinterviewhandbook.org/">Read on the website</a>
</h3>
<p>
- Join/follow us on <a href="https://discord.gg/usMqNaPczq" target="_blank">Discord</a> | <a href="https://twitter.com/techinterviewhb" target="_blank">Twitter</a> | <a href="https://t.me/techinterviewhandbook" target="_blank">Telegram</a> | <a href="https://facebook.com/techinterviewhandbook" target="_blank">Facebook</a>
+ Follow us on <a href="https://facebook.com/techinterviewhandbook">Facebook</a> | <a href="https://twitter.com/techinterviewhb">Twitter</a> | <a href="https://t.me/techinterviewhandbook">Telegram</a>
</p>
</div>
---
-<a href="https://www.techinterviewhandbook.org/software-engineering-interview-guide/" target="_blank">
+<a href="https://www.techinterviewhandbook.org/software-engineering-interview-guide/">
<img src="assets/start-reading-button.jpg" alt="Start Reading Tech Interview Handbook" />
</a>
@@ -26,7 +26,7 @@ Not everyone has the time to do a few hundred LeetCode questions. Here are _free
Besides the usual algorithm questions, other **awesome** stuff includes:
- [Best practice questions](https://www.techinterviewhandbook.org/coding-interview-study-plan/) for coding interviews
-- [Grind 75](https://www.techinterviewhandbook.org/grind75) - the next evolution of Blind 75, bigger and better
+- [Grind 75](https://www.techinterviewhandbook.org/grind75) the next evolution of Blind 75, bigger and better.
- [How to prepare](https://www.techinterviewhandbook.org/coding-interview-prep/) for coding interviews
- [Coding interview best practices](https://www.techinterviewhandbook.org/coding-interview-cheatsheet/) - Straight-to-the-point Do's and Don'ts
- [Algorithm cheatsheets and tips](https://www.techinterviewhandbook.org/algorithms/study-cheatsheet/) categorized by topic
|
tech-interview-handbook
|
yangshun
|
TypeScript
|
TypeScript
| 122,353
| 15,039
|
💯 Curated coding interview preparation materials for busy software engineers
|
yangshun_tech-interview-handbook
|
DOC_CHANGE
|
changes in readme
|
edeec4912123ec4c37abc10c3aca49171f906d50
|
2024-10-03 07:47:51
|
Richard Shiue
|
fix: hide editing rows from groups when filters are applied (#6409) * fix: editing a row while in active filters
* fix: dont allow filtering by group field
| false
| 39
| 26
| 65
|
--- frontend/appflowy_flutter/lib/plugins/database/grid/application/filter/filter_editor_bloc.dart
@@ -222,7 +222,7 @@ class FilterEditorState with _$FilterEditorState {
List<FieldInfo> _getCreatableFilter(List<FieldInfo> fieldInfos) {
final List<FieldInfo> creatableFields = List.from(fieldInfos);
creatableFields.retainWhere(
- (field) => field.fieldType.canCreateFilter && !field.isGroupField,
+ (field) => field.fieldType.canCreateFilter,
);
return creatableFields;
}
--- frontend/rust-lib/flowy-database2/src/services/database_view/view_editor.rs
@@ -307,46 +307,33 @@ impl DatabaseViewEditor {
let rows = vec![Arc::new(row.clone())];
let mut rows = self.v_filter_rows(rows).await;
- let mut group_changes = GroupChangesPB {
- view_id: self.view_id.clone(),
- ..Default::default()
- };
-
- let (inserted_group, deleted_group, row_changesets) = if let Some(row) = rows.pop() {
- if let Ok(result) = controller.did_update_group_row(old_row, &row, &field) {
- (
- result.inserted_group,
- result.deleted_group,
- result.row_changesets,
- )
- } else {
- (None, None, vec![])
- }
- } else {
- if let Ok(result) = controller.did_delete_row(&row) {
- (None, result.deleted_group, result.row_changesets)
- } else {
- (None, None, vec![])
- }
- };
-
- if let Some(inserted_group) = inserted_group {
- tracing::trace!("Create group after editing the row: {:?}", inserted_group);
- group_changes.inserted_groups.push(inserted_group);
- }
- if let Some(delete_group) = deleted_group {
- tracing::trace!("Delete group after editing the row: {:?}", delete_group);
- group_changes.deleted_groups.push(delete_group.group_id);
- }
+ if let Some(row) = rows.pop() {
+ let result = controller.did_update_group_row(old_row, &row, &field);
+
+ if let Ok(result) = result {
+ let mut group_changes = GroupChangesPB {
+ view_id: self.view_id.clone(),
+ ..Default::default()
+ };
+ if let Some(inserted_group) = result.inserted_group {
+ tracing::trace!("Create group after editing the row: {:?}", inserted_group);
+ group_changes.inserted_groups.push(inserted_group);
+ }
+ if let Some(delete_group) = result.deleted_group {
+ tracing::trace!("Delete group after editing the row: {:?}", delete_group);
+ group_changes.deleted_groups.push(delete_group.group_id);
+ }
- if !group_changes.is_empty() {
- notify_did_update_num_of_groups(&self.view_id, group_changes).await;
- }
+ if !group_changes.is_empty() {
+ notify_did_update_num_of_groups(&self.view_id, group_changes).await;
+ }
- for changeset in row_changesets {
- if !changeset.is_empty() {
- tracing::trace!("Group change after editing the row: {:?}", changeset);
- notify_did_update_group_rows(changeset).await;
+ for changeset in result.row_changesets {
+ if !changeset.is_empty() {
+ tracing::trace!("Group change after editing the row: {:?}", changeset);
+ notify_did_update_group_rows(changeset).await;
+ }
+ }
}
}
}
|
appflowy
|
appflowy-io
|
Dart
|
Dart
| 61,077
| 4,078
|
Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.
|
appflowy-io_appflowy
|
NEW_FEAT
|
Introducing new collaboration features
|
0e627e2fa32e16296e309af314eb3cdaae00de66
|
2023-05-15 22:45:59
|
Jordan Harband
|
[readme] update eslint plugin repo URLs
| false
| 106
| 106
| 212
|
--- README.md
@@ -1373,7 +1373,7 @@ Other Style Guides
<a name="modules--no-mutable-exports"></a>
- [10.5](#modules--no-mutable-exports) Do not export mutable bindings.
- eslint: [`import/no-mutable-exports`](https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-mutable-exports.md)
+ eslint: [`import/no-mutable-exports`](https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-mutable-exports.md)
> Why? Mutation should be avoided in general, but in particular when exporting mutable bindings. While this technique may be needed for some special cases, in general, only constant references should be exported.
```javascript
@@ -1388,7 +1388,7 @@ Other Style Guides
<a name="modules--prefer-default-export"></a>
- [10.6](#modules--prefer-default-export) In modules with a single export, prefer default export over named export.
- eslint: [`import/prefer-default-export`](https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/prefer-default-export.md)
+ eslint: [`import/prefer-default-export`](https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/prefer-default-export.md)
> Why? To encourage more files that only ever export one thing, which is better for readability and maintainability.
```javascript
@@ -1401,7 +1401,7 @@ Other Style Guides
<a name="modules--imports-first"></a>
- [10.7](#modules--imports-first) Put all `import`s above non-import statements.
- eslint: [`import/first`](https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/first.md)
+ eslint: [`import/first`](https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/first.md)
> Why? Since `import`s are hoisted, keeping them all at the top prevents surprising behavior.
```javascript
@@ -1440,7 +1440,7 @@ Other Style Guides
<a name="modules--no-webpack-loader-syntax"></a>
- [10.9](#modules--no-webpack-loader-syntax) Disallow Webpack loader syntax in module import statements.
- eslint: [`import/no-webpack-loader-syntax`](https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-webpack-loader-syntax.md)
+ eslint: [`import/no-webpack-loader-syntax`](https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-webpack-loader-syntax.md)
> Why? Since using Webpack syntax in the imports couples the code to a module bundler. Prefer using the loader syntax in `webpack.config.js`.
```javascript
@@ -1455,7 +1455,7 @@ Other Style Guides
<a name="modules--import-extensions"></a>
- [10.10](#modules--import-extensions) Do not include JavaScript filename extensions
- eslint: [`import/extensions`](https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/extensions.md)
+ eslint: [`import/extensions`](https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md)
> Why? Including extensions inhibits refactoring, and inappropriately hardcodes implementation details of the module you're importing in every consumer.
```javascript
--- packages/eslint-config-airbnb-base/rules/es6.js
@@ -53,7 +53,7 @@ module.exports = {
// disallow importing from the same path more than once
// https://eslint.org/docs/rules/no-duplicate-imports
- // replaced by https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-duplicates.md
+ // replaced by https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-duplicates.md
'no-duplicate-imports': 'off',
// disallow symbol constructor
--- packages/eslint-config-airbnb-base/rules/imports.js
@@ -33,40 +33,40 @@ module.exports = {
// Static analysis:
// ensure imports point to files/modules that can be resolved
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-unresolved.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unresolved.md
'import/no-unresolved': ['error', { commonjs: true, caseSensitive: true }],
// ensure named imports coupled with named exports
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/named.md#when-not-to-use-it
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/named.md#when-not-to-use-it
'import/named': 'error',
// ensure default import coupled with default export
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/default.md#when-not-to-use-it
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/default.md#when-not-to-use-it
'import/default': 'off',
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/namespace.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/namespace.md
'import/namespace': 'off',
// Helpful warnings:
// disallow invalid exports, e.g. multiple defaults
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/export.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/export.md
'import/export': 'error',
// do not allow a default import name to match a named export
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-named-as-default.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-named-as-default.md
'import/no-named-as-default': 'error',
// warn on accessing default export property names that are also named exports
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-named-as-default-member.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-named-as-default-member.md
'import/no-named-as-default-member': 'error',
// disallow use of jsdoc-marked-deprecated imports
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-deprecated.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-deprecated.md
'import/no-deprecated': 'off',
// Forbid the use of extraneous packages
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md
// paths are treated both as absolute paths, and relative to process.cwd()
'import/no-extraneous-dependencies': ['error', {
devDependencies: [
@@ -97,46 +97,46 @@ module.exports = {
}],
// Forbid mutable exports
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-mutable-exports.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-mutable-exports.md
'import/no-mutable-exports': 'error',
// Module systems:
// disallow require()
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-commonjs.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-commonjs.md
'import/no-commonjs': 'off',
// disallow AMD require/define
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-amd.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-amd.md
'import/no-amd': 'error',
// No Node.js builtin modules
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-nodejs-modules.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-nodejs-modules.md
// TODO: enable?
'import/no-nodejs-modules': 'off',
// Style guide:
// disallow non-import statements appearing before import statements
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/first.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/first.md
'import/first': 'error',
// disallow non-import statements appearing before import statements
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/imports-first.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/imports-first.md
// deprecated: use `import/first`
'import/imports-first': 'off',
// disallow duplicate imports
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-duplicates.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-duplicates.md
'import/no-duplicates': 'error',
// disallow namespace imports
// TODO: enable?
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-namespace.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-namespace.md
'import/no-namespace': 'off',
// Ensure consistent use of file extension within the import path
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/extensions.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md
'import/extensions': ['error', 'ignorePackages', {
js: 'never',
mjs: 'never',
@@ -144,62 +144,62 @@ module.exports = {
}],
// ensure absolute imports are above relative imports and that unassigned imports are ignored
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/order.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md
// TODO: enforce a stricter convention in module import order?
'import/order': ['error', { groups: [['builtin', 'external', 'internal']] }],
// Require a newline after the last import/require in a group
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/newline-after-import.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/newline-after-import.md
'import/newline-after-import': 'error',
// Require modules with a single export to use a default export
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/prefer-default-export.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/prefer-default-export.md
'import/prefer-default-export': 'error',
// Restrict which files can be imported in a given folder
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-restricted-paths.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-restricted-paths.md
'import/no-restricted-paths': 'off',
// Forbid modules to have too many dependencies
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/max-dependencies.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/max-dependencies.md
'import/max-dependencies': ['off', { max: 10 }],
// Forbid import of modules using absolute paths
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-absolute-path.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-absolute-path.md
'import/no-absolute-path': 'error',
// Forbid require() calls with expressions
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-dynamic-require.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-dynamic-require.md
'import/no-dynamic-require': 'error',
// prevent importing the submodules of other modules
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-internal-modules.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-internal-modules.md
'import/no-internal-modules': ['off', {
allow: [],
}],
// Warn if a module could be mistakenly parsed as a script by a consumer
// leveraging Unambiguous JavaScript Grammar
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/unambiguous.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/unambiguous.md
// this should not be enabled until this proposal has at least been *presented* to TC39.
// At the moment, it's not a thing.
'import/unambiguous': 'off',
// Forbid Webpack loader syntax in imports
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-webpack-loader-syntax.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-webpack-loader-syntax.md
'import/no-webpack-loader-syntax': 'error',
// Prevent unassigned imports
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-unassigned-import.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unassigned-import.md
// importing for side effects is perfectly acceptable, if you need side effects.
'import/no-unassigned-import': 'off',
// Prevent importing the default as if it were named
- // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-named-default.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-named-default.md
'import/no-named-default': 'error',
// Reports if a module's default export is unnamed
- // https://github.com/import-js/eslint-plugin-import/blob/d9b712ac7fd1fddc391f7b234827925c160d956f/docs/rules/no-anonymous-default-export.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/d9b712ac7fd1fddc391f7b234827925c160d956f/docs/rules/no-anonymous-default-export.md
'import/no-anonymous-default-export': ['off', {
allowArray: false,
allowArrowFunction: false,
@@ -210,49 +210,49 @@ module.exports = {
}],
// This rule enforces that all exports are declared at the bottom of the file.
- // https://github.com/import-js/eslint-plugin-import/blob/98acd6afd04dcb6920b81330114e146dc8532ea4/docs/rules/exports-last.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/98acd6afd04dcb6920b81330114e146dc8532ea4/docs/rules/exports-last.md
// TODO: enable?
'import/exports-last': 'off',
// Reports when named exports are not grouped together in a single export declaration
// or when multiple assignments to CommonJS module.exports or exports object are present
// in a single file.
- // https://github.com/import-js/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/group-exports.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/group-exports.md
'import/group-exports': 'off',
// forbid default exports. this is a terrible rule, do not use it.
- // https://github.com/import-js/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/no-default-export.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/no-default-export.md
'import/no-default-export': 'off',
// Prohibit named exports. this is a terrible rule, do not use it.
- // https://github.com/import-js/eslint-plugin-import/blob/1ec80fa35fa1819e2d35a70e68fb6a149fb57c5e/docs/rules/no-named-export.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/1ec80fa35fa1819e2d35a70e68fb6a149fb57c5e/docs/rules/no-named-export.md
'import/no-named-export': 'off',
// Forbid a module from importing itself
- // https://github.com/import-js/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/no-self-import.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/no-self-import.md
'import/no-self-import': 'error',
// Forbid cyclical dependencies between modules
- // https://github.com/import-js/eslint-plugin-import/blob/d81f48a2506182738409805f5272eff4d77c9348/docs/rules/no-cycle.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/d81f48a2506182738409805f5272eff4d77c9348/docs/rules/no-cycle.md
'import/no-cycle': ['error', { maxDepth: '∞' }],
// Ensures that there are no useless path segments
- // https://github.com/import-js/eslint-plugin-import/blob/ebafcbf59ec9f653b2ac2a0156ca3bcba0a7cf57/docs/rules/no-useless-path-segments.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/ebafcbf59ec9f653b2ac2a0156ca3bcba0a7cf57/docs/rules/no-useless-path-segments.md
'import/no-useless-path-segments': ['error', { commonjs: true }],
// dynamic imports require a leading comment with a webpackChunkName
- // https://github.com/import-js/eslint-plugin-import/blob/ebafcbf59ec9f653b2ac2a0156ca3bcba0a7cf57/docs/rules/dynamic-import-chunkname.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/ebafcbf59ec9f653b2ac2a0156ca3bcba0a7cf57/docs/rules/dynamic-import-chunkname.md
'import/dynamic-import-chunkname': ['off', {
importFunctions: [],
webpackChunknameFormat: '[0-9a-zA-Z-_/.]+',
}],
// Use this rule to prevent imports to folders in relative parent paths.
- // https://github.com/import-js/eslint-plugin-import/blob/c34f14f67f077acd5a61b3da9c0b0de298d20059/docs/rules/no-relative-parent-imports.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/c34f14f67f077acd5a61b3da9c0b0de298d20059/docs/rules/no-relative-parent-imports.md
'import/no-relative-parent-imports': 'off',
// Reports modules without any exports, or with unused exports
- // https://github.com/import-js/eslint-plugin-import/blob/f63dd261809de6883b13b6b5b960e6d7f42a7813/docs/rules/no-unused-modules.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/f63dd261809de6883b13b6b5b960e6d7f42a7813/docs/rules/no-unused-modules.md
// TODO: enable once it supports CJS
'import/no-unused-modules': ['off', {
ignoreExports: [],
@@ -261,13 +261,13 @@ module.exports = {
}],
// Reports the use of import declarations with CommonJS exports in any module except for the main module.
- // https://github.com/import-js/eslint-plugin-import/blob/1012eb951767279ce3b540a4ec4f29236104bb5b/docs/rules/no-import-module-exports.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/1012eb951767279ce3b540a4ec4f29236104bb5b/docs/rules/no-import-module-exports.md
'import/no-import-module-exports': ['error', {
exceptions: [],
}],
// Use this rule to prevent importing packages through relative paths.
- // https://github.com/import-js/eslint-plugin-import/blob/1012eb951767279ce3b540a4ec4f29236104bb5b/docs/rules/no-relative-packages.md
+ // https://github.com/benmosher/eslint-plugin-import/blob/1012eb951767279ce3b540a4ec4f29236104bb5b/docs/rules/no-relative-packages.md
'import/no-relative-packages': 'error',
// enforce a consistent style for type specifiers (inline or top-level)
--- packages/eslint-config-airbnb/rules/react-a11y.js
@@ -12,12 +12,12 @@ module.exports = {
rules: {
// ensure emoji are accessible
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/accessible-emoji.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/accessible-emoji.md
// disabled; rule is deprecated
'jsx-a11y/accessible-emoji': 'off',
// Enforce that all elements that require alternative text have meaningful information
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/alt-text.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/alt-text.md
'jsx-a11y/alt-text': ['error', {
elements: ['img', 'object', 'area', 'input[type="image"]'],
img: [],
@@ -27,11 +27,11 @@ module.exports = {
}],
// Enforce that anchors have content
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-has-content.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-has-content.md
'jsx-a11y/anchor-has-content': ['error', { components: [] }],
// ensure <a> tags are valid
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/0745af376cdc8686d85a361ce36952b1fb1ccf6e/docs/rules/anchor-is-valid.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/0745af376cdc8686d85a361ce36952b1fb1ccf6e/docs/rules/anchor-is-valid.md
'jsx-a11y/anchor-is-valid': ['error', {
components: ['Link'],
specialLink: ['to'],
@@ -39,24 +39,24 @@ module.exports = {
}],
// elements with aria-activedescendant must be tabbable
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-activedescendant-has-tabindex.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-activedescendant-has-tabindex.md
'jsx-a11y/aria-activedescendant-has-tabindex': 'error',
// Enforce all aria-* props are valid.
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-props.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-props.md
'jsx-a11y/aria-props': 'error',
// Enforce ARIA state and property values are valid.
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-proptypes.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-proptypes.md
'jsx-a11y/aria-proptypes': 'error',
// Require ARIA roles to be valid and non-abstract
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-role.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-role.md
'jsx-a11y/aria-role': ['error', { ignoreNonDOM: false }],
// Enforce that elements that do not support ARIA roles, states, and
// properties do not have those attributes.
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-unsupported-elements.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-unsupported-elements.md
'jsx-a11y/aria-unsupported-elements': 'error',
// Ensure the autocomplete attribute is correct and suitable for the form field it is used with
@@ -66,11 +66,11 @@ module.exports = {
}],
// require onClick be accompanied by onKeyUp/onKeyDown/onKeyPress
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/click-events-have-key-events.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/click-events-have-key-events.md
'jsx-a11y/click-events-have-key-events': 'error',
// Enforce that a control (an interactive element) has a text label.
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/control-has-associated-label.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/control-has-associated-label.md
'jsx-a11y/control-has-associated-label': ['error', {
labelAttributes: ['label'],
controlComponents: [],
@@ -99,27 +99,27 @@ module.exports = {
}],
// ensure <hX> tags have content and are not aria-hidden
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/heading-has-content.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/heading-has-content.md
'jsx-a11y/heading-has-content': ['error', { components: [''] }],
// require HTML elements to have a "lang" prop
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/html-has-lang.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/html-has-lang.md
'jsx-a11y/html-has-lang': 'error',
// ensure iframe elements have a unique title
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/iframe-has-title.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/iframe-has-title.md
'jsx-a11y/iframe-has-title': 'error',
// Prevent img alt text from containing redundant words like "image", "picture", or "photo"
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/img-redundant-alt.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/img-redundant-alt.md
'jsx-a11y/img-redundant-alt': 'error',
// Elements with an interactive role and interaction handlers must be focusable
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/interactive-supports-focus.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/interactive-supports-focus.md
'jsx-a11y/interactive-supports-focus': 'error',
// Enforce that a label tag has a text label and an associated control.
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/b800f40a2a69ad48015ae9226fbe879f946757ed/docs/rules/label-has-associated-control.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/b800f40a2a69ad48015ae9226fbe879f946757ed/docs/rules/label-has-associated-control.md
'jsx-a11y/label-has-associated-control': ['error', {
labelComponents: [],
labelAttributes: [],
@@ -129,11 +129,11 @@ module.exports = {
}],
// require HTML element's lang prop to be valid
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/lang.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/lang.md
'jsx-a11y/lang': 'error',
// media elements must have captions
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/media-has-caption.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/media-has-caption.md
'jsx-a11y/media-has-caption': ['error', {
audio: [],
video: [],
@@ -141,31 +141,31 @@ module.exports = {
}],
// require that mouseover/out come with focus/blur, for keyboard-only users
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/mouse-events-have-key-events.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/mouse-events-have-key-events.md
'jsx-a11y/mouse-events-have-key-events': 'error',
// Prevent use of `accessKey`
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-access-key.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-access-key.md
'jsx-a11y/no-access-key': 'error',
// prohibit autoFocus prop
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-autofocus.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-autofocus.md
'jsx-a11y/no-autofocus': ['error', { ignoreNonDOM: true }],
// prevent distracting elements, like <marquee> and <blink>
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-distracting-elements.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-distracting-elements.md
'jsx-a11y/no-distracting-elements': ['error', {
elements: ['marquee', 'blink'],
}],
// WAI-ARIA roles should not be used to convert an interactive element to non-interactive
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-interactive-element-to-noninteractive-role.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-interactive-element-to-noninteractive-role.md
'jsx-a11y/no-interactive-element-to-noninteractive-role': ['error', {
tr: ['none', 'presentation'],
}],
// A non-interactive element does not support event handlers (mouse and key handlers)
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-element-interactions.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-element-interactions.md
'jsx-a11y/no-noninteractive-element-interactions': ['error', {
handlers: [
'onClick',
@@ -178,7 +178,7 @@ module.exports = {
}],
// WAI-ARIA roles should not be used to convert a non-interactive element to interactive
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-element-to-interactive-role.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-element-to-interactive-role.md
'jsx-a11y/no-noninteractive-element-to-interactive-role': ['error', {
ul: ['listbox', 'menu', 'menubar', 'radiogroup', 'tablist', 'tree', 'treegrid'],
ol: ['listbox', 'menu', 'menubar', 'radiogroup', 'tablist', 'tree', 'treegrid'],
@@ -188,22 +188,22 @@ module.exports = {
}],
// Tab key navigation should be limited to elements on the page that can be interacted with.
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-tabindex.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-noninteractive-tabindex.md
'jsx-a11y/no-noninteractive-tabindex': ['error', {
tags: [],
roles: ['tabpanel'],
}],
// require onBlur instead of onChange
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-onchange.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-onchange.md
'jsx-a11y/no-onchange': 'off',
// ensure HTML elements do not specify redundant ARIA roles
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-redundant-roles.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-redundant-roles.md
'jsx-a11y/no-redundant-roles': 'error',
// Enforce that DOM elements without semantic behavior not have interaction handlers
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-static-element-interactions.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-static-element-interactions.md
'jsx-a11y/no-static-element-interactions': ['error', {
handlers: [
'onClick',
@@ -217,20 +217,20 @@ module.exports = {
// Enforce that elements with ARIA roles must have all required attributes
// for that role.
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/role-has-required-aria-props.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/role-has-required-aria-props.md
'jsx-a11y/role-has-required-aria-props': 'error',
// Enforce that elements with explicit or implicit roles defined contain
// only aria-* properties supported by that role.
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/role-supports-aria-props.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/role-supports-aria-props.md
'jsx-a11y/role-supports-aria-props': 'error',
// only allow <th> to have the "scope" attr
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/scope.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/scope.md
'jsx-a11y/scope': 'error',
// Enforce tabIndex value is not greater than zero.
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/tabindex-no-positive.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/tabindex-no-positive.md
'jsx-a11y/tabindex-no-positive': 'error',
// ----------------------------------------------------
@@ -238,7 +238,7 @@ module.exports = {
// ----------------------------------------------------
// require that JSX labels use "htmlFor"
- // https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-for.md
+ // https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-for.md
// deprecated: replaced by `label-has-associated-control` rule
'jsx-a11y/label-has-for': ['off', {
components: [],
--- react/README.md
@@ -25,14 +25,14 @@ This style guide is mostly based on the standards that are currently prevalent i
## Basic Rules
- Only include one React component per file.
- - However, multiple [Stateless, or Pure, Components](https://facebook.github.io/react/docs/reusable-components.html#stateless-functions) are allowed per file. eslint: [`react/no-multi-comp`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-multi-comp.md#ignorestateless).
+ - However, multiple [Stateless, or Pure, Components](https://facebook.github.io/react/docs/reusable-components.html#stateless-functions) are allowed per file. eslint: [`react/no-multi-comp`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-multi-comp.md#ignorestateless).
- Always use JSX syntax.
- Do not use `React.createElement` unless you’re initializing the app from a file that is not JSX.
- - [`react/forbid-prop-types`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/forbid-prop-types.md) will allow `arrays` and `objects` only if it is explicitly noted what `array` and `object` contains, using `arrayOf`, `objectOf`, or `shape`.
+ - [`react/forbid-prop-types`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-prop-types.md) will allow `arrays` and `objects` only if it is explicitly noted what `array` and `object` contains, using `arrayOf`, `objectOf`, or `shape`.
## Class vs `React.createClass` vs stateless
- - If you have internal state and/or refs, prefer `class extends React.Component` over `React.createClass`. eslint: [`react/prefer-es6-class`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/prefer-es6-class.md) [`react/prefer-stateless-function`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/prefer-stateless-function.md)
+ - If you have internal state and/or refs, prefer `class extends React.Component` over `React.createClass`. eslint: [`react/prefer-es6-class`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prefer-es6-class.md) [`react/prefer-stateless-function`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/prefer-stateless-function.md)
```jsx
// bad
@@ -81,9 +81,9 @@ This style guide is mostly based on the standards that are currently prevalent i
## Naming
- - **Extensions**: Use `.jsx` extension for React components. eslint: [`react/jsx-filename-extension`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md)
+ - **Extensions**: Use `.jsx` extension for React components. eslint: [`react/jsx-filename-extension`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md)
- **Filename**: Use PascalCase for filenames. E.g., `ReservationCard.jsx`.
- - **Reference Naming**: Use PascalCase for React components and camelCase for their instances. eslint: [`react/jsx-pascal-case`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-pascal-case.md)
+ - **Reference Naming**: Use PascalCase for React components and camelCase for their instances. eslint: [`react/jsx-pascal-case`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-pascal-case.md)
```jsx
// bad
@@ -172,7 +172,7 @@ This style guide is mostly based on the standards that are currently prevalent i
## Alignment
- - Follow these alignment styles for JSX syntax. eslint: [`react/jsx-closing-bracket-location`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-closing-bracket-location.md) [`react/jsx-closing-tag-location`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-closing-tag-location.md)
+ - Follow these alignment styles for JSX syntax. eslint: [`react/jsx-closing-bracket-location`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-closing-bracket-location.md) [`react/jsx-closing-tag-location`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-closing-tag-location.md)
```jsx
// bad
@@ -259,7 +259,7 @@ This style guide is mostly based on the standards that are currently prevalent i
## Spacing
- - Always include a single space in your self-closing tag. eslint: [`no-multi-spaces`](https://eslint.org/docs/rules/no-multi-spaces), [`react/jsx-tag-spacing`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-tag-spacing.md)
+ - Always include a single space in your self-closing tag. eslint: [`no-multi-spaces`](https://eslint.org/docs/rules/no-multi-spaces), [`react/jsx-tag-spacing`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-tag-spacing.md)
```jsx
// bad
@@ -276,7 +276,7 @@ This style guide is mostly based on the standards that are currently prevalent i
<Foo />
```
- - Do not pad JSX curly braces with spaces. eslint: [`react/jsx-curly-spacing`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-curly-spacing.md)
+ - Do not pad JSX curly braces with spaces. eslint: [`react/jsx-curly-spacing`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-curly-spacing.md)
```jsx
// bad
@@ -305,7 +305,7 @@ This style guide is mostly based on the standards that are currently prevalent i
/>
```
- - Omit the value of the prop when it is explicitly `true`. eslint: [`react/jsx-boolean-value`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-boolean-value.md)
+ - Omit the value of the prop when it is explicitly `true`. eslint: [`react/jsx-boolean-value`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-boolean-value.md)
```jsx
// bad
@@ -322,7 +322,7 @@ This style guide is mostly based on the standards that are currently prevalent i
<Foo hidden />
```
- - Always include an `alt` prop on `<img>` tags. If the image is presentational, `alt` can be an empty string or the `<img>` must have `role="presentation"`. eslint: [`jsx-a11y/alt-text`](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/alt-text.md)
+ - Always include an `alt` prop on `<img>` tags. If the image is presentational, `alt` can be an empty string or the `<img>` must have `role="presentation"`. eslint: [`jsx-a11y/alt-text`](https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/alt-text.md)
```jsx
// bad
@@ -338,7 +338,7 @@ This style guide is mostly based on the standards that are currently prevalent i
<img src="hello.jpg" role="presentation" />
```
- - Do not use words like "image", "photo", or "picture" in `<img>` `alt` props. eslint: [`jsx-a11y/img-redundant-alt`](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/img-redundant-alt.md)
+ - Do not use words like "image", "photo", or "picture" in `<img>` `alt` props. eslint: [`jsx-a11y/img-redundant-alt`](https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/img-redundant-alt.md)
> Why? Screenreaders already announce `img` elements as images, so there is no need to include this information in the alt text.
@@ -350,7 +350,7 @@ This style guide is mostly based on the standards that are currently prevalent i
<img src="hello.jpg" alt="Me waving hello" />
```
- - Use only valid, non-abstract [ARIA roles](https://www.w3.org/TR/wai-aria/#usage_intro). eslint: [`jsx-a11y/aria-role`](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-role.md)
+ - Use only valid, non-abstract [ARIA roles](https://www.w3.org/TR/wai-aria/#usage_intro). eslint: [`jsx-a11y/aria-role`](https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/aria-role.md)
```jsx
// bad - not an ARIA role
@@ -363,7 +363,7 @@ This style guide is mostly based on the standards that are currently prevalent i
<div role="button" />
```
- - Do not use `accessKey` on elements. eslint: [`jsx-a11y/no-access-key`](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-access-key.md)
+ - Do not use `accessKey` on elements. eslint: [`jsx-a11y/no-access-key`](https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/no-access-key.md)
> Why? Inconsistencies between keyboard shortcuts and keyboard commands used by people using screenreaders and keyboards complicate accessibility.
@@ -375,7 +375,7 @@ This style guide is mostly based on the standards that are currently prevalent i
<div />
```
- - Avoid using an array index as `key` prop, prefer a stable ID. eslint: [`react/no-array-index-key`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-array-index-key.md)
+ - Avoid using an array index as `key` prop, prefer a stable ID. eslint: [`react/no-array-index-key`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-array-index-key.md)
> Why? Not using a stable ID [is an anti-pattern](https://medium.com/@robinpokorny/index-as-a-key-is-an-anti-pattern-e0349aece318) because it can negatively impact performance and cause issues with component state.
@@ -483,7 +483,7 @@ We don’t recommend using indexes for keys if the order of items may change.
## Refs
- - Always use ref callbacks. eslint: [`react/no-string-refs`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-string-refs.md)
+ - Always use ref callbacks. eslint: [`react/no-string-refs`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-string-refs.md)
```jsx
// bad
@@ -499,7 +499,7 @@ We don’t recommend using indexes for keys if the order of items may change.
## Parentheses
- - Wrap JSX tags in parentheses when they span more than one line. eslint: [`react/jsx-wrap-multilines`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-wrap-multilines.md)
+ - Wrap JSX tags in parentheses when they span more than one line. eslint: [`react/jsx-wrap-multilines`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-wrap-multilines.md)
```jsx
// bad
@@ -527,7 +527,7 @@ We don’t recommend using indexes for keys if the order of items may change.
## Tags
- - Always self-close tags that have no children. eslint: [`react/self-closing-comp`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/self-closing-comp.md)
+ - Always self-close tags that have no children. eslint: [`react/self-closing-comp`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/self-closing-comp.md)
```jsx
// bad
@@ -537,7 +537,7 @@ We don’t recommend using indexes for keys if the order of items may change.
<Foo variant="stuff" />
```
- - If your component has multiline properties, close its tag on a new line. eslint: [`react/jsx-closing-bracket-location`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-closing-bracket-location.md)
+ - If your component has multiline properties, close its tag on a new line. eslint: [`react/jsx-closing-bracket-location`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-closing-bracket-location.md)
```jsx
// bad
@@ -571,7 +571,7 @@ We don’t recommend using indexes for keys if the order of items may change.
}
```
- - Bind event handlers for the render method in the constructor. eslint: [`react/jsx-no-bind`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md)
+ - Bind event handlers for the render method in the constructor. eslint: [`react/jsx-no-bind`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md)
> Why? A bind call in the render path creates a brand new function on every single render. Do not use arrow functions in class fields, because it makes them [challenging to test and debug, and can negatively impact performance](https://medium.com/@charpeni/arrow-functions-in-class-properties-might-not-be-as-great-as-we-think-3b3551c440b1), and because conceptually, class fields are for data, not logic.
@@ -639,7 +639,7 @@ We don’t recommend using indexes for keys if the order of items may change.
}
```
- - Be sure to return a value in your `render` methods. eslint: [`react/require-render-return`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/require-render-return.md)
+ - Be sure to return a value in your `render` methods. eslint: [`react/require-render-return`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/require-render-return.md)
```jsx
// bad
@@ -705,7 +705,7 @@ We don’t recommend using indexes for keys if the order of items may change.
export default Link;
```
- - Ordering for `React.createClass`: eslint: [`react/sort-comp`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/sort-comp.md)
+ - Ordering for `React.createClass`: eslint: [`react/sort-comp`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/sort-comp.md)
1. `displayName`
1. `propTypes`
@@ -731,7 +731,7 @@ We don’t recommend using indexes for keys if the order of items may change.
## `isMounted`
- - Do not use `isMounted`. eslint: [`react/no-is-mounted`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/no-is-mounted.md)
+ - Do not use `isMounted`. eslint: [`react/no-is-mounted`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-is-mounted.md)
> Why? [`isMounted` is an anti-pattern][anti-pattern], is not available when using ES6 classes, and is on its way to being officially deprecated.
|
javascript
|
airbnb
|
JavaScript
|
JavaScript
| 146,197
| 26,671
|
JavaScript Style Guide
|
airbnb_javascript
|
DOC_CHANGE
|
changes in readme
|
e2763c0fa61f6a95c9ff04ea567b5cf71c0aa81b
|
2024-02-22 20:24:54
|
Vinta Chen
|
link to github
| false
| 1
| 1
| 2
|
--- README.md
@@ -141,7 +141,7 @@ Inspired by [awesome-php](https://github.com/ziadoz/awesome-php).
* [asyncio](https://docs.python.org/3/library/asyncio.html) - (Python standard library) Asynchronous I/O, event loop, coroutines and tasks.
- [awesome-asyncio](https://github.com/timofurrer/awesome-asyncio)
* [trio](https://github.com/python-trio/trio) - A friendly library for async concurrency and I/O.
-* [twisted](https://github.com/twisted/twisted) - An event-driven networking engine.
+* [Twisted](https://twistedmatrix.com/trac/) - An event-driven networking engine.
* [uvloop](https://github.com/MagicStack/uvloop) - Ultra fast asyncio event loop.
## Audio
|
awesome-python
|
vinta
|
Python
|
Python
| 236,071
| 25,368
|
An opinionated list of awesome Python frameworks, libraries, software and resources.
|
vinta_awesome-python
|
DOC_CHANGE
|
Obvious
|
38c24726092773bc360d7c440683b57316d6aeac
| null |
Cary Hull
|
Unterminated declaration breaks build. R=rsc APPROVED=rsc DELTA=1 (0 added, 0 deleted, 1 changed) OCL=16688 CL=16690
| false
| 1
| 1
| 0
|
--- fd_linux.go
@@ -39,7 +39,7 @@ export func NewPollster() (p *Pollster, err *os.Error) {
}
func (p *Pollster) AddFD(fd int64, mode int, repeat bool) *os.Error {
- var ev syscall.EpollEvent
+ var ev syscall.EpollEvent;
var already bool;
ev.fd = int32(fd);
ev.events, already = p.events[fd];
|
golang_go.json
| null | null | null | null | null | null |
golang_go.json
|
BUG_FIX
|
5, obvious
|
d73acd7af3a329e8ebe5df1c738ae8c1d0a5f778
|
2025-03-26 00:07:57
|
Pavel Begunkov
|
io_uring: rename "min" arg in io_iopoll_check() Don't name arguments "min", it shadows the namesake function. min_events is also more consistent. Signed-off-by: Pavel Begunkov <[email protected]> Link: https://lore.kernel.org/r/f52ce9d88d3bca5732a218b0da14924aa6968909.1742829388.git.asml.silence@gmail.com Signed-off-by: Jens Axboe <[email protected]>
| false
| 4
| 4
| 8
|
--- io_uring/io_uring.c
@@ -1505,7 +1505,7 @@ static __cold void io_iopoll_try_reap_events(struct io_ring_ctx *ctx)
mutex_unlock(&ctx->uring_lock);
}
-static int io_iopoll_check(struct io_ring_ctx *ctx, long min_events)
+static int io_iopoll_check(struct io_ring_ctx *ctx, long min)
{
unsigned int nr_events = 0;
unsigned long check_cq;
@@ -1551,7 +1551,7 @@ static int io_iopoll_check(struct io_ring_ctx *ctx, long min_events)
io_task_work_pending(ctx)) {
u32 tail = ctx->cached_cq_tail;
- (void) io_run_local_work_locked(ctx, min_events);
+ (void) io_run_local_work_locked(ctx, min);
if (task_work_pending(current) ||
wq_list_empty(&ctx->iopoll_list)) {
@@ -1564,7 +1564,7 @@ static int io_iopoll_check(struct io_ring_ctx *ctx, long min_events)
wq_list_empty(&ctx->iopoll_list))
break;
}
- ret = io_do_iopoll(ctx, !min_events);
+ ret = io_do_iopoll(ctx, !min);
if (unlikely(ret < 0))
return ret;
@@ -1574,7 +1574,7 @@ static int io_iopoll_check(struct io_ring_ctx *ctx, long min_events)
break;
nr_events += ret;
- } while (nr_events < min_events);
+ } while (nr_events < min);
return 0;
}
|
linux
|
torvalds
|
C
|
C
| 189,022
| 55,340
|
Linux kernel source tree
|
torvalds_linux
|
CODE_IMPROVEMENT
|
argument name changed
|
214f026e8f5004197415ad585ec6ee3031c020e3
|
2022-04-13 17:46:18
|
Max Lowther
|
add goven (#4165)
| false
| 1
| 0
| 1
|
--- README.md
@@ -1940,7 +1940,6 @@ _Unofficial libraries for package and dependency management._
- [api-fu](https://github.com/ccbrown/api-fu) - Comprehensive GraphQL implementation.
- [dasel](https://github.com/tomwright/dasel) - Query and update data structures using selectors from the command line. Comparable to jq/yq but supports JSON, YAML, TOML and XML with zero runtime dependencies.
- [gojsonq](https://github.com/thedevsaddam/gojsonq) - A simple Go package to Query over JSON Data.
-- [goven](https://github.com/SeldonIO/goven) - A drop-in query language for any database schema.
- [gqlgen](https://github.com/99designs/gqlgen) - go generate based graphql server library.
- [graphql](https://github.com/tmc/graphql) - graphql parser + utilities.
- [graphql](https://github.com/neelance/graphql-go) - GraphQL server with a focus on ease of use.
|
awesome-go
|
avelino
|
Go
|
Go
| 139,192
| 12,134
|
A curated list of awesome Go frameworks, libraries and software
|
avelino_awesome-go
|
CONFIG_CHANGE
|
Very small changes
|
0519ca272bb2a74ee5277db7d53f2e163e7295b4
|
2024-04-23 20:50:38
|
dependabot[bot]
|
chore(deps-dev): bump eslint from 9.0.0 to 9.1.1 in /libraries/javascript in the lint group (#142) Bumps the lint group in /libraries/javascript with 1 update:
[eslint](https://github.com/eslint/eslint).
Updates `eslint` from 9.0.0 to 9.1.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/eslint/eslint/releases">eslint's
releases</a>.</em></p>
<blockquote>
<h2>v9.1.1</h2>
<h2>Bug Fixes</h2>
<ul>
<li><a
href="https://github.com/eslint/eslint/commit/a26b40279f283853717236b44602b27b57f0b627"><code>a26b402</code></a>
fix: use <code>@eslint/create-config</code> latest (<a
href="https://redirect.github.com/eslint/eslint/issues/18373">#18373</a>)
(唯然)</li>
</ul>
<h2>v9.1.0</h2>
<h2>Features</h2>
<ul>
<li><a
href="https://github.com/eslint/eslint/commit/03068f13c0e3e6b34b8ca63628cfc79dd256feac"><code>03068f1</code></a>
feat: Provide helpful error message for nullish configs (<a
href="https://redirect.github.com/eslint/eslint/issues/18357">#18357</a>)
(Nicholas C. Zakas)</li>
<li><a
href="https://github.com/eslint/eslint/commit/751b518f02b1e9f4f0cb4a4007ffacb1be2246af"><code>751b518</code></a>
feat: replace dependency graphemer with <code>Intl.Segmenter</code> (<a
href="https://redirect.github.com/eslint/eslint/issues/18110">#18110</a>)
(Francesco Trotta)</li>
<li><a
href="https://github.com/eslint/eslint/commit/4d11e567baff575146fd267b3765ab2c788aa1e5"><code>4d11e56</code></a>
feat: add <code>name</code> to eslint configs (<a
href="https://redirect.github.com/eslint/eslint/issues/18289">#18289</a>)
(唯然)</li>
<li><a
href="https://github.com/eslint/eslint/commit/1cbe1f6d38272784307c260f2375ab30e68716e8"><code>1cbe1f6</code></a>
feat: allow <code>while(true)</code> in
<code>no-constant-condition</code> (<a
href="https://redirect.github.com/eslint/eslint/issues/18286">#18286</a>)
(Tanuj Kanti)</li>
<li><a
href="https://github.com/eslint/eslint/commit/0db676f9c64d2622ada86b653136d2bda4f0eee0"><code>0db676f</code></a>
feat: add <code>Intl</code> in es6 globals (<a
href="https://redirect.github.com/eslint/eslint/issues/18318">#18318</a>)
(唯然)</li>
</ul>
<h2>Bug Fixes</h2>
<ul>
<li><a
href="https://github.com/eslint/eslint/commit/8d189586d60f9beda7be8cdefd4156c023c4fdde"><code>8d18958</code></a>
fix: Remove name from eslint/js packages (<a
href="https://redirect.github.com/eslint/eslint/issues/18368">#18368</a>)
(Nicholas C. Zakas)</li>
<li><a
href="https://github.com/eslint/eslint/commit/594eb0e5c2b14a418d686c33d2d40fb439888b70"><code>594eb0e</code></a>
fix: do not crash on error in <code>fs.walk</code> filter (<a
href="https://redirect.github.com/eslint/eslint/issues/18295">#18295</a>)
(Francesco Trotta)</li>
<li><a
href="https://github.com/eslint/eslint/commit/0d8cf6350ce3dc417d6e23922e6d4ad03952aaaa"><code>0d8cf63</code></a>
fix: EMFILE errors (<a
href="https://redirect.github.com/eslint/eslint/issues/18313">#18313</a>)
(Nicholas C. Zakas)</li>
<li><a
href="https://github.com/eslint/eslint/commit/e1ac0b5c035bfdff7be08b69e89e1470a7becac3"><code>e1ac0b5</code></a>
fix: --inspect-config only for flat config and respect -c (<a
href="https://redirect.github.com/eslint/eslint/issues/18306">#18306</a>)
(Nicholas C. Zakas)</li>
<li><a
href="https://github.com/eslint/eslint/commit/09675e153169d4d0f4a85a95007dcd17d34d70c7"><code>09675e1</code></a>
fix: <code>--no-ignore</code> should not apply to non-global ignores (<a
href="https://redirect.github.com/eslint/eslint/issues/18334">#18334</a>)
(Milos Djermanovic)</li>
</ul>
<h2>Documentation</h2>
<ul>
<li><a
href="https://github.com/eslint/eslint/commit/fb50077fec497fbf01d754fc75aa22cff43ef066"><code>fb50077</code></a>
docs: include notes about globals in migration-guide (<a
href="https://redirect.github.com/eslint/eslint/issues/18356">#18356</a>)
(Gabriel Rohden)</li>
<li><a
href="https://github.com/eslint/eslint/commit/71c771fb390cf178220d06fd7316033a385128a9"><code>71c771f</code></a>
docs: Fix missing accessible name for scroll-to-top link (<a
href="https://redirect.github.com/eslint/eslint/issues/18329">#18329</a>)
(Germán Freixinós)</li>
<li><a
href="https://github.com/eslint/eslint/commit/200fd4e3223d1ad22dca3dc79aa6eaa860fefe32"><code>200fd4e</code></a>
docs: indicate eslintrc mode for <code>.eslintignore</code> (<a
href="https://redirect.github.com/eslint/eslint/issues/18285">#18285</a>)
(Francesco Trotta)</li>
<li><a
href="https://github.com/eslint/eslint/commit/16b6a8b469d2e0ba6d904b9e858711590568b246"><code>16b6a8b</code></a>
docs: Update README (GitHub Actions Bot)</li>
<li><a
href="https://github.com/eslint/eslint/commit/df5f8a9bc1042c13f1969c9fbd8c72eee0662daa"><code>df5f8a9</code></a>
docs: <code>paths</code> and <code>patterns</code> difference in
<code>no-restricted-imports</code> (<a
href="https://redirect.github.com/eslint/eslint/issues/18273">#18273</a>)
(Tanuj Kanti)</li>
<li><a
href="https://github.com/eslint/eslint/commit/c537d76327586616b7ca5d00e76eaf6c76e6bcd2"><code>c537d76</code></a>
docs: update <code>npm init @eslint/config</code> generated file names
(<a
href="https://redirect.github.com/eslint/eslint/issues/18298">#18298</a>)
(唯然)</li>
<li><a
href="https://github.com/eslint/eslint/commit/e1e305defaab98605d79c81d67ee5a48558c458a"><code>e1e305d</code></a>
docs: fix <code>linebreak-style</code> examples (<a
href="https://redirect.github.com/eslint/eslint/issues/18262">#18262</a>)
(Francesco Trotta)</li>
<li><a
href="https://github.com/eslint/eslint/commit/113f51ec4e52d3082a74b9682239a6e28d1a70ee"><code>113f51e</code></a>
docs: Mention package.json config support dropped (<a
href="https://redirect.github.com/eslint/eslint/issues/18305">#18305</a>)
(Nicholas C. Zakas)</li>
<li><a
href="https://github.com/eslint/eslint/commit/5c353215e05818e17e83192acbb4d3730c716afa"><code>5c35321</code></a>
docs: add eslintrc-only note to <code>--rulesdir</code> (<a
href="https://redirect.github.com/eslint/eslint/issues/18281">#18281</a>)
(Adam Lui 刘展鹏)</li>
</ul>
<h2>Build Related</h2>
<ul>
<li><a
href="https://github.com/eslint/eslint/commit/1fa66220ad130eeb69cfa0207d3896b7bb09c576"><code>1fa6622</code></a>
build: do not use <code>--force</code> flag to install dependencies (<a
href="https://redirect.github.com/eslint/eslint/issues/18284">#18284</a>)
(Francesco Trotta)</li>
</ul>
<h2>Chores</h2>
<ul>
<li><a
href="https://github.com/eslint/eslint/commit/d9a2983e1301599117cf554aa6a9bd44b84f2e55"><code>d9a2983</code></a>
chore: upgrade <code>@eslint/js</code> to v9.1.1 (<a
href="https://redirect.github.com/eslint/eslint/issues/18367">#18367</a>)
(Francesco Trotta)</li>
<li><a
href="https://github.com/eslint/eslint/commit/50d406d68c0304370fa47d156a407258b68dfa1b"><code>50d406d</code></a>
chore: package.json update for <code>@eslint/js</code> release
(Jenkins)</li>
<li><a
href="https://github.com/eslint/eslint/commit/155c71c210aaa7235ddadabb067813d8b1c76f65"><code>155c71c</code></a>
chore: package.json update for <code>@eslint/js</code> release
(Jenkins)</li>
<li><a
href="https://github.com/eslint/eslint/commit/0588fc5ecb87fddd70e1848e417ba712b48473c3"><code>0588fc5</code></a>
refactor: Move directive gathering to SourceCode (<a
href="https://redirect.github.com/eslint/eslint/issues/18328">#18328</a>)
(Nicholas C. Zakas)</li>
<li><a
href="https://github.com/eslint/eslint/commit/9048e2184c19799bb9b8a5908345d4ce05020c41"><code>9048e21</code></a>
chore: lint <code>docs/src/_data</code> js files (<a
href="https://redirect.github.com/eslint/eslint/issues/18335">#18335</a>)
(Milos Djermanovic)</li>
<li><a
href="https://github.com/eslint/eslint/commit/48207908a8291916a124af60e02d0327276f8957"><code>4820790</code></a>
chore: upgrade [email protected] dev dependency (<a
href="https://redirect.github.com/eslint/eslint/issues/18332">#18332</a>)
(Milos Djermanovic)</li>
<li><a
href="https://github.com/eslint/eslint/commit/698d9ff2c9c4e24836d69358b93d42c356eb853b"><code>698d9ff</code></a>
chore: upgrade jsdoc & unicorn plugins in eslint-config-eslint (<a
href="https://redirect.github.com/eslint/eslint/issues/18333">#18333</a>)
(Milos Djermanovic)</li>
<li><a
href="https://github.com/eslint/eslint/commit/32c08cf66536e595e93284500b0b8d702e30cfd8"><code>32c08cf</code></a>
chore: drop Node < 18 and use <code>@eslint/js</code> v9 in
eslint-config-eslint (<a
href="https://redirect.github.com/eslint/eslint/issues/18323">#18323</a>)
(Milos Djermanovic)</li>
<li><a
href="https://github.com/eslint/eslint/commit/a76fb55004ea095c68dde134ca7db0212c93c86e"><code>a76fb55</code></a>
chore: <code>@eslint-community/eslint-plugin-eslint-comments</code>
v4.3.0 (<a
href="https://redirect.github.com/eslint/eslint/issues/18319">#18319</a>)
(Milos Djermanovic)</li>
<li><a
href="https://github.com/eslint/eslint/commit/78e45b1d8d6b673ced233ca82b9ff1dddcdd1fec"><code>78e45b1</code></a>
chore: eslint-plugin-eslint-plugin v6.0.0 (<a
href="https://redirect.github.com/eslint/eslint/issues/18316">#18316</a>)
(唯然)</li>
<li><a
href="https://github.com/eslint/eslint/commit/36103a52432fffa20b90f2c6960757e6b9dc778f"><code>36103a5</code></a>
chore: eslint-plugin-n v17.0.0 (<a
href="https://redirect.github.com/eslint/eslint/issues/18315">#18315</a>)
(唯然)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/eslint/eslint/blob/main/CHANGELOG.md">eslint's
changelog</a>.</em></p>
<blockquote>
<p>v9.1.1 - April 22, 2024</p>
<ul>
<li><a
href="https://github.com/eslint/eslint/commit/a26b40279f283853717236b44602b27b57f0b627"><code>a26b402</code></a>
fix: use <code>@eslint/create-config</code> latest (<a
href="https://redirect.github.com/eslint/eslint/issues/18373">#18373</a>)
(唯然)</li>
</ul>
<p>v9.1.0 - April 19, 2024</p>
<ul>
<li><a
href="https://github.com/eslint/eslint/commit/d9a2983e1301599117cf554aa6a9bd44b84f2e55"><code>d9a2983</code></a>
chore: upgrade <code>@eslint/js</code> to v9.1.1 (<a
href="https://redirect.github.com/eslint/eslint/issues/18367">#18367</a>)
(Francesco Trotta)</li>
<li><a
href="https://github.com/eslint/eslint/commit/03068f13c0e3e6b34b8ca63628cfc79dd256feac"><code>03068f1</code></a>
feat: Provide helpful error message for nullish configs (<a
href="https://redirect.github.com/eslint/eslint/issues/18357">#18357</a>)
(Nicholas C. Zakas)</li>
<li><a
href="https://github.com/eslint/eslint/commit/50d406d68c0304370fa47d156a407258b68dfa1b"><code>50d406d</code></a>
chore: package.json update for <code>@eslint/js</code> release
(Jenkins)</li>
<li><a
href="https://github.com/eslint/eslint/commit/8d189586d60f9beda7be8cdefd4156c023c4fdde"><code>8d18958</code></a>
fix: Remove name from eslint/js packages (<a
href="https://redirect.github.com/eslint/eslint/issues/18368">#18368</a>)
(Nicholas C. Zakas)</li>
<li><a
href="https://github.com/eslint/eslint/commit/155c71c210aaa7235ddadabb067813d8b1c76f65"><code>155c71c</code></a>
chore: package.json update for <code>@eslint/js</code> release
(Jenkins)</li>
<li><a
href="https://github.com/eslint/eslint/commit/594eb0e5c2b14a418d686c33d2d40fb439888b70"><code>594eb0e</code></a>
fix: do not crash on error in <code>fs.walk</code> filter (<a
href="https://redirect.github.com/eslint/eslint/issues/18295">#18295</a>)
(Francesco Trotta)</li>
<li><a
href="https://github.com/eslint/eslint/commit/751b518f02b1e9f4f0cb4a4007ffacb1be2246af"><code>751b518</code></a>
feat: replace dependency graphemer with <code>Intl.Segmenter</code> (<a
href="https://redirect.github.com/eslint/eslint/issues/18110">#18110</a>)
(Francesco Trotta)</li>
<li><a
href="https://github.com/eslint/eslint/commit/fb50077fec497fbf01d754fc75aa22cff43ef066"><code>fb50077</code></a>
docs: include notes about globals in migration-guide (<a
href="https://redirect.github.com/eslint/eslint/issues/18356">#18356</a>)
(Gabriel Rohden)</li>
<li><a
href="https://github.com/eslint/eslint/commit/4d11e567baff575146fd267b3765ab2c788aa1e5"><code>4d11e56</code></a>
feat: add <code>name</code> to eslint configs (<a
href="https://redirect.github.com/eslint/eslint/issues/18289">#18289</a>)
(唯然)</li>
<li><a
href="https://github.com/eslint/eslint/commit/1cbe1f6d38272784307c260f2375ab30e68716e8"><code>1cbe1f6</code></a>
feat: allow <code>while(true)</code> in
<code>no-constant-condition</code> (<a
href="https://redirect.github.com/eslint/eslint/issues/18286">#18286</a>)
(Tanuj Kanti)</li>
<li><a
href="https://github.com/eslint/eslint/commit/0588fc5ecb87fddd70e1848e417ba712b48473c3"><code>0588fc5</code></a>
refactor: Move directive gathering to SourceCode (<a
href="https://redirect.github.com/eslint/eslint/issues/18328">#18328</a>)
(Nicholas C. Zakas)</li>
<li><a
href="https://github.com/eslint/eslint/commit/0d8cf6350ce3dc417d6e23922e6d4ad03952aaaa"><code>0d8cf63</code></a>
fix: EMFILE errors (<a
href="https://redirect.github.com/eslint/eslint/issues/18313">#18313</a>)
(Nicholas C. Zakas)</li>
<li><a
href="https://github.com/eslint/eslint/commit/e1ac0b5c035bfdff7be08b69e89e1470a7becac3"><code>e1ac0b5</code></a>
fix: --inspect-config only for flat config and respect -c (<a
href="https://redirect.github.com/eslint/eslint/issues/18306">#18306</a>)
(Nicholas C. Zakas)</li>
<li><a
href="https://github.com/eslint/eslint/commit/09675e153169d4d0f4a85a95007dcd17d34d70c7"><code>09675e1</code></a>
fix: <code>--no-ignore</code> should not apply to non-global ignores (<a
href="https://redirect.github.com/eslint/eslint/issues/18334">#18334</a>)
(Milos Djermanovic)</li>
<li><a
href="https://github.com/eslint/eslint/commit/9048e2184c19799bb9b8a5908345d4ce05020c41"><code>9048e21</code></a>
chore: lint <code>docs/src/_data</code> js files (<a
href="https://redirect.github.com/eslint/eslint/issues/18335">#18335</a>)
(Milos Djermanovic)</li>
<li><a
href="https://github.com/eslint/eslint/commit/48207908a8291916a124af60e02d0327276f8957"><code>4820790</code></a>
chore: upgrade [email protected] dev dependency (<a
href="https://redirect.github.com/eslint/eslint/issues/18332">#18332</a>)
(Milos Djermanovic)</li>
<li><a
href="https://github.com/eslint/eslint/commit/698d9ff2c9c4e24836d69358b93d42c356eb853b"><code>698d9ff</code></a>
chore: upgrade jsdoc & unicorn plugins in eslint-config-eslint (<a
href="https://redirect.github.com/eslint/eslint/issues/18333">#18333</a>)
(Milos Djermanovic)</li>
<li><a
href="https://github.com/eslint/eslint/commit/71c771fb390cf178220d06fd7316033a385128a9"><code>71c771f</code></a>
docs: Fix missing accessible name for scroll-to-top link (<a
href="https://redirect.github.com/eslint/eslint/issues/18329">#18329</a>)
(Germán Freixinós)</li>
<li><a
href="https://github.com/eslint/eslint/commit/0db676f9c64d2622ada86b653136d2bda4f0eee0"><code>0db676f</code></a>
feat: add <code>Intl</code> in es6 globals (<a
href="https://redirect.github.com/eslint/eslint/issues/18318">#18318</a>)
(唯然)</li>
<li><a
href="https://github.com/eslint/eslint/commit/200fd4e3223d1ad22dca3dc79aa6eaa860fefe32"><code>200fd4e</code></a>
docs: indicate eslintrc mode for <code>.eslintignore</code> (<a
href="https://redirect.github.com/eslint/eslint/issues/18285">#18285</a>)
(Francesco Trotta)</li>
<li><a
href="https://github.com/eslint/eslint/commit/32c08cf66536e595e93284500b0b8d702e30cfd8"><code>32c08cf</code></a>
chore: drop Node < 18 and use <code>@eslint/js</code> v9 in
eslint-config-eslint (<a
href="https://redirect.github.com/eslint/eslint/issues/18323">#18323</a>)
(Milos Djermanovic)</li>
<li><a
href="https://github.com/eslint/eslint/commit/16b6a8b469d2e0ba6d904b9e858711590568b246"><code>16b6a8b</code></a>
docs: Update README (GitHub Actions Bot)</li>
<li><a
href="https://github.com/eslint/eslint/commit/a76fb55004ea095c68dde134ca7db0212c93c86e"><code>a76fb55</code></a>
chore: <code>@eslint-community/eslint-plugin-eslint-comments</code>
v4.3.0 (<a
href="https://redirect.github.com/eslint/eslint/issues/18319">#18319</a>)
(Milos Djermanovic)</li>
<li><a
href="https://github.com/eslint/eslint/commit/df5f8a9bc1042c13f1969c9fbd8c72eee0662daa"><code>df5f8a9</code></a>
docs: <code>paths</code> and <code>patterns</code> difference in
<code>no-restricted-imports</code> (<a
href="https://redirect.github.com/eslint/eslint/issues/18273">#18273</a>)
(Tanuj Kanti)</li>
<li><a
href="https://github.com/eslint/eslint/commit/c537d76327586616b7ca5d00e76eaf6c76e6bcd2"><code>c537d76</code></a>
docs: update <code>npm init @eslint/config</code> generated file names
(<a
href="https://redirect.github.com/eslint/eslint/issues/18298">#18298</a>)
(唯然)</li>
<li><a
href="https://github.com/eslint/eslint/commit/78e45b1d8d6b673ced233ca82b9ff1dddcdd1fec"><code>78e45b1</code></a>
chore: eslint-plugin-eslint-plugin v6.0.0 (<a
href="https://redirect.github.com/eslint/eslint/issues/18316">#18316</a>)
(唯然)</li>
<li><a
href="https://github.com/eslint/eslint/commit/36103a52432fffa20b90f2c6960757e6b9dc778f"><code>36103a5</code></a>
chore: eslint-plugin-n v17.0.0 (<a
href="https://redirect.github.com/eslint/eslint/issues/18315">#18315</a>)
(唯然)</li>
<li><a
href="https://github.com/eslint/eslint/commit/e1e305defaab98605d79c81d67ee5a48558c458a"><code>e1e305d</code></a>
docs: fix <code>linebreak-style</code> examples (<a
href="https://redirect.github.com/eslint/eslint/issues/18262">#18262</a>)
(Francesco Trotta)</li>
<li><a
href="https://github.com/eslint/eslint/commit/113f51ec4e52d3082a74b9682239a6e28d1a70ee"><code>113f51e</code></a>
docs: Mention package.json config support dropped (<a
href="https://redirect.github.com/eslint/eslint/issues/18305">#18305</a>)
(Nicholas C. Zakas)</li>
<li><a
href="https://github.com/eslint/eslint/commit/1fa66220ad130eeb69cfa0207d3896b7bb09c576"><code>1fa6622</code></a>
build: do not use <code>--force</code> flag to install dependencies (<a
href="https://redirect.github.com/eslint/eslint/issues/18284">#18284</a>)
(Francesco Trotta)</li>
<li><a
href="https://github.com/eslint/eslint/commit/5c353215e05818e17e83192acbb4d3730c716afa"><code>5c35321</code></a>
docs: add eslintrc-only note to <code>--rulesdir</code> (<a
href="https://redirect.github.com/eslint/eslint/issues/18281">#18281</a>)
(Adam Lui 刘展鹏)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/eslint/eslint/commit/b4d2512809a1b28466ad1ce5af9d01c181b9bf9e"><code>b4d2512</code></a>
9.1.1</li>
<li><a
href="https://github.com/eslint/eslint/commit/ef36aa46b9d946d67f90c0b6aa07d66c83b5fcbc"><code>ef36aa4</code></a>
Build: changelog update for 9.1.1</li>
<li><a
href="https://github.com/eslint/eslint/commit/a26b40279f283853717236b44602b27b57f0b627"><code>a26b402</code></a>
fix: use <code>@eslint/create-config</code> latest (<a
href="https://redirect.github.com/eslint/eslint/issues/18373">#18373</a>)</li>
<li><a
href="https://github.com/eslint/eslint/commit/b78d831e244171c939279b03be519b5c13836fce"><code>b78d831</code></a>
9.1.0</li>
<li><a
href="https://github.com/eslint/eslint/commit/e4d9c921f64175d90de4d3094b4d68f4da4f95cf"><code>e4d9c92</code></a>
Build: changelog update for 9.1.0</li>
<li><a
href="https://github.com/eslint/eslint/commit/d9a2983e1301599117cf554aa6a9bd44b84f2e55"><code>d9a2983</code></a>
chore: upgrade <code>@eslint/js</code> to v9.1.1 (<a
href="https://redirect.github.com/eslint/eslint/issues/18367">#18367</a>)</li>
<li><a
href="https://github.com/eslint/eslint/commit/03068f13c0e3e6b34b8ca63628cfc79dd256feac"><code>03068f1</code></a>
feat: Provide helpful error message for nullish configs (<a
href="https://redirect.github.com/eslint/eslint/issues/18357">#18357</a>)</li>
<li><a
href="https://github.com/eslint/eslint/commit/50d406d68c0304370fa47d156a407258b68dfa1b"><code>50d406d</code></a>
chore: package.json update for <code>@eslint/js</code> release</li>
<li><a
href="https://github.com/eslint/eslint/commit/8d189586d60f9beda7be8cdefd4156c023c4fdde"><code>8d18958</code></a>
fix: Remove name from eslint/js packages (<a
href="https://redirect.github.com/eslint/eslint/issues/18368">#18368</a>)</li>
<li><a
href="https://github.com/eslint/eslint/commit/155c71c210aaa7235ddadabb067813d8b1c76f65"><code>155c71c</code></a>
chore: package.json update for <code>@eslint/js</code> release</li>
<li>Additional commits viewable in <a
href="https://github.com/eslint/eslint/compare/v9.0.0...v9.1.1">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
| false
| 19
| 14
| 33
|
--- libraries/javascript/yarn.lock
@@ -447,15 +447,15 @@
minimatch "^3.1.2"
strip-json-comments "^3.1.1"
-"@eslint/[email protected]":
- version "9.1.1"
- resolved "https://registry.yarnpkg.com/@eslint/js/-/js-9.1.1.tgz#eb0f82461d12779bbafc1b5045cde3143d350a8a"
- integrity sha512-5WoDz3Y19Bg2BnErkZTp0en+c/i9PvgFS7MBe1+m60HjFr0hrphlAGp4yzI7pxpt4xShln4ZyYp4neJm8hmOkQ==
+"@eslint/[email protected]":
+ version "9.0.0"
+ resolved "https://registry.yarnpkg.com/@eslint/js/-/js-9.0.0.tgz#1a9e4b4c96d8c7886e0110ed310a0135144a1691"
+ integrity sha512-RThY/MnKrhubF6+s1JflwUjPEsnCEmYCWwqa/aRISKWNXGZ9epUwft4bUMM35SdKF9xvBrLydAM1RDHd1Z//ZQ==
-"@humanwhocodes/config-array@^0.13.0":
- version "0.13.0"
- resolved "https://registry.yarnpkg.com/@humanwhocodes/config-array/-/config-array-0.13.0.tgz#fb907624df3256d04b9aa2df50d7aa97ec648748"
- integrity sha512-DZLEEqFWQFiyK6h5YIeynKx7JlvCYWL0cImfSRXZ9l4Sg2efkFGTuFf6vzXjK1cq6IYkU+Eg/JizXw+TD2vRNw==
+"@humanwhocodes/config-array@^0.12.3":
+ version "0.12.3"
+ resolved "https://registry.yarnpkg.com/@humanwhocodes/config-array/-/config-array-0.12.3.tgz#a6216d90f81a30bedd1d4b5d799b47241f318072"
+ integrity sha512-jsNnTBlMWuTpDkeE3on7+dWJi0D6fdDfeANj/w7MpS8ztROCoLvIO2nG0CcFj+E4k8j4QrSTh4Oryi3i2G669g==
dependencies:
"@humanwhocodes/object-schema" "^2.0.3"
debug "^4.3.1"
@@ -471,11 +471,6 @@
resolved "https://registry.yarnpkg.com/@humanwhocodes/object-schema/-/object-schema-2.0.3.tgz#4a2868d75d6d6963e423bcf90b7fd1be343409d3"
integrity sha512-93zYdMES/c1D69yZiKDBj0V24vqNzB/koF26KPaagAfd3P/4gUlh3Dys5ogAK+Exi9QyzlD8x/08Zt7wIKcDcA==
-"@humanwhocodes/retry@^0.2.3":
- version "0.2.3"
- resolved "https://registry.yarnpkg.com/@humanwhocodes/retry/-/retry-0.2.3.tgz#c9aa036d1afa643f1250e83150f39efb3a15a631"
- integrity sha512-X38nUbachlb01YMlvPFojKoiXq+LzZvuSce70KPMPdeM1Rj03k4dR7lDslhbqXn3Ang4EU3+EAmwEAsbrjHW3g==
-
"@istanbuljs/load-nyc-config@^1.0.0":
version "1.1.0"
resolved "https://registry.yarnpkg.com/@istanbuljs/load-nyc-config/-/load-nyc-config-1.1.0.tgz#fd3db1d59ecf7cf121e80650bb86712f9b55eced"
@@ -1403,17 +1398,16 @@ eslint-visitor-keys@^4.0.0:
integrity sha512-OtIRv/2GyiF6o/d8K7MYKKbXrOUBIK6SfkIRM4Z0dY3w+LiQ0vy3F57m0Z71bjbyeiWFiHJ8brqnmE6H6/jEuw==
eslint@^9.0.0:
- version "9.1.1"
- resolved "https://registry.yarnpkg.com/eslint/-/eslint-9.1.1.tgz#39ec657ccd12813cb4a1dab2f9229dcc6e468271"
- integrity sha512-b4cRQ0BeZcSEzPpY2PjFY70VbO32K7BStTGtBsnIGdTSEEQzBi8hPBcGQmTG2zUvFr9uLe0TK42bw8YszuHEqg==
+ version "9.0.0"
+ resolved "https://registry.yarnpkg.com/eslint/-/eslint-9.0.0.tgz#6270548758e390343f78c8afd030566d86927d40"
+ integrity sha512-IMryZ5SudxzQvuod6rUdIUz29qFItWx281VhtFVc2Psy/ZhlCeD/5DT6lBIJ4H3G+iamGJoTln1v+QSuPw0p7Q==
dependencies:
"@eslint-community/eslint-utils" "^4.2.0"
"@eslint-community/regexpp" "^4.6.1"
"@eslint/eslintrc" "^3.0.2"
- "@eslint/js" "9.1.1"
- "@humanwhocodes/config-array" "^0.13.0"
+ "@eslint/js" "9.0.0"
+ "@humanwhocodes/config-array" "^0.12.3"
"@humanwhocodes/module-importer" "^1.0.1"
- "@humanwhocodes/retry" "^0.2.3"
"@nodelib/fs.walk" "^1.2.8"
ajv "^6.12.4"
chalk "^4.0.0"
@@ -1429,6 +1423,7 @@ eslint@^9.0.0:
file-entry-cache "^8.0.0"
find-up "^5.0.0"
glob-parent "^6.0.2"
+ graphemer "^1.4.0"
ignore "^5.2.0"
imurmurhash "^0.1.4"
is-glob "^4.0.0"
|
standard-webhooks
|
standard-webhooks
|
Elixir
|
Elixir
| 1,390
| 37
|
The Standard Webhooks specification
|
standard-webhooks_standard-webhooks
|
CONFIG_CHANGE
|
just some version changes
|
c8721ccdeb45396c5acf53da058a0fe1e3d03590
|
2025-03-21 17:25:44
|
Owen Avery
|
gccrs: Remove Rust::make_unique Since our bootstrap requirement has been bumped to C++14, we don't need a custom implementation of std::make_unique anymore. gcc/rust/ChangeLog: * ast/rust-ast-builder-type.cc: Remove inclusion of rust-make-unique.h. * ast/rust-ast-builder.cc: Likewise. (Builder::array): Use std::make_unique instead of Rust::make_unique. * ast/rust-ast.cc (Attribute::get_traits_to_derive): Likewise. * ast/rust-macro.h: Remove inclusion of rust-make-unique.h. (MacroRulesDefinition::mbe): Use std::make_unique instead of Rust::make_unique. (MacroRulesDefinition::decl_macro): Likewise. * ast/rust-path.h (PathInExpression::PathInExpression): Likewise. (QualifiedPathInExpression::QualifiedPathInExpression): Likewise. * backend/rust-compile-pattern.cc (CompilePatternCheckExpr::visit): Likewise. * expand/rust-derive-copy.cc (DeriveCopy::copy_impl): Likewise. * expand/rust-expand-format-args.cc (expand_format_args): Likewise. * expand/rust-macro-builtins-asm.cc: Remove inclusion of rust-make-unique.h. (parse_asm): Use std::make_unique instead of Rust::make_unique. * hir/rust-ast-lower-expr.cc (ASTLoweringExpr::visit): Likewise. * hir/tree/rust-hir-expr.cc (StructExprStructFields::StructExprStructFields): Likewise. (StructExprStructFields::operator=): Likewise. * hir/tree/rust-hir.cc (TypePath::to_trait_bound): Likewise. * lex/rust-token.h: Remove inclusion of rust-make-unique.h. (Token::Token): Use std::make_unique instead of Rust::make_unique. * metadata/rust-import-archive.cc: Remove inclusion of rust-make-unique.h. (Import::find_archive_export_data): Use std::make_unique instead of Rust::make_unique. * metadata/rust-imports.cc: Remove inclusion of rust-make-unique.h. (Import::find_export_data): Use std::make_unique instead of Rust::make_unique. (Import::find_object_export_data): Likewise. * parse/rust-parse-impl.h: Remove inclusion of rust-make-unique.h. (Parser::parse_function_param): Use std::make_unique instead of Rust::make_unique. (Parser::parse_self_param): Likewise. (Parser::parse_array_expr): Likewise. * typecheck/rust-hir-type-check-enumitem.cc (TypeCheckEnumItem::visit): Likewise. * typecheck/rust-hir-type-check-implitem.cc (TypeCheckTopLevelExternItem::visit): Likewise. (TypeCheckImplItem::visit): Likewise. * typecheck/rust-hir-type-check-type.cc (TypeResolveGenericParam::visit): Likewise. * typecheck/rust-hir-type-check.cc: Remove inclusion of rust-make-unique.h. (TraitItemReference::get_type_from_fn): Use std::make_unique instead of Rust::make_unique. * typecheck/rust-tyty-bounds.cc (TypeCheckBase::get_predicate_from_bound): Likewise. * util/rust-make-unique.h: Removed. Signed-off-by: Owen Avery <[email protected]>
| false
| 50
| 94
| 144
|
--- gcc/rust/ast/rust-ast-builder-type.cc
@@ -20,6 +20,7 @@
#include "rust-ast-builder.h"
#include "rust-ast-full.h"
#include "rust-common.h"
+#include "rust-make-unique.h"
namespace Rust {
namespace AST {
--- gcc/rust/ast/rust-ast-builder.cc
@@ -22,6 +22,7 @@
#include "rust-expr.h"
#include "rust-path.h"
#include "rust-token.h"
+#include "rust-make-unique.h"
namespace Rust {
namespace AST {
@@ -72,7 +73,7 @@ Builder::call (std::unique_ptr<Path> &&path, std::unique_ptr<Expr> &&arg) const
std::unique_ptr<Expr>
Builder::array (std::vector<std::unique_ptr<Expr>> &&members) const
{
- auto elts = std::make_unique<ArrayElemsValues> (std::move (members), loc);
+ auto elts = Rust::make_unique<ArrayElemsValues> (std::move (members), loc);
return std::unique_ptr<Expr> (new ArrayExpr (std::move (elts), {}, {}, loc));
}
--- gcc/rust/ast/rust-ast.cc
@@ -272,8 +272,8 @@ Attribute::get_traits_to_derive ()
case AST::MetaItem::ItemKind::Word: {
auto word = static_cast<AST::MetaWord *> (meta_item);
// Convert current word to path
- current = std::make_unique<AST::MetaItemPath> (
- AST::MetaItemPath (
+ current
+ = make_unique<AST::MetaItemPath> (AST::MetaItemPath (
AST::SimplePath (word->get_ident ())));
auto path
= static_cast<AST::MetaItemPath *> (current.get ());
--- gcc/rust/ast/rust-macro.h
@@ -24,6 +24,7 @@
#include "rust-ast-fragment.h"
#include "rust-location.h"
#include "rust-item.h"
+#include "rust-make-unique.h"
#include "rust-macro-builtins.h"
namespace Rust {
@@ -520,7 +521,7 @@ public:
mbe (Identifier rule_name, DelimType delim_type, std::vector<MacroRule> rules,
std::vector<Attribute> outer_attrs, location_t locus)
{
- return std::make_unique<MacroRulesDefinition> (
+ return Rust::make_unique<MacroRulesDefinition> (
MacroRulesDefinition (rule_name, delim_type, rules, outer_attrs, locus,
AST::MacroRulesDefinition::MacroKind::MBE,
AST::Visibility::create_error ()));
@@ -531,7 +532,7 @@ public:
std::vector<Attribute> outer_attrs, location_t locus,
Visibility vis)
{
- return std::make_unique<MacroRulesDefinition> (MacroRulesDefinition (
+ return Rust::make_unique<MacroRulesDefinition> (MacroRulesDefinition (
rule_name, AST::DelimType::CURLY, rules, outer_attrs, locus,
AST::MacroRulesDefinition::MacroKind::DeclMacro, vis));
}
--- gcc/rust/ast/rust-path.h
@@ -710,8 +710,8 @@ public:
: outer_attrs (std::move (outer_attrs)),
has_opening_scope_resolution (has_opening_scope_resolution),
locus (locus), _node_id (Analysis::Mappings::get ().get_next_node_id ()),
- path (std::make_unique<RegularPath> (std::move (path_segments), locus,
- _node_id)),
+ path (Rust::make_unique<RegularPath> (std::move (path_segments), locus,
+ _node_id)),
marked_for_strip (false)
{}
@@ -720,7 +720,7 @@ public:
: outer_attrs (std::move (outer_attrs)),
has_opening_scope_resolution (false), locus (locus),
_node_id (Analysis::Mappings::get ().get_next_node_id ()),
- path (std::make_unique<LangItemPath> (lang_item_kind, locus)),
+ path (Rust::make_unique<LangItemPath> (lang_item_kind, locus)),
marked_for_strip (false)
{}
@@ -1439,7 +1439,7 @@ public:
location_t locus)
: outer_attrs (std::move (outer_attrs)),
path_type (std::move (qual_path_type)),
- path (std::make_unique<RegularPath> (
+ path (Rust::make_unique<RegularPath> (
std::move (path_segments), locus,
Analysis::Mappings::get ().get_next_node_id ()))
{}
--- gcc/rust/backend/rust-compile-pattern.cc
@@ -80,7 +80,7 @@ void
CompilePatternCheckExpr::visit (HIR::LiteralPattern &pattern)
{
// Compile the literal
- auto litexpr = std::make_unique<HIR::LiteralExpr> (
+ auto litexpr = Rust::make_unique<HIR::LiteralExpr> (
HIR::LiteralExpr (pattern.get_mappings (), pattern.get_literal (),
pattern.get_locus (), std::vector<AST::Attribute> ()));
--- gcc/rust/expand/rust-derive-copy.cc
@@ -46,7 +46,7 @@ DeriveCopy::copy_impl (
// `$crate::core::marker::Copy` instead
auto segments = std::vector<std::unique_ptr<TypePathSegment>> ();
segments.emplace_back (builder.type_path_segment ("Copy"));
- auto copy = std::make_unique<LangItemPath> (LangItem::Kind::COPY, loc);
+ auto copy = Rust::make_unique<LangItemPath> (LangItem::Kind::COPY, loc);
// we need to build up the generics for this impl block which will be just a
// clone of the types specified ones
--- gcc/rust/expand/rust-expand-format-args.cc
@@ -120,7 +120,7 @@ expand_format_args (AST::FormatArgs &fmt,
auto pieces = builder.ref (builder.array (std::move (static_pieces)));
auto args_slice = builder.ref (builder.array (std::move (args_array)));
- auto final_path = std::make_unique<AST::PathInExpression> (
+ auto final_path = make_unique<AST::PathInExpression> (
builder.path_in_expression ({"core", "fmt", "Arguments", "new_v1"}));
auto final_args = std::vector<std::unique_ptr<AST::Expr>> ();
final_args.emplace_back (std::move (pieces));
--- gcc/rust/expand/rust-macro-builtins-asm.cc
@@ -17,6 +17,7 @@
// <http://www.gnu.org/licenses/>.
#include "expected.h"
+#include "rust-make-unique.h"
#include "rust-macro-builtins-asm.h"
#include "rust-ast-fragment.h"
#include "rust-ast.h"
@@ -857,9 +858,9 @@ parse_asm (location_t invoc_locus, AST::MacroInvocData &invoc,
// properly.
if (semicolon == AST::InvocKind::Semicoloned)
single_vec.emplace_back (AST::SingleASTNode (
- std::make_unique<AST::ExprStmt> (std::move (node), invoc_locus,
- semicolon
- == AST::InvocKind::Semicoloned)));
+ Rust::make_unique<AST::ExprStmt> (std::move (node), invoc_locus,
+ semicolon
+ == AST::InvocKind::Semicoloned)));
else
single_vec.emplace_back (AST::SingleASTNode (std::move (node)));
--- gcc/rust/hir/rust-ast-lower-expr.cc
@@ -518,7 +518,7 @@ ASTLoweringExpr::visit (AST::StructExprStructFields &struct_expr)
HIR::Expr *translated_base = ASTLoweringExpr::translate (
struct_expr.get_struct_base ().get_base_struct ());
base = tl::optional<std::unique_ptr<HIR::StructBase>> (
- std::make_unique<StructBase> (
+ Rust::make_unique<StructBase> (
std::unique_ptr<HIR::Expr> (translated_base)));
}
--- gcc/rust/hir/tree/rust-hir-expr.cc
@@ -541,10 +541,10 @@ StructExprStructFields::StructExprStructFields (
StructExprStructFields::StructExprStructFields (
StructExprStructFields const &other)
: StructExprStruct (other),
- struct_base (other.has_struct_base ()
- ? tl::optional<std::unique_ptr<StructBase>> (
- std::make_unique<StructBase> (*other.struct_base.value ()))
- : tl::nullopt),
+ struct_base (
+ other.has_struct_base () ? tl::optional<std::unique_ptr<StructBase>> (
+ Rust::make_unique<StructBase> (*other.struct_base.value ()))
+ : tl::nullopt),
union_index (other.union_index)
{
fields.reserve (other.fields.size ());
@@ -558,7 +558,7 @@ StructExprStructFields::operator= (StructExprStructFields const &other)
StructExprStruct::operator= (other);
struct_base = other.has_struct_base ()
? tl::optional<std::unique_ptr<StructBase>> (
- std::make_unique<StructBase> (*other.struct_base.value ()))
+ Rust::make_unique<StructBase> (*other.struct_base.value ()))
: tl::nullopt;
union_index = other.union_index;
--- gcc/rust/hir/tree/rust-hir.cc
@@ -2710,8 +2710,8 @@ TypePath::to_trait_bound (bool in_parens) const
// create clone FIXME is this required? or is copy constructor automatically
// called?
TypePath copy (*this);
- return std::make_unique<TraitBound> (mappings, std::move (copy),
- copy.get_locus (), in_parens);
+ return Rust::make_unique<TraitBound> (mappings, std::move (copy),
+ copy.get_locus (), in_parens);
}
std::string
--- gcc/rust/lex/rust-token.h
@@ -21,6 +21,7 @@
#include "rust-system.h"
#include "rust-linemap.h"
+#include "rust-make-unique.h"
#include "rust-unicode.h"
namespace Rust {
@@ -267,7 +268,7 @@ private:
: token_id (token_id), locus (location), type_hint (CORETYPE_UNKNOWN)
{
// Normalize identifier tokens
- str = std::make_unique<std::string> (
+ str = Rust::make_unique<std::string> (
nfc_normalize_token_string (location, token_id, paramStr));
}
@@ -284,7 +285,7 @@ private:
: token_id (token_id), locus (location), type_hint (CORETYPE_UNKNOWN)
{
// Normalize identifier tokens
- str = std::make_unique<std::string> (
+ str = Rust::make_unique<std::string> (
nfc_normalize_token_string (location, token_id,
paramCodepoint.as_string ()));
}
@@ -295,7 +296,7 @@ private:
: token_id (token_id), locus (location), type_hint (parType)
{
// Normalize identifier tokens
- str = std::make_unique<std::string> (
+ str = Rust::make_unique<std::string> (
nfc_normalize_token_string (location, token_id, paramStr));
}
--- gcc/rust/metadata/rust-import-archive.cc
@@ -7,6 +7,7 @@
#include "rust-system.h"
#include "rust-diagnostics.h"
#include "rust-imports.h"
+#include "rust-make-unique.h"
#ifndef O_BINARY
#define O_BINARY 0
@@ -843,7 +844,7 @@ Import::find_archive_export_data (const std::string &filename, int fd,
if (!afile.initialize ())
return nullptr;
- auto ret = std::make_unique<Stream_concatenate> ();
+ auto ret = Rust::make_unique<Stream_concatenate> ();
bool any_data = false;
bool any_members = false;
@@ -871,7 +872,7 @@ Import::find_archive_export_data (const std::string &filename, int fd,
if (!any_members)
{
// It's normal to have an empty archive file when using gobuild.
- return std::make_unique<Stream_from_string> ("");
+ return Rust::make_unique<Stream_from_string> ("");
}
if (!any_data)
--- gcc/rust/metadata/rust-imports.cc
@@ -21,6 +21,7 @@
#include "rust-imports.h"
#include "rust-object-export.h"
#include "rust-export-metadata.h"
+#include "rust-make-unique.h"
#ifndef O_BINARY
#define O_BINARY 0
@@ -258,7 +259,7 @@ Import::find_export_data (const std::string &filename, int fd,
//
if (memcmp (buf, Metadata::kMagicHeader, sizeof (Metadata::kMagicHeader))
== 0)
- return std::make_unique<Stream_from_file> (fd);
+ return Rust::make_unique<Stream_from_file> (fd);
// See if we can read this as an archive.
if (Import::is_archive_magic (buf))
@@ -290,7 +291,7 @@ Import::find_object_export_data (const std::string &filename, int fd,
if (buf == nullptr)
return nullptr;
- return std::make_unique<Stream_from_buffer> (buf, len);
+ return Rust::make_unique<Stream_from_buffer> (buf, len);
}
// Class Import.
--- gcc/rust/parse/rust-parse-impl.h
@@ -29,6 +29,7 @@
#include "rust-token.h"
#define INCLUDE_ALGORITHM
#include "rust-diagnostics.h"
+#include "rust-make-unique.h"
#include "rust-dir-owner.h"
#include "rust-attribute-values.h"
#include "rust-keyword-values.h"
@@ -3682,7 +3683,7 @@ Parser<ManagedTokenSource>::parse_function_param ()
if (lexer.peek_token ()->get_id () == ELLIPSIS) // Unnamed variadic
{
lexer.skip_token (); // Skip ellipsis
- return std::make_unique<AST::VariadicParam> (
+ return Rust::make_unique<AST::VariadicParam> (
AST::VariadicParam (std::move (outer_attrs), locus));
}
@@ -3704,7 +3705,7 @@ Parser<ManagedTokenSource>::parse_function_param ()
if (lexer.peek_token ()->get_id () == ELLIPSIS) // Named variadic
{
lexer.skip_token (); // Skip ellipsis
- return std::make_unique<AST::VariadicParam> (
+ return Rust::make_unique<AST::VariadicParam> (
AST::VariadicParam (std::move (param_pattern), std::move (outer_attrs),
locus));
}
@@ -3715,7 +3716,7 @@ Parser<ManagedTokenSource>::parse_function_param ()
{
return nullptr;
}
- return std::make_unique<AST::FunctionParam> (
+ return Rust::make_unique<AST::FunctionParam> (
AST::FunctionParam (std::move (param_pattern), std::move (param_type),
std::move (outer_attrs), locus));
}
@@ -7123,14 +7124,14 @@ Parser<ManagedTokenSource>::parse_self_param ()
if (has_reference)
{
- return std::make_unique<AST::SelfParam> (std::move (lifetime), has_mut,
- locus);
+ return Rust::make_unique<AST::SelfParam> (std::move (lifetime), has_mut,
+ locus);
}
else
{
// note that type may be nullptr here and that's fine
- return std::make_unique<AST::SelfParam> (std::move (type), has_mut,
- locus);
+ return Rust::make_unique<AST::SelfParam> (std::move (type), has_mut,
+ locus);
}
}
@@ -8692,10 +8693,10 @@ Parser<ManagedTokenSource>::parse_array_expr (AST::AttrVec outer_attrs,
std::vector<std::unique_ptr<AST::Expr>> exprs;
auto array_elems
- = std::make_unique<AST::ArrayElemsValues> (std::move (exprs), locus);
- return std::make_unique<AST::ArrayExpr> (std::move (array_elems),
- std::move (inner_attrs),
- std::move (outer_attrs), locus);
+ = Rust::make_unique<AST::ArrayElemsValues> (std::move (exprs), locus);
+ return Rust::make_unique<AST::ArrayExpr> (std::move (array_elems),
+ std::move (inner_attrs),
+ std::move (outer_attrs), locus);
}
else
{
--- gcc/rust/typecheck/rust-hir-type-check-enumitem.cc
@@ -69,7 +69,7 @@ TypeCheckEnumItem::visit (HIR::EnumItem &item)
mappings.get_next_hir_id (
item.get_mappings ().get_crate_num ()),
item.get_mappings ().get_local_defid ());
- auto discim_expr = std::make_unique<HIR::LiteralExpr> (
+ auto discim_expr = Rust::make_unique<HIR::LiteralExpr> (
HIR::LiteralExpr (mapping, std::to_string (last_discriminant),
HIR::Literal::LitType::INT,
PrimitiveCoreType::CORETYPE_I64, item.get_locus (), {}));
@@ -174,7 +174,7 @@ TypeCheckEnumItem::visit (HIR::EnumItemTuple &item)
mappings.get_next_hir_id (
item.get_mappings ().get_crate_num ()),
item.get_mappings ().get_local_defid ());
- auto discim_expr = std::make_unique<HIR::LiteralExpr> (
+ auto discim_expr = Rust::make_unique<HIR::LiteralExpr> (
HIR::LiteralExpr (mapping, std::to_string (last_discriminant),
HIR::Literal::LitType::INT,
PrimitiveCoreType::CORETYPE_I64, item.get_locus (), {}));
@@ -234,7 +234,7 @@ TypeCheckEnumItem::visit (HIR::EnumItemStruct &item)
mappings.get_next_hir_id (
item.get_mappings ().get_crate_num ()),
item.get_mappings ().get_local_defid ());
- auto discrim_expr = std::make_unique<HIR::LiteralExpr> (
+ auto discrim_expr = Rust::make_unique<HIR::LiteralExpr> (
HIR::LiteralExpr (mapping, std::to_string (last_discriminant),
HIR::Literal::LitType::INT,
PrimitiveCoreType::CORETYPE_I64, item.get_locus (), {}));
--- gcc/rust/typecheck/rust-hir-type-check-implitem.cc
@@ -142,7 +142,7 @@ TypeCheckTopLevelExternItem::visit (HIR::ExternalFunctionItem &function)
mappings.get_next_hir_id (crate_num),
UNKNOWN_LOCAL_DEFID);
- auto param_pattern = std::make_unique<HIR::IdentifierPattern> (
+ auto param_pattern = Rust::make_unique<HIR::IdentifierPattern> (
HIR::IdentifierPattern (mapping, param.get_param_name (),
UNDEF_LOCATION, false, Mutability::Imm,
std::unique_ptr<HIR::Pattern> (nullptr)));
@@ -390,7 +390,7 @@ TypeCheckImplItem::visit (HIR::Function &function)
HIR::SelfParam &self_param = function.get_self_param ();
// FIXME: which location should be used for Rust::Identifier for `self`?
std::unique_ptr<HIR::Pattern> self_pattern
- = std::make_unique<HIR::IdentifierPattern> (
+ = Rust::make_unique<HIR::IdentifierPattern> (
HIR::IdentifierPattern (mapping, {"self"}, self_param.get_locus (),
self_param.is_ref (), self_param.get_mut (),
std::unique_ptr<HIR::Pattern> (nullptr)));
--- gcc/rust/typecheck/rust-hir-type-check-type.cc
@@ -924,7 +924,7 @@ TypeResolveGenericParam::visit (HIR::TypeParam ¶m)
param.get_mappings ().get_nodeid (),
implicit_id,
param.get_mappings ().get_local_defid ());
- implicit_self_bound = std::make_unique<HIR::TypePath> (
+ implicit_self_bound = Rust::make_unique<HIR::TypePath> (
HIR::TypePath (mappings, {}, BUILTINS_LOCATION, false));
}
--- gcc/rust/typecheck/rust-hir-type-check.cc
@@ -24,6 +24,7 @@
#include "rust-hir-type-check-item.h"
#include "rust-hir-type-check-pattern.h"
#include "rust-hir-type-check-struct-field.h"
+#include "rust-make-unique.h"
#include "rust-immutable-name-resolution-context.h"
// for flag_name_resolution_2_0
@@ -237,7 +238,7 @@ TraitItemReference::get_type_from_fn (/*const*/ HIR::TraitItemFunc &fn) const
// but we reuse the HIR identifier pattern which requires it
HIR::SelfParam &self_param = function.get_self ();
std::unique_ptr<HIR::Pattern> self_pattern
- = std::make_unique<HIR::IdentifierPattern> (HIR::IdentifierPattern (
+ = Rust::make_unique<HIR::IdentifierPattern> (HIR::IdentifierPattern (
mapping, {"self"}, self_param.get_locus (), self_param.is_ref (),
self_param.is_mut () ? Mutability::Mut : Mutability::Imm,
std::unique_ptr<HIR::Pattern> (nullptr)));
--- gcc/rust/typecheck/rust-tyty-bounds.cc
@@ -237,8 +237,8 @@ TypeCheckBase::get_predicate_from_bound (
std::vector<std::unique_ptr<HIR::Type>> inputs;
inputs.push_back (
- std::make_unique<HIR::TupleType> (mapping, std::move (params_copy),
- final_seg.get_locus ()));
+ Rust::make_unique<HIR::TupleType> (mapping, std::move (params_copy),
+ final_seg.get_locus ()));
// resolve the fn_once_output type which assumes there must be an output
// set
--- gcc/rust/util/rust-make-unique.h
@@ -0,0 +1,35 @@
+// Copyright (C) 2020-2025 Free Software Foundation, Inc.
+
+// This file is part of GCC.
+
+// GCC is free software; you can redistribute it and/or modify it under
+// the terms of the GNU General Public License as published by the Free
+// Software Foundation; either version 3, or (at your option) any later
+// version.
+
+// GCC is distributed in the hope that it will be useful, but WITHOUT ANY
+// WARRANTY; without even the implied warranty of MERCHANTABILITY or
+// FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+// for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with GCC; see the file COPYING3. If not see
+// <http://www.gnu.org/licenses/>.
+
+#ifndef RUST_MAKE_UNIQUE_H
+#define RUST_MAKE_UNIQUE_H
+
+#include "rust-system.h"
+
+namespace Rust {
+
+template <typename T, typename... Ts>
+std::unique_ptr<T>
+make_unique (Ts &&...params)
+{
+ return std::unique_ptr<T> (new T (std::forward<Ts> (params)...));
+}
+
+} // namespace Rust
+
+#endif // RUST_MAKE_UNIQUE_H
|
gcc
|
gcc-mirror
|
C
|
C
| null | null |
Compiler
|
gcc-mirror_gcc
|
CODE_IMPROVEMENT
|
redundant code removed
|
2266a371cebaf52880bd74e0b5d402354c148721
|
2025-02-14 11:07:24
|
JungLee-Dev
|
fix(curriculum): add mention of transcripts to forms dates (#58798)
| false
| 5
| 5
| 10
|
--- curriculum/challenges/english/25-front-end-development/lecture-understanding-form-validation/6733aae9d25004f60d1e86f2.md
@@ -8,7 +8,7 @@ dashedName: what-are-some-ways-to-validate-forms-using-javascript
# --description--
-Watch the video or read the transcript and answer the questions below.
+Watch the video lecture and answer the questions below.
# --transcript--
--- curriculum/challenges/english/25-front-end-development/lecture-understanding-form-validation/6733d3a33abdd27cd562bdf2.md
@@ -8,7 +8,7 @@ dashedName: what-is-the-purpose-of-e-preventdefault
# --description--
-Watch the video or read the transcript and answer the questions below.
+Watch the lecture video and answer the questions below.
# --transcript--
--- curriculum/challenges/english/25-front-end-development/lecture-understanding-form-validation/6733d3ab69e94b7df7ee91b0.md
@@ -8,7 +8,7 @@ dashedName: how-does-the-submit-event-work-with-forms
# --description--
-Watch the video or read the transcript and answer the questions below.
+Watch the lecture video and answer the questions below.
# --transcript--
--- curriculum/challenges/english/25-front-end-development/lecture-working-with-dates/6733aafb9c0802f66cc1e056.md
@@ -8,7 +8,7 @@ dashedName: how-does-the-javascript-data-object-work-and-what-are-some-common-me
# --description--
-Watch the video or read the transcript and answer the questions below.
+Watch the video lecture and answer the questions below.
# --transcript--
--- curriculum/challenges/english/25-front-end-development/lecture-working-with-dates/6733d608654c17868e01c0a2.md
@@ -8,7 +8,7 @@ dashedName: what-are-the-different-ways-to-format-dates
# --description--
-Watch the video or read the transcript and answer the questions below.
+Watch the lecture video and answer the questions below.
# --transcript--
|
freecodecamp
|
freecodecamp
|
TypeScript
|
TypeScript
| 410,748
| 39,092
|
freeCodeCamp.org's open-source codebase and curriculum. Learn to code for free.
|
freecodecamp_freecodecamp
|
DOC_CHANGE
|
The prefix fix: suggests a bug fix, but the actual change is not fixing code behavior, it’s improving documentation rendering
|
e1fc361e98b0a895cd49dc5aaddb86eb6be27483
|
2024-03-12 08:03:27
|
Kieran
|
Improve audio-only download (#74) * Improved quality from auto-only download; enables thumbnail and data embedding for audio
* Updated UI to reflect new audio behaviour
| false
| 19
| 40
| 59
|
--- lib/pinchflat/yt_dlp/download_option_builder.ex
@@ -61,11 +61,11 @@ defmodule Pinchflat.YtDlp.DownloadOptionBuilder do
mapped_struct = Map.from_struct(media_profile)
Enum.reduce(mapped_struct, [], fn attr, acc ->
- case attr do
- {:download_thumbnail, true} ->
+ case {attr, media_profile} do
+ {{:download_thumbnail, true}, _} ->
acc ++ [:write_thumbnail, convert_thumbnail: "jpg"]
- {:embed_thumbnail, true} ->
+ {{:embed_thumbnail, true}, %{preferred_resolution: pr}} when pr != :audio ->
acc ++ [:embed_thumbnail]
_ ->
@@ -78,26 +78,31 @@ defmodule Pinchflat.YtDlp.DownloadOptionBuilder do
mapped_struct = Map.from_struct(media_profile)
Enum.reduce(mapped_struct, [], fn attr, acc ->
- case attr do
- {:download_metadata, true} -> acc ++ [:write_info_json, :clean_info_json]
- {:embed_metadata, true} -> acc ++ [:embed_metadata]
- _ -> acc
+ case {attr, media_profile} do
+ {{:download_metadata, true}, _} ->
+ acc ++ [:write_info_json, :clean_info_json]
+
+ {{:embed_metadata, true}, %{preferred_resolution: pr}} when pr != :audio ->
+ acc ++ [:embed_metadata]
+
+ _ ->
+ acc
end
end)
end
defp quality_options(media_profile) do
- video_codec_options = "+codec:avc:m4a"
+ codec_options = "+codec:avc:m4a"
case media_profile.preferred_resolution do
- # Also be aware that :audio disabled all embedding options for subtitles
- :audio -> [:extract_audio, format: "bestaudio[ext=m4a]"]
- :"360p" -> [format_sort: "res:360,#{video_codec_options}"]
- :"480p" -> [format_sort: "res:480,#{video_codec_options}"]
- :"720p" -> [format_sort: "res:720,#{video_codec_options}"]
- :"1080p" -> [format_sort: "res:1080,#{video_codec_options}"]
- :"1440p" -> [format_sort: "res:1440,#{video_codec_options}"]
- :"2160p" -> [format_sort: "res:2160,#{video_codec_options}"]
+ # Also be aware that :audio disabled all embedding options for thumbnails, subtitles, and metadata
+ :audio -> [format_sort: "ext", format: "bestaudio"]
+ :"360p" -> [format_sort: "res:360,#{codec_options}"]
+ :"480p" -> [format_sort: "res:480,#{codec_options}"]
+ :"720p" -> [format_sort: "res:720,#{codec_options}"]
+ :"1080p" -> [format_sort: "res:1080,#{codec_options}"]
+ :"1440p" -> [format_sort: "res:1440,#{codec_options}"]
+ :"2160p" -> [format_sort: "res:2160,#{codec_options}"]
end
end
--- lib/pinchflat_web/controllers/media_profiles/media_profile_html/media_profile_form.html.heex
@@ -109,7 +109,7 @@
options={friendly_resolution_options()}
type="select"
label="Preferred Resolution"
- help="Will grab the closest available resolution if your preferred is not available"
+ help="Will grab the closest available resolution if your preferred is not available. Setting to 'Audio Only' negates embedding options."
/>
<.button class="my-10 sm:mb-7.5 w-full sm:w-auto">Save Media profile</.button>
--- test/pinchflat/yt_dlp/download_option_builder_test.exs
@@ -141,6 +141,14 @@ defmodule Pinchflat.YtDlp.DownloadOptionBuilderTest do
assert :embed_thumbnail in res
end
+ test "doesn't include :embed_thumbnail option when preferred_resolution is :audio", %{media_item: media_item} do
+ media_item = update_media_profile_attribute(media_item, %{embed_thumbnail: true, preferred_resolution: :audio})
+
+ assert {:ok, res} = DownloadOptionBuilder.build(media_item)
+
+ refute :embed_thumbnail in res
+ end
+
test "doesn't include these options when not specified", %{media_item: media_item} do
media_item = update_media_profile_attribute(media_item, %{embed_thumbnail: false, download_thumbnail: false})
@@ -169,6 +177,14 @@ defmodule Pinchflat.YtDlp.DownloadOptionBuilderTest do
assert :embed_metadata in res
end
+ test "doesn't include :embed_metadata option when preferred_resolution is :audio", %{media_item: media_item} do
+ media_item = update_media_profile_attribute(media_item, %{embed_metadata: true, preferred_resolution: :audio})
+
+ assert {:ok, res} = DownloadOptionBuilder.build(media_item)
+
+ refute :embed_metadata in res
+ end
+
test "doesn't include these options when not specified", %{media_item: media_item} do
media_item = update_media_profile_attribute(media_item, %{embed_metadata: false, download_metadata: false})
@@ -194,8 +210,8 @@ defmodule Pinchflat.YtDlp.DownloadOptionBuilderTest do
assert {:ok, res} = DownloadOptionBuilder.build(media_item)
- assert :extract_audio in res
- assert {:format, "bestaudio[ext=m4a]"} in res
+ assert {:format, "bestaudio"} in res
+ assert {:format_sort, "ext"} in res
end
end
|
pinchflat
|
kieraneglin
|
Elixir
|
Elixir
| 2,779
| 59
|
Your next YouTube media manager
|
kieraneglin_pinchflat
|
PERF_IMPROVEMENT
|
obvious
|
cd961a68a9876d35ba745c0cc7cb90e1ddccf313
|
2025-02-12 16:59:12
|
bannedbook
|
update
| false
| 0
| 0
| 0
|
--- docs/vsp-cn.py
Binary files a/docs/vsp-cn.py and b/docs/vsp-cn.py differ
|
fanqiang
|
bannedbook
|
Kotlin
|
Kotlin
| 39,286
| 7,317
|
翻墙-科学上网
|
bannedbook_fanqiang
|
CODE_IMPROVEMENT
|
refactoring done
|
fa148cdf427762527d37fc65f9eedc90debaa04d
|
2024-10-25 06:31:59
|
2dust
|
Bug fix
| false
| 3
| 2
| 5
|
--- v2rayN/ServiceLib/ViewModels/RoutingRuleSettingViewModel.cs
@@ -176,14 +176,13 @@ namespace ServiceLib.ViewModels
return;
}
- var lst = new List<RulesItem>();
+ var lst = new List<RulesItem4Ray>();
foreach (var it in SelectedSources ?? [SelectedSource])
{
var item = _rules.FirstOrDefault(t => t.Id == it?.Id);
if (item != null)
{
- var item2 = JsonUtils.DeepCopy(item); //JsonUtils.Deserialize<RulesItem4Ray>(JsonUtils.Serialize(item));
- item2.Id = null;
+ var item2 = JsonUtils.Deserialize<RulesItem4Ray>(JsonUtils.Serialize(item));
lst.Add(item2 ?? new());
}
}
|
v2rayn
|
2dust
|
C#
|
C#
| 75,986
| 12,289
|
A GUI client for Windows, Linux and macOS, support Xray and sing-box and others
|
2dust_v2rayn
|
BUG_FIX
|
Obvious
|
169384d9483769e59f14210308c6bc8c7580c290
|
2025-03-28 21:13:38
|
Hadley Wickham
|
Better handling of whitespace-only content (#393) For `chat_claude()` and `chat_bedrock()`. Fixes #376.
| false
| 38
| 2
| 40
|
--- NEWS.md
@@ -1,8 +1,5 @@
# ellmer (development version)
-* `chat_claude()` and `chat_bedrock()` no longer choke after receiving an
- output that consists only of whitespace (#376).
-
* `live_browser()` now initializes `shinychat::chat_ui()` with the messages from
the chat turns, rather than replaying the turns server-side (#381).
--- R/provider-bedrock.R
@@ -284,11 +284,7 @@ method(as_json, list(ProviderBedrock, Turn)) <- function(provider, x) {
}
method(as_json, list(ProviderBedrock, ContentText)) <- function(provider, x) {
- if (is_whitespace(x@text)) {
- list(text = "[empty string]")
- } else {
- list(text = x@text)
- }
+ list(text = x@text)
}
method(as_json, list(ProviderBedrock, ContentImageRemote)) <- function(
--- R/provider-claude.R
@@ -266,11 +266,7 @@ method(as_json, list(ProviderClaude, Turn)) <- function(provider, x) {
}
method(as_json, list(ProviderClaude, ContentText)) <- function(provider, x) {
- if (is_whitespace(x@text)) {
- list(type = "text", text = "[empty string]")
- } else {
- list(type = "text", text = x@text)
- }
+ list(type = "text", text = x@text)
}
method(as_json, list(ProviderClaude, ContentPDF)) <- function(provider, x) {
--- R/utils.R
@@ -128,7 +128,3 @@ modify_list <- function(x, y) {
utils::modifyList(x, y)
}
-
-is_whitespace <- function(x) {
- grepl("^(\\s|\n)*$", x)
-}
--- tests/testthat/test-provider-bedrock.R
@@ -72,13 +72,6 @@ test_that("can use pdfs", {
test_pdf_local(chat_fun)
})
-# Provider idiosynchronies -----------------------------------------------
-
-test_that("continues to work after whitespace only outputs (#376)", {
- chat <- chat_bedrock()
- chat$chat("Respond with only two blank lines")
- expect_equal(chat$chat("What's 1+1? Just give me the number"), "2")
-})
# Auth --------------------------------------------------------------------
--- tests/testthat/test-provider-claude.R
@@ -62,9 +62,3 @@ test_that("can set beta headers", {
req <- chat_request(provider)
expect_equal(req$headers$`anthropic-beta`, c("a", "b"))
})
-
-test_that("continues to work after whitespace only outputs (#376)", {
- chat <- chat_claude()
- chat$chat("Respond with only two blank lines")
- expect_equal(chat$chat("What's 1+1? Just give me the number"), "2")
-})
--- tests/testthat/test-utils.R
@@ -10,11 +10,3 @@ test_that("informative error if no key", {
expect_false(key_exists("FOO"))
expect_snapshot(key_get("FOO"), error = TRUE)
})
-
-test_that("detects whitespace", {
- expect_true(is_whitespace("\n\n\n \t"))
- expect_true(is_whitespace(""))
-
- expect_false(is_whitespace("a"))
- expect_false(is_whitespace("."))
-})
|
ellmer
|
tidyverse
|
R
|
R
| 401
| 55
|
Call LLM APIs from R
|
tidyverse_ellmer
|
NEW_FEAT
|
Obvious
|
3d7270c946f4e15a7b0a9ad233e8575e092d0c77
|
2022-11-07 23:10:08
|
Serhiy Mytrovtsiy
|
fix: added cluster color to the list of all colors (#1154)
| false
| 3
| 2
| 5
|
--- Kit/Widgets/BarChart.swift
@@ -17,7 +17,7 @@ public class BarChart: WidgetWrapper {
private var frameState: Bool = false
private var colorState: Color = .systemAccent
- private var colors: [Color] = Color.allCases
+ private var colors: [Color] = [Color.cluster] + Color.allCases
private var value: [[ColorValue]] = [[]]
private var pressureLevel: DispatchSource.MemoryPressureEvent = .normal
private var colorZones: colorZones = (0.6, 0.8)
@@ -330,7 +330,6 @@ public class BarChart: WidgetWrapper {
self.colorState = newColor
}
- print(key)
Store.shared.set(key: "\(self.title)_\(self.type.rawValue)_color", value: key)
self.display()
}
--- Kit/types.swift
@@ -163,7 +163,7 @@ extension Color: CaseIterable {
} }
public static var allCases: [Color] {
- return [.utilization, .pressure, .cluster, separator1,
+ return [.utilization, .pressure, separator1,
.systemAccent, .monochrome, separator2,
.clear, .white, .black, .gray, .secondGray, .darkGray, .lightGray,
.red, .secondRed, .green, .secondGreen, .blue, .secondBlue, .yellow, .secondYellow,
|
stats
|
exelban
|
Swift
|
Swift
| 29,655
| 950
|
macOS system monitor in your menu bar
|
exelban_stats
|
BUG_FIX
|
obvious
|
3c734b8e9dc357f8ec743e8db25ca916cfdcf7bc
|
2023-10-18 15:55:52
|
sundb
|
Add new compilation CI for macos-11 and macos-13 (#12666) As discussed in #12611
Add a build CI for macox 11 and 13 to avoid compatibility breakage introduced by future macos sdk versions.
| false
| 29
| 0
| 29
|
--- .github/workflows/daily.yml
@@ -870,35 +870,6 @@ jobs:
if: true && !contains(github.event.inputs.skiptests, 'cluster')
run: ./runtest-cluster ${{github.event.inputs.cluster_test_args}}
- build-macos:
- strategy:
- matrix:
- os: [macos-11, macos-13]
- runs-on: ${{ matrix.os }}
- if: |
- (github.event_name == 'workflow_dispatch' || (github.event_name != 'workflow_dispatch' && github.repository == 'redis/redis')) &&
- !contains(github.event.inputs.skipjobs, 'macos')
- timeout-minutes: 14400
- steps:
- - uses: maxim-lobanov/setup-xcode@v1
- with:
- xcode-version: latest
- - name: prep
- if: github.event_name == 'workflow_dispatch'
- run: |
- echo "GITHUB_REPOSITORY=${{github.event.inputs.use_repo}}" >> $GITHUB_ENV
- echo "GITHUB_HEAD_REF=${{github.event.inputs.use_git_ref}}" >> $GITHUB_ENV
- echo "skipjobs: ${{github.event.inputs.skipjobs}}"
- echo "skiptests: ${{github.event.inputs.skiptests}}"
- echo "test_args: ${{github.event.inputs.test_args}}"
- echo "cluster_test_args: ${{github.event.inputs.cluster_test_args}}"
- - uses: actions/checkout@v3
- with:
- repository: ${{ env.GITHUB_REPOSITORY }}
- ref: ${{ env.GITHUB_HEAD_REF }}
- - name: make
- run: make REDIS_CFLAGS='-Werror -DREDIS_TEST'
-
test-freebsd:
runs-on: macos-12
if: |
|
redis
|
redis
|
C
|
C
| 68,201
| 23,916
|
Redis is an in-memory database that persists on disk. The data model is key-value, but many different kind of values are supported: Strings, Lists, Sets, Sorted Sets, Hashes, Streams, HyperLogLogs, Bitmaps.
|
redis_redis
|
CONFIG_CHANGE
|
probably config change, new compilation added to avoid compatibility issues in future
|
c5a97e6ec7692f69c756fbf1f3f9ad3711e49205
|
2023-04-03 16:46:25
|
Kirill Zhuravlev
|
fix linter warnings
| false
| 12
| 9
| 21
|
--- main.go
@@ -1,4 +1,3 @@
-/* Package main contains code for generate static site. */
package main
import (
@@ -17,14 +16,12 @@ import (
"github.com/avelino/awesome-go/pkg/slug"
)
-// Link contains info about awesome url
type Link struct {
Title string
- URL string
+ Url string
Description string
}
-// Category describe link category
type Category struct {
Title string
Slug string
@@ -254,7 +251,7 @@ func extractCategory(doc *goquery.Document, selector string) (*Category, error)
// FIXME(kazhuravlev): Title contains only title but
// description contains Title + description
Description: selLi.Text(),
- URL: url,
+ Url: url,
}
links = append(links, link)
})
@@ -300,14 +297,14 @@ func rewriteLinksInIndex(doc *goquery.Document, categories map[string]Category)
return true
}
- linkURL, err := url.Parse(href)
+ linkUrl, err := url.Parse(href)
if err != nil {
iterErr = err
return false
}
- if linkURL.Fragment != "" && linkURL.Fragment != "contents" {
- s.SetAttr("href", linkURL.Fragment)
+ if linkUrl.Fragment != "" && linkUrl.Fragment != "contents" {
+ s.SetAttr("href", linkUrl.Fragment)
}
return true
@@ -318,12 +315,12 @@ func rewriteLinksInIndex(doc *goquery.Document, categories map[string]Category)
}
fmt.Printf("Rewrite links in Index file: %s\n", outIndexFile)
- resultHTML, err := doc.Html()
+ resultHtml, err := doc.Html()
if err != nil {
return fmt.Errorf("render html: %w", err)
}
- if err := os.WriteFile(outIndexFile, []byte(resultHTML), 0644); err != nil {
+ if err := os.WriteFile(outIndexFile, []byte(resultHtml), 0644); err != nil {
return fmt.Errorf("rewrite index file: %w", err)
}
--- tmpl/assets/awesome-go.css
@@ -115,6 +115,6 @@ h1 > a img {
line-height: 1;
}
-td {
- padding: 6px;
+td{
+ padding: 6px;
}
|
awesome-go
|
avelino
|
Go
|
Go
| 139,192
| 12,134
|
A curated list of awesome Go frameworks, libraries and software
|
avelino_awesome-go
|
CODE_IMPROVEMENT
|
Obvious
|
acd64b71f2255be38997bfca1fb77b387836f44a
|
2024-01-05 10:03:51
|
Jaida Wu
|
Add notice for `extension_dir`
| false
| 1
| 1
| 2
|
--- docs/README.md
@@ -56,7 +56,7 @@ If you're experiencing any of the above, consider yourself damned. Ever since Xi
## ⚙️ How to use
1. Download and install PHP 8.0+ for your system from the [official website](https://www.php.net/downloads).
-2. Enable OpenSSL and Curl extension in `php.ini`. (And/or set `extension_dir` to your PHP's `ext` directory if script not work.)
+2. Enable OpenSSL and Curl extension in `php.ini`.
3. Place `adb.php` in [php-adb](https://github.com/MlgmXyysd/php-adb) to the directory.
4. Download [platform-tools](https://developer.android.com/studio/releases/platform-tools) and place them in `libraries`. *Note: Mac OS needs to rename `adb` to `adb-darwin`.*
5. Open a terminal and use PHP interpreter to execute the [script](../bypass.php).
|
xiaomi-hyperos-bootloader-bypass
|
mlgmxyysd
|
PHP
|
PHP
| 3,496
| 367
|
A PoC that exploits a vulnerability to bypass the Xiaomi HyperOS community restrictions of BootLoader unlocked account bindings.
|
mlgmxyysd_xiaomi-hyperos-bootloader-bypass
|
DOC_CHANGE
|
changes in readme
|
adf7b8dc4083b6ddc318e466dbb5d87f3af0ce17
|
2023-03-15 10:10:58
|
XhmikosR
|
Docs: use core mixins in a couple of places (#38236)
| false
| 3
| 3
| 6
|
--- site/assets/scss/_masthead.scss
@@ -99,7 +99,7 @@
.animate-img {
> img {
- @include transition(transform .2s ease-in-out);
+ transition: .2s ease-in-out transform; // stylelint-disable-line property-disallowed-list
}
&:hover > img {
--- site/assets/scss/_navbar.scss
@@ -39,7 +39,7 @@
.navbar-brand {
color: $white;
- @include transition(transform .2s ease-in-out);
+ transition: .2s ease-in-out transform; // stylelint-disable-line property-disallowed-list
&:hover {
transform: rotate(-5deg) scale(1.1);
--- site/assets/scss/_variables.scss
@@ -2,7 +2,7 @@
$bd-purple: #4c0bce;
$bd-violet: lighten(saturate($bd-purple, 5%), 15%); // stylelint-disable-line function-disallowed-list
$bd-purple-light: lighten(saturate($bd-purple, 5%), 45%); // stylelint-disable-line function-disallowed-list
-$bd-accent: #ffe484;
+$bd-accent: #ffe484;
$bd-gutter-x: 3rem;
$bd-callout-variants: info, warning, danger !default;
|
bootstrap
|
twbs
|
JavaScript
|
JavaScript
| 171,693
| 79,045
|
The most popular HTML, CSS, and JavaScript framework for developing responsive, mobile first projects on the web.
|
twbs_bootstrap
|
CODE_IMPROVEMENT
|
syntaxes updated
|
79fc659f1cf9d24388aba810c400624dcb2fcb94
| null |
Waren Gonzaga
|
👌 IMPROVE: update fork-corner (#1248)
| false
| 1
| 1
| 0
|
--- template.html
@@ -48,7 +48,7 @@
<body>
<!-- Fork Corner -->
- <a href="https://github.com/animate-css/animate.css" target="_blank" id="fork-corner" class="fork-corner fc-size-small fc-pos-tl fc-animate-default fc-theme-github"></a>
+ <a href="https://github.com/animate-css/animate.css" target="_blank" id="fork-corner" class="fork-corner fc-size-small fc-pos-tl fc-animate-grow fc-theme-github"></a>
<article class="intro">
<section class="callout">
|
animate-css_animate.css.json
| null | null | null | null | null | null |
animate-css_animate.css.json
|
CODE_IMPROVEMENT
|
3, update fork-corner
|
988e7f5e952bbb7b6ae885f4da744f536f22693f
|
2024-11-19 08:53:11
|
Patrick Steinhardt
|
reftable/system: provide thin wrapper for lockfile subsystem We use the lockfile subsystem to write lockfiles for "tables.list". As with the tempfile subsystem, the lockfile subsystem also hooks into our infrastructure to prune stale locks via atexit(3p) or signal handlers. Furthermore, the lockfile subsystem also handles locking timeouts, which do add quite a bit of logic. Having to reimplement that in the context of Git wouldn't make a whole lot of sense, and it is quite likely that downstream users of the reftable library may have a better idea for how exactly to implement timeouts. So again, provide a thin wrapper for the lockfile subsystem instead such that the compatibility shim is fully self-contained. Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
| false
| 154
| 37
| 191
|
--- reftable/stack.c
@@ -657,7 +657,7 @@ static int format_name(struct reftable_buf *dest, uint64_t min, uint64_t max)
}
struct reftable_addition {
- struct reftable_flock tables_list_lock;
+ struct lock_file tables_list_lock;
struct reftable_stack *stack;
char **new_tables;
@@ -676,8 +676,10 @@ static int reftable_stack_init_addition(struct reftable_addition *add,
add->stack = st;
- err = flock_acquire(&add->tables_list_lock, st->list_file,
- st->opts.lock_timeout_ms);
+ err = hold_lock_file_for_update_timeout(&add->tables_list_lock,
+ st->list_file,
+ LOCK_NO_DEREF,
+ st->opts.lock_timeout_ms);
if (err < 0) {
if (errno == EEXIST) {
err = REFTABLE_LOCK_ERROR;
@@ -687,7 +689,7 @@ static int reftable_stack_init_addition(struct reftable_addition *add,
goto done;
}
if (st->opts.default_permissions) {
- if (chmod(add->tables_list_lock.path,
+ if (chmod(get_lock_file_path(&add->tables_list_lock),
st->opts.default_permissions) < 0) {
err = REFTABLE_IO_ERROR;
goto done;
@@ -731,7 +733,7 @@ static void reftable_addition_close(struct reftable_addition *add)
add->new_tables_len = 0;
add->new_tables_cap = 0;
- flock_release(&add->tables_list_lock);
+ rollback_lock_file(&add->tables_list_lock);
reftable_buf_release(&nm);
}
@@ -747,6 +749,7 @@ void reftable_addition_destroy(struct reftable_addition *add)
int reftable_addition_commit(struct reftable_addition *add)
{
struct reftable_buf table_list = REFTABLE_BUF_INIT;
+ int lock_file_fd = get_lock_file_fd(&add->tables_list_lock);
int err = 0;
size_t i;
@@ -764,20 +767,20 @@ int reftable_addition_commit(struct reftable_addition *add)
goto done;
}
- err = write_in_full(add->tables_list_lock.fd, table_list.buf, table_list.len);
+ err = write_in_full(lock_file_fd, table_list.buf, table_list.len);
reftable_buf_release(&table_list);
if (err < 0) {
err = REFTABLE_IO_ERROR;
goto done;
}
- err = stack_fsync(&add->stack->opts, add->tables_list_lock.fd);
+ err = stack_fsync(&add->stack->opts, lock_file_fd);
if (err < 0) {
err = REFTABLE_IO_ERROR;
goto done;
}
- err = flock_commit(&add->tables_list_lock);
+ err = commit_lock_file(&add->tables_list_lock);
if (err < 0) {
err = REFTABLE_IO_ERROR;
goto done;
@@ -1157,8 +1160,8 @@ static int stack_compact_range(struct reftable_stack *st,
struct reftable_buf new_table_name = REFTABLE_BUF_INIT;
struct reftable_buf new_table_path = REFTABLE_BUF_INIT;
struct reftable_buf table_name = REFTABLE_BUF_INIT;
- struct reftable_flock tables_list_lock = REFTABLE_FLOCK_INIT;
- struct reftable_flock *table_locks = NULL;
+ struct lock_file tables_list_lock = LOCK_INIT;
+ struct lock_file *table_locks = NULL;
struct reftable_tmpfile new_table = REFTABLE_TMPFILE_INIT;
int is_empty_table = 0, err = 0;
size_t first_to_replace, last_to_replace;
@@ -1176,7 +1179,10 @@ static int stack_compact_range(struct reftable_stack *st,
* Hold the lock so that we can read "tables.list" and lock all tables
* which are part of the user-specified range.
*/
- err = flock_acquire(&tables_list_lock, st->list_file, st->opts.lock_timeout_ms);
+ err = hold_lock_file_for_update_timeout(&tables_list_lock,
+ st->list_file,
+ LOCK_NO_DEREF,
+ st->opts.lock_timeout_ms);
if (err < 0) {
if (errno == EEXIST)
err = REFTABLE_LOCK_ERROR;
@@ -1199,20 +1205,19 @@ static int stack_compact_range(struct reftable_stack *st,
* older process is still busy compacting tables which are preexisting
* from the point of view of the newer process.
*/
- REFTABLE_ALLOC_ARRAY(table_locks, last - first + 1);
+ REFTABLE_CALLOC_ARRAY(table_locks, last - first + 1);
if (!table_locks) {
err = REFTABLE_OUT_OF_MEMORY_ERROR;
goto done;
}
- for (i = 0; i < last - first + 1; i++)
- table_locks[i] = REFTABLE_FLOCK_INIT;
for (i = last + 1; i > first; i--) {
err = stack_filename(&table_name, st, reader_name(st->readers[i - 1]));
if (err < 0)
goto done;
- err = flock_acquire(&table_locks[nlocks], table_name.buf, 0);
+ err = hold_lock_file_for_update(&table_locks[nlocks],
+ table_name.buf, LOCK_NO_DEREF);
if (err < 0) {
/*
* When the table is locked already we may do a
@@ -1248,7 +1253,7 @@ static int stack_compact_range(struct reftable_stack *st,
* run into file descriptor exhaustion when we compress a lot
* of tables.
*/
- err = flock_close(&table_locks[nlocks++]);
+ err = close_lock_file_gently(&table_locks[nlocks++]);
if (err < 0) {
err = REFTABLE_IO_ERROR;
goto done;
@@ -1260,7 +1265,7 @@ static int stack_compact_range(struct reftable_stack *st,
* "tables.list" lock while compacting the locked tables. This allows
* concurrent updates to the stack to proceed.
*/
- err = flock_release(&tables_list_lock);
+ err = rollback_lock_file(&tables_list_lock);
if (err < 0) {
err = REFTABLE_IO_ERROR;
goto done;
@@ -1283,7 +1288,10 @@ static int stack_compact_range(struct reftable_stack *st,
* "tables.list". We'll then replace the compacted range of tables with
* the new table.
*/
- err = flock_acquire(&tables_list_lock, st->list_file, st->opts.lock_timeout_ms);
+ err = hold_lock_file_for_update_timeout(&tables_list_lock,
+ st->list_file,
+ LOCK_NO_DEREF,
+ st->opts.lock_timeout_ms);
if (err < 0) {
if (errno == EEXIST)
err = REFTABLE_LOCK_ERROR;
@@ -1293,7 +1301,7 @@ static int stack_compact_range(struct reftable_stack *st,
}
if (st->opts.default_permissions) {
- if (chmod(tables_list_lock.path,
+ if (chmod(get_lock_file_path(&tables_list_lock),
st->opts.default_permissions) < 0) {
err = REFTABLE_IO_ERROR;
goto done;
@@ -1448,7 +1456,7 @@ static int stack_compact_range(struct reftable_stack *st,
goto done;
}
- err = write_in_full(tables_list_lock.fd,
+ err = write_in_full(get_lock_file_fd(&tables_list_lock),
tables_list_buf.buf, tables_list_buf.len);
if (err < 0) {
err = REFTABLE_IO_ERROR;
@@ -1456,14 +1464,14 @@ static int stack_compact_range(struct reftable_stack *st,
goto done;
}
- err = stack_fsync(&st->opts, tables_list_lock.fd);
+ err = stack_fsync(&st->opts, get_lock_file_fd(&tables_list_lock));
if (err < 0) {
err = REFTABLE_IO_ERROR;
unlink(new_table_path.buf);
goto done;
}
- err = flock_commit(&tables_list_lock);
+ err = commit_lock_file(&tables_list_lock);
if (err < 0) {
err = REFTABLE_IO_ERROR;
unlink(new_table_path.buf);
@@ -1484,11 +1492,12 @@ static int stack_compact_range(struct reftable_stack *st,
* readers, so it is expected that unlinking tables may fail.
*/
for (i = 0; i < nlocks; i++) {
- struct reftable_flock *table_lock = &table_locks[i];
+ struct lock_file *table_lock = &table_locks[i];
+ const char *lock_path = get_lock_file_path(table_lock);
reftable_buf_reset(&table_name);
- err = reftable_buf_add(&table_name, table_lock->path,
- strlen(table_lock->path) - strlen(".lock"));
+ err = reftable_buf_add(&table_name, lock_path,
+ strlen(lock_path) - strlen(".lock"));
if (err)
continue;
@@ -1496,9 +1505,9 @@ static int stack_compact_range(struct reftable_stack *st,
}
done:
- flock_release(&tables_list_lock);
+ rollback_lock_file(&tables_list_lock);
for (i = 0; table_locks && i < nlocks; i++)
- flock_release(&table_locks[i]);
+ rollback_lock_file(&table_locks[i]);
reftable_free(table_locks);
tmpfile_delete(&new_table);
--- reftable/system.c
@@ -1,7 +1,6 @@
#include "system.h"
#include "basics.h"
#include "reftable-error.h"
-#include "../lockfile.h"
#include "../tempfile.h"
int tmpfile_from_pattern(struct reftable_tmpfile *out, const char *pattern)
@@ -48,79 +47,3 @@ int tmpfile_rename(struct reftable_tmpfile *t, const char *path)
return REFTABLE_IO_ERROR;
return 0;
}
-
-int flock_acquire(struct reftable_flock *l, const char *target_path,
- long timeout_ms)
-{
- struct lock_file *lockfile;
- int err;
-
- lockfile = reftable_malloc(sizeof(*lockfile));
- if (!lockfile)
- return REFTABLE_OUT_OF_MEMORY_ERROR;
-
- err = hold_lock_file_for_update_timeout(lockfile, target_path, LOCK_NO_DEREF,
- timeout_ms);
- if (err < 0) {
- reftable_free(lockfile);
- if (errno == EEXIST)
- return REFTABLE_LOCK_ERROR;
- return -1;
- }
-
- l->fd = get_lock_file_fd(lockfile);
- l->path = get_lock_file_path(lockfile);
- l->priv = lockfile;
-
- return 0;
-}
-
-int flock_close(struct reftable_flock *l)
-{
- struct lock_file *lockfile = l->priv;
- int ret;
-
- if (!lockfile)
- return REFTABLE_API_ERROR;
-
- ret = close_lock_file_gently(lockfile);
- l->fd = -1;
- if (ret < 0)
- return REFTABLE_IO_ERROR;
-
- return 0;
-}
-
-int flock_release(struct reftable_flock *l)
-{
- struct lock_file *lockfile = l->priv;
- int ret;
-
- if (!lockfile)
- return 0;
-
- ret = rollback_lock_file(lockfile);
- reftable_free(lockfile);
- *l = REFTABLE_FLOCK_INIT;
- if (ret < 0)
- return REFTABLE_IO_ERROR;
-
- return 0;
-}
-
-int flock_commit(struct reftable_flock *l)
-{
- struct lock_file *lockfile = l->priv;
- int ret;
-
- if (!lockfile)
- return REFTABLE_API_ERROR;
-
- ret = commit_lock_file(lockfile);
- reftable_free(lockfile);
- *l = REFTABLE_FLOCK_INIT;
- if (ret < 0)
- return REFTABLE_IO_ERROR;
-
- return 0;
-}
--- reftable/system.h
@@ -12,6 +12,7 @@ license that can be found in the LICENSE file or at
/* This header glues the reftable library to the rest of Git */
#include "git-compat-util.h"
+#include "lockfile.h"
/*
* An implementation-specific temporary file. By making this specific to the
@@ -54,48 +55,4 @@ int tmpfile_delete(struct reftable_tmpfile *t);
*/
int tmpfile_rename(struct reftable_tmpfile *t, const char *path);
-/*
- * An implementation-specific file lock. Same as with `reftable_tmpfile`,
- * making this specific to the implementation makes it possible to tie this
- * into signal or atexit handlers such that we know to clean up stale locks on
- * abnormal exits.
- */
-struct reftable_flock {
- const char *path;
- int fd;
- void *priv;
-};
-#define REFTABLE_FLOCK_INIT ((struct reftable_flock){ .fd = -1, })
-
-/*
- * Acquire the lock for the given target path by exclusively creating a file
- * with ".lock" appended to it. If that lock exists, we wait up to `timeout_ms`
- * to acquire the lock. If `timeout_ms` is 0 we don't wait, if it is negative
- * we block indefinitely.
- *
- * Retrun 0 on success, a reftable error code on error.
- */
-int flock_acquire(struct reftable_flock *l, const char *target_path,
- long timeout_ms);
-
-/*
- * Close the lockfile's file descriptor without removing the lock itself. This
- * is a no-op in case the lockfile has already been closed beforehand. Returns
- * 0 on success, a reftable error code on error.
- */
-int flock_close(struct reftable_flock *l);
-
-/*
- * Release the lock by unlinking the lockfile. This is a no-op in case the
- * lockfile has already been released or committed beforehand. Returns 0 on
- * success, a reftable error code on error.
- */
-int flock_release(struct reftable_flock *l);
-
-/*
- * Commit the lock by renaming the lockfile into place. Returns 0 on success, a
- * reftable error code on error.
- */
-int flock_commit(struct reftable_flock *l);
-
#endif
--- t/unit-tests/lib-reftable.c
@@ -2,7 +2,6 @@
#include "test-lib.h"
#include "reftable/constants.h"
#include "reftable/writer.h"
-#include "strbuf.h"
void t_reftable_set_hash(uint8_t *p, int i, enum reftable_hash id)
{
--- t/unit-tests/t-reftable-block.c
@@ -11,7 +11,6 @@ license that can be found in the LICENSE file or at
#include "reftable/blocksource.h"
#include "reftable/constants.h"
#include "reftable/reftable-error.h"
-#include "strbuf.h"
static void t_ref_block_read_write(void)
{
--- t/unit-tests/t-reftable-pq.c
@@ -9,7 +9,6 @@ license that can be found in the LICENSE file or at
#include "test-lib.h"
#include "reftable/constants.h"
#include "reftable/pq.h"
-#include "strbuf.h"
static void merged_iter_pqueue_check(const struct merged_iter_pqueue *pq)
{
--- t/unit-tests/t-reftable-readwrite.c
@@ -13,7 +13,6 @@ license that can be found in the LICENSE file or at
#include "reftable/reader.h"
#include "reftable/reftable-error.h"
#include "reftable/reftable-writer.h"
-#include "strbuf.h"
static const int update_index = 5;
--- t/unit-tests/t-reftable-stack.c
@@ -13,8 +13,6 @@ license that can be found in the LICENSE file or at
#include "reftable/reader.h"
#include "reftable/reftable-error.h"
#include "reftable/stack.h"
-#include "strbuf.h"
-#include "tempfile.h"
#include <dirent.h>
static void clear_dir(const char *dirname)
|
git
| null |
C
|
C
| null | null |
Version control
|
_git
|
NEW_FEAT
|
Matched \bimplement(s|ed|ation)?\b in message
|
67f0c45b6e1c52d04cdfbb1aa55a1577e5a40932
|
2025-03-04 01:55:23
|
engine-flutter-autoroll
|
Roll Skia from 1e9fa50fc296 to a11cc17d0133 (1 revision) (#164505) https://skia.googlesource.com/skia.git/+log/1e9fa50fc296..a11cc17d0133 2025-03-03 [email protected] [graphite] Require interpolation settings for precomp gradient objects If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
| false
| 2
| 2
| 4
|
--- DEPS
@@ -14,7 +14,7 @@ vars = {
'flutter_git': 'https://flutter.googlesource.com',
'skia_git': 'https://skia.googlesource.com',
'llvm_git': 'https://llvm.googlesource.com',
- 'skia_revision': 'a11cc17d013353408fe28ec423755b2366860397',
+ 'skia_revision': '1e9fa50fc296c2ce2c337d70252127685d2ef23e',
# WARNING: DO NOT EDIT canvaskit_cipd_instance MANUALLY
# See `lib/web_ui/README.md` for how to roll CanvasKit to a new version.
--- engine/src/flutter/ci/licenses_golden/licenses_skia
@@ -1,4 +1,4 @@
-Signature: 1d38f7b61637e990037942a473f95bbd
+Signature: ac991c4bc9a6a8622ee709ec55e1018c
====================================================================================================
LIBRARY: etc1
|
flutter
|
flutter
|
Dart
|
Dart
| 168,965
| 28,132
|
Flutter makes it easy and fast to build beautiful apps for mobile and beyond
|
flutter_flutter
|
CONFIG_CHANGE
|
Obvious
|
25580f3251a8dcaa04a3edd9af328372c7caca4a
| null |
Philipp Hagemeister
|
8tracks: Ignore hashes
| false
| 1
| 1
| 0
|
--- InfoExtractors.py
@@ -3861,7 +3861,7 @@ def _real_extract(self, url):
class EightTracksIE(InfoExtractor):
IE_NAME = '8tracks'
- _VALID_URL = r'https?://8tracks.com/(?P<user>[^/]+)/(?P<id>[^/]+)'
+ _VALID_URL = r'https?://8tracks.com/(?P<user>[^/]+)/(?P<id>[^/#]+)(?:#.*)?$'
def _real_extract(self, url):
mobj = re.match(self._VALID_URL, url)
|
yt-dlp_yt-dlp.json
| null | null | null | null | null | null |
yt-dlp_yt-dlp.json
|
CODE_IMPROVEMENT
|
4, Just updated the code to ignore hashes which wasn't causing any problem
|
293a6c5c91619a86b70e9d23e26412a1095db569
|
2025-02-19 18:11:24
|
Thomas Morin
|
fix typo: optimitically -> optimistically Signed-off-by: Thomas Morin <[email protected]>
| false
| 1
| 1
| 2
|
--- staging/src/k8s.io/client-go/tools/leaderelection/leaderelection.go
@@ -339,7 +339,7 @@ func (le *LeaderElector) tryAcquireOrRenew(ctx context.Context) bool {
le.setObservedRecord(&leaderElectionRecord)
return true
}
- klog.Errorf("Failed to update lock optimistically: %v, falling back to slow path", err)
+ klog.Errorf("Failed to update lock optimitically: %v, falling back to slow path", err)
}
// 2. obtain or create the ElectionRecord
|
kubernetes
|
kubernetes
|
Go
|
Go
| 113,460
| 40,344
|
Production-Grade Container Scheduling and Management
|
kubernetes_kubernetes
|
CODE_IMPROVEMENT
|
typo fixed in the code, non-functional code change
|
54639a4b64126bc320519883a2219b18c70bfc32
|
2024-03-14 04:25:24
|
github-actions[bot]
|
chore(main): release 1.16.2 (#228) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| false
| 7
| 0
| 7
|
--- CHANGELOG.md
@@ -1,12 +1,5 @@
# Changelog
-## [1.16.2](https://github.com/ellite/Wallos/compare/v1.16.1...v1.16.2) (2024-03-13)
-
-
-### Bug Fixes
-
-* wrong folder for payment method logos ([#227](https://github.com/ellite/Wallos/issues/227)) ([f6c1ff2](https://github.com/ellite/Wallos/commit/f6c1ff2a6be6545c6c179722235db3cd724127fd))
-
## [1.16.1](https://github.com/ellite/Wallos/compare/v1.16.0...v1.16.1) (2024-03-12)
|
wallos
|
ellite
|
PHP
|
PHP
| 4,155
| 178
|
Wallos: Open-Source Personal Subscription Tracker
|
ellite_wallos
|
DOC_CHANGE
|
changes in md file
|
75d3d5ee5bc5aab8c0e915b1e3919f83d51399b7
|
2024-03-15 14:06:15
|
Christopher Helmerich
|
Add files via upload
| false
| 0
| 0
| 0
|
--- Visualizer/images/AlcubierreMomentumFlow.gif
Binary files a/Visualizer/images/AlcubierreMomentumFlow.gif and /dev/null differ
--- Visualizer/images/Alcubierre_v0P5_4K_3.png
Binary files a/Visualizer/images/Alcubierre_v0P5_4K_3.png and /dev/null differ
|
warpfactory
|
nerdswithattitudes
|
MATLAB
|
MATLAB
| 298
| 41
|
WarpFactory is a numerical toolkit for analyzing warp drive spacetimes.
|
nerdswithattitudes_warpfactory
|
CONFIG_CHANGE
|
new files uploaded
|
39a491ada3309f47a0c8bdc41748461d00b4f735
|
2025-03-31 02:50:04
|
mejrs
|
unstable book: document import_trait_associated_functions
| false
| 22
| 0
| 22
|
--- src/doc/unstable-book/src/language-features/import-trait-associated-functions.md
@@ -1,22 +0,0 @@
-# import_trait_associated_functions
-
-The tracking issue for this feature is: [#134691]
-
-[#134691]: https://github.com/rust-lang/rust/issues/134691
-
-------------------------
-
-This feature allows importing associated functions and constants from traits and then using them like regular items.
-
-```rust
-#![feature(import_trait_associated_functions)]
-
-use std::ops::Add::add;
-
-fn main() {
- let numbers = vec![1, 2, 3, 4, 5, 6];
- let sum = numbers.into_iter().reduce(add); // instead of `.reduce(Add:add)`
-
- assert_eq!(sum, Some(21));
-}
-```
|
rust
|
rust-lang
|
Rust
|
Rust
| 101,693
| 13,172
|
Empowering everyone to build reliable and efficient software.
|
rust-lang_rust
|
DOC_CHANGE
|
Matched \.md\b in diff
|
193e2df8ba95efd6e3326cb0907576a0c74f1d74
| null |
Jade Abbott
|
Remove rogue comment
| false
| 0
| 1
| -1
|
--- run_classifier.py
@@ -566,7 +566,6 @@ def main():
if args.do_eval and (args.local_rank == -1 or torch.distributed.get_rank() == 0):
eval_examples = processor.get_dev_examples(args.data_dir)
- # should tokenize this too.
eval_features = convert_examples_to_features(
eval_examples, label_list, args.max_seq_length, tokenizer)
logger.info("***** Running evaluation *****")
|
huggingface_transformers.json
| null | null | null | null | null | null |
huggingface_transformers.json
|
CONFIG_CHANGE
|
5, comment change
|
e19d00dfbe9a14a4c588c84867feacd0fb4cc02a
|
2025-02-05 22:52:10
|
Jessica Wilkins
|
refactor(curriculum): remove second events quiz and review page (#58483) Co-authored-by: moT01 <[email protected]>
| false
| 60
| 601
| 661
|
--- client/i18n/locales/english/intro.json
@@ -2959,6 +2959,19 @@
"In this lab, you'll build a favorite icon toggler by utilizing JavaScript click events."
]
},
+ "review-dom-manipulation-and-click-events-with-javascript": {
+ "title": "DOM Manipulation and Click Events with JavaScript Review",
+ "intro": [
+ "Before you're quizzed on the DOM, you should review what you've learned about it.",
+ "Open up this page to review concepts including how to work with the <code>DOM</code>, <code>Web API's</code>, the <code>addEventListener()</code> method and more."
+ ]
+ },
+ "quiz-dom-manipulation-and-click-event-with-javascript": {
+ "title": "DOM Manipulation and Click Events with JavaScript Quiz",
+ "intro": [
+ "Test your knowledge of DOM manipulation and click events in JavaScript with this quiz."
+ ]
+ },
"lecture-understanding-the-event-object-and-event-delegation": {
"title": "Understanding the Event Object and Event Delegation",
"intro": [
@@ -3003,18 +3016,16 @@
"In this lab, you'll use DOM manipulation, object destructuring, event handling, and data filtering to build a set of football team cards."
]
},
- "review-dom-manipulation-and-click-events-with-javascript": {
- "title": "DOM Manipulation and Click Events with JavaScript Review",
+ "review-javascript-events": {
+ "title": "JavaScript Events Review",
"intro": [
- "Before you're quizzed on the DOM, you should review what you've learned about it.",
- "Open up this page to review concepts including how to work with the <code>DOM</code>, <code>Web APIs</code>, the <code>addEventListener()</code> method, change events, event bubbling and more."
+ "Before you're quizzed on events, you should review what you've learned.",
+ "Open up this page to review concepts like change events, event bubbling, and event delegation."
]
},
- "quiz-dom-manipulation-and-click-event-with-javascript": {
- "title": "DOM Manipulation and Click Events with JavaScript Quiz",
- "intro": [
- "Test your knowledge of DOM manipulation and click events in JavaScript with this quiz."
- ]
+ "quiz-javascript-events": {
+ "title": "JavaScript Events Quiz",
+ "intro": ["Test your knowledge of JavaScript events with this quiz."]
},
"lecture-debugging-techniques": {
"title": "Debugging Techniques",
--- client/src/pages/learn/full-stack-developer/quiz-javascript-events/index.md
@@ -0,0 +1,9 @@
+---
+title: Introduction to the JavaScript Events Quiz
+block: quiz-javascript-events
+superBlock: full-stack-developer
+---
+
+## Introduction to the JavaScript Events Quiz
+
+Test what you've learned in this quiz on JavaScript Events.
--- client/src/pages/learn/full-stack-developer/review-javascript-events/index.md
@@ -0,0 +1,9 @@
+---
+title: Introduction to the JavaScript Events Review
+block: review-javascript-events
+superBlock: full-stack-developer
+---
+
+## Introduction to the JavaScript Events Review
+
+Review the JavaScript Events concepts to prepare for the upcoming quiz.
--- curriculum/challenges/_meta/quiz-javascript-events/meta.json
@@ -0,0 +1,12 @@
+{
+ "name": "JavaScript Events Quiz",
+ "blockType": "quiz",
+ "blockLayout": "link",
+ "isUpcomingChange": false,
+ "dashedName": "quiz-javascript-events",
+ "superBlock": "full-stack-developer",
+ "challengeOrder": [
+ { "id": "66edd0ac31fea6e678eb925a", "title": "JavaScript Events Quiz" }
+ ],
+ "helpCategory": "JavaScript"
+}
--- curriculum/challenges/_meta/review-javascript-events/meta.json
@@ -0,0 +1,12 @@
+{
+ "name": "JavaScript Events Review",
+ "blockType": "review",
+ "blockLayout": "link",
+ "isUpcomingChange": false,
+ "dashedName": "review-javascript-events",
+ "superBlock": "full-stack-developer",
+ "challengeOrder": [
+ { "id": "6723cc0ca05ce9b87a319ceb", "title": "JavaScript Events Review" }
+ ],
+ "helpCategory": "JavaScript"
+}
--- curriculum/challenges/english/25-front-end-development/quiz-dom-manipulation-and-click-event-with-javascript/66edd07682767adff3a6231e.md
@@ -449,23 +449,31 @@ It is used to manipulate graphics via your JavaScript file.
#### --text--
-What is event delegation?
+Which of the following is the correct way to work with the `fillRect` property?
#### --distractors--
-The process of listening to events when an event is cancelled.
+```js
+ctx.fillRect(1fr 1fr 1fr 1fr);
+```
---
-The process of listening to events when a click event occurs.
+```js
+ctx.fillRect(set 50);
+```
---
-The process of listening to events when a change event occurs.
+```js
+ctx.fillRect(allow);
+```
#### --answer--
-The process of listening to events that have bubbled up to a parent.
+```js
+ctx.fillRect(25, 25, 50, 50);
+```
### --question--
--- curriculum/challenges/english/25-front-end-development/quiz-javascript-events/66edd0ac31fea6e678eb925a.md
@@ -0,0 +1,465 @@
+---
+id: 66edd0ac31fea6e678eb925a
+title: JavaScript Events Quiz
+challengeType: 8
+dashedName: quiz-javascript-events
+---
+
+# --description--
+
+To pass the quiz, you must correctly answer at least 18 of the 20 questions below.
+
+# --quizzes--
+
+## --quiz--
+
+### --question--
+
+#### --text--
+
+Which method is used to listen to events in JavaScript?
+
+#### --distractors--
+
+`.getElementById()`
+
+---
+
+`.createElement()`
+
+---
+
+`.innerHTML`
+
+#### --answer--
+
+`.addEventListener()`
+
+### --question--
+
+#### --text--
+
+What does this code demonstrate?
+
+```js
+const parentList = document.getElementById('parent-list');
+
+parentList.addEventListener('click', function(event) {
+ if (event.target && event.target.nodeName === 'LI') {
+ console.log('List item clicked:', event.target.textContent);
+ }
+});
+```
+
+#### --distractors--
+
+DOM Manipulation.
+
+---
+
+Event Bubbling.
+
+---
+
+Callback Function.
+
+#### --answer--
+
+Event Delegation.
+
+### --question--
+
+#### --text--
+
+What is the term for a function that runs in response to an event?
+
+#### --distractors--
+
+Middleware function.
+
+---
+
+Promise function.
+
+---
+
+Asynchronous function.
+
+#### --answer--
+
+Callback function.
+
+### --question--
+
+#### --text--
+
+What does the `event.target` property return?
+
+#### --distractors--
+
+The parent of the event object.
+
+---
+
+The HTML document.
+
+---
+
+The window object.
+
+#### --answer--
+
+The element that triggered the event.
+
+### --question--
+
+#### --text--
+
+How do you correctly pass an argument to an event handler function in JavaScript?
+
+#### --distractors--
+
+`addEventListener('click', myFunction())`
+
+---
+
+`addEventListener('click', myFunction.argument)`
+
+---
+
+`addEventListener('click', parameter => myFunction(argument))`
+
+#### --answer--
+
+`addEventListener('click', () => myFunction(argument))`
+
+### --question--
+
+#### --text--
+
+Which event type captures an input event across all types of input fields?
+
+#### --distractors--
+
+`keyup`
+
+---
+
+`keypress`
+
+---
+
+`keydown`
+
+#### --answer--
+
+`input`
+
+### --question--
+
+#### --text--
+
+What is the main advantage of using `addEventListener()` over inline event handlers?
+
+#### --distractors--
+
+It supports synchronous handling.
+
+---
+
+It reduces CSS file size.
+
+---
+
+It can't be removed once added.
+
+#### --answer--
+
+It allows multiple event listeners to be attached to a single element.
+
+### --question--
+
+#### --text--
+
+What is the purpose of the `event.preventDefault()` method?
+
+#### --distractors--
+
+To stop the event from propagating to other listeners.
+
+---
+
+To set a default value to the event.
+
+---
+
+To remove the event handler.
+
+#### --answer--
+
+To prevent the default action associated with an event from being executed.
+
+### --question--
+
+#### --text--
+
+What does the term "event propagation" refer to?
+
+#### --distractors--
+
+Events can only be handled by inline handlers.
+
+---
+
+Events are triggered by CSS changes.
+
+---
+
+Events are copied to a new window.
+
+#### --answer--
+
+Events travel through the DOM in phases.
+
+### --question--
+
+#### --text--
+
+What event handler would you use to detect a right-click on an element?
+
+#### --distractors--
+
+`click`
+
+---
+
+`hover`
+
+---
+
+`mousedown`
+
+#### --answer--
+
+`contextmenu`
+
+### --question--
+
+#### --text--
+
+Which of the following is an example of an inline event handler?
+
+#### --distractors--
+
+`<script>myButton.addEventListener('click', myFunction);</script>`
+
+---
+
+`<button id="myButton"></button>`
+
+---
+
+`<button class="myButton">Click me</button>`
+
+#### --answer--
+
+`<button onclick="myFunction()">Click me</button>`
+
+### --question--
+
+#### --text--
+
+Which of the following is a common use case for event delegation?
+
+#### --distractors--
+
+Preventing default browser behaviors.
+
+---
+
+Canceling event propagation.
+
+---
+
+Creating custom events.
+
+#### --answer--
+
+Handling click events on dynamically created elements.
+
+### --question--
+
+#### --text--
+
+What is meant by the "default action" of an event in JavaScript?
+
+#### --distractors--
+
+The event's propagation is stopped automatically.
+
+---
+
+An external stylesheet is applied.
+
+---
+
+The event listener is called twice.
+
+#### --answer--
+
+The browser's predefined behavior that occurs after an event is triggered.
+
+### --question--
+
+#### --text--
+
+Why is the once option in `addEventListener()` useful?
+
+#### --distractors--
+
+It makes the event listener asynchronous.
+
+---
+
+It allows capturing to be the default phase.
+
+---
+
+It stops the event from bubbling up.
+
+#### --answer--
+
+It ensures that the event listener is removed after being triggered once.
+
+### --question--
+
+#### --text--
+
+What property refers to the HTML element to which the event handler is attached?
+
+#### --distractors--
+
+`event.caller`
+
+---
+
+`event.this`
+
+---
+
+`event.parent`
+
+#### --answer--
+
+`event.currentTarget`
+
+### --question--
+
+#### --text--
+
+How does the concept of event delegation improve performance?
+
+#### --distractors--
+
+It creates separate listeners for each child.
+
+---
+
+It prevents child elements from triggering events.
+
+---
+
+It limits event propagation to the capturing phase.
+
+#### --answer--
+
+It reduces the number of event listeners by using a single listener on a parent element.
+
+### --question--
+
+#### --text--
+
+Why is it important to remove event listeners when they are no longer needed?
+
+#### --distractors--
+
+It makes the page load slower.
+
+---
+
+It prevents CSS styles from being applied.
+
+---
+
+It breaks JavaScript execution.
+
+#### --answer--
+
+It improves performance and reduces memory leaks.
+
+### --question--
+
+#### --text--
+
+What does the `DOMContentLoaded` event indicate?
+
+#### --distractors--
+
+The page fully loaded with all images.
+
+---
+
+Only external styles are loaded.
+
+---
+
+The page is still loading.
+
+#### --answer--
+
+The HTML document has been completely loaded and parsed.
+
+### --question--
+
+#### --text--
+
+What is the role of `stopPropagation()` in event handling?
+
+#### --distractors--
+
+To execute the default behavior of the event.
+
+---
+
+To start event capturing.
+
+---
+
+To bind the event handler to multiple events.
+
+#### --answer--
+
+To stop the event from propagating to parent elements.
+
+### --question--
+
+#### --text--
+
+How can you remove all event listeners attached to an element?
+
+#### --distractors--
+
+`element.removeAllListeners()`
+
+---
+
+`element.removeEventListeners()`
+
+---
+
+`element.clearEventListeners()`
+
+#### --answer--
+
+There is no direct way to remove all event listeners.
+
--- curriculum/challenges/english/25-front-end-development/review-dom-manipulation-and-click-events-with-javascript/6723cc7a8e7aa3b9befd4bac.md
@@ -9,7 +9,7 @@ dashedName: review-dom-manipulation-and-click-events-with-javascript
Review the concepts below to prepare for the upcoming quiz.
-## Working with the DOM and Web APIs
+## Working with the DOM and Web API's
- **API**: An API (Application Programming Interface) is a set of rules and protocols that allow software applications to communicate with each other and exchange data efficiently.
- **Web API**: Web APIs are specifically designed for web applications. These types of APIs are often divided into two main categories: browser APIs and third-party APIs.
@@ -140,7 +140,7 @@ const lastParagraph = document.querySelector("#example-section p:last-of-type");
sectionEl.removeChild(lastParagraph);
```
-## Work with the `setAttribute()` Method
+## Work with the `setAttribute` Method
- **Definition**: This method is used to set the attribute for a given element. If the attribute already exists, then the value is updated. Otherwise, a new attribute is added with a value.
@@ -167,7 +167,7 @@ const btn = document.getElementById("btn");
btn.addEventListener("click", () => alert("You clicked the button"));
```
-- **`removeEventListener()` Method**: This method is used to remove an event listener that was previously added to an element using the `addEventListener()` method. This is useful when you want to stop listening for a particular event on an element.
+- **`removeEventListener` Method**: This method is used to remove an event listener that was previously added to an element using the `addEventListener` method. This is useful when you want to stop listening for a particular event on an element.
```js
const bodyEl = document.querySelector("body");
@@ -194,42 +194,6 @@ para.addEventListener("mouseover", () => {
<button onclick="alert('Hello World!')">Show alert</button>
```
-## The Change Event
-
-- **Definition**: The change event is a special event which is fired when the user modifies the value of certain input elements. Examples would include when a checkbox or a radio button is ticked. Or when the user makes a selection from something like a date picker or dropdown menu.
-
-```html
-<label>
- Choose a programming language:
- <select class="language" name="language">
- <option value="">---Select One---</option>
- <option value="JavaScript">JavaScript</option>
- <option value="Python">Python</option>
- <option value="C++">C++</option>
- </select>
-</label>
-
-<p class="result"></p>
-```
-
-```js
-const selectEl = document.querySelector(".language");
-const result = document.querySelector(".result");
-
-selectEl.addEventListener("change", (e) => {
- result.textContent = `You enjoy programming in ${e.target.value}.`;
-});
-```
-
-## Event Bubbling
-
-- **Definition**: Event bubbling, or propagation, refers to how an event "bubbles up" to parent objects when triggered.
-- **`stopPropagation()` Method**: This method prevents further propagation for an event.
-
-## Event Delegation
-
-- **Definition**: Event delegation is the process of listening to events that have bubbled up to a parent, rather than handling them directly on the element that triggered them.
-
## DOMContentLoaded
- **Definition**: The `DOMContentLoaded` event is fired when everything in the HTML document has been loaded and parsed. If you have external stylesheets, or images, the `DOMContentLoaded` event will not wait for those to be loaded. It will only wait for the HTML to be loaded.
@@ -261,7 +225,7 @@ toggleBtn.addEventListener("click", () => menu.classList.toggle("show"));
```
-## Working with the `setTimeout()` and `setInterval()` Methods
+## Working with the `setTimeout` and `setInterval` Methods
- **`setTimeout()` Method**: This method lets you delay an action for a specified time.
--- curriculum/challenges/english/25-front-end-development/review-javascript-events/6723cc0ca05ce9b87a319ceb.md
@@ -0,0 +1,49 @@
+---
+id: 6723cc0ca05ce9b87a319ceb
+title: JavaScript Events Review
+challengeType: 24
+dashedName: review-javascript-events
+---
+
+# --description--
+
+Review the concepts below to prepare for the upcoming quiz.
+
+## The Change Event
+
+- **Definition**: The change event is a special event which is fired when the user modifies the value of certain input elements. Examples would include when a checkbox or a radio button is ticked. Or when the user makes a selection from something like a date picker or dropdown menu.
+
+```html
+<label>
+ Choose a programming language:
+ <select class="language" name="language">
+ <option value="">---Select One---</option>
+ <option value="JavaScript">JavaScript</option>
+ <option value="Python">Python</option>
+ <option value="C++">C++</option>
+ </select>
+</label>
+
+<p class="result"></p>
+```
+
+```js
+const selectEl = document.querySelector(".language");
+const result = document.querySelector(".result");
+
+selectEl.addEventListener("change", (e) => {
+ result.textContent = `You enjoy programming in ${e.target.value}.`;
+});
+```
+
+## Event Bubbling
+
+- **Definition**: Event bubbling, or propagation, refers to how an event "bubbles up" to parent objects when triggered.
+
+## Event Delegation
+
+- **Definition**: Event delegation is the process of listening to events that have bubbled up to a parent, rather than handling them directly on the element that triggered them.
+
+# --assignment--
+
+Review the JavaScript Events topics and concepts.
--- curriculum/superblock-structure/full-stack.json
@@ -414,6 +414,12 @@
},
{ "dashedName": "workshop-storytelling-app" },
{ "dashedName": "lab-favorite-icon-toggler" },
+ {
+ "dashedName": "review-dom-manipulation-and-click-events-with-javascript"
+ },
+ {
+ "dashedName": "quiz-dom-manipulation-and-click-event-with-javascript"
+ },
{
"dashedName": "lecture-understanding-the-event-object-and-event-delegation"
},
@@ -423,12 +429,8 @@
{ "dashedName": "workshop-rps-game" },
{ "dashedName": "lab-palindrome-checker" },
{ "dashedName": "lab-football-team-cards" },
- {
- "dashedName": "review-dom-manipulation-and-click-events-with-javascript"
- },
- {
- "dashedName": "quiz-dom-manipulation-and-click-event-with-javascript"
- }
+ { "dashedName": "review-javascript-events" },
+ { "dashedName": "quiz-javascript-events" }
]
},
{
|
freecodecamp
|
freecodecamp
|
TypeScript
|
TypeScript
| 410,748
| 39,092
|
freeCodeCamp.org's open-source codebase and curriculum. Learn to code for free.
|
freecodecamp_freecodecamp
|
CONFIG_CHANGE
|
Obvious
|
beedc4b9714c68d9a662615e44f585ab5982860f
|
2024-09-26 20:39:01
|
Swifty
|
tweak(platform): Updated onOpenChange code style (#8187)
| false
| 1
| 5
| 6
|
--- autogpt_platform/frontend/src/components/edit/control/BlocksControl.tsx
@@ -77,7 +77,11 @@ export const BlocksControl: React.FC<BlocksControlProps> = ({
return (
<Popover
open={pinBlocksPopover ? true : undefined}
- onOpenChange={(open) => open || resetFilters()}
+ onOpenChange={(open) => {
+ if (!open) {
+ resetFilters();
+ }
+ }}
>
<Tooltip delayDuration={500}>
<TooltipTrigger asChild>
|
autogpt
|
significant-gravitas
|
Python
|
Python
| 172,255
| 45,197
|
AutoGPT is the vision of accessible AI for everyone, to use and to build on. Our mission is to provide the tools, so that you can focus on what matters.
|
significant-gravitas_autogpt
|
CODE_IMPROVEMENT
|
only code style is changed
|
f81c3fd89ed998f211e60e76b8f55a2df27000fe
|
2024-01-18 20:05:12
|
Chen Tianjie
|
Optimize dictTypeResizeAllowed to avoid mistaken OOM judgement. (#12950) When doing dict resizing, dictTypeResizeAllowed is used to judge whether
the new allocated memory for rehashing would cause OOM.
However when shrinking, we alloc `_dictNextExp(d->ht_used[0])` bytes of
memory, while in `dictTypeResizeAllowed` we still use
`_dictNextExp(d->ht_used[0]+1)` as the new allocated memory size. This
will overestimate the memory used by shrinking at special conditions,
causing a false OOM judgement.
| false
| 6
| 6
| 12
|
--- src/dict.c
@@ -1421,12 +1421,12 @@ unsigned long dictScanDefrag(dict *d,
/* ------------------------- private functions ------------------------------ */
/* Because we may need to allocate huge memory chunk at once when dict
- * resizes, we will check this allocation is allowed or not if the dict
- * type has resizeAllowed member function. */
-static int dictTypeResizeAllowed(dict *d, size_t size) {
+ * expands, we will check this allocation is allowed or not if the dict
+ * type has expandAllowed member function. */
+static int dictTypeResizeAllowed(dict *d) {
if (d->type->resizeAllowed == NULL) return 1;
return d->type->resizeAllowed(
- DICTHT_SIZE(_dictNextExp(size)) * sizeof(dictEntry*),
+ DICTHT_SIZE(_dictNextExp(d->ht_used[0] + 1)) * sizeof(dictEntry*),
(double)d->ht_used[0] / DICTHT_SIZE(d->ht_size_exp[0]));
}
@@ -1454,7 +1454,7 @@ static void _dictExpandIfNeeded(dict *d)
(dict_can_resize != DICT_RESIZE_FORBID &&
d->ht_used[0] >= dict_force_resize_ratio * DICTHT_SIZE(d->ht_size_exp[0])))
{
- if (!dictTypeResizeAllowed(d, d->ht_used[0] + 1))
+ if (!dictTypeResizeAllowed(d))
return;
dictExpand(d, d->ht_used[0] + 1);
}
@@ -1479,7 +1479,7 @@ static void _dictShrinkIfNeeded(dict *d)
(dict_can_resize != DICT_RESIZE_FORBID &&
d->ht_used[0] * 100 * dict_force_resize_ratio <= HASHTABLE_MIN_FILL * DICTHT_SIZE(d->ht_size_exp[0])))
{
- if (!dictTypeResizeAllowed(d, d->ht_used[0]))
+ if (!dictTypeResizeAllowed(d))
return;
dictShrink(d, d->ht_used[0]);
}
|
redis
|
redis
|
C
|
C
| 68,201
| 23,916
|
Redis is an in-memory database that persists on disk. The data model is key-value, but many different kind of values are supported: Strings, Lists, Sets, Sorted Sets, Hashes, Streams, HyperLogLogs, Bitmaps.
|
redis_redis
|
PERF_IMPROVEMENT
|
Obvious
|
d5ebca3a3c4305a51efbe8b8c75456b51a2ec1dc
|
2022-06-12 06:36:41
|
macro
|
Update PmsProductCategoryService.java
| false
| 0
| 2
| 2
|
--- mall-admin/src/main/java/com/macro/mall/service/PmsProductCategoryService.java
@@ -3,6 +3,8 @@ package com.macro.mall.service;
import com.macro.mall.dto.PmsProductCategoryParam;
import com.macro.mall.dto.PmsProductCategoryWithChildrenItem;
import com.macro.mall.model.PmsProductCategory;
+import org.springframework.transaction.annotation.Isolation;
+import org.springframework.transaction.annotation.Propagation;
import org.springframework.transaction.annotation.Transactional;
import java.util.List;
|
mall
|
macrozheng
|
Java
|
Java
| 79,319
| 29,052
|
mall项目是一套电商系统,包括前台商城系统及后台管理系统,基于Spring Boot+MyBatis实现,采用Docker容器化部署。 前台商城系统包含首页门户、商品推荐、商品搜索、商品展示、购物车、订单流程、会员中心、客户服务、帮助中心等模块。 后台管理系统包含商品管理、订单管理、会员管理、促销管理、运营管理、内容管理、统计报表、财务管理、权限管理、设置等模块。
|
macrozheng_mall
|
CODE_IMPROVEMENT
|
probably refactoring since just new functions are imported
|
ed55491ef8e63cf7a09a19c72966abb34d9cfdc9
| null |
Saurabh Vyas
|
update requirement.txt file path Its now in root
| false
| 1
| 1
| 0
|
--- README.md
@@ -18,7 +18,7 @@ Manually install [Git Large File Storage](https://git-lfs.github.com/), then ope
```
git clone https://github.com/mozilla/DeepSpeech
cd DeepSpeech
-pip install -r doc/requirements.txt
+pip install -r requirements.txt
```
## Recommendations
|
mozilla_DeepSpeech.json
| null | null | null | null | null | null |
mozilla_DeepSpeech.json
|
CONFIG_CHANGE
|
Changes in readme only
|
dd4b4dd9d0e7e64080bed04d9e21f43933f8021f
| null |
Guillermo Rauch
|
Release 2.4.1
| false
| 1
| 1
| 0
|
--- package.json
@@ -1,6 +1,6 @@
{
"name": "next",
- "version": "2.4.0",
+ "version": "2.4.1",
"description": "Minimalistic framework for server-rendered React applications",
"main": "./dist/server/next.js",
"license": "MIT",
|
vercel_next.js.json
| null | null | null | null | null | null |
vercel_next.js.json
|
CONFIG_CHANGE
|
5, obvious
|
68449986bc828bda96b386158bbf6b50f913f6eb
|
2024-04-15 07:56:37
|
Ikko Eltociear Ashimine
|
fix typo in threePlusOneDecomposer.m OUPUTS -> OUTPUTS
| false
| 1
| 1
| 2
|
--- Metrics/threePlusOneDecomposer.m
@@ -4,7 +4,7 @@
% INPUTS:
% metric - metric struct object.
%
-% OUTPUTS:
+% OUPUTS:
% alpha - 4D array. Lapse rate.
%
% betaDown - 1x3 cell of 4D arrays. Shift vectors.
|
warpfactory
|
nerdswithattitudes
|
MATLAB
|
MATLAB
| 298
| 41
|
WarpFactory is a numerical toolkit for analyzing warp drive spacetimes.
|
nerdswithattitudes_warpfactory
|
BUG_FIX
|
Obvious
|
7b5b7b20de37aec198eef630e61f84373b5a4244
|
2025-02-24 13:29:51
|
Jakub Piasecki
|
Update VirtualizedSectionList props name (#49592) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/49592 Changelog: [Internal] Reviewed By: huntie Differential Revision: D69984225 fbshipit-source-id: 753917f31a803c3bc8ea2e4635ec1d58cecb9224
| false
| 5
| 5
| 10
|
--- packages/virtualized-lists/Lists/VirtualizedSectionList.js
@@ -91,7 +91,7 @@ type OptionalProps<SectionT: SectionBase<any>> = {
type VirtualizedListProps = React.ElementConfig<typeof VirtualizedList>;
-export type VirtualizedSectionListProps<SectionT: SectionBase<any>> = {
+export type Props<SectionT: SectionBase<any>> = {
...RequiredProps<SectionT>,
...OptionalProps<SectionT>,
...$Diff<
@@ -120,7 +120,7 @@ type State = {childProps: VirtualizedListProps, ...};
*/
class VirtualizedSectionList<
SectionT: SectionBase<any>,
-> extends React.PureComponent<VirtualizedSectionListProps<SectionT>, State> {
+> extends React.PureComponent<Props<SectionT>, State> {
scrollToLocation(params: ScrollToLocationParamsType) {
let index = params.itemIndex;
for (let i = 0; i < params.sectionIndex; i++) {
@@ -203,7 +203,7 @@ class VirtualizedSectionList<
}
_getItem(
- props: VirtualizedSectionListProps<SectionT>,
+ props: Props<SectionT>,
sections: ?$ReadOnlyArray<Item>,
index: number,
): ?Item {
@@ -605,5 +605,5 @@ export default VirtualizedSectionList as component(
scrollToLocation(params: ScrollToLocationParamsType): void,
},
>,
- ...VirtualizedSectionListProps<SectionBase<any>>
+ ...Props<SectionBase<any>>
);
--- packages/virtualized-lists/index.js
@@ -31,7 +31,7 @@ export type {
Separators,
} from './Lists/VirtualizedListProps';
export type {
- VirtualizedSectionListProps,
+ Props as VirtualizedSectionListProps,
ScrollToLocationParamsType,
SectionBase,
} from './Lists/VirtualizedSectionList';
|
react-native
|
facebook
|
C++
|
C++
| 120,863
| 24,536
|
A framework for building native applications using React
|
facebook_react-native
|
CODE_IMPROVEMENT
|
Non-functional code changes to improve readability, migration etc.
|
a5a4bffa3c6cad4faca20cd4bb292fcd9bd667eb
|
2023-01-20 16:36:33
|
Arnim Bleier
|
add CSS at UMass
| false
| 4
| 0
| 4
|
--- README.md
@@ -97,10 +97,6 @@ Koç University, Turkey
- [CSS Lab TU
Graz](https://www.tugraz.at/institute/isds/research/research-groups/computational-social-science-lab-css-lab/),
Graz, Austria
-
-- [Computational Social Science Institute at UMass](https://www.cssi.umass.edu),
- Massachusetts Amherst, USA
-
## Journals
|
awesome-computational-social-science
|
gesiscss
|
R
|
R
| 648
| 83
|
A list of awesome resources for Computational Social Science
|
gesiscss_awesome-computational-social-science
|
DOC_CHANGE
|
The prefix fix: suggests a bug fix, but the actual change is not fixing code behavior, it’s improving documentation rendering
|
ec80239e5e3c7f0a4298dab823759c39ec3f2a0a
|
2024-03-09 18:41:05
|
Hong Geon-ui
|
translation : Translate the Visitor to Korean (#2726)
| false
| 230
| 0
| 230
|
--- localization/ko/visitor/README.md
@@ -1,230 +0,0 @@
----
-title: Visitor
-category: Behavioral
-language: ko
-tag:
- - Gang of Four
----
-
-## 의도
-
-
-객체 구조의 요소들에 대해 수행할 작업을 나타냅니다. 방문자(Visitor)는
-연산하는 요소의 클래스를 변경하지 않고 새 연산을 정의할 수 있게 해줍니다.
-## 설명
-
-살제 예제
-
-> 육군 부대의 편성을 생각해보세요. 지휘관은 아래에 2명의 중사를 휘하에 두고 있고 각 중사들은
-> 3명의 병사를 휘하에 두고 있습니다. 위계에 따라 방문자(Visitor) 패턴이 구현되는 것을 함께 생각하면,
-> 우리는 지휘관, 중사 병사 또는 그들 모두와 상호작용하는 새로운 게체를 쉽게 만들 수 있습니다.
-
-쉽게 말하자면
-
-> 방문자(Visitor) 패턴은 데이터 구조의 노드에서 수행할 수 있는 작업들을 정의합니다.
-
-Wikipedia에 의하면
-
-> 객체 지향 프로그래밍 및 소프트웨어 엔지니어링에에서, 방문자(Visitor) 패턴은
-> 알고리즘이 동작하는 객체 구조로부터 알고리즘을 분리하는 것,
-> 이 분리를 통해, 구조의 변경 없이 기본 객체 구조에 새로운 연산을 추가할 수 있도록 하는 방법입니다.
-
-**코드 예제**
-
-위의 육군 부대를 예로 들겠습니다. 먼저 `Unit` 추상화 클래스와 `UnitVisitor` 인터페이스가 있습니다.
-
-```java
-public abstract class Unit {
-
- private final Unit[] children;
-
- public Unit(Unit... children) {
- this.children = children;
- }
-
- public void accept(UnitVisitor visitor) {
- Arrays.stream(children).forEach(child -> child.accept(visitor));
- }
-}
-
-public interface UnitVisitor {
-
- void visit(Soldier soldier);
-
- void visit(Sergeant sergeant);
-
- void visit(Commander commander);
-}
-```
-
-그리고 이를 구현한 `Commander`,`Sergant`,`Soilder` 구현 클래스입니다.
-
-```java
-public class Commander extends Unit {
-
- public Commander(Unit... children) {
- super(children);
- }
-
- @Override
- public void accept(UnitVisitor visitor) {
- visitor.visit(this);
- super.accept(visitor);
- }
-
- @Override
- public String toString() {
- return "commander";
- }
-}
-
-public class Sergeant extends Unit {
-
- public Sergeant(Unit... children) {
- super(children);
- }
-
- @Override
- public void accept(UnitVisitor visitor) {
- visitor.visit(this);
- super.accept(visitor);
- }
-
- @Override
- public String toString() {
- return "sergeant";
- }
-}
-
-public class Soldier extends Unit {
-
- public Soldier(Unit... children) {
- super(children);
- }
-
- @Override
- public void accept(UnitVisitor visitor) {
- visitor.visit(this);
- super.accept(visitor);
- }
-
- @Override
- public String toString() {
- return "soldier";
- }
-}
-```
-
-그리고 `UnitVisiotr`를 구현한 `CommanderVisitor`,`SergantVisitor`,`Soilder` 구현 클래스입니다.
-
-```java
-@Slf4j
-public class CommanderVisitor implements UnitVisitor {
-
- @Override
- public void visit(Soldier soldier) {
- // Do nothing
- }
-
- @Override
- public void visit(Sergeant sergeant) {
- // Do nothing
- }
-
- @Override
- public void visit(Commander commander) {
- LOGGER.info("Good to see you {}", commander);
- }
-}
-
-@Slf4j
-public class SergeantVisitor implements UnitVisitor {
-
- @Override
- public void visit(Soldier soldier) {
- // Do nothing
- }
-
- @Override
- public void visit(Sergeant sergeant) {
- LOGGER.info("Hello {}", sergeant);
- }
-
- @Override
- public void visit(Commander commander) {
- // Do nothing
- }
-}
-
-@Slf4j
-public class SoldierVisitor implements UnitVisitor {
-
- @Override
- public void visit(Soldier soldier) {
- LOGGER.info("Greetings {}", soldier);
- }
-
- @Override
- public void visit(Sergeant sergeant) {
- // Do nothing
- }
-
- @Override
- public void visit(Commander commander) {
- // Do nothing
- }
-}
-```
-
-마지막으로, 우린 방문자(Visitor)의 위력을 볼 수 있습니다.
-
-```java
-commander.accept(new SoldierVisitor());
-commander.accept(new SergeantVisitor());
-commander.accept(new CommanderVisitor());
-```
-
-프로그램 실행 결과:
-
-```
-Greetings soldier
-Greetings soldier
-Greetings soldier
-Greetings soldier
-Greetings soldier
-Greetings soldier
-Hello sergeant
-Hello sergeant
-Good to see you commander
-```
-
-## 클래스 다이어그램
-
-
-
-## 적용 가능성
-
-일반적으로 방문자(Visitor) 패턴은 다음과 같은 상황에 사용할 수 있습니다.
-
-* 객체 구조에 다양한 인터페이스를 가진 객체의 클래스가 많이 포함되어 있고, 객체들의 구현 클래스에 따라 연산되게 하고 싶을 때 사용할 수 있습니다.
-* 객체 구조에 있는 객체들에 대해 개별적이고 서로 연관이 없는 연산들을 수행하고 싶을 때, 이러한 연산들로 인해 클래스가 "오염(Polluting)"되는 것을 방지하고자 합니다. 이럴 때, 방문자(Visitor)를 사용해 관련 연산을 하나의 클래스에 정의하여 유지할 수 있습니다. 객체 구조가 여러 응용 프로그램에서 공유되는 경우에는 방문자(Visitor)를 사용해 필요한 응용 프로그램에만 연산을 추가할 수 있습니다.
-* 객체 구조를 정의하는 클래스들은 거의 변경되지 않지만, 종종 새로운 연산을 정의해야 할 때가 있습니다. 객체 구조 클래스들을 변경하려면 모둔 방문자(Visitor)에 데한 인터페이스를 재정의해야 하므로 비용이 많이 들수 있습니다. 객체 구조 클래스가 자주 변경되는 경우 해당 클래스의 연산을 정의하는 것이 더 나을 수 있습니다.
-
-## 튜토리얼
-
-* [Refactoring Guru](https://refactoring.guru/design-patterns/visitor)
-* [Dzone](https://dzone.com/articles/design-patterns-visitor)
-* [Sourcemaking](https://sourcemaking.com/design_patterns/visitor)
-
-## 실제 사례
-
-* [Apache Wicket](https://github.com/apache/wicket) 구성 요소, [MarkupContainer](https://github.com/apache/wicket/blob/b60ec64d0b50a611a9549809c9ab216f0ffa3ae3/wicket-core/src/main/java/org/apache/wicket/MarkupContainer.java)를 참조하세요.
-* [javax.lang.model.element.AnnotationValue](http://docs.oracle.com/javase/8/docs/api/javax/lang/model/element/AnnotationValue.html) 그리고 [AnnotationValueVisitor](http://docs.oracle.com/javase/8/docs/api/javax/lang/model/element/AnnotationValueVisitor.html)
-* [javax.lang.model.element.Element](http://docs.oracle.com/javase/8/docs/api/javax/lang/model/element/Element.html) 그리고 [Element Visitor](http://docs.oracle.com/javase/8/docs/api/javax/lang/model/element/ElementVisitor.html)
-* [java.nio.file.FileVisitor](http://docs.oracle.com/javase/8/docs/api/java/nio/file/FileVisitor.html)
-
-## 크레딧
-
-* [Design Patterns: Elements of Reusable Object-Oriented Software](https://www.amazon.com/gp/product/0201633612/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=0201633612&linkCode=as2&tag=javadesignpat-20&linkId=675d49790ce11db99d90bde47f1aeb59)
-* [Head First Design Patterns: A Brain-Friendly Guide](https://www.amazon.com/gp/product/0596007124/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=0596007124&linkCode=as2&tag=javadesignpat-20&linkId=6b8b6eea86021af6c8e3cd3fc382cb5b)
-* [Refactoring to Patterns](https://www.amazon.com/gp/product/0321213351/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=0321213351&linkCode=as2&tag=javadesignpat-20&linkId=2a76fcb387234bc71b1c61150b3cc3a7)
--- localization/ko/visitor/etc/visitor_1.png
Binary files a/localization/ko/visitor/etc/visitor_1.png and /dev/null differ
|
java-design-patterns
|
iluwatar
|
Java
|
Java
| 90,911
| 26,831
|
Design patterns implemented in Java
|
iluwatar_java-design-patterns
|
DOC_CHANGE
|
changes in readme
|
4bb8832eadac03871219ac754e2669390cb2b66b
|
2024-03-27 18:40:06
|
Easy
|
添加epub导出设置
| false
| 4
| 1
| 5
|
--- book.toml
@@ -1,9 +1,6 @@
[book]
authors = ["Easy"]
-language = "zh-cn"
+language = "en"
multilingual = false
src = "src"
title = "一人企业方法论"
-
-[output.epub]
-cover-image = "src/images/opb-book-cover.jpg"
\ No newline at end of file
|
one-person-businesses-methodology-v2.0
|
easychen
|
PHP
|
PHP
| 5,272
| 464
|
《一人企业方法论》第二版,也适合做其他副业(比如自媒体、电商、数字商品)的非技术人群。
|
easychen_one-person-businesses-methodology-v2.0
|
CONFIG_CHANGE
|
changes is toml file
|
a42a969e079ed2908b5c2fd004376dc43f476d83
| null |
Tim Neutkens
|
6.1.1-canary.0
| false
| 1
| 1
| 0
|
--- package.json
@@ -1,6 +1,6 @@
{
"name": "next",
- "version": "6.1.1",
+ "version": "6.1.1-canary.0",
"description": "Minimalistic framework for server-rendered React applications",
"main": "./dist/server/next.js",
"license": "MIT",
|
vercel_next.js.json
| null | null | null | null | null | null |
vercel_next.js.json
|
CONFIG_CHANGE
|
5, obvious
|
acd7d03266e1b2b1df07c608ba225eb46a57d4cf
|
2024-12-07 00:35:11
|
Michael
|
readme: add llama3.3 to readme (#7975) readme: add llama3.3 to readme
| false
| 1
| 1
| 2
|
--- README.md
@@ -49,12 +49,12 @@ Here are some example models that can be downloaded:
| Model | Parameters | Size | Download |
| ------------------ | ---------- | ----- | -------------------------------- |
-| Llama 3.3 | 70B | 43GB | `ollama run llama3.3` |
| Llama 3.2 | 3B | 2.0GB | `ollama run llama3.2` |
| Llama 3.2 | 1B | 1.3GB | `ollama run llama3.2:1b` |
| Llama 3.2 Vision | 11B | 7.9GB | `ollama run llama3.2-vision` |
| Llama 3.2 Vision | 90B | 55GB | `ollama run llama3.2-vision:90b` |
| Llama 3.1 | 8B | 4.7GB | `ollama run llama3.1` |
+| Llama 3.1 | 70B | 40GB | `ollama run llama3.1:70b` |
| Llama 3.1 | 405B | 231GB | `ollama run llama3.1:405b` |
| Phi 3 Mini | 3.8B | 2.3GB | `ollama run phi3` |
| Phi 3 Medium | 14B | 7.9GB | `ollama run phi3:medium` |
|
ollama
|
ollama
|
Go
|
Go
| 131,099
| 10,753
|
Get up and running with Llama 3.3, DeepSeek-R1, Phi-4, Gemma 2, and other large language models.
|
ollama_ollama
|
DOC_CHANGE
|
Obvious
|
5da6daa4023f74a0753206e7990492fab13c9c35
| null |
WindowsAddict
|
Rename the file to add CRC32 hash
| false
| 0
| 0
| 0
|
--- MAS_AIO-CRC32_63055B8E.cmd
|
massgravel_Microsoft-Activation-Scripts.json
| null | null | null | null | null | null |
massgravel_Microsoft-Activation-Scripts.json
|
NEW_FEAT
|
4, Adds a new hash which probably translates to new feature
|
0bc3756250ef110a1c6adfd910cc1ecf0ededefd
| null |
Ilkka Seppälä
|
update all-contributors config
| false
| 1
| 1
| 0
|
--- .all-contributorsrc
@@ -283,7 +283,7 @@
]
}
],
- "contributorsPerLine": 7,
+ "contributorsPerLine": 4,
"projectName": "java-design-patterns",
"projectOwner": "iluwatar",
"repoType": "github",
|
iluwatar_java-design-patterns.json
| null | null | null | null | null | null |
iluwatar_java-design-patterns.json
|
CONFIG_CHANGE
|
5, just a change in contributor config
|
6427f8580bdafcdff64ffb46e31986ae39c0d71b
|
2024-02-06 08:51:59
|
Suoqin Jin
|
The ECM-receptor signaling is assumed as diffusible signaling by default; Update `filterCommunication` to enable the identification of consistent communications across different samples The ECM-receptor signaling is assumed as diffusible signaling by default when analyzing spatial transcriptomics; Update `filterCommunication` to enable the identification of consistent communications across different samples/batches/experiments.
| false
| 176
| 29
| 205
|
--- R/modeling.R
@@ -80,7 +80,7 @@ computeCommunProb <- function(object, type = c("triMean", "truncatedMean","thres
pairLR.use <- object@LR$LRsig
} else {
if (length(unique(LR.use$annotation)) > 1) {
- LR.use$annotation <- factor(LR.use$annotation, levels = c("Secreted Signaling","ECM-Receptor", "Non-protein Signaling", "Cell-Cell Contact"))
+ LR.use$annotation <- factor(LR.use$annotation, levels = c("Secreted Signaling", "ECM-Receptor", "Cell-Cell Contact","Non-protein Signaling"))
LR.use <- LR.use[order(LR.use$annotation), , drop = FALSE]
LR.use$annotation <- as.character(LR.use$annotation)
}
@@ -142,7 +142,7 @@ computeCommunProb <- function(object, type = c("triMean", "truncatedMean","thres
tol <- object@images$scale.factors$tol
}
- meta.t = data.frame(group = group, samples = object@meta$samples, row.names = rownames(object@meta))
+ meta.t = data.frame(group = group, slices = object@meta$slices, row.names = rownames(object@meta))
res <- computeRegionDistance(coordinates = data.spatial, meta = meta.t, interaction.range = interaction.range, ratio = ratio, tol = tol, k.min = k.min, contact.dependent = contact.dependent, contact.range = contact.range, contact.knn.k = contact.knn.k)
d.spatial <- res$d.spatial # NaN if no nearby cell pairs
adj.contact <- res$adj.contact # zeros if no nearby cell pairs
@@ -174,30 +174,22 @@ computeCommunProb <- function(object, type = c("triMean", "truncatedMean","thres
distance.use = NULL; interaction.range = NULL; ratio = NULL; tol = NULL; k.min = NULL;
}
- if (object@options$datatype == "RNA") {
- nLR1 <- nLR
+ if (object@options$datatype != "RNA" & contact.dependent == TRUE) {
+ if (all(unique(pairLRsig$interaction$annotation) %in% c("ECM-Receptor", "Cell-Cell Contact"))) {
+ P.spatial <- P.spatial * adj.contact
+ nLR1 <- nLR
+ } else if (all(unique(pairLRsig$interaction$annotation) %in% c("Secreted Signaling"))) {
+ nLR1 <- nLR
+ } else {
+ nLR1 <- max(which(pairLRsig$interaction$annotation == "Secreted Signaling"))
+ }
} else {
- if (contact.dependent.forced == TRUE) {
- cat("Force to run CellChat in a `contact-dependent` manner for all L-R pairs including secreted signaling.\n")
+ nLR1 <- nLR
+ }
+ if (object@options$datatype != "RNA" & contact.dependent.forced == TRUE) {
+ if (contact.dependent == TRUE & all(unique(pairLRsig$interaction$annotation) %in% c("ECM-Receptor", "Cell-Cell Contact")) == FALSE) {
P.spatial <- P.spatial * adj.contact
nLR1 <- nLR
- } else { # contact.dependent.forced == F
- if (contact.dependent == TRUE && length(unique(pairLRsig$annotation)) > 0) {
- if (all(unique(pairLRsig$annotation) %in% c("Cell-Cell Contact"))) {
- cat("All the input L-R pairs are `Cell-Cell Contact` signaling. Run CellChat in a contact-dependent manner. \n")
- P.spatial <- P.spatial * adj.contact
- nLR1 <- nLR
- } else if (all(unique(pairLRsig$annotation) %in% c("Secreted Signaling", "ECM-Receptor", "Non-protein Signaling"))) {
- cat("Molecules of the input L-R pairs are diffusible. Run CellChat in a diffusion manner based on the `interaction.range`.\n")
- nLR1 <- nLR
- } else {
- cat("The input L-R pairs have both secreted signaling and contact-dependent signaling. Run CellChat in a contact-dependent manner for `Cell-Cell Contact` signaling, and in a diffusion manner based on the `interaction.range` for other L-R pairs. \n")
- nLR1 <- max(which(pairLRsig$annotation %in% c("Secreted Signaling", "ECM-Receptor", "Non-protein Signaling")))
- }
- } else { # contact.dependent == F or there is no `annotation` column in the database
- cat("Run CellChat in a diffusion manner based on the `interaction.range` for all L-R pairs. Setting `contact.dependent = TRUE` if preferring a contact-dependent manner for `Cell-Cell Contact` signaling. \n")
- nLR1 <- nLR
- }
}
}
@@ -891,144 +883,6 @@ thresholdedMean <- function(x, trim = 0.1, na.rm = TRUE) {
}
}
-#' Filter cell-cell communication if there are only few number of cells in certain cell groups or inconsistent cell-cell communication across samples
-#'
-#' @param object CellChat object
-#' @param min.cells The minmum number of cells required in each cell group for cell-cell communication
-#' @param min.samples The minmum number of samples required for consistent cell-cell communication across samples (that is an interaction present in at least `min.samples` samples) when mutiple samples/replicates/batches are merged as an input for CellChat analysis.
-#' @param rare.keep Whether to keep the interactions associated with the rare populations when min.samples >= 2. When a rare population is identified in the merged samples (say 15 cells in this rare population from two samples), it is likely to filter out the interactions associated with this rare population when setting min.samples >= 2. Setting `rare.keep = TRUE` to retain the identified interactions associated with this rare population.
-#' @param nonFilter.keep Whether to keep the non-filtered cell-cell communication in the CellChat object. This is useful for avoiding re-running `computeCommunProb` if you want to adjust the parameters when running `filterCommunication`.
-#' @return CellChat object with an updated slot net
-#' @export
-#'
-filterCommunication <- function(object, min.cells = 10, min.samples = NULL, rare.keep = FALSE, nonFilter.keep = FALSE) {
- net <- object@net
- if (nonFilter.keep == TRUE) {
- cat("The non-filtered cell-cell communication is stored in `object@net$prob.nonFilter` and `object@net$pval.nonFilter`. \n")
- object@net$prob.nonFilter <- net$prob
- object@net$pval.nonFilter <- net$pval
- }
- num.interaction0 <- sum(net$prob > 0)
- cell.excludes <- which(as.numeric(table(object@idents)) <= min.cells)
- if (length(cell.excludes) > 0) {
- cat("The cell-cell communication related with the following cell groups are excluded due to the few number of cells: ", toString(levels(object@idents)[cell.excludes]), "!",'\t')
- net$prob[cell.excludes,,] <- 0
- net$prob[,cell.excludes,] <- 0
- num.interaction1 <- sum(net$prob > 0)
- pct.dicrease <- scales::percent((num.interaction0-num.interaction1)/num.interaction0, accuracy = .1)
- cat(paste0(pct.dicrease, " interactions are removed!",'\n'))
- } else {
- num.interaction1 <- num.interaction0
- }
-
- sample.info <- object@meta$samples
- sample.id <- levels(sample.info)
- if (is.null(min.samples)) {
- min.samples <- 1
- } else if (min.samples > length(sample.id)) {
- stop(paste0("There are only ", length(sample.id), " samples in the data. Please change the value of `min.samples`! "))
- }
- if (length(sample.id) >= 2 & min.samples >= 2) {
- if (object@options$parameter$raw.use == TRUE) {
- data <- as.matrix([email protected])
- } else {
- data <- [email protected]
- }
- data.use <- data/max(data)
- group <- object@idents
- type <- object@options$parameter$type.mean
- trim <- object@options$parameter$trim
- FunMean <- switch(type,
- triMean = triMean,
- truncatedMean = function(x) mean(x, trim = trim, na.rm = TRUE),
- thresholdedMean = function(x) thresholdedMean(x, trim = trim, na.rm = TRUE),
- median = function(x) median(x, na.rm = TRUE))
-
- LR <- dimnames(net$prob)[[3]]
- idx.nonzero <- which(apply(net$prob, 3, sum) != 0)
- LR.nonzero <- LR[idx.nonzero] # only examine the L-R pairs with nonzero communication probabilities.
-
- interaction_input <- object@DB$interaction
- complex_input <- object@DB$complex
- geneIfo <- object@DB$geneInfo
- idx <- match(LR.nonzero, interaction_input$interaction_name)
- geneL <- as.character(interaction_input$ligand[idx])
- geneR <- as.character(interaction_input$receptor[idx])
-
- geneLR <- c(unique(geneL), unique(geneR))
- geneLR <- extractGeneSubset(geneLR, complex_input, geneIfo)
- data.use <- data.use[rownames(data.use) %in% geneLR, ]
-
- score.LR <- array(0, dim = c(nlevels(group),nlevels(group),length(LR.nonzero), length(sample.id)))
- LR.nonzero.all <- c()
- cell.excludes.sample <- c()
- for (i in 1:length(sample.id)) {
- cell.use <- which(sample.info == sample.id[i])
- group.use <- group[cell.use]
- group.use <- droplevels(group.use)
- # get the rare populations with few cells in each sample
- cell.excludes.sample.i <- which(as.numeric(table(object@idents[cell.use])) <= min.cells)
- cell.excludes.sample <- c(cell.excludes.sample, cell.excludes.sample.i)
- # compute average expression per cell group
- data.use.i <- data.use[, cell.use]
- data.use.avg <- aggregate(t(data.use.i), list(group.use), FUN = FunMean)
- data.use.avg <- t(data.use.avg[,-1])
- group.exist <- which(levels(group) %in% unique(group.use))
- if (length(group.exist) < nlevels(group)) {
- data.use.avg.temp <- matrix(0, nrow = nrow(data.use), ncol = nlevels(group))
- data.use.avg.temp[ , group.exist] <- data.use.avg
- rownames(data.use.avg.temp) <- rownames(data.use.avg)
- data.use.avg <- data.use.avg.temp
- }
- colnames(data.use.avg) <- levels(group)
- # compute the average expression of ligand or receptor in each cell group
- dataLavg <- computeExpr_LR(geneL, data.use.avg, complex_input)
- dataRavg <- computeExpr_LR(geneR, data.use.avg, complex_input)
- # compute the interaction scores for each ligand-receptor pair based on their expression
- for (jj in 1:length(LR.nonzero)) { # It is not good to use parallel here because it will change the order of LR
- score.LR[,,jj,i] <- Matrix::crossprod(matrix(dataLavg[jj, ], nrow = 1), matrix(dataRavg[jj, ], nrow = 1))
- }
- if (length(cell.excludes.sample.i) > 0) {
- cat(paste0("The number of cells of the following cell groups in ", sample.id[i], " sample are less than ", min.cells, " cells: ",toString(levels(object@idents)[cell.excludes.sample.i]), "!",'\n'))
- score.LR[cell.excludes.sample.i, , , i] <- 0
- score.LR[ ,cell.excludes.sample.i, , i] <- 0
- }
- #LR.nonzero.all <- c(LR.nonzero.all, LR.nonzero[apply(score.LR[ , , , i], 3, sum) != 0])
- }
- #LR.nonzero.jointOnly <- setdiff(LR.nonzero, unique(LR.nonzero.all))
-
- # get the excluded cell groups that are not observed in the merged data, which is very possible for rare populations
- cell.excludes.sample <- unique(cell.excludes.sample)
- if (length(cell.excludes.sample) > 0) {
- cell.excludes.sample <- setdiff(cell.excludes.sample, cell.excludes)
- }
-
- score.LR[score.LR > 0] <- 1 # binarize the interaction score
- score.LR.consitent <- array(0, dim = c(nlevels(group),nlevels(group),length(LR.nonzero)))
- LR.inconsitent <- c()
- for (jj in 1:length(LR.nonzero)) {
- score.LR.sum <- apply(score.LR[ , , jj, ], c(1,2), sum) # elements 2 and 1 means consistent and inconsistent interactions across samples, respectively.
- # set communication probability to be zero for inconsistent interactions across samples
- if (sum((score.LR.sum > 0) * (score.LR.sum < min.samples)) > 0) {
- #LR.inconsitent <- c(LR.inconsitent, LR.nonzero[jj])
- score.LR.consitent <- (score.LR.sum >= min.samples) * 1
- if (rare.keep == TRUE & length(cell.excludes.sample) > 0) {
- score.LR.consitent[cell.excludes.sample, ] <- 1
- score.LR.consitent[ ,cell.excludes.sample] <- 1
- }
- net$prob[ , , LR.nonzero[jj]] <- net$prob[ , , LR.nonzero[jj]] * score.LR.consitent
- }
- }
- num.interaction2 <- sum(net$prob > 0)
- pct.dicrease <- scales::percent((num.interaction1-num.interaction2)/num.interaction1, accuracy = .1)
- cat(paste0(pct.dicrease, " interactions are removed due to their inconsistence across ", min.samples, " samples!",'\n'))
- }
-
- object@net <- net
- return(object)
-}
-
-
#' Identify all the significant interactions (L-R pairs) from some cell groups to other cell groups
#'
#' @param object CellChat object
@@ -1118,7 +972,7 @@ identifyEnrichedInteractions <- function(object, from, to, bidirection = FALSE,
#' Compute the region distance based on the spatial locations of each splot/cell of the spatial transcriptomics
#'
#' @param coordinates a data matrix in which each row gives the spatial locations/coordinates of each cell/spot
-#' @param meta a data frame including at least two columns named `group` and `samples`. `meta$group` is a factor vector defining the regions/labels of each cell/spot. `meta$samples` is a factor vector defining the sample labels of each dataset.
+#' @param meta a data frame including at least two columns named `group` and `slices`. `meta$group` is a factor vector defining the regions/labels of each cell/spot. `meta$slices` is a factor vector defining the slice labels of each dataset.
#' @param interaction.range The maximum interaction/diffusion range of ligands. This hard threshold is used to filter out the connections between spatially distant regions
#' @param ratio a numerical vector giving the conversion factor when converting spatial coordinates from Pixels or other units to Micrometers (i.e.,Microns).
#'
@@ -1154,20 +1008,20 @@ computeRegionDistance <- function(coordinates, meta,
numCluster <- nlevels(group)
level.use <- levels(group)
level.use <- level.use[level.use %in% unique(group)]
- samples <- meta$samples
- samples.use <- levels(samples)
- d.spatial <- array(NaN, dim = c(numCluster,numCluster,length(samples.use)))
- adj.spatial <- array(0, dim = c(numCluster,numCluster,length(samples.use)))
- adj.contact <- array(0, dim = c(numCluster,numCluster,length(samples.use)))
- adj.contact.knn <- array(0, dim = c(numCluster,numCluster,length(samples.use)))
+ slices <- meta$slices
+ slices.use <- levels(slices)
+ d.spatial <- array(NaN, dim = c(numCluster,numCluster,length(slices.use)))
+ adj.spatial <- array(0, dim = c(numCluster,numCluster,length(slices.use)))
+ adj.contact <- array(0, dim = c(numCluster,numCluster,length(slices.use)))
+ adj.contact.knn <- array(0, dim = c(numCluster,numCluster,length(slices.use)))
if (contact.dependent == TRUE & !is.null(contact.knn.k)) {
## find the k-nearest neighbors for each single cell
# my.knn <- FNN::get.knn(coordinates, k = contact.knn.k)
# nn.ranked <- my.knn$nn.index # this is a matrix with the size of nCell * contact.knn.k
nn.ranked <- matrix(NA, nrow = nrow(coordinates), ncol = contact.knn.k)
- for (k in 1:length(samples.use)) {
- idx.k <- which(samples == samples.use[k])
+ for (k in 1:length(slices.use)) {
+ idx.k <- which(slices == slices.use[k])
my.knn <- suppressWarnings(BiocNeighbors::findKNN(coordinates[idx.k, ], k = contact.knn.k, BNPARAM = BiocNeighbors::AnnoyParam(), get.index = TRUE))
nn.ranked[idx.k, ] <- my.knn$index # this is a matrix with the size of nCell * contact.knn.k
}
@@ -1184,14 +1038,14 @@ computeRegionDistance <- function(coordinates, meta,
contact.range <- 10000 # this produces adj.contact with all elements being 1
}
- for (k in 1:length(samples.use)) {
- idx.k <- samples == samples.use[k]
+ for (k in 1:length(slices.use)) {
+ idx.k <- slices == slices.use[k]
for (i in 1:numCluster) {
for (j in 1:numCluster) {
idx.i <- which((group == level.use[i]) & idx.k)
idx.j <- which((group == level.use[j]) & idx.k)
if (length(idx.i) == 0 | length(idx.j) == 0) {
- next # if one cell group is missing in one sample, just goes to next loop
+ next # if one cell group is missing in one slice, just goes to next loop
}
data.spatial.i <- coordinates[idx.i, , drop = FALSE]
data.spatial.j <- coordinates[idx.j, , drop = FALSE]
@@ -1220,12 +1074,12 @@ computeRegionDistance <- function(coordinates, meta,
}
}
- # merged spatial information from different samples
+ # merged spatial information from different slices
d.spatial <- apply(d.spatial, c(1,2), function(x) mean(x, na.rm = TRUE))
adj.spatial <- apply(adj.spatial, c(1,2), mean)
adj.contact <- apply(adj.contact, c(1,2), mean)
adj.contact.knn <- apply(adj.contact.knn, c(1,2), mean)
- # for multi-samples analysis, the following is needed
+ # for multi-slices analysis, the following is needed
adj.spatial[adj.spatial > 0] <- 1
adj.contact[adj.contact > 0] <- 1
adj.contact.knn[adj.contact.knn > 0] <- 1
@@ -1287,4 +1141,3 @@ computeCellDistance <- function(coordinates, interaction.range = NULL, ratio = N
return(d.spatial)
}
-
|
cellchat
|
jinworks
|
R
|
R
| 367
| 61
|
R toolkit for inference, visualization and analysis of cell-cell communication from single-cell and spatially resolved transcriptomics
|
jinworks_cellchat
|
NEW_FEAT
|
Obvious
|
e6231be02a03711ca404e5121a151b24afbff733
|
2022-02-08 00:12:13
|
Apple OSS Distributions
|
xnu-8019.41.5 Imported from xnu-8019.41.5.tar.gz
| false
| 0
| 0
| 0
|
(error extracting diff)
|
xnu
| null |
C
|
C
| null | null |
Operating system, kernels
|
_xnu
|
CONFIG_CHANGE
|
version change
|
35e882e74fb01d91e24df7c08fafe58e9f5bef6c
| null |
Martin Probst
|
feat: add constructors without type arguments. As the constructed objects have an any type, the resulting containers are assignable to any type: var x: Map<string, number> = new Map(); That is useful to avoid having to specify types twice when declaration and assignment are in different places.
| false
| 2
| 0
| 2
|
--- traceur-runtime.d.ts
@@ -45,6 +45,7 @@ interface Map<K, V> {
size: number;
}
declare var Map: {
+ new (): Map<any, any>;
new<K, V>(): Map<K, V>;
// alexeagle: PATCHED
new<K, V>(m: Map<K, V>): Map<K, V>;
@@ -61,6 +62,7 @@ interface Set<T> {
size: number;
}
declare var Set: {
+ new (): Set<any>;
new<T>(): Set<T>;
// alexeagle PATCHED
new<T>(s: Set<T>): Set<T>;
|
angular_angular.json
| null | null | null | null | null | null |
angular_angular.json
|
NEW_FEAT
|
5, added a new feature
|
93cd6801f5394ce2452c1eb48831f6f02ff31d49
| null |
珠峰培训
|
修改gitignore中的文件 (#773)
| false
| 1
| 0
| 1
|
--- .gitignore
@@ -3,3 +3,4 @@ node_modules/
.DS_Store
test/
npm-debug.log
+.idea
|
animate-css_animate.css.json
| null | null | null | null | null | null |
animate-css_animate.css.json
|
CONFIG_CHANGE
|
5, obvious
|
cda2c99aa9681e94270f7c6ec06c388b9d8bb382
|
2023-10-11 18:34:01
|
Artem Barinov
|
Fix small typo (#3779)
| false
| 1
| 1
| 2
|
--- docs/d3-shape/arc.md
@@ -164,7 +164,7 @@ function cornerRadius() {
If the corner radius is greater than zero, the corners of the arc are rounded using circles of the given radius. For a circular sector, the two outer corners are rounded; for an annular sector, all four corners are rounded.
-The corner radius may not be larger than ([outerRadius](#arc_outerRadius) - [innerRadius](#arc_innerRadius)) / 2. In addition, for arcs whose angular span is less than π, the corner radius may be reduced as two adjacent rounded corners intersect. This occurs more often with the inner corners. See the [arc corners animation](https://observablehq.com/@d3/arc-corners) for illustration.
+The corner radius may not be larger than ([outerRadius](#arc_outerRadius) - [innerRadius](#arc_innerRadius)) / 2. In addition, for arcs whose angular span is less than π, the corner radius may be reduced as two adjacent rounded corners intersect. This is occurs more often with the inner corners. See the [arc corners animation](https://observablehq.com/@d3/arc-corners) for illustration.
## *arc*.startAngle(*angle*) {#arc_startAngle}
|
d3
|
d3
|
Shell
|
Shell
| 109,977
| 22,868
|
Bring data to life with SVG, Canvas and HTML. :bar_chart::chart_with_upwards_trend::tada:
|
d3_d3
|
DOC_CHANGE
|
changes in readme
|
2daaf493815e8b4bfa9862559cecf6f0f2383314
|
2025-03-19 21:36:50
|
Tshepang Mbambo
|
use correct code block markers This makes this command pass
mdbook test --chapter "Remarks on perma-unstable features"
| false
| 3
| 4
| 7
|
--- src/doc/rustc-dev-guide/src/rustc-driver/remarks-on-perma-unstable-features.md
@@ -1,3 +1,4 @@
+
# Remarks on perma unstable features
## `rustc_private`
@@ -17,7 +18,7 @@ When using the `rustc_private` feature with official Rust toolchains distributed
Install both components using rustup:
-```text
+```bash
rustup component add rustc-dev llvm-tools
```
@@ -25,7 +26,7 @@ rustup component add rustc-dev llvm-tools
Without the `llvm-tools` component, you'll encounter linking errors like:
-```text
+```
error: linking with `cc` failed: exit status: 1
|
= note: rust-lld: error: unable to find library -lLLVM-{version}
@@ -44,7 +45,7 @@ For custom-built toolchains or environments not using rustup, additional configu
1. **Check LLVM installation**: Verify LLVM is installed and accessible
2. **Configure library paths**: You may need to set environment variables:
- ```text
+ ```bash
export LD_LIBRARY_PATH=/path/to/llvm/lib:$LD_LIBRARY_PATH
```
3. **Check version compatibility**: Ensure your LLVM version is compatible with your Rust toolchain
|
rust
|
rust-lang
|
Rust
|
Rust
| 101,693
| 13,172
|
Empowering everyone to build reliable and efficient software.
|
rust-lang_rust
|
DOC_CHANGE
|
updates in md file
|
bda4d4453c7f0b4b7f340eb0ca1434eb5cab3c70
|
2024-12-07 02:50:57
|
João Matos
|
Change `SubstTypesContext` to contain an optional `TypeSubstMap`. (#6773) ## Description
Changes `SubstTypesContext` to contain an optional `TypeSubstMap`.
This is to make this usable from collection context where no type
substitution needs to be done.
## Checklist
- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [x] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] If my change requires substantial documentation changes, I have
[requested support from the DevRel
team](https://github.com/FuelLabs/devrel-requests/issues/new/choose)
- [x] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.
| false
| 22
| 11
| 33
|
--- sway-core/src/decl_engine/ref.rs
@@ -102,7 +102,7 @@ where
let decl_engine = ctx.engines.de();
if ctx
.type_subst_map
- .is_some_and(|tsm| tsm.source_ids_contains_concrete_type(ctx.engines))
+ .source_ids_contains_concrete_type(ctx.engines)
|| !decl_engine.get(&self.id).is_concrete(ctx.engines)
{
let mut decl = (*decl_engine.get(&self.id)).clone();
--- sway-core/src/type_system/id.rs
@@ -95,10 +95,7 @@ impl CollectTypesMetadata for TypeId {
impl SubstTypes for TypeId {
fn subst_inner(&mut self, ctx: &SubstTypesContext) -> HasChanges {
let type_engine = ctx.engines.te();
- if let Some(matching_id) = ctx
- .type_subst_map
- .and_then(|tsm| tsm.find_match(*self, ctx.engines))
- {
+ if let Some(matching_id) = ctx.type_subst_map.find_match(*self, ctx.engines) {
if !matches!(&*type_engine.get(matching_id), TypeInfo::ErrorRecovery(_)) {
*self = matching_id;
HasChanges::Yes
--- sway-core/src/type_system/substitute/subst_types.rs
@@ -24,39 +24,31 @@ impl std::ops::BitOr for HasChanges {
}
}
-pub struct SubstTypesContext<'eng, 'tsm> {
- pub engines: &'eng Engines,
- pub type_subst_map: Option<&'tsm TypeSubstMap>,
+pub struct SubstTypesContext<'a, 'b> {
+ pub engines: &'a Engines,
+ pub type_subst_map: &'b TypeSubstMap,
pub subst_function_body: bool,
}
-impl<'eng, 'tsm> SubstTypesContext<'eng, 'tsm> {
+impl<'a, 'b> SubstTypesContext<'a, 'b> {
pub fn new(
- engines: &'eng Engines,
- type_subst_map: &'tsm TypeSubstMap,
+ engines: &'a Engines,
+ type_subst_map: &'b TypeSubstMap,
subst_function_body: bool,
- ) -> SubstTypesContext<'eng, 'tsm> {
+ ) -> SubstTypesContext<'a, 'b> {
SubstTypesContext {
engines,
- type_subst_map: Some(type_subst_map),
+ type_subst_map,
subst_function_body,
}
}
-
- pub fn dummy(engines: &'eng Engines) -> SubstTypesContext<'eng, 'tsm> {
- SubstTypesContext {
- engines,
- type_subst_map: None,
- subst_function_body: false,
- }
- }
}
pub trait SubstTypes {
fn subst_inner(&mut self, ctx: &SubstTypesContext) -> HasChanges;
fn subst(&mut self, ctx: &SubstTypesContext) -> HasChanges {
- if ctx.type_subst_map.is_some_and(|tsm| tsm.is_empty()) {
+ if ctx.type_subst_map.is_empty() {
HasChanges::No
} else {
self.subst_inner(ctx)
|
sway
|
fuellabs
|
Rust
|
Rust
| 62,435
| 5,382
|
🌴 Empowering everyone to build reliable and efficient smart contracts.
|
fuellabs_sway
|
BUG_FIX
|
Matched \bfix(e[ds]|ing)?\b in message
|
d875e99e4639dc07af90b2e3ea0d175e2e692efb
|
2024-11-16 01:22:25
|
Jesse Gross
|
runner.go: Propagate panics back to the user. This is a partial revert of 8a35bb92 "runner.go: Increase survivability of main processing loop", removing the panic handler. Although we want to avoid errors taking down the runner, we also should make the user aware of problems when they happen. In the future, we can restructure things so both parts are true.
| false
| 0
| 10
| 10
|
--- llama/runner/runner.go
@@ -14,6 +14,7 @@ import (
"path/filepath"
"regexp"
"runtime"
+ "runtime/debug"
"strconv"
"strings"
"sync"
@@ -339,6 +340,15 @@ func (s *Server) run(ctx context.Context) {
// it should only be responsible for accepting tokens or embeddings and
// processing batches as fast as possible
func (s *Server) processBatch(tokenBatch *llama.Batch, embedBatch *llama.Batch) {
+ // Try to keep going even if we hit a panic so that corner cases don't take the whole
+ // runner down. In most cases, this will result in dropping the tokens that we are currently
+ // processing and then continuing with what is remaining.
+ defer func() {
+ if err := recover(); err != nil {
+ slog.Error("error while processing batch", "error", err, "stack", debug.Stack())
+ }
+ }()
+
s.mu.Lock()
for s.allNil() {
s.cond.Wait() // Wait until an item is added
|
ollama
|
ollama
|
Go
|
Go
| 131,099
| 10,753
|
Get up and running with Llama 3.3, DeepSeek-R1, Phi-4, Gemma 2, and other large language models.
|
ollama_ollama
|
BUG_FIX
|
partial revert of previous commit to also make users aware of the errors
|
6bd8b82520d9724bf64606309d21c4bbcc3f8dcc
|
2024-04-17 03:44:20
|
Robert Felker
|
gen
| false
| 20
| 18
| 38
|
--- README.md
@@ -155,8 +155,11 @@ Meteo
### UI
+- [StaggeredGridView](https://github.com/letsar/flutter_staggered_grid_view) [3037⭐] - GridView with tiles of variable sizes by [Romain Rastel](https://github.com/letsar)
- [Facebook Reactions](https://github.com/duytq94/facebook-reaction-animation) [409⭐] - Facebook reactions widget by [Duy Tran](https://github.com/duytq94)
- [Flushbar](https://github.com/AndreHaueisen/flushbar) [984⭐] - Highly configurable Snackbar by [Andre Haueisen](https://github.com/AndreHaueisen)
+- [Typeahead](https://github.com/AbdulRahmanAlHamali/flutter_typeahead) [781⭐] - Display overlay suggestions to users as they type by [Abdul Rahman Al Hamali](https://github.com/AbdulRahmanAlHamali)
+- [Pin Code](https://github.com/LiewJunTung/pin_code_text_field) [376⭐] - Animated & customisable Pin code for login and OTP by [Liew Jun Tung](https://github.com/liewjuntung)
- [Liquid Pull To Refresh](https://github.com/aagarwal1012/Liquid-Pull-To-Refresh) [1213⭐] - A beautiful and custom refresh indicator by [Ayush Agarwal](https://github.com/aagarwal1012/).
- [Slide Container](https://pub.dev/packages/slide_container) Slide vertically and horizontally with a smooth dampened motion by [Quentin Le Guennec](https://github.com/quentinleguennec).
- [Direct Select](https://github.com/LanarsInc/direct-select-flutter) - Selection widget with an ethereal, full-screen modal popup by [Ivan Yatsouba](https://github.com/iyatsouba).
@@ -169,20 +172,11 @@ Meteo
- [Dough](https://github.com/HatFeather/flutter_dough) [683⭐] - Widgets for a squishy user interface by [Josiah Saunders](https://github.com/HatFeather).
- [Card Settings](https://github.com/codegrue/card_settings) [519⭐] - package for building settings forms by [codegrue](https://github.com/codegrue).
- [Timelines](https://github.com/chulwoo-park/timelines) [689⭐] - Powerful & Easy to use timeline package by [Chulwoo Park](https://github.com/chulwoo-park).
-- [Timeline Tile](https://github.com/JHBitencourt/timeline_tile) [673⭐] - Tile to help build beautiful and customisable timelines by [Julio Bitencourt](https://github.com/JHBitencourt).
+- [Timeline Tile](https://github.com/JHBitencourt/timeline_tile) [673⭐] - A tile to help build beautiful and customisable timelines by [Julio Bitencourt](https://github.com/JHBitencourt).
- [Rounded Loading Button](https://github.com/chrisedg87/flutter_rounded_loading_button) [294⭐] - Button with a loading indicator, complete with success and error animations by [Chris Edgington](https://twitter.com/ChrisTheEdg)
-- [Flyer Chat](https://github.com/flyerhq/flutter_chat_ui) [1356⭐] - Community-driven chat UI implementation by the [Flyer Chat team](https://github.com/flyerhq)
-- [Smooth Page Indicator](https://github.com/Milad-Akarie/smooth_page_indicator) [1081⭐] - Customizable animated page indicator with a set of built-in effects. [Milad Akarie](https://github.com/Milad-Akarie)
-
-#### List
-
-- [Super List](https://github.com/superlistapp/super_sliver_list) [183⭐] - Drop-in replacement for SliverList and ListView that can handle large amount of items with variable extents by [Matej Knopp](https://github.com/knopp)
-- [Reorderables](https://github.com/hanshengchiu/reorderables) [714⭐] - Drag&Drop Table, Row, Column, Wrap(Grid) and SliverList elements by [Hansheng Chiu](https://github.com/hanshengchiu).
-- [Liquid Pull To Refresh](https://github.com/aagarwal1012/Liquid-Pull-To-Refresh) [1213⭐] - A beautiful and custom refresh indicator by [Ayush Agarwal](https://github.com/aagarwal1012/).
- [PlutoGrid](https://github.com/bosskmk/pluto_grid) [620⭐] - Web and desktop datagrid that can be controlled by the keyboard by [bosskmk](https://github.com/bosskmk).
-- [Typeahead](https://github.com/AbdulRahmanAlHamali/flutter_typeahead) [781⭐] - Display overlay suggestions to users as they type by [Abdul Rahman Al Hamali](https://github.com/AbdulRahmanAlHamali)
-- [StaggeredGridView](https://github.com/letsar/flutter_staggered_grid_view) [3037⭐] - GridView with tiles of variable sizes by [Romain Rastel](https://github.com/letsar)
-
+- [Flyer Chat](https://github.com/flyerhq/flutter_chat_ui) [1356⭐] - Community-driven chat UI implementation by the [Flyer Chat team](https://github.com/flyerhq)
+- [smooth_page_indicator](https://github.com/Milad-Akarie/smooth_page_indicator) [1081⭐] - Customizable animated page indicator with a set of built-in effects. [Milad Akarie](https://github.com/Milad-Akarie)
#### Sticky Headers
- [Sticky Header](https://github.com/letsar/flutter_sticky_header) [876⭐] - Sliver based sticky headers by [Romain Rastel](https://github.com/letsar)
@@ -210,6 +204,8 @@ Meteo
#### UI Helpers
+- [Reorderables](https://github.com/hanshengchiu/reorderables) [714⭐] - Drag&Drop Table, Row, Column, Wrap(Grid) and SliverList elements by [Hansheng Chiu](https://github.com/hanshengchiu).
+- [Liquid Pull To Refresh](https://github.com/aagarwal1012/Liquid-Pull-To-Refresh) [1213⭐] - A beautiful and custom refresh indicator by [Ayush Agarwal](https://github.com/aagarwal1012/).
- [Offline](https://github.com/jogboms/flutter_offline) [993⭐] - Tidy utility to handle offline/online connectivity by [Jeremiah Ogbomo](https://twitter.com/jogboms).
- [Scroll To Index](https://github.com/quire-io/scroll-to-index) [481⭐] - Scroll to specified child element with given index for SliverList/ListView by [Jerry Chen](https://github.com/jerrywell/).
- [In View Notifier List](https://github.com/rvamsikrishna/inview_notifier_list) - ListView that notify when widgets are on screen within a provided area by [Vamsi Krishna](https://github.com/rvamsikrishna).
@@ -334,7 +330,7 @@ Meteo
- [Audio Players Plugin](https://github.com/luanpotter/audioplayers) [1884⭐] - Play multiple audio files simultaneously (Android/iOS) by [Luan Nico](https://github.com/luanpotter).
- [Flutter Audio Recorder](https://github.com/shadow-app/flutter_audio_recorder) - Provides full controls and access to recording details such as level metering by [Wenyan Li](https://github.com/nikli2009).
- [Flutter Sound](https://github.com/dooboolab/flutter_sound) [845⭐] - Flutter audio recorder and player at one hand by [dooboolab](https://github.com/dooboolab)
-- [AssetsAudioPlayer](https://github.com/florent37/Flutter-AssetsAudioPlayer) [737⭐] Simultaneous playback of audio from assets/network/file and displaying notifications [android / ios / web / macos]
+- [AssetsAudioPlayer](https://github.com/florent37/Flutter-AssetsAudioPlayer) [736⭐] Simultaneous playback of audio from assets/network/file and displaying notifications [android / ios / web / macos]
- [Audio Service](https://pub.dev/packages/audio_service) - System background audio support by [Ryan Heise](https://github.com/ryanheise). [Tutorial](https://suragch.medium.com/background-audio-in-flutter-with-audio-service-and-just-audio-3cce17b4a7d?sk=0837a1b1773e27a4f879ff3072e90305) by [Suragch](https://twitter.com/Suragch1).
#### Video
@@ -357,6 +353,7 @@ Meteo
#### Preferences
+- [Streaming Shared Preferences](https://github.com/roughike/streaming_shared_preferences)<!--stargazers:roughike/streaming_shared_preferences--> - Reactive key-value store, shared preferences with Streams by [Iiro Krankka](https://github.com/roughike)
### Monetization
@@ -382,7 +379,7 @@ Meteo
### Clone
- [GitTouch](https://github.com/pd4d10/git-touch) [1493⭐] - Open source mobile client for GitHub, GitLab, Bitbucket and Gitea by [Rongjian Zhang](https://github.com/pd4d10)
-- [RustDesk](https://github.com/rustdesk/rustdesk) [62435⭐] - Open source virtual / remote desktop. TeamViewer alternative. Built with Rust by [RustDesk team](https://www.rustdesk.com/)
+- [RustDesk](https://github.com/rustdesk/rustdesk) <!--stargazers:rustdesk/rustdesk-->- Open source virtual / remote desktop. TeamViewer alternative. Built with Rust by [RustDesk team](https://www.rustdesk.com/)
### Machine Learning
@@ -415,10 +412,11 @@ Meteo
- [InAppWebView](https://github.com/pichillilorenzo/flutter_inappwebview) [2975⭐] - Add inline WebView widgets or open an in-app browser window by [Lorenzo Pichilli](https://github.com/pichillilorenzo)
- [AppAvailability](https://github.com/pichillilorenzo/flutter_appavailability) [91⭐] - List, launch and check installed apps by [Lorenzo Pichilli](https://github.com/pichillilorenzo)
- [File Picker](https://github.com/miguelpruivo/plugins_flutter_file_picker) [1248⭐] - Native file explorer to load absolute file path by [Miguel Ruivo](https://github.com/miguelpruivo)
-- [VPN](https://github.com/X-dea/Flutter_VPN) [329⭐] - Access VPN services by [Jason C.H](https://github.com/ctrysbita)
-- [Geolocator](https://github.com/baseflow/flutter-geolocator) [1204⭐] - A Flutter geolocation plugin which provides easy access to the platform specific location services by [Baseflow](https://baseflow.com)
-- [Permission Handler](https://github.com/baseflow/flutter-permission-handler) [1965⭐] - A Flutter permission plugin which provides a cross-platform (iOS, Android) API to request and check permissions by [Baseflow](https://baseflow.com)
-- [Live Activities](https://github.com/istornz/live_activities) [139⭐] - A plugin to use iOS live activities & Dynamic Island features by [Dimitri Dessus](https://github.com/istornz)
+- [VPN](https://github.com/X-dea/Flutter_VPN)<!--stargazers:X-dea/Flutter_VPN--> - Access VPN services by [Jason C.H](https://github.com/ctrysbita)
+- [Geolocator](https://github.com/baseflow/flutter-geolocator)<!--stargazers:baseflow/flutter-geolocator--> - A Flutter geolocation plugin which provides easy access to the platform specific location services by [Baseflow](https://baseflow.com)
+- [Permission Handler](https://github.com/baseflow/flutter-permission-handler)<!--stargazers:baseflow/flutter-permission-handler--> - A Flutter permission plugin which provides a cross-platform (iOS, Android) API to request and check permissions by [Baseflow](https://baseflow.com)
+- [WidgetKit](https://github.com/fasky-software/flutter_widgetkit)<!--stargazers:baseflow/fasky-software/flutter_widgetkit--> - A plugins which allows you to create a Widget-Extention for iOS by [Thomas Leiter](https://github.com/tomLadder)
+- [Live Activities](https://github.com/istornz/live_activities)<!--stargazers:istornz/live_activities--> - A plugin to use iOS live activities & Dynamic Island features by [Dimitri Dessus](https://github.com/istornz)
#### Scanner
@@ -531,14 +529,14 @@ This section contains libraries that take an experimental or unorthodox approach
#### Game Engine resources
-- [Awesome Flame](https://github.com/flame-engine/awesome-flame) [938⭐] - Curated list of the best Flame games, projects, libraries, tools, tutorials, articles and more by [Flame Engine](https://github.com/flame-engine)
+- [Awesome Flame](https://github.com/flame-engine/awesome-flame)<!--stargazers:flame-engine/awesome-flame--> - Curated list of the best Flame games, projects, libraries, tools, tutorials, articles and more by [Flame Engine](https://github.com/flame-engine)
## Open Source Apps
### Premium
-- [AppFlowy](https://github.com/AppFlowy-IO/appflowy) [48482⭐] - Open Source Notion Alternative. You are in charge of your data and customizations. Built with Flutter and Rust by [AppFlowy team](https://www.appflowy.io/)
+- [AppFlowy](https://github.com/AppFlowy-IO/appflowy) [48481⭐] - Open Source Notion Alternative. You are in charge of your data and customizations. Built with Flutter and Rust by [AppFlowy team](https://www.appflowy.io/)
- [RustDesk](https://github.com/rustdesk/rustdesk) [62435⭐] - Open source virtual/remote desktop and TeamViewer alternative. Built with Flutter and Rust by [RustDesk team](https://www.rustdesk.com/).
- [Spotube](https://github.com/KRTirtho/spotube) - Open source Spotify client for desktop and mobile by [Kingkor Roy Tirtho](https://github.com/KRTirtho)
|
awesome-flutter
|
solido
|
Dart
|
Dart
| 54,974
| 6,726
|
An awesome list that curates the best Flutter libraries, tools, tutorials, articles and more.
|
solido_awesome-flutter
|
DOC_CHANGE
|
changes in readme
|
63502d37c249b43d2bfabca915695f744fd38e58
|
2022-11-02 10:12:34
|
Adetunji Dahunsi
|
Update screenshots
| false
| 1
| 1
| 2
|
--- README.md
@@ -32,7 +32,7 @@ This project hosts each sample app in separate repository branches. For more inf
## Screenshots
-<img src="screenshots/screenshots.png" alt="Screenshot">
+<img src="screenshots/todoapp.gif" alt="Screenshot">
## Why a to-do app?
--- screenshots/screenshots.png
Binary files a/screenshots/screenshots.png and /dev/null differ
|
architecture-samples
|
android
|
Kotlin
|
Kotlin
| 44,806
| 11,701
|
A collection of samples to discuss and showcase different architectural tools and patterns for Android apps.
|
android_architecture-samples
|
DOC_CHANGE
|
changes in readme
|
f61dd7239bfe0aa750f4f0d4db74d5e060ea1183
| null |
Mark Otto
|
fixes #4277: typo
| false
| 1
| 1
| 0
|
--- README.md
@@ -92,7 +92,7 @@ $ npm install recess connect uglify-js jshint -g
Runs the recess compiler to rebuild the `/less` files and compiles the docs pages. Requires recess and uglify-js. <a href="http://twitter.github.com/bootstrap/less.html#compiling">Read more in our docs »</a>
+ **test** - `make test`
-Runs jshint and qunit tests headlessly in [phatomjs] (http://code.google.com/p/phantomjs/) (used for ci). Depends on having phatomjs installed.
+Runs jshint and qunit tests headlessly in [phatomjs] (http://code.google.com/p/phantomjs/) (used for ci). Depends on having phantomjs installed.
+ **watch** - `make watch`
This is a convenience method for watching just Less files and automatically building them whenever you save. Requires the Watchr gem.
|
twbs_bootstrap.json
| null | null | null | null | null | null |
twbs_bootstrap.json
|
BUG_FIX
|
5, fix written in commits msg
|
1a408ca871366a9099445e007df7479b830a8ea1
|
2025-01-28 11:18:40
|
Fatih Uzunoglu
|
qt: do not use `CSDWin32EventHandler` on Windows 7
| false
| 15
| 4
| 19
|
--- modules/gui/qt/maininterface/interface_window_handler.hpp
@@ -64,7 +64,6 @@ signals:
private:
bool applyKeyEvent(QKeyEvent * event) const;
-protected:
virtual void updateCSDWindowSettings();
protected:
--- modules/gui/qt/maininterface/mainctx_win32.cpp
@@ -798,14 +798,8 @@ bool MainCtxWin32::getDisableVolumeKeys() const
InterfaceWindowHandlerWin32::InterfaceWindowHandlerWin32(qt_intf_t *_p_intf, MainCtx* mainCtx, QWindow* window, QObject *parent)
: InterfaceWindowHandler(_p_intf, mainCtx, window, parent)
+ , m_CSDWindowEventHandler(new CSDWin32EventHandler(mainCtx, window, window))
{
- assert(mainCtx);
- if (mainCtx->platformHandlesResizeWithCSD() || mainCtx->platformHandlesShadowsWithCSD())
- {
- assert(mainCtx->platformHandlesResizeWithCSD() && mainCtx->platformHandlesShadowsWithCSD());
- m_CSDWindowEventHandler = new CSDWin32EventHandler(mainCtx, window, window);
- }
-
auto mainCtxWin32 = qobject_cast<MainCtxWin32*>(mainCtx);
assert(mainCtxWin32);
m_disableVolumeKeys = mainCtxWin32->getDisableVolumeKeys();
@@ -993,8 +987,5 @@ bool InterfaceWindowHandlerWin32::eventFilter(QObject* obj, QEvent* ev)
void InterfaceWindowHandlerWin32::updateCSDWindowSettings()
{
- if (m_CSDWindowEventHandler)
- static_cast<CSDWin32EventHandler *>(m_CSDWindowEventHandler)->setUseClientSideDecoration(m_mainCtx->useClientSideDecoration());
- else
- InterfaceWindowHandler::updateCSDWindowSettings();
+ static_cast<CSDWin32EventHandler *>(m_CSDWindowEventHandler)->setUseClientSideDecoration(m_mainCtx->useClientSideDecoration());
}
--- modules/gui/qt/maininterface/mainctx_win32.hpp
@@ -28,7 +28,6 @@
#include "player/player_controller.hpp"
#include "interface_window_handler.hpp"
#include <QAbstractNativeEventFilter>
-#include <QOperatingSystemVersion>
#include <wrl/client.h>
#include <objbase.h>
@@ -88,8 +87,8 @@ public:
public:
bool getDisableVolumeKeys() const;
- Q_INVOKABLE bool platformHandlesShadowsWithCSD() const override { return (QOperatingSystemVersion::current() >= QOperatingSystemVersion::Windows8); };
- Q_INVOKABLE bool platformHandlesResizeWithCSD() const override { return (QOperatingSystemVersion::current() >= QOperatingSystemVersion::Windows8); };
+ Q_INVOKABLE bool platformHandlesShadowsWithCSD() const override { return true; };
+ Q_INVOKABLE bool platformHandlesResizeWithCSD() const override { return true; };
public slots:
void reloadPrefs() override;
|
vlc
| null |
C
|
C
| null | null |
Video player
|
_vlc
|
BUG_FIX
|
this commit fixes/polishes an earlier feature
|
e502f52e2087b9ffa4f5ec64f6cc959219a212b5
|
2023-03-07 22:19:16
|
Michael de Hoog
|
Bump optimism + op-geth versions
| false
| 2
| 2
| 4
|
--- Dockerfile
@@ -3,7 +3,7 @@ FROM golang:1.19 as op
WORKDIR /app
ENV REPO=https://github.com/ethereum-optimism/optimism.git
-ENV COMMIT=759c0b297c3dfa05370c27b9380c7bffb67b12d2
+ENV COMMIT=3c3e1a88b234a68bcd59be0c123d9f3cc152a91e
RUN git init && \
git remote add origin $REPO && \
git fetch --depth=1 origin $COMMIT && \
@@ -18,7 +18,7 @@ FROM golang:1.19 as geth
WORKDIR /app
ENV REPO=https://github.com/ethereum-optimism/op-geth.git
-ENV COMMIT=c407b2a217b78d13d33f86873bbf38af6e73523e
+ENV COMMIT=0678a130d7908b64aea596320099d30463119169
RUN git init && \
git remote add origin $REPO && \
git fetch --depth=1 origin $COMMIT && \
|
node
|
base
|
Shell
|
Shell
| 68,555
| 2,658
|
Everything required to run your own Base node
|
base_node
|
BUG_FIX
|
Fixing a memory leak in the node server
|
9408ee1241da935c773fe4b590e14cb66998c952
|
2023-06-11 16:46:20
|
Guide
|
Update 10-classical-sorting-algorithms.md
| false
| 2
| 2
| 4
|
--- docs/cs-basics/algorithms/10-classical-sorting-algorithms.md
@@ -27,7 +27,7 @@ tag:
上图存在错误:
1. 插入排序的最好时间复杂度为 O(n) 而不是 O(n^2) 。
-2. 希尔排序的平均时间复杂度为 O(nlogn)
+2.
**图片名词解释:**
@@ -263,7 +263,7 @@ public static int[] shellSort(int[] arr) {
### 算法分析
- **稳定性**:不稳定
-- **时间复杂度**:最佳:O(nlogn), 最差:O(n^2) 平均:O(nlogn)
+- **时间复杂度**:最佳:O(nlogn), 最差:O(n2) 平均:O(nlogn)
- **空间复杂度**:`O(1)`
## 归并排序 (Merge Sort)
|
javaguide
|
snailclimb
|
Java
|
Java
| 148,495
| 45,728
|
「Java学习+面试指南」一份涵盖大部分 Java 程序员所需要掌握的核心知识。准备 Java 面试,首选 JavaGuide!
|
snailclimb_javaguide
|
DOC_CHANGE
|
Obvious
|
e487e5a7f7b298add3d9d7d21dc4914e2a18c4b9
|
2023-08-16 01:19:52
|
Oleksandr Tsurenko
|
Adding Indeo Solutions company
| false
| 5
| 0
| 5
|
--- index.html
@@ -318,11 +318,6 @@
<td>Company</td>
<td>Development; open-source community efforts</td>
</tr>
- <tr>
- <td><a href="https://adindeo.com">Indeo Solutions</a></td>
- <td>Company</td>
- <td>Development; open-source community efforts</td>
- </tr>
<!-- Projects go below here -->
|
manifesto
|
opentofu
|
HTML
|
HTML
| 36,134
| 1,083
|
The OpenTF Manifesto expresses concern over HashiCorp's switch of the Terraform license from open-source to the Business Source License (BSL) and calls for the tool's return to a truly open-source license.
|
opentofu_manifesto
|
CODE_IMPROVEMENT
|
Obvious
|
05da92b5aaf5fdc7b5b6a0a28dcc2c5478a0b5ed
|
2023-08-15 22:15:01
|
Mariano Rodríguez
|
Add MarianoRD
| false
| 6
| 1
| 7
|
--- index.html
@@ -239,12 +239,7 @@
<td><a href="https://finisterra.io">Finisterra</a></td>
<td>Company</td>
<td>Development; open-source community efforts</td>
- </tr>
- <tr>
- <td><a href="https://marianord.com">Mariano Rodríguez</a></td>
- <td>Individual</td>
- <td>Development; open-source community efforts</td>
- </tr>
+ </tr>
</tbody>
</table>
|
manifesto
|
opentofu
|
HTML
|
HTML
| 36,134
| 1,083
|
The OpenTF Manifesto expresses concern over HashiCorp's switch of the Terraform license from open-source to the Business Source License (BSL) and calls for the tool's return to a truly open-source license.
|
opentofu_manifesto
|
CONFIG_CHANGE
|
Very small changes
|
e79cda6dade8bde4f3e67e55f3a4eab6405cb781
| null |
Liam
|
Add pyopencl to dependency installs (#174) * Add pyopencl to dependency installs OpenCL was not actually being tested as pyopencl was not installed. * Reduce installation to 1 liner
| false
| 1
| 1
| 0
|
--- test.yml
@@ -29,6 +29,6 @@ jobs:
with:
python-version: 3.8
- name: Install Dependencies
- run: pip install -r requirements.txt
+ run: pip install -e '.[gpu,testing]'
- name: Run Pytest
run: python -m pytest -s -v
|
tinygrad_tinygrad.json
| null | null | null | null | null | null |
tinygrad_tinygrad.json
|
NEW_FEAT
|
4, Adds a new dependency
|
b54d97e3146b0d5a0161c1483e6f8fb7ac846395
|
2025-03-18 15:04:45
|
A. Unique TensorFlower
|
compat: Update forward compatibility horizon to 2025-03-18 PiperOrigin-RevId: 737917160
| false
| 1
| 1
| 2
|
--- tensorflow/python/compat/compat.py
@@ -29,7 +29,7 @@ from tensorflow.python.util.tf_export import tf_export
# This value changes every day with an automatic CL. It can be modified in code
# via `forward_compatibility_horizon()` or with the environment variable
# TF_FORWARD_COMPATIBILITY_DELTA_DAYS, which is added to the compatibility date.
-_FORWARD_COMPATIBILITY_HORIZON = datetime.date(2025, 3, 18)
+_FORWARD_COMPATIBILITY_HORIZON = datetime.date(2025, 3, 17)
_FORWARD_COMPATIBILITY_DELTA_DAYS_VAR_NAME = "TF_FORWARD_COMPATIBILITY_DELTA_DAYS"
_FORWARD_COMPATIBILITY_DATE_NUMBER = None
|
tensorflow
|
tensorflow
|
C++
|
C++
| 188,388
| 74,565
|
An Open Source Machine Learning Framework for Everyone
|
nan_tensorflow
|
CONFIG_CHANGE
|
Obvious
|
02b324a23dcf03b364318fcba305ffc968b3d661
| null |
Philipp Hagemeister
|
Restore 2.5 compat by activating with_statement future
| false
| 2
| 0
| 2
|
--- __init__.py
@@ -1,6 +1,8 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-
+from __future__ import with_statement
+
__authors__ = (
'Ricardo Garcia Gonzalez',
'Danny Colligan',
|
yt-dlp_yt-dlp.json
| null | null | null | null | null | null |
yt-dlp_yt-dlp.json
|
CODE_IMPROVEMENT
|
4, probably refactoring
|
8c9a24983e8b9dd452f5e378e845104e81333b74
| null |
Isaac Salier-Hellendag
|
Remove calls to `Range.detach` This method is a no-op, as demonstrated by console warnings in Chrome and https://developer.mozilla.org/en-US/docs/Web/API/range.detach. Remove callsites. Fixes #2142
| false
| 0
| 3
| -3
|
--- ReactDOMSelection.js
@@ -114,7 +114,6 @@ function getModernOffsets(node) {
detectionRange.setStart(anchorNode, anchorOffset);
detectionRange.setEnd(focusNode, focusOffset);
var isBackward = detectionRange.collapsed;
- detectionRange.detach();
return {
start: isBackward ? end : start,
@@ -194,8 +193,6 @@ function setModernOffsets(node, offsets) {
range.setEnd(endMarker.node, endMarker.offset);
selection.addRange(range);
}
-
- range.detach();
}
}
|
facebook_react.json
| null | null | null | null | null | null |
facebook_react.json
|
BUG_FIX
|
4, fix.
|
842671d33e426e415e53afe3f61982c62a32d9d7
|
2025-02-06 23:03:15
|
Kyle Walker
|
Add support for PDFs in Claude and Gemini (#265) Co-authored-by: Hadley Wickham <[email protected]>
| false
| 222
| 42
| 264
|
--- DESCRIPTION
@@ -61,7 +61,6 @@ Collate:
'utils-coro.R'
'chat.R'
'content-image.R'
- 'content-pdf.R'
'content-tools.R'
'ellmer-package.R'
'httr2.R'
--- NAMESPACE
@@ -5,7 +5,6 @@ export(Content)
export(ContentImage)
export(ContentImageInline)
export(ContentImageRemote)
-export(ContentPDF)
export(ContentText)
export(ContentToolRequest)
export(ContentToolResult)
@@ -34,8 +33,6 @@ export(chat_vllm)
export(content_image_file)
export(content_image_plot)
export(content_image_url)
-export(content_pdf_file)
-export(content_pdf_url)
export(contents_html)
export(contents_markdown)
export(contents_text)
--- NEWS.md
@@ -1,7 +1,5 @@
# ellmer (development version)
-* New `content_pdf_file()` and `content_pdf_url()` allow you to upload PDFs to supported models. Models that currently support PDFs are Google Gemini and Claude Anthropic. With help from @walkerke and @andrie (#265).
-
* `Chat$get_model()` returns the model name (#299).
* `chat_gemini()` now defaults to using the gemini-2.0-flash model.
--- R/content-image.R
@@ -1,4 +1,5 @@
-#' Encode images for chat input
+
+#' Encode image content for chat input
#'
#' These functions are used to prepare image URLs and files for input to the
#' chatbot. The `content_image_url()` function is used to provide a URL to an
@@ -35,8 +36,15 @@ content_image_url <- function(url, detail = c("auto", "low", "high")) {
detail <- arg_match(detail)
if (grepl("^data:", url)) {
- parsed <- parse_data_url(url)
- ContentImageInline(parsed$content_type, parsed$base64)
+ # https://developer.mozilla.org/en-US/docs/Web/URI/Schemes/data
+ parts <- strsplit(sub("^data:", "", url), ";")[[1]]
+ if (length(parts) != 2 || !grepl("^base64,", parts[[2]])) {
+ cli::cli_abort("{.arg url} is not a valid data url.")
+ }
+ content_type <- parts[[1]]
+ base64 <- sub("^base64,", "", parts[[2]])
+
+ ContentImageInline(content_type, base64)
} else {
ContentImageRemote(url = url, detail = detail)
}
@@ -147,17 +155,3 @@ content_image_plot <- function(width = 768, height = 768) {
content_image_file(path, "image/png", resize = "none")
}
-
-
-parse_data_url <- function(url, error_call = caller_env()) {
- # https://developer.mozilla.org/en-US/docs/Web/URI/Schemes/data
- parts <- strsplit(sub("^data:", "", url), ";")[[1]]
- if (length(parts) != 2 || !grepl("^base64,", parts[[2]])) {
- cli::cli_abort("{.arg url} is not a valid data url.", call = error_call)
- }
-
- list(
- content_type = parts[[1]],
- base64 = sub("^base64,", "", parts[[2]])
- )
-}
--- R/content-pdf.R
@@ -1,42 +0,0 @@
-#' Encode PDFs content for chat input
-#'
-#' @description
-#' These functions are used to prepare PDFs as input to the chatbot. The
-#' `content_pdf_url()` function is used to provide a URL to an PDF file,
-#' while `content_pdf_file()` is used to for local PDF files.
-#'
-#' Not all providers support PDF input, so check the documentation for the
-#' provider you are using.
-#'
-#' @param path,url Path or URL to a PDF file.
-#' @return A `ContentPDF` object
-#' @export
-content_pdf_file <- function(path) {
- check_string(path, allow_empty = FALSE)
- if (!file.exists(path) || dir.exists(path)) {
- cli::cli_abort("{.arg path} must be an existing file.")
- }
-
- ContentPDF(
- type = "application/pdf",
- data = base64enc::base64encode(path)
- )
-}
-
-#' @rdname content_pdf_file
-#' @export
-content_pdf_url <- function(url) {
- if (grepl("^data:", url)) {
- parsed <- parse_data_url(url)
- ContentPDF(parsed$content_type, parsed$base64)
- } else {
- # TODO: need seperate ContentPDFRemote type so we can use file upload
- # apis where they exist. Might need some kind of mutable state so can
- # record point to uploaded file.
- path <- tempfile(fileext = ".pdf")
- on.exit(unlink(path))
-
- resp <- httr2::req_perform(httr2::request(url), path = path)
- content_pdf_file(path)
- }
-}
--- R/content.R
@@ -270,18 +270,3 @@ as_content <- function(x, error_call = caller_env()) {
)
}
}
-
-#' @rdname Content
-#' @export
-ContentPDF <- new_class(
- "ContentPDF",
- parent = Content,
- properties = list(
- type = prop_string(),
- data = prop_string()
- )
-)
-
-method(format, ContentPDF) <- function(x, ...) {
- "<PDF document>"
-}
--- R/provider-bedrock.R
@@ -12,7 +12,7 @@ NULL
#' [Claude](https://aws.amazon.com/bedrock/claude/).
#'
#' ## Authentication
-#'
+#'
#' Authenthication is handled through \{paws.common\}, so if authenthication
#' does not work for you automatically, you'll need to follow the advice
#' at <https://www.paws-r-sdk.com/#credentials>. In particular, if your
@@ -267,20 +267,6 @@ method(as_json, list(ProviderBedrock, ContentImageInline)) <- function(provider,
)
}
-# https://docs.aws.amazon.com/bedrock/latest/APIReference/API_runtime_DocumentBlock.html
-method(as_json, list(ProviderBedrock, ContentPDF)) <- function(provider, x) {
- list(
- document = list(
- #> This field is vulnerable to prompt injections, because the model
- #> might inadvertently interpret it as instructions. Therefore, we
- #> that you specify a neutral name.
- name = bedrock_document_name(),
- format = "pdf",
- source = list(bytes = x@data)
- )
- )
-}
-
# https://docs.aws.amazon.com/bedrock/latest/APIReference/API_runtime_ToolUseBlock.html
method(as_json, list(ProviderBedrock, ContentToolRequest)) <- function(provider, x) {
list(
@@ -342,11 +328,3 @@ locate_aws_credentials <- function(profile) {
aws_creds_cache <- function(profile) {
credentials_cache(key = hash(c("aws", profile)))
}
-
-bedrock_document_name <- local({
- i <- 1
- function() {
- i <<- i + 1
- paste0("document-", i)
- }
-})
--- R/provider-claude.R
@@ -243,17 +243,6 @@ method(as_json, list(ProviderClaude, ContentText)) <- function(provider, x) {
list(type = "text", text = x@text)
}
-method(as_json, list(ProviderClaude, ContentPDF)) <- function(provider, x) {
- list(
- type = "document",
- source = list(
- type = "base64",
- media_type = x@type,
- data = x@data
- )
- )
-}
-
method(as_json, list(ProviderClaude, ContentImageRemote)) <- function(provider, x) {
cli::cli_abort("Claude doesn't support remote images")
}
--- R/provider-gemini.R
@@ -209,15 +209,6 @@ method(as_json, list(ProviderGemini, ContentText)) <- function(provider, x) {
}
}
-method(as_json, list(ProviderGemini, ContentPDF)) <- function(provider, x) {
- list(
- inlineData = list(
- mimeType = x@type,
- data = x@data
- )
- )
-}
-
# https://ai.google.dev/api/caching#FileData
method(as_json, list(ProviderGemini, ContentImageRemote)) <- function(provider, x) {
cli::cli_abort("Gemini doesn't support remote images")
--- _pkgdown.yml
@@ -10,37 +10,36 @@ development:
mode: auto
reference:
- - title: Chatbots
- contents:
- - starts_with("chat_")
- - token_usage
+- title: Chatbots
+ contents:
+ - starts_with("chat_")
+ - token_usage
- - title: Chat helpers
- contents:
- - create_tool_def
- - content_image_url
- - content_pdf_url
- - starts_with("live_")
- - interpolate
+- title: Chat helpers
+ contents:
+ - create_tool_def
+ - content_image_url
+ - starts_with("live_")
+ - interpolate
- - title: Tools and structured data
- contents:
- - tool
- - type_boolean
+- title: Tools and structured data
+ contents:
+ - tool
+ - type_boolean
- - title: Objects
- desc: >
- These classes abstact across behaviour differences in chat providers so
- that for typical ellmer use you don't need to worry about them. You'll need
- to learn more about the objects if you're doing something that's only
- supported by one provider, or if you're implementing a new provider.
- contents:
- - Turn
- - Provider
- - Content
- - Chat
- - Type
+- title: Objects
+ desc: >
+ These classes abstact across behaviour differences in chat providers so
+ that for typical ellmer use you don't need to worry about them. You'll need
+ to learn more about the objects if you're doing something that's only
+ supported by one provider, or if you're implementing a new provider.
+ contents:
+ - Turn
+ - Provider
+ - Content
+ - Chat
+ - Type
- - title: Utilities
- contents:
- - contents_text
+- title: Utilities
+ contents:
+ - contents_text
--- ellmer.Rproj
@@ -5,13 +5,8 @@ SaveWorkspace: No
AlwaysSaveHistory: Default
EnableCodeIndexing: Yes
-UseSpacesForTab: Yes
-NumSpacesForTab: 2
Encoding: UTF-8
-RnwWeave: Sweave
-LaTeX: pdfLaTeX
-
AutoAppendNewline: Yes
StripTrailingWhitespace: Yes
LineEndingConversion: Posix
--- man/Content.Rd
@@ -8,7 +8,6 @@
\alias{ContentImageInline}
\alias{ContentToolRequest}
\alias{ContentToolResult}
-\alias{ContentPDF}
\title{Content types received from and sent to a chatbot}
\usage{
Content()
@@ -28,8 +27,6 @@ ContentToolRequest(
)
ContentToolResult(id = stop("Required"), value = NULL, error = NULL)
-
-ContentPDF(type = stop("Required"), data = stop("Required"))
}
\arguments{
\item{text}{A single string.}
--- man/content_image_url.Rd
@@ -4,7 +4,7 @@
\alias{content_image_url}
\alias{content_image_file}
\alias{content_image_plot}
-\title{Encode images for chat input}
+\title{Encode image content for chat input}
\usage{
content_image_url(url, detail = c("auto", "low", "high"))
--- man/content_pdf_file.Rd
@@ -1,25 +0,0 @@
-% Generated by roxygen2: do not edit by hand
-% Please edit documentation in R/content-pdf.R
-\name{content_pdf_file}
-\alias{content_pdf_file}
-\alias{content_pdf_url}
-\title{Encode PDFs content for chat input}
-\usage{
-content_pdf_file(path)
-
-content_pdf_url(url)
-}
-\arguments{
-\item{path, url}{Path or URL to a PDF file.}
-}
-\value{
-A \code{ContentPDF} object
-}
-\description{
-These functions are used to prepare PDFs as input to the chatbot. The
-\code{content_pdf_url()} function is used to provide a URL to an PDF file,
-while \code{content_pdf_file()} is used to for local PDF files.
-
-Not all providers support PDF input, so check the documentation for the
-provider you are using.
-}
--- tests/testthat/apples.pdf
Binary files a/tests/testthat/apples.pdf and /dev/null differ
--- tests/testthat/helper-provider.R
@@ -176,15 +176,3 @@ test_images_remote_error <- function(chat_fun) {
)
expect_length(chat$get_turns(), 0)
}
-
-# PDF ---------------------------------------------------------------------
-
-test_pdf_local <- function(chat_fun) {
- chat <- chat_fun()
- response <- chat$chat(
- "What's the title of this document?",
- content_pdf_file(test_path("apples.pdf"))
- )
- expect_match(response, "Apples are tasty")
- expect_match(chat$chat("What apple is not tasty?"), "red delicious")
-}
--- tests/testthat/test-content-pdf.R
@@ -1,4 +0,0 @@
-test_that("can create pdf from path", {
- obj <- content_pdf_file(test_path("apples.pdf"))
- expect_s3_class(obj, "ellmer::ContentPDF")
-})
--- tests/testthat/test-provider-bedrock.R
@@ -46,13 +46,6 @@ test_that("can use images", {
test_images_remote_error(chat_fun)
})
-test_that("can use pdfs", {
- chat_fun <- chat_bedrock
-
- test_pdf_local(chat_fun)
-})
-
-
# Auth --------------------------------------------------------------------
test_that("AWS credential caching works as expected", {
--- tests/testthat/test-provider-claude.R
@@ -46,9 +46,3 @@ test_that("can use images", {
test_images_inline(chat_fun)
test_images_remote_error(chat_fun)
})
-
-test_that("can use pdfs", {
- chat_fun <- chat_claude
-
- test_pdf_local(chat_fun)
-})
--- tests/testthat/test-provider-gemini.R
@@ -48,12 +48,6 @@ test_that("can use images", {
test_images_remote_error(chat_fun)
})
-test_that("can use pdfs", {
- chat_fun <- chat_gemini
-
- test_pdf_local(chat_fun)
-})
-
# chunk merging ----------------------------------------------------------
test_that("can merge text output", {
|
ellmer
|
tidyverse
|
R
|
R
| 401
| 55
|
Call LLM APIs from R
|
tidyverse_ellmer
|
NEW_FEAT
|
obvious
|
e5cb16f5b365b462e67c3ef570609c841f8c0b55
|
2024-09-19 11:45:34
|
Mathias Mogensen
|
chore: add changelog for 0.7.0 (#6355)
| false
| 26
| 0
| 26
|
--- CHANGELOG.md
@@ -1,30 +1,4 @@
# Release Notes
-## Version 0.7.0 - 19/09/2024
-### New Features
-- Support reordering blocks in document with drag and drop
-- Support for adding a cover to a row/card in databases
-- Added support for accessing settings on the sign-in page
-- Added "Move to" option to the document menu in top right corner
-- Support for adjusting the document width from settings
-- Show full name of a group on hover
-- Colored group names in kanban boards
-- Support "Ask AI" on multiple lines of text
-- Support for keyboard gestures to move cursor on Mobile
-- Added markdown support for quickly inserting a code block using three backticks
-
-### Bug Fixes
-- Fixed a critical bug where the backtick character would crash the application
-- Fixed an issue with signing-in from the settings dialog where the dialog would persist
-- Fixed a visual bug with icon alignment in primary cell of database rows
-- Fixed a bug with filters applied where new rows were inserted in wrong position
-- Fixed a bug where "Untitled" would override the name of the row
-- Fixed page title not updating after renaming from "More"-menu
-- Fixed File block breaking row detail document
-- Fixed issues with reordering rows with sorting rules applied
-- Improvements to the File & Media type in Database
-- Performance improvement in Grid view
-- Fixed filters sometimes not applying properly in databases
-
## Version 0.6.9 - 09/09/2024
### New Features
- Added a new property type, 'Files & media'
|
appflowy
|
appflowy-io
|
Dart
|
Dart
| 61,077
| 4,078
|
Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.
|
appflowy-io_appflowy
|
DOC_CHANGE
|
Obvious
|
96bd155cbdf03c67d88f1facb13fabfa86e094d4
| null |
Ian Obermiller
|
Support marginHeight and marginWidth attributes marginHeight and marginWidth are used on iframes to set the default body margin inside the iframe.
| false
| 2
| 0
| 2
|
--- HTMLDOMPropertyConfig.js
@@ -104,6 +104,8 @@ var HTMLDOMPropertyConfig = {
list: MUST_USE_ATTRIBUTE,
loop: MUST_USE_PROPERTY | HAS_BOOLEAN_VALUE,
manifest: MUST_USE_ATTRIBUTE,
+ marginHeight: MUST_USE_ATTRIBUTE,
+ marginWidth: MUST_USE_ATTRIBUTE,
max: null,
maxLength: MUST_USE_ATTRIBUTE,
media: MUST_USE_ATTRIBUTE,
|
facebook_react.json
| null | null | null | null | null | null |
facebook_react.json
|
NEW_FEAT
|
4, added a support for marginHeight and marginWidth attributes
|
d9d83deb250a8172c9380c0daf57ceeda7feb8be
| null |
Javier Provecho Fernandez
|
Apply gofmt to PR #179
| false
| 1
| 2
| -1
|
--- routergroup.go
@@ -5,10 +5,9 @@
package gin
import (
+ "github.com/julienschmidt/httprouter"
"net/http"
"path"
-
- "github.com/julienschmidt/httprouter"
)
// Used internally to configure router, a RouterGroup is associated with a prefix
|
gin-gonic_gin.json
| null | null | null | null | null | null |
gin-gonic_gin.json
|
CONFIG_CHANGE
|
5, formatting
|
d15d4feb65bdcbcc736bf8966b065aa484fb76d0
|
2024-10-22 01:46:08
|
Michael de Hoog
|
Remove reth arm64 build (running out of memory) (#338)
| false
| 0
| 2
| 2
|
--- .github/workflows/pr.yml
@@ -31,6 +31,8 @@ jobs:
include:
- arch: linux/amd64
features: jemalloc,asm-keccak,optimism
+ - arch: linux/arm64
+ features: jemalloc,optimism
steps:
- name: Checkout
uses: actions/checkout@v3
|
node
|
base
|
Shell
|
Shell
| 68,555
| 2,658
|
Everything required to run your own Base node
|
base_node
|
CODE_IMPROVEMENT
|
I guess redundant code is removed
|
79347e08e2e77d4f85faf65d7ca2016f7d8ffa99
|
2025-01-21 07:17:57
|
Bobby Wang
|
[SPARK-50844][ML][CONNECT] Make model be loaded by ServiceLoader when loading ### What changes were proposed in this pull request? Currently ml connect discoveries Estimators, Evaluators and Transformers (not including Model) by ServiceLoader which could make it more secure. This PR adds a public no-args constructors for some Models which could make model to be loaded by ServiceLoader too. ### Why are the changes needed? This PR is a follow up of https://github.com/apache/spark/pull/49503, and it will be more safe to discovery a Model by ServiceLoader when loading a model. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? The existing tests pass ### Was this patch authored or co-authored using generative AI tooling? No Closes #49569 from wbo4958/ml.model.serviceloader. Authored-by: Bobby Wang <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
| false
| 155
| 21
| 176
|
--- mllib/src/main/resources/META-INF/services/org.apache.spark.ml.Transformer
@@ -18,23 +18,3 @@
# Spark Connect ML uses ServiceLoader to find out the supported Spark Ml non-model transformer.
# So register the supported transformer here if you're trying to add a new one.
org.apache.spark.ml.feature.VectorAssembler
-
-########### Model for loading
-# classification
-org.apache.spark.ml.classification.LogisticRegressionModel
-org.apache.spark.ml.classification.DecisionTreeClassificationModel
-org.apache.spark.ml.classification.RandomForestClassificationModel
-org.apache.spark.ml.classification.GBTClassificationModel
-
-# regression
-org.apache.spark.ml.regression.LinearRegressionModel
-org.apache.spark.ml.regression.DecisionTreeRegressionModel
-org.apache.spark.ml.regression.RandomForestRegressionModel
-org.apache.spark.ml.regression.GBTRegressionModel
-
-# clustering
-org.apache.spark.ml.clustering.KMeansModel
-org.apache.spark.ml.clustering.BisectingKMeansModel
-
-# recommendation
-org.apache.spark.ml.recommendation.ALSModel
--- mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
@@ -192,10 +192,6 @@ class DecisionTreeClassificationModel private[ml] (
private[ml] def this(rootNode: Node, numFeatures: Int, numClasses: Int) =
this(Identifiable.randomUID("dtc"), rootNode, numFeatures, numClasses)
- // For ml connect only
- @Since("4.0.0")
- private[ml] def this() = this(Node.dummyNode, 0, 0)
-
override def predict(features: Vector): Double = {
rootNode.predictImpl(features).prediction
}
--- mllib/src/main/scala/org/apache/spark/ml/classification/GBTClassifier.scala
@@ -272,11 +272,6 @@ class GBTClassificationModel private[ml](
def this(uid: String, _trees: Array[DecisionTreeRegressionModel], _treeWeights: Array[Double]) =
this(uid, _trees, _treeWeights, -1, 2)
- // For ml connect only
- @Since("4.0.0")
- private[ml] def this() = this(Identifiable.randomUID("gbtc"),
- Array(new DecisionTreeRegressionModel), Array(0.0))
-
@Since("1.4.0")
override def trees: Array[DecisionTreeRegressionModel] = _trees
--- mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
@@ -1076,10 +1076,6 @@ class LogisticRegressionModel private[spark] (
this(uid, new DenseMatrix(1, coefficients.size, coefficients.toArray, isTransposed = true),
Vectors.dense(intercept), 2, isMultinomial = false)
- // For ml connect only
- @Since("4.0.0")
- private[ml] def this() = this(Identifiable.randomUID("logreg"), Vectors.zeros(0), 0)
-
/**
* A vector of model coefficients for "binomial" logistic regression. If this model was trained
* using the "multinomial" family then an exception is thrown.
--- mllib/src/main/scala/org/apache/spark/ml/classification/RandomForestClassifier.scala
@@ -255,10 +255,6 @@ class RandomForestClassificationModel private[ml] (
numClasses: Int) =
this(Identifiable.randomUID("rfc"), trees, numFeatures, numClasses)
- // For ml connect only
- @Since("4.0.0")
- private[ml] def this() = this(Array(new DecisionTreeClassificationModel), 0, 0)
-
@Since("1.4.0")
override def trees: Array[DecisionTreeClassificationModel] = _trees
--- mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala
@@ -96,10 +96,6 @@ class BisectingKMeansModel private[ml] (
extends Model[BisectingKMeansModel] with BisectingKMeansParams with MLWritable
with HasTrainingSummary[BisectingKMeansSummary] {
- @Since("4.0.0")
- private[ml] def this() = this(Identifiable.randomUID("bisecting-kmeans"),
- new MLlibBisectingKMeansModel(null))
-
@Since("3.0.0")
lazy val numFeatures: Int = parentModel.clusterCenters.head.size
--- mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala
@@ -138,11 +138,6 @@ class KMeansModel private[ml] (
extends Model[KMeansModel] with KMeansParams with GeneralMLWritable
with HasTrainingSummary[KMeansSummary] {
- // For ml connect only
- @Since("4.0.0")
- private[ml] def this() = this(Identifiable.randomUID("kmeans"),
- new MLlibKMeansModel(clusterCenters = null))
-
@Since("3.0.0")
lazy val numFeatures: Int = parentModel.clusterCenters.head.size
--- mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
@@ -280,10 +280,6 @@ class ALSModel private[ml] (
@transient val itemFactors: DataFrame)
extends Model[ALSModel] with ALSModelParams with MLWritable {
- // For ml connect only
- @Since("4.0.0")
- private[ml] def this() = this(Identifiable.randomUID("als"), 0, null, null)
-
/** @group setParam */
@Since("1.4.0")
def setUserCol(value: String): this.type = set(userCol, value)
--- mllib/src/main/scala/org/apache/spark/ml/regression/DecisionTreeRegressor.scala
@@ -187,10 +187,6 @@ class DecisionTreeRegressionModel private[ml] (
private[ml] def this(rootNode: Node, numFeatures: Int) =
this(Identifiable.randomUID("dtr"), rootNode, numFeatures)
- // For ml connect only
- @Since("4.0.0")
- private[ml] def this() = this(Node.dummyNode, 0)
-
override def predict(features: Vector): Double = {
rootNode.predictImpl(features).prediction
}
--- mllib/src/main/scala/org/apache/spark/ml/regression/GBTRegressor.scala
@@ -242,11 +242,6 @@ class GBTRegressionModel private[ml](
def this(uid: String, _trees: Array[DecisionTreeRegressionModel], _treeWeights: Array[Double]) =
this(uid, _trees, _treeWeights, -1)
- // For ml connect only
- @Since("4.0.0")
- private[ml] def this() = this(Identifiable.randomUID("gbtr"),
- Array(new DecisionTreeRegressionModel), Array(0.0))
-
@Since("1.4.0")
override def trees: Array[DecisionTreeRegressionModel] = _trees
--- mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala
@@ -702,10 +702,6 @@ class LinearRegressionModel private[ml] (
private[ml] def this(uid: String, coefficients: Vector, intercept: Double) =
this(uid, coefficients, intercept, 1.0)
- // For ml connect only
- @Since("4.0.0")
- private[ml] def this() = this(Identifiable.randomUID("linReg"), Vectors.zeros(0), 0.0, 0.0)
-
override val numFeatures: Int = coefficients.size
/**
--- mllib/src/main/scala/org/apache/spark/ml/regression/RandomForestRegressor.scala
@@ -212,10 +212,6 @@ class RandomForestRegressionModel private[ml] (
private[ml] def this(trees: Array[DecisionTreeRegressionModel], numFeatures: Int) =
this(Identifiable.randomUID("rfr"), trees, numFeatures)
- // For ml connect only
- @Since("4.0.0")
- private[ml] def this() = this(Array(new DecisionTreeRegressionModel), 0)
-
@Since("1.4.0")
override def trees: Array[DecisionTreeRegressionModel] = _trees
--- mllib/src/main/scala/org/apache/spark/ml/tree/Node.scala
@@ -105,11 +105,6 @@ private[ml] object Node {
split = Split.fromOld(oldNode.split.get, categoricalFeatures), impurityStats = null)
}
}
-
- // A dummy node used for ml connect only
- val dummyNode: Node = {
- new LeafNode(0.0, 0.0, ImpurityCalculator.getCalculator("gini", Array.empty, 0))
- }
}
/**
--- sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLHandler.scala
@@ -204,7 +204,7 @@ private[connect] object MLHandler extends Logging {
val path = mlCommand.getRead.getPath
if (operator.getType == proto.MlOperator.OperatorType.MODEL) {
- val model = MLUtils.loadTransformer(sessionHolder, name, path)
+ val model = MLUtils.load(sessionHolder, name, path).asInstanceOf[Model[_]]
val id = mlCache.register(model)
proto.MlCommandResult
.newBuilder()
@@ -218,21 +218,15 @@ private[connect] object MLHandler extends Logging {
} else if (operator.getType == proto.MlOperator.OperatorType.ESTIMATOR ||
operator.getType == proto.MlOperator.OperatorType.EVALUATOR) {
- val mlOperator = {
- if (operator.getType == proto.MlOperator.OperatorType.ESTIMATOR) {
- MLUtils.loadEstimator(sessionHolder, name, path).asInstanceOf[Params]
- } else {
- MLUtils.loadEvaluator(sessionHolder, name, path).asInstanceOf[Params]
- }
- }
+ val operator = MLUtils.load(sessionHolder, name, path).asInstanceOf[Params]
proto.MlCommandResult
.newBuilder()
.setOperatorInfo(
proto.MlCommandResult.MlOperatorInfo
.newBuilder()
.setName(name)
- .setUid(mlOperator.uid)
- .setParams(Serializer.serializeParams(mlOperator)))
+ .setUid(operator.uid)
+ .setParams(Serializer.serializeParams(operator)))
.build()
} else {
throw MlUnsupportedException(s"${operator.getType} read not supported")
--- sql/connect/server/src/main/scala/org/apache/spark/sql/connect/ml/MLUtils.scala
@@ -29,13 +29,13 @@ import org.apache.spark.ml.{Estimator, Transformer}
import org.apache.spark.ml.evaluation.Evaluator
import org.apache.spark.ml.linalg._
import org.apache.spark.ml.param.Params
-import org.apache.spark.ml.util.MLWritable
+import org.apache.spark.ml.util.{MLReadable, MLWritable}
import org.apache.spark.sql.{DataFrame, Dataset}
import org.apache.spark.sql.connect.common.{DataTypeProtoConverter, LiteralValueProtoConverter}
import org.apache.spark.sql.connect.planner.SparkConnectPlanner
import org.apache.spark.sql.connect.plugin.SparkConnectPluginRegistry
import org.apache.spark.sql.connect.service.SessionHolder
-import org.apache.spark.util.Utils
+import org.apache.spark.util.{SparkClassUtils, Utils}
private[ml] object MLUtils {
@@ -352,62 +352,28 @@ private[ml] object MLUtils {
}
/**
- * Load an ML component (Estimator, Transformer, or Evaluator) from the given path.
+ * Call "load" function on the ML operator given the operator name
*
- * @param sessionHolder
- * the session holder
* @param className
* the ML operator name
* @param path
* the path to be loaded
- * @param operatorClass
- * the class type of the ML operator (Estimator, Transformer, or Evaluator)
- * @tparam T
- * the type of the ML operator
* @return
- * the instance of the ML operator
+ * the ML instance
*/
- private def loadOperator[T](
- sessionHolder: SessionHolder,
- className: String,
- path: String,
- operatorClass: Class[T]): T = {
+ def load(sessionHolder: SessionHolder, className: String, path: String): Object = {
val name = replaceOperator(sessionHolder, className)
- val operators = loadOperators(operatorClass)
- if (operators.isEmpty || !operators.contains(name)) {
- throw MlUnsupportedException(s"Unsupported read for $name")
- }
- operators(name)
- .getMethod("load", classOf[String])
- .invoke(null, path)
- .asInstanceOf[T]
- }
-
- /**
- * Load an estimator from the specified path.
- */
- def loadEstimator(
- sessionHolder: SessionHolder,
- className: String,
- path: String): Estimator[_] = {
- loadOperator(sessionHolder, className, path, classOf[Estimator[_]])
- }
- /**
- * Load a transformer from the specified path.
- */
- def loadTransformer(
- sessionHolder: SessionHolder,
- className: String,
- path: String): Transformer = {
- loadOperator(sessionHolder, className, path, classOf[Transformer])
- }
+ // It's the companion object of the corresponding spark operators to load.
+ val objectCls = SparkClassUtils.classForName(name + "$")
+ val mlReadableClass = classOf[MLReadable[_]]
+ // Make sure it is implementing MLReadable
+ if (!mlReadableClass.isAssignableFrom(objectCls)) {
+ throw MlUnsupportedException(s"$name must implement MLReadable.")
+ }
- /**
- * Load an evaluator from the specified path.
- */
- def loadEvaluator(sessionHolder: SessionHolder, className: String, path: String): Evaluator = {
- loadOperator(sessionHolder, className, path, classOf[Evaluator])
+ val loadedMethod = SparkClassUtils.classForName(name).getMethod("load", classOf[String])
+ loadedMethod.invoke(null, path)
}
// Since we're using reflection way to get the attribute, in order not to
--- sql/connect/server/src/test/resources/META-INF/services/org.apache.spark.ml.Transformer
@@ -1,20 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one or more
-# contributor license agreements. See the NOTICE file distributed with
-# this work for additional information regarding copyright ownership.
-# The ASF licenses this file to You under the Apache License, Version 2.0
-# (the "License"); you may not use this file except in compliance with
-# the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-# Spark Connect ML uses ServiceLoader to find out the supported Spark Ml estimators.
-# So register the supported estimator here if you're trying to add a new one.
-org.apache.spark.sql.connect.ml.MyLogisticRegressionModel
--- sql/connect/server/src/test/scala/org/apache/spark/sql/connect/ml/MLHelper.scala
@@ -149,8 +149,6 @@ class MyLogisticRegressionModel(
with HasFakedParam
with DefaultParamsWritable {
- private[spark] def this() = this("MyLogisticRegressionModel", 1.0f, 1.0f)
-
def setFakeParam(v: Int): this.type = set(fakeParam, v)
def setMaxIter(v: Int): this.type = set(maxIter, v)
--- sql/connect/server/src/test/scala/org/apache/spark/sql/connect/ml/MLSuite.scala
@@ -322,7 +322,7 @@ class MLSuite extends MLHelper {
}
}
- test("Model must be registered into ServiceLoader when loading") {
+ test("ML operator must implement MLReadable for loading") {
val thrown = intercept[MlUnsupportedException] {
val sessionHolder = SparkConnectTestUtils.createDummySessionHolder(spark)
val readCmd = proto.MlCommand
@@ -339,8 +339,8 @@ class MLSuite extends MLHelper {
MLHandler.handleMlCommand(sessionHolder, readCmd)
}
assert(
- thrown.message.contains("Unsupported read for " +
- "org.apache.spark.sql.connect.ml.NotImplementingMLReadble"))
+ thrown.message.contains("org.apache.spark.sql.connect.ml.NotImplementingMLReadble " +
+ "must implement MLReadable"))
}
test("RegressionEvaluator works") {
|
apache-spark
| null |
Scala
|
Scala
| null | null |
Apache Spark - A unified analytics engine for large-scale data processing
|
_apache-spark
|
NEW_FEAT
|
new feature introduced by loading the model through serviceloader
|
2b511cd3fa3a1805af5bcf3c65583b7308aad4a4
|
2023-06-12 05:34:06
|
Mike Bostock
|
icon
| false
| 4
| 0
| 4
|
--- docs/.vitepress/config.ts
@@ -7,10 +7,6 @@ export default defineConfig({
description: "The JavaScript library for bespoke data visualization",
base: "/d3/", // temporary
cleanUrls: true,
- head: [
- ["link", {rel: "apple-touch-icon", href: "https://static.observableusercontent.com/files/082781eba5e2203c0c63ef9af5ace08ae0faaf8c3e2c251e77a4383f2fffd85ac236a4066f12e838dee5e2f3abb518c27db51b47b5e21a96d094a8f27f89fcd7"}],
- ["link", {rel: "icon", type: "image/png", href: "https://static.observableusercontent.com/files/082781eba5e2203c0c63ef9af5ace08ae0faaf8c3e2c251e77a4383f2fffd85ac236a4066f12e838dee5e2f3abb518c27db51b47b5e21a96d094a8f27f89fcd7", sizes: "512x512"}]
- ],
vite: {
resolve: {
alias: {
|
d3
|
d3
|
Shell
|
Shell
| 109,977
| 22,868
|
Bring data to life with SVG, Canvas and HTML. :bar_chart::chart_with_upwards_trend::tada:
|
d3_d3
|
CODE_IMPROVEMENT
|
refactored to update icon links
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.