Switch to ChatCompletion for OpenAI

app/smart_recommendation.py

@@ -5,22 +5,15 @@ from collections import defaultdict
 from datetime import datetime, timedelta
 from typing import Dict, List
 
+import openai
 from dotenv import load_dotenv
-from openai import OpenAI
 
 from app.models import BudgetRecommendation, CategoryExpense
 
 load_dotenv()
 OPENAI_API_KEY = os.getenv("OPENAI_API_KEY")
-
-def _build_openai_client():
-    if not OPENAI_API_KEY:
-        return None
-    try:
-        return OpenAI(api_key=OPENAI_API_KEY)
-    except Exception as exc:
-        print(f"OpenAI client initialization failed: {exc}")
-        return None
+if OPENAI_API_KEY:
+    openai.api_key = OPENAI_API_KEY
 
 class SmartBudgetRecommender:
     """
@@ -32,7 +25,6 @@ class SmartBudgetRecommender:
     
     def __init__(self, db):
         self.db = db
-        self.openai_client = _build_openai_client()
     
     def get_recommendations(self, user_id: str, month: int, year: int) -> List[BudgetRecommendation]:
         """
@@ -246,7 +238,7 @@ class SmartBudgetRecommender:
 
     def _get_ai_recommendation(self, category: str, data: Dict, avg_expense: float, fallback_budget: float):
         """Use OpenAI to refine the budget recommendation."""
-        if not self.openai_client:
+        if not OPENAI_API_KEY:
             return None
 
         history = ", ".join(f"{value:.0f}" for value in data["monthly_values"])
@@ -270,13 +262,15 @@ class SmartBudgetRecommender:
         )
 
         try:
-            response = self.openai_client.responses.create(
-                model="gpt-4.1-mini",
-                input=prompt,
+            response = openai.ChatCompletion.create(
+                model="gpt-4o-mini",
                 temperature=0.1,
-                response_format={"type": "json_object"},
+                messages=[
+                    {"role": "system", "content": "You are an Indian personal finance coach who outputs JSON."},
+                    {"role": "user", "content": prompt},
+                ],
             )
-            content = response.output[0].content[0].text
+            content = response.choices[0].message["content"]
             return json.loads(content)
         except Exception as exc:
             print(f"OpenAI recommendation error for {category}: {exc}")