hash,date,author,commit_message,is_merge,masked_commit_message,type,git_diff 21f62add921a09cc89ce88c7d4d85b5656f8028f,2024-01-25 14:47:05,Rishabh Rathod,fix: debugger errors CE (#30596),False,debugger errors CE (#30596),fix,"diff --git a/app/client/src/ce/utils/getEntityPayloadInfo.ts b/app/client/src/ce/utils/getEntityPayloadInfo.ts index be68792e9eb0..247cd2ce199f 100644 --- a/app/client/src/ce/utils/getEntityPayloadInfo.ts +++ b/app/client/src/ce/utils/getEntityPayloadInfo.ts @@ -15,6 +15,7 @@ export const getEntityPayloadInfo: Record< iconId: string; id: string; pluginType?: PluginType | string; + entityName?: string; } > = { [ENTITY_TYPE.WIDGET]: (entityConfig) => { diff --git a/app/client/src/sagas/ActionExecution/PluginActionSaga.ts b/app/client/src/sagas/ActionExecution/PluginActionSaga.ts index 3c89a8e5c647..3fd78855e1d5 100644 --- a/app/client/src/sagas/ActionExecution/PluginActionSaga.ts +++ b/app/client/src/sagas/ActionExecution/PluginActionSaga.ts @@ -622,12 +622,12 @@ export default function* executePluginActionTriggerSaga( }); if (onError) { throw new PluginTriggerFailureError( - createMessage(ERROR_ACTION_EXECUTE_FAIL, action.name), + createMessage(ERROR_ACTION_EXECUTE_FAIL, pluginActionNameToDisplay), [payload.body, params], ); } else { throw new PluginTriggerFailureError( - createMessage(ERROR_PLUGIN_ACTION_EXECUTE, action.name), + createMessage(ERROR_PLUGIN_ACTION_EXECUTE, pluginActionNameToDisplay), [], ); } diff --git a/app/client/src/sagas/EvalErrorHandler.ts b/app/client/src/sagas/EvalErrorHandler.ts index db561f2a979c..f2e118fd5430 100644 --- a/app/client/src/sagas/EvalErrorHandler.ts +++ b/app/client/src/sagas/EvalErrorHandler.ts @@ -130,7 +130,7 @@ function logLatestEvalPropertyErrors( messages: errorMessages, source: { id: payloadInfo.id, - name: entityName, + name: payloadInfo.entityName || entityName, type: entityType as ENTITY_TYPE, propertyPath: logPropertyPath, pluginType: payloadInfo.pluginType, diff --git a/app/client/src/sagas/InitSagas.ts b/app/client/src/sagas/InitSagas.ts index dc75cc0f67ea..6828eee77145 100644 --- a/app/client/src/sagas/InitSagas.ts +++ b/app/client/src/sagas/InitSagas.ts @@ -341,7 +341,7 @@ export function* startAppEngine(action: ReduxAction) { } } -function* resetDebuggerLogs() { +export function* resetDebuggerLogs() { // clear all existing debugger errors const debuggerErrors: ReturnType = yield select(getDebuggerErrors);" cdcb6a00198750cac145419003590376c3da6af8,2022-11-24 12:36:37,akash-codemonk,chore: add back feature flag for context switching (#18417),False,add back feature flag for context switching (#18417),chore,"diff --git a/app/server/appsmith-server/src/main/resources/features/init-flags.yml b/app/server/appsmith-server/src/main/resources/features/init-flags.yml index 3b92e881be86..a9534b53301a 100644 --- a/app/server/appsmith-server/src/main/resources/features/init-flags.yml +++ b/app/server/appsmith-server/src/main/resources/features/init-flags.yml @@ -57,10 +57,10 @@ ff4j: enable: true description: Restoring old context while navigating across the app flipstrategy: - class: org.ff4j.strategy.PonderationStrategy + class: com.appsmith.server.featureflags.strategies.EmailBasedRolloutStrategy param: - - name: weight - value: 1 + - name: emailDomains + value: appsmith.com,moolya.com - uid: DATASOURCE_ENVIRONMENTS enable: true" facc4d75ebd9ea3ae6394e4ebf88422189c76d80,2023-07-20 18:45:27,Vijetha-Kaja,test: Cypress - Flaky fix (#25451),False,Cypress - Flaky fix (#25451),test,"diff --git a/app/client/cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js b/app/client/cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js index b03c33174b72..9848792758eb 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js +++ b/app/client/cypress/e2e/Regression/ClientSide/Binding/TableTextPagination_spec.js @@ -136,7 +136,7 @@ describe(""Test Create Api and Bind to Table widget"", function () { cy.executeDbQuery(""Api2"", ""onPageChange""); }); - it(""5. Table-Text, Validate Server Side Pagination of Paginate with response URL"", function () { + it.skip(""5. Table-Text, Validate Server Side Pagination of Paginate with response URL"", function () { /**Validate Response data with Table data in Text Widget */ entityExplorer.SelectEntityByName(""Table1"", ""Widgets""); diff --git a/app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2TextPagination_spec.js b/app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2TextPagination_spec.js index 4ae7d3418eef..bdc3d6f37989 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2TextPagination_spec.js +++ b/app/client/cypress/e2e/Regression/ClientSide/Binding/TableV2TextPagination_spec.js @@ -135,7 +135,7 @@ describe(""Test Create Api and Bind to Table widget"", function () { cy.executeDbQuery(""Api2"", ""onPageChange""); }); - it(""5. Table-Text, Validate Server Side Pagination of Paginate with Response URL"", function () { + it.skip(""5. Table-Text, Validate Server Side Pagination of Paginate with Response URL"", function () { /**Validate Response data with Table data in Text Widget */ cy.get(""body"").then(($ele) => { if ($ele.find(locators._backToEditor).length) { diff --git a/app/client/cypress/e2e/Regression/ClientSide/BugTests/ApiBugs_Spec.ts b/app/client/cypress/e2e/Regression/ClientSide/BugTests/ApiBugs_Spec.ts index c7ab7ea95269..6f0bfd64fa95 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/BugTests/ApiBugs_Spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/BugTests/ApiBugs_Spec.ts @@ -70,11 +70,11 @@ describe(""API Bugs"", function () { }); it(""4. Bug 16683, When Api url has dynamic binding expressions, ensures the query params is not truncated"", function () { - const apiUrl = `https://echo.hoppscotch.io/v6/deployments?limit=4{{Math.random() > 0.5 ? '¶m1=5' : '¶m2=6'}}`; + const apiUrl = `http://host.docker.internal:5001/v1/mock-api?records=4{{Math.random() > 0.5 ? '¶m1=5' : '¶m2=6'}}`; apiPage.CreateAndFillApi(apiUrl, ""BindingExpressions""); apiPage.ValidateQueryParams({ - key: ""limit"", + key: ""records"", value: ""4{{Math.random() > 0.5 ? '¶m1=5' : '¶m2=6'}}"", }); }); diff --git a/app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js b/app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js index fc904cbaaab6..f33b35962480 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js +++ b/app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Page_Load_Spec.js @@ -43,7 +43,7 @@ describe(""Page Load tests"", () => { ""This is Page 2"", ); // Test after reload - agHelper.RefreshPage(true, ""viewPage""); + agHelper.RefreshPage(""viewPage""); // Assert active page tab cy.get("".t--page-switch-tab"") .contains(""Page2"") diff --git a/app/client/cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts index 018a5461f93c..8edd00b84ab5 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts @@ -41,7 +41,7 @@ describe(""Import and validate older app (app created in older versions of Appsmi it(""1. Validate merge status"", () => { entityExplorer.AssertEntityPresenceInExplorer(""ListingAndReviews""); //Wait for the app to settle - agHelper.Sleep(1000); + agHelper.Sleep(3000); homePage.RenameApplication(appName); agHelper.AssertElementVisible(gitSync._bottomBarCommit); diff --git a/app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js b/app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js index 9bfa3994d88c..a55f6cab6e9c 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js +++ b/app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/GitSyncedApps_spec.js @@ -207,6 +207,7 @@ describe(""Git sync apps"", function () { it(""3. Commit and push changes, validate data binding on all pages in edit and deploy mode on master"", () => { // verfiy data binding on all pages in edit mode cy.wait(2000); + agHelper.RefreshPage(""getPage""); cy.get("".t--draggable-inputwidgetv2"").should(""be.visible""); cy.get("".t--draggable-inputwidgetv2"") .first() @@ -254,6 +255,7 @@ describe(""Git sync apps"", function () { expect(cellData).to.be.equal(""New Config""); }); cy.get("".t--page-switch-tab"").contains(`${newPage}`).click({ force: true }); + agHelper.RefreshPage(); cy.get("".bp3-input"") .first() .invoke(""val"") diff --git a/app/client/cypress/e2e/Regression/ClientSide/Onboarding/FirstTimeUserOnboarding_spec.js b/app/client/cypress/e2e/Regression/ClientSide/Onboarding/FirstTimeUserOnboarding_spec.js index 79204ac30cff..7a26478de6ec 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Onboarding/FirstTimeUserOnboarding_spec.js +++ b/app/client/cypress/e2e/Regression/ClientSide/Onboarding/FirstTimeUserOnboarding_spec.js @@ -192,7 +192,7 @@ describe(""FirstTimeUserOnboarding"", function () { agHelper.AssertElementVisible(OnboardingLocator.widgetSidebar); agHelper.AssertElementVisible(OnboardingLocator.dropTarget); entityExplorer.DragDropWidgetNVerify(draggableWidgets.TEXT); - agHelper.RefreshPage(true, ""getPage""); + agHelper.RefreshPage(""getPage""); agHelper.AssertElementEnabledDisabled( debuggerHelper.locators._helpButton, 0, diff --git a/app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApplicationURL_spec.js b/app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApplicationURL_spec.js index 2699da1f5e24..8c244ac5302e 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApplicationURL_spec.js +++ b/app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApplicationURL_spec.js @@ -67,7 +67,7 @@ describe(""Slug URLs"", () => { const application = response.body.data; expect(application.applicationVersion).to.equal(1); homePage.NavigateToHome(); - //agHelper.RefreshPage(true, ""getReleaseItems""); + //agHelper.RefreshPage(""getReleaseItems""); cy.SearchApp(applicationName); diff --git a/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/table_data_change_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/table_data_change_spec.ts index bf297457f023..335ebf8298b5 100644 --- a/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/table_data_change_spec.ts +++ b/app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/table_data_change_spec.ts @@ -187,7 +187,7 @@ describe(""Table widget v2: tableData change test"", function () { freezeColumnFromDropdown(""status"", ""left""); freezeColumnFromDropdown(""action"", ""right""); - agHelper.RefreshPage(true, ""viewPage""); + agHelper.RefreshPage(""viewPage""); checkIfColumnIsFrozenViaCSS(""status""); checkIfColumnIsFrozenViaCSS(""action""); @@ -208,7 +208,7 @@ describe(""Table widget v2: tableData change test"", function () { freezeColumnFromDropdown(""id"", ""left""); freezeColumnFromDropdown(""updatedAt"", ""right""); - agHelper.RefreshPage(true, ""viewPage""); + agHelper.RefreshPage(""viewPage""); checkIfColumnIsFrozenViaCSS(""id""); checkIfColumnIsFrozenViaCSS(""updatedAt""); diff --git a/app/client/cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts b/app/client/cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts index b1eae09cf0a7..c2a4cae52667 100644 --- a/app/client/cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts +++ b/app/client/cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad1_Spec.ts @@ -91,7 +91,7 @@ describe(""JSObjects OnLoad Actions tests"", function () { table.WaitForTableEmpty(); agHelper.WaitUntilAllToastsDisappear(); - agHelper.RefreshPage(true, ""viewPage""); + agHelper.RefreshPage(""viewPage""); agHelper.AssertElementVisible(jsEditor._dialog(""Confirmation dialog"")); agHelper.AssertElementVisible( jsEditor._dialogBody((jsName as string) + "".getEmployee""), diff --git a/app/client/cypress/e2e/Regression/ServerSide/OnLoadTests/JsOnLoad3_Spec.ts b/app/client/cypress/e2e/Regression/ServerSide/OnLoadTests/JsOnLoad3_Spec.ts index 68d8b6820810..2f4ca6a77962 100644 --- a/app/client/cypress/e2e/Regression/ServerSide/OnLoadTests/JsOnLoad3_Spec.ts +++ b/app/client/cypress/e2e/Regression/ServerSide/OnLoadTests/JsOnLoad3_Spec.ts @@ -137,7 +137,7 @@ describe(""JSObjects OnLoad Actions tests"", function () { agHelper.AssertElementAbsence(jsEditor._dialogBody(""WhatTrumpThinks"")); //Since JS call is NO, dependent API confirmation should not appear - agHelper.RefreshPage(true, ""viewPage""); + agHelper.RefreshPage(""viewPage""); // agHelper.AssertElementVisible( // jsEditor._dialogBody((jsName as string) + "".callTrump""), // ); diff --git a/app/client/cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js b/app/client/cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js index ddafae04610e..4d7a760e52e3 100644 --- a/app/client/cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js +++ b/app/client/cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js @@ -457,7 +457,8 @@ describe(""Validate CRUD queries for Amazon S3 along with UI flow verifications"", cy.ClickGotIt(); //Verifying Searching File from UI - cy.xpath(queryLocators.searchFilefield).type(""S3Crud_"").wait(10000); //for search to finish + agHelper.TypeText(queryLocators.searchFilefield, fileName.substring(0,14)); + agHelper.Sleep(10000); //for search to finish cy.get("".t--widget-textwidget span:contains('"" + fileName + ""')"") .should(""have.length"", 1) diff --git a/app/client/cypress/support/Pages/AggregateHelper.ts b/app/client/cypress/support/Pages/AggregateHelper.ts index 4136e4604e7a..c2e6334e65aa 100644 --- a/app/client/cypress/support/Pages/AggregateHelper.ts +++ b/app/client/cypress/support/Pages/AggregateHelper.ts @@ -92,8 +92,7 @@ export class AggregateHelper extends ReusableHelper { public AddDsl( dslFile: string, - elementToCheckPresenceaftDslLoad: string | """" = """", - reloadWithoutCache = true, + elementToCheckPresenceaftDslLoad: string | """" = """", // reloadWithoutCache = true, ) { let pageid: string, layoutId; let appId: string | null; @@ -125,7 +124,7 @@ export class AggregateHelper extends ReusableHelper { //cy.log(""Pages resposne is : "" + dslDumpResp.body); expect(dslDumpResp.status).equal(200); this.Sleep(3000); //for dsl to settle in layouts api & then refresh - this.RefreshPage(reloadWithoutCache); + this.RefreshPage(); if (elementToCheckPresenceaftDslLoad) this.WaitUntilEleAppear(elementToCheckPresenceaftDslLoad); this.Sleep(2000); //settling time for dsl @@ -866,8 +865,7 @@ export class AggregateHelper extends ReusableHelper { } public RefreshPage( - reloadWithoutCache = true, - networkCallAlias = ""getWorkspace"", + networkCallAlias = ""getWorkspace"", // reloadWithoutCache = true, ) { this.Sleep(2000); this.assertHelper.AssertDocumentReady(); diff --git a/app/client/cypress/support/Pages/Templates.ts b/app/client/cypress/support/Pages/Templates.ts index 78914f49a272..9474c8587c87 100644 --- a/app/client/cypress/support/Pages/Templates.ts +++ b/app/client/cypress/support/Pages/Templates.ts @@ -71,7 +71,7 @@ export class Templates { }); } cy.intercept(""GET"", ""/api/v1/app-templates/filters"").as(""fetchFilters""); - this.agHelper.RefreshPage(false, ""fetchFilters""); + this.agHelper.RefreshPage(""fetchFilters""); this.agHelper.AssertElementVisible(this.locators._templateCard); } }" 9e70ebe658558f66a96c6e15e53566c3f1ed74f8,2024-02-27 11:56:45,Vemparala Surya Vamsi,fix: 'are you sure' state reset (#31227),False,'are you sure' state reset (#31227),fix,"diff --git a/app/client/src/pages/Editor/Explorer/Actions/MoreActionsMenu.tsx b/app/client/src/pages/Editor/Explorer/Actions/MoreActionsMenu.tsx index 2625fb044841..996b9aa318d7 100644 --- a/app/client/src/pages/Editor/Explorer/Actions/MoreActionsMenu.tsx +++ b/app/client/src/pages/Editor/Explorer/Actions/MoreActionsMenu.tsx @@ -1,4 +1,4 @@ -import React, { useCallback, useState } from ""react""; +import React, { useCallback, useEffect, useState } from ""react""; import { useDispatch, useSelector } from ""react-redux""; import type { AppState } from ""@appsmith/reducers""; @@ -44,6 +44,10 @@ export function MoreActionsMenu(props: EntityContextMenuProps) { const [confirmDelete, setConfirmDelete] = useState(false); const { isChangePermitted = false, isDeletePermitted = false } = props; + useEffect(() => { + if (!isMenuOpen) setConfirmDelete(false); + }, [isMenuOpen]); + const dispatch = useDispatch(); const copyActionToPage = useCallback( (actionId: string, actionName: string, pageId: string) => diff --git a/app/client/src/pages/Editor/JSEditor/AppJSEditorContextMenu.tsx b/app/client/src/pages/Editor/JSEditor/AppJSEditorContextMenu.tsx index e9a34b00fecb..e17099456c45 100644 --- a/app/client/src/pages/Editor/JSEditor/AppJSEditorContextMenu.tsx +++ b/app/client/src/pages/Editor/JSEditor/AppJSEditorContextMenu.tsx @@ -181,7 +181,13 @@ export function AppJSEditorContextMenu({ if (isDeletePermitted) options.push(deleteOption); return ( - + { + setConfirmDelete(false); + }} + options={options} + /> ); } diff --git a/app/client/src/pages/Editor/JSEditor/JSEditorContextMenu.tsx b/app/client/src/pages/Editor/JSEditor/JSEditorContextMenu.tsx index a15fc3527fe3..d868d8805dd2 100644 --- a/app/client/src/pages/Editor/JSEditor/JSEditorContextMenu.tsx +++ b/app/client/src/pages/Editor/JSEditor/JSEditorContextMenu.tsx @@ -27,17 +27,26 @@ export interface ContextMenuOption { interface EntityContextMenuProps { className?: string; options: ContextMenuOption[]; + onMenuClose: (() => void) | undefined; } export function JSEditorContextMenu({ className, + onMenuClose, options, }: EntityContextMenuProps) { if (options.length === 0) { return null; } return ( - + { + if (!open) { + onMenuClose?.(); + } + }} + >